From 48d55a7963e1851183cae68e23fefcb7cd077568 Mon Sep 17 00:00:00 2001 From: Gavin Shan Date: Tue, 30 May 2023 13:35:11 +1000 Subject: [PATCH] rtc: hym8563: use IRQ flags obtained from fwnode Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2183349 commit badba1e5b111c6f32038953efc8078cba3390326 Author: Alexandre Belloni Date: Mon Jan 23 21:02:08 2023 +0100 rtc: hym8563: use IRQ flags obtained from fwnode Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-3-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni (cherry picked from commit badba1e5b111c6f32038953efc8078cba3390326) Signed-off-by: Gavin Shan --- drivers/rtc/rtc-hym8563.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index cc710d682121..7d5a298a9a3b 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -518,9 +518,14 @@ static int hym8563_probe(struct i2c_client *client) } if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + ret = devm_request_threaded_irq(&client->dev, client->irq, NULL, hym8563_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, client->name, hym8563); if (ret < 0) { dev_err(&client->dev, "irq %d request failed, %d\n",