qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rv: Fix out-of-bound memory access in rv_is_container_monitor() 

JIRA: https://issues.redhat.com/browse/RHEL-92623

commit 8d7861ac507d23024c7d74b6cb59a9cca248bcb7
Author: Nam Cao <namcao@linutronix.de>
Date:   Fri Apr 11 09:37:17 2025 +0200

    rv: Fix out-of-bound memory access in rv_is_container_monitor()

    When rv_is_container_monitor() is called on the last monitor in
    rv_monitors_list, KASAN yells:

      BUG: KASAN: global-out-of-bounds in rv_is_container_monitor+0x101/0x110
      Read of size 8 at addr ffffffff97c7c798 by task setup/221

      The buggy address belongs to the variable:
       rv_monitors_list+0x18/0x40

    This is due to list_next_entry() is called on the last entry in the list.
    It wraps around to the first list_head, and the first list_head is not
    embedded in struct rv_monitor_def.

    Fix it by checking if the monitor is last in the list.

    Cc: stable@vger.kernel.org
    Cc: Gabriele Monaco <gmonaco@redhat.com>
    Fixes: cb85c660fcd4 ("rv: Add option for nested monitors and include sched")
    Link: https://lore.kernel.org/e85b5eeb7228bfc23b8d7d4ab5411472c54ae91b.1744355018.git.namcao@linutronix.de
    Signed-off-by: Nam Cao <namcao@linutronix.de>
    Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
This commit is contained in:
Gabriele Monaco 2025-05-27 15:46:45 +02:00
parent 18e140bb81
commit 5127322f3e
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/trace/rv/rv.c
View File

@ -225,7 +225,12 @@ bool rv_is_nested_monitor(struct rv_monitor_def *mdef)
*/
bool rv_is_container_monitor(struct rv_monitor_def *mdef)
{
struct rv_monitor_def *next = list_next_entry(mdef, list);
struct rv_monitor_def *next;
if (list_is_last(&mdef->list, &rv_monitors_list))
return false;
next = list_next_entry(mdef, list);
return next->parent == mdef->monitor || !mdef->monitor->enable;
}