qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fanotify: delete useless parenthesis in FANOTIFY_INLINE_FH macro 

JIRA: https://issues.redhat.com/browse/RHEL-102134

commit 1758cd2e95d31b308f29ae3828ae92c8b8d20466
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date:   Tue Oct 10 14:44:35 2023 +0300

    fanotify: delete useless parenthesis in FANOTIFY_INLINE_FH macro

    Parenthesis around identifier name in declaration are useless.
    This is just "put every macro argument inside parenthesis" practice.

    Now "size" must be constant expression, but using comma expression in
    constant expression is useless too, therefore [] will guard "size"
    expression just as well as ().

    Also g++ is somewhat upset about these:

            fs/notify/fanotify/fanotify.h:278:28: warning: unnecessary parentheses in declaration of ‘object_fh’ [-Wparentheses]
              278 |         struct fanotify_fh (name);

    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Message-Id: <633c251a-b548-4428-9e91-1cf8147d8c55@p183>

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
This commit is contained in:
Miklos Szeredi 2025-07-07 17:15:21 +02:00
parent 999f009f80
commit b5ce01a2ab
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/notify/fanotify/fanotify.h
View File

@ -275,9 +275,9 @@ static inline void fanotify_init_event(struct fanotify_event *event,
#define FANOTIFY_INLINE_FH(name, size) \
struct { \
struct fanotify_fh (name); \
struct fanotify_fh name; \
/* Space for object_fh.buf[] - access with fanotify_fh_buf() */ \
unsigned char _inline_fh_buf[(size)]; \
unsigned char _inline_fh_buf[size]; \
}
struct fanotify_fid_event {