qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

sysdeps/ieee754/ldbl-128ibm-compat: Fix warn unused result 

Return value from *scanf and *asprintf routines are now properly checked
in test-scanf-ldbl-compat-template.c and test-printf-ldbl-compat.c.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
This commit is contained in:
Frédéric Bérat 2023-06-19 14:56:49 +02:00
parent 923b53e920
commit 02261d1bd9
2 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sysdeps/ieee754/ldbl-128ibm-compat/test-printf-ldbl-compat.c
View File

@ -30,12 +30,13 @@ do_test_call_varg (FILE *stream, const char *format, ...)
char *buffer = NULL; char *buffer = NULL;
char string[128]; char string[128];
va_list args; va_list args;
int ret;
printf ("%15s", "vasprintf: "); printf ("%15s", "vasprintf: ");
va_start (args, format); va_start (args, format);
vasprintf (&buffer, format, args); ret = vasprintf (&buffer, format, args);
va_end (args); va_end (args);
if (buffer == NULL) if (ret == -1 || buffer == NULL)
printf ("Error using vasprintf\n"); printf ("Error using vasprintf\n");
else else
{ {
@ -82,10 +83,11 @@ do_test_call_rarg (FILE *stream, const char *format, long double ld, double d)
{ {
char *buffer = NULL; char *buffer = NULL;
char string[128]; char string[128];
int ret;
printf ("%15s", "asprintf: "); printf ("%15s", "asprintf: ");
asprintf (&buffer, format, ld, d); ret = asprintf (&buffer, format, ld, d);
if (buffer == NULL) if (ret == -1 || buffer == NULL)
printf ("Error using asprintf\n"); printf ("Error using asprintf\n");
else else
{ {

21
sysdeps/ieee754/ldbl-128ibm-compat/test-scanf-ldbl-compat-template.c
View File

@ -37,10 +37,10 @@
ldptr = va_arg (args, long double *); \ ldptr = va_arg (args, long double *); \
fptr = va_arg (args, float *); \ fptr = va_arg (args, float *); \
va_end (args); \ va_end (args); \
if (*ldptr == -1 && *fptr == -2) \ if (*ldptr == -1 && *fptr == -2 && ret == 2) \
printf ("OK"); \ printf ("OK"); \
else \ else \
printf ("ERROR (%Lf %f)", *ldptr, *fptr); \ printf ("ERROR (%Lf %f %d)", *ldptr, *fptr, ret); \
printf ("\n"); printf ("\n");
#define CLEAR_VALUE \ #define CLEAR_VALUE \
@ -48,10 +48,10 @@
f = 0; f = 0;
#define CHECK_VALUE \ #define CHECK_VALUE \
if (ld == -1 && f == -2) \ if (ld == -1 && f == -2 && ret == 2) \
printf ("OK"); \ printf ("OK"); \
else \ else \
printf ("ERROR (%Lf %f)", ld, f); \ printf ("ERROR (%Lf %f %d)", ld, f, ret); \
printf ("\n"); printf ("\n");
static void static void
@ -62,40 +62,41 @@ do_test_call (FILE *stream, CHAR *string, const CHAR *format, ...)
float *fptr; float *fptr;
long double *ldptr; long double *ldptr;
va_list args; va_list args;
int ret;
CLEAR_VALUE CLEAR_VALUE
printf ("fscanf: "); printf ("fscanf: ");
FSCANF (stream, format, &ld, &f); ret = FSCANF (stream, format, &ld, &f);
CHECK_VALUE CHECK_VALUE
CLEAR_VALUE CLEAR_VALUE
printf ("scanf: "); printf ("scanf: ");
SCANF (format, &ld, &f); ret = SCANF (format, &ld, &f);
CHECK_VALUE CHECK_VALUE
CLEAR_VALUE CLEAR_VALUE
printf ("sscanf: "); printf ("sscanf: ");
SSCANF (string, format, &ld, &f); ret = SSCANF (string, format, &ld, &f);
CHECK_VALUE CHECK_VALUE
CLEAR_VARGS CLEAR_VARGS
printf ("vfscanf: "); printf ("vfscanf: ");
va_start (args, format); va_start (args, format);
VFSCANF (stream, format, args); ret = VFSCANF (stream, format, args);
va_end (args); va_end (args);
CHECK_VARGS CHECK_VARGS
CLEAR_VARGS CLEAR_VARGS
printf ("vscanf: "); printf ("vscanf: ");
va_start (args, format); va_start (args, format);
VSCANF (format, args); ret = VSCANF (format, args);
va_end (args); va_end (args);
CHECK_VARGS CHECK_VARGS
CLEAR_VARGS CLEAR_VARGS
printf ("vsscanf: "); printf ("vsscanf: ");
va_start (args, format); va_start (args, format);
VSSCANF (string, format, args); ret = VSSCANF (string, format, args);
va_end (args); va_end (args);
CHECK_VARGS CHECK_VARGS
} }