qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

x86-64: Fix SSE2 memcmp and SSSE3 memmove for x32 

Clear the upper 32 bits in RDX (memory size) for x32 to fix

FAIL: string/tst-size_t-memcmp
FAIL: string/tst-size_t-memcmp-2
FAIL: string/tst-size_t-memcpy
FAIL: wcsmbs/tst-size_t-wmemcmp

on x32 introduced by

8804157ad9 x86: Optimize memcmp SSE2 in memcmp.S
26b2478322 x86: Reduce code size of mem{move|pcpy|cpy}-ssse3

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
This commit is contained in:
H.J. Lu 2022-04-22 10:53:13 -07:00
parent 198abcbb94
commit 8ea20ee5f6
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sysdeps/x86_64/memcmp.S
View File

@ -46,6 +46,10 @@
.text .text
ENTRY(MEMCMP) ENTRY(MEMCMP)
# ifdef __ILP32__
/* Clear the upper 32 bits. */
movl %edx, %edx
# endif
#ifdef USE_AS_WMEMCMP #ifdef USE_AS_WMEMCMP
/* Use 0xffff to test for mismatches on pmovmskb bitmask. Store /* Use 0xffff to test for mismatches on pmovmskb bitmask. Store
in ecx for code size. This is preferable to using `incw` as in ecx for code size. This is preferable to using `incw` as

4
sysdeps/x86_64/multiarch/memmove-ssse3.S
View File

@ -27,6 +27,10 @@ ENTRY(MEMMOVE_CHK)
END(MEMMOVE_CHK) END(MEMMOVE_CHK)
ENTRY_P2ALIGN(MEMMOVE, 6) ENTRY_P2ALIGN(MEMMOVE, 6)
# ifdef __ILP32__
/* Clear the upper 32 bits. */
movl %edx, %edx
# endif
movq %rdi, %rax movq %rdi, %rax
L(start): L(start):
cmpq $16, %rdx cmpq $16, %rdx