qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Correct checking loop in group_member.

This commit is contained in:
Ulrich Drepper 2010-06-19 11:38:04 -07:00
parent 63c4ed22b5
commit ac2b484c02
3 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -1,5 +1,8 @@
2010-06-19 Ulrich Drepper <drepper@redhat.com> 2010-06-19 Ulrich Drepper <drepper@redhat.com>
[BZ #11701]
* posix/group_member.c (__group_member): Correct checking loop.
* sysdeps/unix/sysv/linux/getlogin_r.c (__getlogin_r_loginuid): Handle * sysdeps/unix/sysv/linux/getlogin_r.c (__getlogin_r_loginuid): Handle
OOM in getpwuid_r correctly. Return error number when the caller OOM in getpwuid_r correctly. Return error number when the caller
should return, otherwise -1. should return, otherwise -1.

8
NEWS
View File

@ -1,4 +1,4 @@
GNU C Library NEWS -- history of user-visible changes. 2010-5-19 GNU C Library NEWS -- history of user-visible changes. 2010-6-19
Copyright (C) 1992-2009, 2010 Free Software Foundation, Inc. Copyright (C) 1992-2009, 2010 Free Software Foundation, Inc.
See the end for copying conditions. See the end for copying conditions.
@ -7,7 +7,11 @@ using `glibc' in the "product" field.
Version 2.13 Version 2.13
* POWER7 optimizations: memset * The following bugs are resolved with this release:
11640, 11701
* POWER7 optimizations: memset, memcmp, strncmp
Version 2.12 Version 2.12

9
posix/group_member.c
View File

@ -1,5 +1,5 @@
/* `group_member' -- test if process is in a given group. /* `group_member' -- test if process is in a given group.
Copyright (C) 1995, 1997, 2002 Free Software Foundation, Inc. Copyright (C) 1995, 1997, 2002, 2010 Free Software Foundation, Inc.
This file is part of the GNU C Library. This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or The GNU C Library is free software; you can redistribute it and/or
@ -39,10 +39,11 @@ __group_member (gid)
groups = __alloca (size * sizeof *groups); groups = __alloca (size * sizeof *groups);
n = __getgroups (size, groups); n = __getgroups (size, groups);
size *= 2; size *= 2;
} while (n == size / 2); }
while (n == size / 2);
while (n >= 0) while (n-- > 0)
if (groups[n--] == gid) if (groups[n] == gid)
return 1; return 1;
return 0; return 0;