mirror of git://sourceware.org/git/glibc.git
9fe3c80c7c
sys/socket.h includes sys/uio.h to get the definition of the iovec
structure.
POSIX allows sys/socket.h to make all sys/uio.h symbols visible.
However, all of sys/uio.h is XSI-shaded, so for non-XSI POSIX this
results in conformtest failures (for sys/socket.h and other headers
that include it):
Namespace violation: "UIO_MAXIOV"
Namespace violation: "readv"
Namespace violation: "writev"
Now, there is some ambiguity in POSIX about what namespace
reservations apply in this case - see
http://austingroupbugs.net/view.php?id=1127 - but glibc convention
would still avoid declaring readv and writev, for example, for feature
test macros that don't include them (if only headers from the relevant
standard are included), even if such declarations are permitted, so
there is a bug here according to glibc conventions.
This patch moves the struct iovec definition to a new
bits/types/struct_iovec.h header and includes that from sys/socket.h
instead of including the whole of sys/uio.h. This fixes the namespace
issue; however, three files in glibc that were relying on the implicit
inclusion needed to be updated to include sys/uio.h explicitly. So
there is a question of whether sys/socket.h should continue to include
sys/uio.h under some conditions, such as __USE_XOPEN or __USE_MISC or
__USE_XOPEN || __USE_MISC, for greater compatibility with code that
(wrongly) expects this optional inclusion to be present there. (I
think the three affected files in glibc should still have explicit
sys/uio.h inclusions added in any case, however.)
Tested for x86_64.
[BZ #21426]
* misc/bits/types/struct_iovec.h: New file.
* misc/Makefile (headers): Add bits/types/struct_iovec.h.
* include/bits/types/struct_iovec.h: New file.
* bits/uio.h (struct iovec): Replace by inclusion of
<bits/types/struct_iovec.h>.
* sysdeps/unix/sysv/linux/bits/uio.h (struct iovec): Likewise.
* socket/sys/socket.h: Include <bits/types/struct_iovec.h> instead
of <sys/uio.h>.
* nptl/tst-cancel4.c: Include <sys/uio.h>
* posix/test-errno.c: Likewise.
* support/resolv_test.c: Likewise.
* conform/Makefile (test-xfail-POSIX2008/arpa/inet.h/conform):
Remove.
(test-xfail-POSIX2008/netdb.h/conform): Likewise.
(test-xfail-POSIX2008/netinet/in.h/conform): Likewise.
(test-xfail-POSIX2008/sys/socket.h/conform): Likewise.
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| README | ||
| README-testing.c | ||
| check.c | ||
| check.h | ||
| check_addrinfo.c | ||
| check_dns_packet.c | ||
| check_hostent.c | ||
| check_netent.c | ||
| check_nss.h | ||
| delayed_exit.c | ||
| format_nss.h | ||
| ignore_stderr.c | ||
| namespace.h | ||
| oom_error.c | ||
| resolv_test.c | ||
| resolv_test.h | ||
| run_diff.h | ||
| set_fortify_handler.c | ||
| support.h | ||
| support_become_root.c | ||
| support_enter_network_namespace.c | ||
| support_format_address_family.c | ||
| support_format_addrinfo.c | ||
| support_format_dns_packet.c | ||
| support_format_herrno.c | ||
| support_format_hostent.c | ||
| support_format_netent.c | ||
| support_record_failure.c | ||
| support_run_diff.c | ||
| support_test_main.c | ||
| support_test_verify_impl.c | ||
| temp_file-internal.h | ||
| temp_file.c | ||
| temp_file.h | ||
| test-driver.c | ||
| test-driver.h | ||
| tst-support-namespace.c | ||
| tst-support_format_dns_packet.c | ||
| tst-support_record_failure-2.sh | ||
| tst-support_record_failure.c | ||
| write_message.c | ||
| xaccept.c | ||
| xaccept4.c | ||
| xasprintf.c | ||
| xbind.c | ||
| xcalloc.c | ||
| xclose.c | ||
| xconnect.c | ||
| xfclose.c | ||
| xfopen.c | ||
| xfork.c | ||
| xgetsockname.c | ||
| xlisten.c | ||
| xmalloc.c | ||
| xmemstream.c | ||
| xmemstream.h | ||
| xmmap.c | ||
| xmunmap.c | ||
| xpoll.c | ||
| xpthread_attr_destroy.c | ||
| xpthread_attr_init.c | ||
| xpthread_attr_setdetachstate.c | ||
| xpthread_attr_setstacksize.c | ||
| xpthread_barrier_destroy.c | ||
| xpthread_barrier_init.c | ||
| xpthread_barrier_wait.c | ||
| xpthread_cancel.c | ||
| xpthread_check_return.c | ||
| xpthread_cond_wait.c | ||
| xpthread_create.c | ||
| xpthread_detach.c | ||
| xpthread_join.c | ||
| xpthread_mutex_consistent.c | ||
| xpthread_mutex_destroy.c | ||
| xpthread_mutex_init.c | ||
| xpthread_mutex_lock.c | ||
| xpthread_mutex_unlock.c | ||
| xpthread_mutexattr_destroy.c | ||
| xpthread_mutexattr_init.c | ||
| xpthread_mutexattr_setprotocol.c | ||
| xpthread_mutexattr_setpshared.c | ||
| xpthread_mutexattr_setrobust.c | ||
| xpthread_mutexattr_settype.c | ||
| xpthread_once.c | ||
| xpthread_sigmask.c | ||
| xpthread_spin_lock.c | ||
| xpthread_spin_unlock.c | ||
| xrealloc.c | ||
| xrecvfrom.c | ||
| xsendto.c | ||
| xsetsockopt.c | ||
| xsignal.h | ||
| xsocket.c | ||
| xsocket.h | ||
| xstdio.h | ||
| xstrdup.c | ||
| xthread.h | ||
| xunistd.h | ||
| xwaitpid.c | ||
| xwrite.c | ||
README
This subdirectory contains infrastructure which is not put into installed libraries, but may be linked into programs (installed or not) and tests. # Error-checking wrappers These wrappers test for error return codes an terminate the process on error. They are declared in these header files: * support.h * xsignal.h * xthread.h In general, new wrappers should be added to support.h if possible. However, support.h must remain fully compatible with C90 and therefore cannot include headers which use identifers not reserved in C90. If the wrappers need additional types, additional headers such as signal.h need to be introduced. # Test framework The test framework provides a main program for tests, including a timeout for hanging tests. See README-testing.c for a minimal example, and test-driver.c for details how to use it. The following header files provide related declarations: * check.h * temp_file.h * test-driver.h