mirror of git://sourceware.org/git/glibc.git
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
|
||
|---|---|---|
| .. | ||
| arpa | ||
| bits | ||
| netinet | ||
| protocols | ||
| rpc | ||
| Makefile | ||
| Versions | ||
| bindresvport.c | ||
| bug-if1.c | ||
| check_native.c | ||
| check_pf.c | ||
| deadline.c | ||
| etc.rpc | ||
| ether_aton.c | ||
| ether_aton_r.c | ||
| ether_line.c | ||
| ether_ntoa.c | ||
| ether_ntoa_r.c | ||
| getipv4sourcefilter.c | ||
| getsourcefilter.c | ||
| herrno-loc.c | ||
| herrno.c | ||
| htonl.c | ||
| htons.c | ||
| htontest.c | ||
| idna.c | ||
| idna_name_classify.c | ||
| if_index.c | ||
| ifaddrs.c | ||
| ifaddrs.h | ||
| ifreq.c | ||
| in6_addr.c | ||
| inet6_opt.c | ||
| inet6_option.c | ||
| inet6_rth.c | ||
| inet6_scopeid_pton.c | ||
| inet_lnaof.c | ||
| inet_mkadr.c | ||
| inet_net.c | ||
| inet_netof.c | ||
| inet_ntoa.c | ||
| net-internal.h | ||
| rcmd.c | ||
| rexec.c | ||
| ruserpass.c | ||
| setipv4sourcefilter.c | ||
| setsourcefilter.c | ||
| test-hnto-types.c | ||
| test-ifaddrs.c | ||
| test-inet6_opt.c | ||
| test_ifindex.c | ||
| tst-checks-posix.c | ||
| tst-checks.c | ||
| tst-deadline.c | ||
| tst-ether_aton.c | ||
| tst-ether_line.c | ||
| tst-getni1.c | ||
| tst-getni2.c | ||
| tst-idna_name_classify.c | ||
| tst-if_index-long.c | ||
| tst-if_nameindex.c | ||
| tst-inet6_rth.c | ||
| tst-inet6_scopeid_pton.c | ||
| tst-network.c | ||
| tst-ntoa.c | ||
| tst-sockaddr.c | ||