mirror of git://sourceware.org/git/glibc.git
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
|
||
|---|---|---|
| .. | ||
| bits | ||
| sys | ||
| Makefile | ||
| Versions | ||
| accept.c | ||
| accept4.c | ||
| bind.c | ||
| connect.c | ||
| getpeername.c | ||
| getsockname.c | ||
| getsockopt.c | ||
| isfdtype.c | ||
| listen.c | ||
| opensock.c | ||
| recv.c | ||
| recvfrom.c | ||
| recvmmsg.c | ||
| recvmsg.c | ||
| sa_len.c | ||
| send.c | ||
| sendmmsg.c | ||
| sendmsg.c | ||
| sendto.c | ||
| setsockopt.c | ||
| shutdown.c | ||
| sockaddr_un_set.c | ||
| sockatmark.c | ||
| socket.c | ||
| socketpair.c | ||
| tst-accept4.c | ||
| tst-cmsg_cloexec.c | ||
| tst-cmsghdr-skeleton.c | ||
| tst-cmsghdr.c | ||
| tst-connect.c | ||
| tst-shutdown.c | ||
| tst-sockaddr_un_set.c | ||
| tst-sockopt-time64.c | ||
| tst-sockopt.c | ||