qiurui
/
linux-kernelorg-stable
mirror of https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: dsa: b53: do not enable EEE on bcm63xx 

BCM63xx internal switches do not support EEE, but provide multiple RGMII
ports where external PHYs may be connected. If one of these PHYs are EEE
capable, we may try to enable EEE for the MACs, which then hangs the
system on access of the (non-existent) EEE registers.

Fix this by checking if the switch actually supports EEE before
attempting to configure it.

Fixes: 22256b0afb ("net: dsa: b53: Move EEE functions to b53")
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Tested-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Link: https://patch.msgid.link/20250602193953.1010487-2-jonas.gorski@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Jonas Gorski 2025-06-02 21:39:49 +02:00 committed by Paolo Abeni
parent 919d763d60
commit 1237c2d4a8
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/dsa/b53/b53_common.c
View File

@ -2353,6 +2353,9 @@ int b53_eee_init(struct dsa_switch *ds, int port, struct phy_device *phy)
{ {
int ret; int ret;
if (!b53_support_eee(ds, port))
return 0;
ret = phy_init_eee(phy, false); ret = phy_init_eee(phy, false);
if (ret) if (ret)
return 0; return 0;
@ -2367,7 +2370,7 @@ bool b53_support_eee(struct dsa_switch *ds, int port)
{ {
struct b53_device *dev = ds->priv; struct b53_device *dev = ds->priv;
return !is5325(dev) && !is5365(dev); return !is5325(dev) && !is5365(dev) && !is63xx(dev);
} }
EXPORT_SYMBOL(b53_support_eee); EXPORT_SYMBOL(b53_support_eee);