net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups
commit5537a46794
upstream. Drop phylink_{suspend,resume}() from ax88772 PM callbacks. MDIO bus accesses have their own runtime-PM handling and will try to wake the device if it is suspended. Such wake attempts must not happen from PM callbacks while the device PM lock is held. Since phylink {sus|re}sume may trigger MDIO, it must not be called in PM context. No extra phylink PM handling is required for this driver: - .ndo_open/.ndo_stop control the phylink start/stop lifecycle. - ethtool/phylib entry points run in process context, not PM. - phylink MAC ops program the MAC on link changes after resume. Fixes:e0bffe3e68
("net: asix: ax88772: migrate to phylink") Reported-by: Hubert Wiśniewski <hubert.wisniewski.25632@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Tested-by: Hubert Wiśniewski <hubert.wisniewski.25632@gmail.com> Tested-by: Xu Yang <xu.yang_2@nxp.com> Link: https://patch.msgid.link/20250908112619.2900723-1-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
f98d88bf36
commit
2e2eb78906
|
@ -607,15 +607,8 @@ static const struct net_device_ops ax88772_netdev_ops = {
|
||||||
|
|
||||||
static void ax88772_suspend(struct usbnet *dev)
|
static void ax88772_suspend(struct usbnet *dev)
|
||||||
{
|
{
|
||||||
struct asix_common_private *priv = dev->driver_priv;
|
|
||||||
u16 medium;
|
u16 medium;
|
||||||
|
|
||||||
if (netif_running(dev->net)) {
|
|
||||||
rtnl_lock();
|
|
||||||
phylink_suspend(priv->phylink, false);
|
|
||||||
rtnl_unlock();
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Stop MAC operation */
|
/* Stop MAC operation */
|
||||||
medium = asix_read_medium_status(dev, 1);
|
medium = asix_read_medium_status(dev, 1);
|
||||||
medium &= ~AX_MEDIUM_RE;
|
medium &= ~AX_MEDIUM_RE;
|
||||||
|
@ -644,12 +637,6 @@ static void ax88772_resume(struct usbnet *dev)
|
||||||
for (i = 0; i < 3; i++)
|
for (i = 0; i < 3; i++)
|
||||||
if (!priv->reset(dev, 1))
|
if (!priv->reset(dev, 1))
|
||||||
break;
|
break;
|
||||||
|
|
||||||
if (netif_running(dev->net)) {
|
|
||||||
rtnl_lock();
|
|
||||||
phylink_resume(priv->phylink);
|
|
||||||
rtnl_unlock();
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static int asix_resume(struct usb_interface *intf)
|
static int asix_resume(struct usb_interface *intf)
|
||||||
|
|
Loading…
Reference in New Issue