qiurui
/
linux-kernelorg-stable
mirror of https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

nfs/localio: restore creds before releasing pageio data 

[ Upstream commit 992203a1fb ]

Otherwise if the nfsd filecache code releases the nfsd_file
immediately, it can trigger the BUG_ON(cred == current->cred) in
__put_cred() when it puts the nfsd_file->nf_file->f-cred.

Fixes: b9f5dd57f4 ("nfs/localio: use dedicated workqueues for filesystem read and write")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
Link: https://lore.kernel.org/r/20250807164938.2395136-1-smayhew@redhat.com
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Scott Mayhew 2025-08-07 12:49:38 -04:00 committed by Greg Kroah-Hartman
parent a707c9a838
commit 57c1bb02b4
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/nfs/localio.c
View File

@ -425,12 +425,13 @@ static void nfs_local_call_read(struct work_struct *work)
nfs_local_iter_init(&iter, iocb, READ); nfs_local_iter_init(&iter, iocb, READ);
status = filp->f_op->read_iter(&iocb->kiocb, &iter); status = filp->f_op->read_iter(&iocb->kiocb, &iter);
revert_creds(save_cred);
if (status != -EIOCBQUEUED) { if (status != -EIOCBQUEUED) {
nfs_local_read_done(iocb, status); nfs_local_read_done(iocb, status);
nfs_local_pgio_release(iocb); nfs_local_pgio_release(iocb);
} }
revert_creds(save_cred);
} }
static int static int
@ -626,14 +627,15 @@ static void nfs_local_call_write(struct work_struct *work)
file_start_write(filp); file_start_write(filp);
status = filp->f_op->write_iter(&iocb->kiocb, &iter); status = filp->f_op->write_iter(&iocb->kiocb, &iter);
file_end_write(filp); file_end_write(filp);
revert_creds(save_cred);
current->flags = old_flags;
if (status != -EIOCBQUEUED) { if (status != -EIOCBQUEUED) {
nfs_local_write_done(iocb, status); nfs_local_write_done(iocb, status);
nfs_local_vfs_getattr(iocb); nfs_local_vfs_getattr(iocb);
nfs_local_pgio_release(iocb); nfs_local_pgio_release(iocb);
} }
revert_creds(save_cred);
current->flags = old_flags;
} }
static int static int