Petr Tesarik 38cc3c6dcc net: stmmac: protect updates of 64-bit statistics counters ... As explained by a comment in <linux/u64_stats_sync.h>, write side of struct u64_stats_sync must ensure mutual exclusion, or one seqcount update could be lost on 32-bit platforms, thus blocking readers forever. Such lockups have been observed in real world after stmmac_xmit() on one CPU raced with stmmac_napi_poll_tx() on another CPU. To fix the issue without introducing a new lock, split the statics into three parts: 1. fields updated only under the tx queue lock, 2. fields updated only during NAPI poll, 3. fields updated only from interrupt context, Updates to fields in the first two groups are already serialized through other locks. It is sufficient to split the existing struct u64_stats_sync so that each group has its own. Note that tx_set_ic_bit is updated from both contexts. Split this counter so that each context gets its own, and calculate their sum to get the total value in stmmac_get_ethtool_stats(). For the third group, multiple interrupts may be processed by different CPUs at the same time, but interrupts on the same CPU will not nest. Move fields from this group to a newly created per-cpu struct stmmac_pcpu_stats. Fixes: 133466c3bb ("net: stmmac: use per-queue 64 bit statistics where necessary") Link: https://lore.kernel.org/netdev/Za173PhviYg-1qIn@torres.zugschlus.de/t/ Cc: stable@vger.kernel.org Signed-off-by: Petr Tesarik <petr@tesarici.cz> Reviewed-by: Jisheng Zhang <jszhang@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2024-02-07 09:00:34 +00:00
..
accel	accel/ivpu: Improve recovery and reset support	2024-01-25 10:17:37 +01:00
accessibility	…
acpi	cxl for v6.8	2024-01-18 16:22:43 -08:00
amba	…
android	Char/Misc and other Driver changes for 6.8-rc1	2024-01-17 16:47:17 -08:00
ata	ahci: add 43-bit DMA address quirk for ASMedia ASM1061 controllers	2024-01-25 16:59:09 +01:00
atm	atm: idt77252: fix a memleak in open_card_ubr0	2024-02-03 12:46:13 +00:00
auxdisplay	…
base	RTC for 6.8	2024-01-18 17:25:39 -08:00
bcma	…
block	block-6.8-2024-01-26	2024-01-26 15:19:43 -08:00
bluetooth	USB / Thunderbolt changes for 6.8-rc1	2024-01-18 11:43:55 -08:00
bus	Char/Misc and other Driver changes for 6.8-rc1	2024-01-17 16:47:17 -08:00
cache	…
cdrom	…
cdx	…
char	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
clk	clk: qcom: gcc-x1e80100: Replace of_device.h with explicit includes	2024-01-19 08:17:28 -06:00
clocksource	…
comedi	…
connector	…
counter	…
cpufreq	cpufreq/amd-pstate: Fix setting scaling max/min freq values	2024-01-22 20:35:58 +01:00
cpuidle	…
crypto	crypto: caam - fix asynchronous hash	2024-01-26 16:35:55 +08:00
cxl	cxl/region：Fix overflow issue in alloc_hpa()	2024-01-24 21:03:03 -08:00
dax	…
dca	…
devfreq	…
dio	…
dma	dmaengine fixes for v6.8-rc1	2024-01-20 15:03:25 -08:00
dma-buf	…
dpll	dpll: fix register pin with unregistered parent pin	2024-01-22 11:01:11 +00:00
edac	Driver core changes for 6.8-rc1	2024-01-18 09:48:40 -08:00
eisa	…
extcon	…
firewire	firewire: core: search descriptor leaf just after vendor directory entry in root directory	2024-02-01 20:53:18 +09:00
firmware	drm fixes for 6.8-rc2	2024-01-26 13:52:18 -08:00
fpga	Char/Misc and other Driver changes for 6.8-rc1	2024-01-17 16:47:17 -08:00
fsi	…
gnss	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
gpio	gpio: eic-sprd: Clear interrupt after set the interrupt type	2024-01-22 11:38:08 +01:00
gpu	One regression fixup to samsung-dsim.c module	2024-01-27 04:12:21 +10:00
greybus	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
hid	HID: bpf: use __bpf_kfunc instead of noinline	2024-01-31 10:27:08 +01:00
hsi	…
hte	…
hv	…
hwmon	hwmon: (npcm750-pwm-fan) Fix crash observed when instantiating nuvoton,npcm750-pwm-fan	2024-01-14 07:44:38 -08:00
hwspinlock	…
hwtracing	…
i2c	This cycle, I2C removes the currently unused CLASS_DDC support	2024-01-18 17:29:01 -08:00
i3c	…
idle	…
iio	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
infiniband	…
input	Input updates for 6.8 merge window:	2024-01-18 17:21:35 -08:00
interconnect	Char/Misc and other Driver changes for 6.8-rc1	2024-01-17 16:47:17 -08:00
iommu	iommufd for 6.8	2024-01-18 15:28:15 -08:00
ipack	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
irqchip	…
isdn	…
leds	- New Drivers	2024-01-17 15:25:27 -08:00
macintosh	…
mailbox	mediatek: add CMDQ support for mt8188	2024-01-17 15:39:32 -08:00
mcb	…
md	md: fix a suspicious RCU usage warning	2024-01-24 22:58:00 -08:00
media	media: vb2: refactor setting flags and caps, fix missing cap	2024-01-24 17:27:51 +01:00
memory	IOMMU Updates for Linux v6.8	2024-01-18 15:16:57 -08:00
memstick	…
message	…
mfd	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
misc	This cycle, I2C removes the currently unused CLASS_DDC support	2024-01-18 17:29:01 -08:00
mmc	TTY/Serial changes for 6.8-rc1	2024-01-18 11:37:24 -08:00
most	…
mtd	This pull request contains updates for UBI and UBIFS:	2024-01-17 10:27:13 -08:00
mux	…
net	net: stmmac: protect updates of 64-bit statistics counters	2024-02-07 09:00:34 +00:00
nfc	…
ntb	…
nubus	…
nvdimm	virtio: features, fixes	2024-01-18 16:44:03 -08:00
nvme	for-6.8/block-2024-01-18	2024-01-18 18:22:40 -08:00
nvmem	Char/Misc and other Driver changes for 6.8-rc1	2024-01-17 16:47:17 -08:00
of	IOMMU Updates for Linux v6.8	2024-01-18 15:16:57 -08:00
opp	…
parisc	…
parport	…
pci	cxl for v6.8	2024-01-18 16:22:43 -08:00
pcmcia	…
peci	…
perf	…
phy	phy-for-6.8	2024-01-18 17:11:43 -08:00
pinctrl	This is the main pin control pull request for the v6.8 kernel series.	2024-01-17 15:55:33 -08:00
platform	platform/x86: touchscreen_dmi: Add info for the TECLAST X16 Plus tablet	2024-01-26 20:21:47 +01:00
pmdomain	Driver core changes for 6.8-rc1	2024-01-18 09:48:40 -08:00
pnp	More ACPI updates for 6.8-rc1	2024-01-17 14:37:40 -08:00
power	power: supply: bq24190_charger: Fix "initializer element is not constant" error	2024-01-19 01:03:17 +01:00
powercap	…
pps	…
ps3	…
ptp	…
pwm	…
rapidio	…
ras	…
regulator	regulator (max5970): Fix IRQ handler	2024-01-30 15:27:16 +00:00
remoteproc	…
reset	…
rpmsg	…
rtc	rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R	2024-01-18 01:05:33 +01:00
s390	s390 updates for 6.8 merge window part 2	2024-01-18 14:11:25 -08:00
sbus	…
scsi	scsi: storvsc: Fix ring buffer size calculation	2024-01-23 21:27:28 -05:00
sh	…
siox	…
slimbus	…
soc	soc: apple: mailbox: error pointers are negative integers	2024-01-30 11:34:49 -08:00
soundwire	soundwire updates for 6.7	2024-01-18 17:08:31 -08:00
spi	spi: sh-msiof: avoid integer overflow in constants	2024-01-30 15:27:21 +00:00
spmi	…
ssb	…
staging	This cycle, I2C removes the currently unused CLASS_DDC support	2024-01-18 17:29:01 -08:00
target	SCSI misc on 20240120	2024-01-20 09:42:32 -08:00
tc	…
tee	…
thermal	thermal: intel: powerclamp: Remove dead code for target mwait value	2024-01-22 11:59:22 +01:00
thunderbolt	USB / Thunderbolt changes for 6.8-rc1	2024-01-18 11:43:55 -08:00
tty	RISC-V Patches for the 6.8 Merge Window, Part 4	2024-01-20 11:06:04 -08:00
ufs	SCSI misc on 20240120	2024-01-20 09:42:32 -08:00
uio	…
usb	USB / Thunderbolt changes for 6.8-rc1	2024-01-18 11:43:55 -08:00
vdpa	virtio: features, fixes	2024-01-18 16:44:03 -08:00
vfio	VFIO updates for v6.8-rc1	2024-01-18 15:57:25 -08:00
vhost	virtio: features, fixes	2024-01-18 16:44:03 -08:00
video	fbdev: stifb: Fix crash in stifb_blank()	2024-01-23 09:13:24 +01:00
virt	Char/Misc and other Driver changes for 6.8-rc1	2024-01-17 16:47:17 -08:00
virtio	virtio: features, fixes	2024-01-18 16:44:03 -08:00
w1	…
watchdog	…
xen	xen: branch for v6.8-rc1	2024-01-17 13:41:38 -08:00
zorro	…
Kconfig	…
Makefile	…