linux-kernelorg-stable

Go to file

Vladimir Oltean 4e0c19fcb8 net: dsa: don't leak tagger-owned storage on switch driver unbind In the initial commit `dc452a471d` ("net: dsa: introduce tagger-owned storage for private and shared data"), we had a call to tag_ops->disconnect(dst) issued from dsa_tree_free(), which is called at tree teardown time. There were problems with connecting to a switch tree as a whole, so this got reworked to connecting to individual switches within the tree. In this process, tag_ops->disconnect(ds) was made to be called only from switch.c (cross-chip notifiers emitted as a result of dynamic tag proto changes), but the normal driver teardown code path wasn't replaced with anything. Solve this problem by adding a function that does the opposite of dsa_switch_setup_tag_protocol(), which is called from the equivalent spot in dsa_switch_teardown(). The positioning here also ensures that we won't have any use-after-free in tagging protocol (*rcv) ops, since the teardown sequence is as follows: dsa_tree_teardown -> dsa_tree_teardown_master -> dsa_master_teardown -> unsets master->dsa_ptr, making no further packets match the ETH_P_XDSA packet type handler -> dsa_tree_teardown_ports -> dsa_port_teardown -> dsa_slave_destroy -> unregisters DSA net devices, there is even a synchronize_net() in unregister_netdevice_many() -> dsa_tree_teardown_switches -> dsa_switch_teardown -> dsa_switch_teardown_tag_protocol -> finally frees the tagger-owned storage Fixes: `7f2973149c` ("net: dsa: make tagging protocols connect to individual switches from a tree") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Saeed Mahameed <saeed@kernel.org> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Link: https://lore.kernel.org/r/20221114143551.1906361-1-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2022-11-15 20:50:52 -08:00
Documentation	Including fixes from netfilter, wifi, can and bpf.	2022-11-10 17:31:15 -08:00
LICENSES	…
arch	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2022-11-11 18:27:40 -08:00
block	…
certs	…
crypto	…
drivers	net: ag71xx: call phylink_disconnect_phy if ag71xx_hw_enable() fail in ag71xx_open()	2022-11-15 20:22:12 -08:00
fs	for-6.1-rc4-tag	2022-11-10 08:58:29 -08:00
include	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2022-11-11 18:27:40 -08:00
init	…
io_uring	…
ipc	…
kernel	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2022-11-11 18:27:40 -08:00
lib	…
mm	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2022-11-11 18:27:40 -08:00
net	net: dsa: don't leak tagger-owned storage on switch driver unbind	2022-11-15 20:50:52 -08:00
rust	…
samples	…
scripts	…
security	…
sound	…
tools	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2022-11-11 18:27:40 -08:00
usr	…
virt	…
.clang-format	…
.cocciconfig	…
.get_maintainer.ignore	…
.gitattributes	…
.gitignore	…
.mailmap	…
.rustfmt.toml	…
COPYING	…
CREDITS	MAINTAINERS: Move Vivien to CREDITS	2022-11-10 13:53:53 -08:00
Kbuild	…
Kconfig	…
MAINTAINERS	Including fixes from netfilter, wifi, can and bpf.	2022-11-10 17:31:15 -08:00
Makefile	…
README	…

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.