qiurui
/
openwrt
mirror of https://git.openwrt.org/openwrt/openwrt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gpio-button-hotplug: use devm_kmemdup_array 

Eliminates a manual memcpy.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/19932
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Rosen Penev 2025-11-28 15:31:24 -08:00 committed by Hauke Mehrtens
parent 5b263f3360
commit 616b0cebe7
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
View File

@ -463,13 +463,12 @@ static int gpio_keys_button_probe(struct platform_device *pdev,
return -EINVAL; return -EINVAL;
} }
buttons = devm_kzalloc(dev, pdata->nbuttons * sizeof(struct gpio_keys_button), buttons = devm_kmemdup_array(dev, pdata->buttons, pdata->nbuttons, sizeof(struct gpio_keys_button),
GFP_KERNEL); GFP_KERNEL);
if (!buttons) { if (!buttons) {
dev_err(dev, "no memory for button data\n"); dev_err(dev, "no memory for button data\n");
return -ENOMEM; return -ENOMEM;
} }
memcpy(buttons, pdata->buttons, pdata->nbuttons * sizeof(struct gpio_keys_button));
bdev = devm_kzalloc(dev, sizeof(struct gpio_keys_button_dev) + bdev = devm_kzalloc(dev, sizeof(struct gpio_keys_button_dev) +
pdata->nbuttons * sizeof(struct gpio_keys_button_data), pdata->nbuttons * sizeof(struct gpio_keys_button_data),