qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
qtdeclarative/tests/auto/quickcontrols2/controls/data/tst_toolbutton.qml

206 lines
7.3 KiB
QML
Raw Normal View History

Use SPDX license identifiers Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-05-13 13:12:05 +00:00
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR BSD-3-Clause
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
Remove all version numbers from QML imports As of Qt 6, the latest version will be used by default. This saves us a lot of effort in terms of version bumps. Task-number: QTBUG-82922 Change-Id: I74eba8185ec3ccc75bc293d4b2ea87d59e2d9928 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-03-26 16:01:51 +00:00
import QtQuick
import QtTest
import QtQuick.Controls
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
TestCase {
id: testCase
width: 200
height: 200
visible: true
when: windowShown
name: "ToolButton"
auto tests: prefer creating signal spies locally where needed It is tedious to always add new static SignalSpy instances for each tested signal. Just create signal spies locally in the same place where they are used. This makes it much more convenient to create more signal spies to achieve better coverage. This practice has been already used in newly written tests. Change-Id: I7f56c4b3cea0c55c34b85254f69a88ec73b8607f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-10-07 12:51:51 +00:00
Component {
id: signalSpy
SignalSpy { }
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
}
Component {
id: toolButton
ToolButton { }
}
Fail on warnings for simple "default" controls tests This patch: - Adds a simple, "default-constructed" (i.e. little or no properties set) test function for each control where one was missing. - Causes those tests to fail on any warning. It would be simpler to just call failOnWarnings(/.?/) in the initTestCase() of each test, but there are too marning warnings to fix right now. Task-number: QTBUG-98718 Change-Id: Ia3aa901feab5db534925824528caf25297e02760 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-25 08:11:57 +00:00
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(toolButton, testCase)
verify(control)
}
Cleanup & improve auto tests - always verify component creation to catch errors early - remove empty init() and cleanup() functions - remove redundant "defaults" checks Change-Id: I39f16404fa2e3d3e38348742afd8f51ea36b2f05 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-06-29 17:14:55 +00:00
function test_text() {
tst_toolbutton: use TestCase's new createTemporaryObject functions This ensures that the appropriate objects are destroyed at the end of each test function, even if the test fails. Change-Id: Ie6e050fdd77b1711350ecc00f05d2e6bcd979fc5 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-12-20 11:48:27 +00:00
var control = createTemporaryObject(toolButton, testCase)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
verify(control)
compare(control.text, "")
control.text = "ToolButton"
compare(control.text, "ToolButton")
control.text = ""
compare(control.text, "")
}
function test_mouse() {
tst_toolbutton: use TestCase's new createTemporaryObject functions This ensures that the appropriate objects are destroyed at the end of each test function, even if the test fails. Change-Id: Ie6e050fdd77b1711350ecc00f05d2e6bcd979fc5 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-12-20 11:48:27 +00:00
var control = createTemporaryObject(toolButton, testCase)
Cleanup & improve auto tests - always verify component creation to catch errors early - remove empty init() and cleanup() functions - remove redundant "defaults" checks Change-Id: I39f16404fa2e3d3e38348742afd8f51ea36b2f05 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-06-29 17:14:55 +00:00
verify(control)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
auto tests: prefer creating signal spies locally where needed It is tedious to always add new static SignalSpy instances for each tested signal. Just create signal spies locally in the same place where they are used. This makes it much more convenient to create more signal spies to achieve better coverage. This practice has been already used in newly written tests. Change-Id: I7f56c4b3cea0c55c34b85254f69a88ec73b8607f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-10-07 12:51:51 +00:00
var pressedSpy = signalSpy.createObject(control, {target: control, signalName: "pressedChanged"})
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
verify(pressedSpy.valid)
auto tests: prefer creating signal spies locally where needed It is tedious to always add new static SignalSpy instances for each tested signal. Just create signal spies locally in the same place where they are used. This makes it much more convenient to create more signal spies to achieve better coverage. This practice has been already used in newly written tests. Change-Id: I7f56c4b3cea0c55c34b85254f69a88ec73b8607f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-10-07 12:51:51 +00:00
var downSpy = signalSpy.createObject(control, {target: control, signalName: "downChanged"})
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
verify(downSpy.valid)
auto tests: prefer creating signal spies locally where needed It is tedious to always add new static SignalSpy instances for each tested signal. Just create signal spies locally in the same place where they are used. This makes it much more convenient to create more signal spies to achieve better coverage. This practice has been already used in newly written tests. Change-Id: I7f56c4b3cea0c55c34b85254f69a88ec73b8607f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-10-07 12:51:51 +00:00
var clickedSpy = signalSpy.createObject(control, {target: control, signalName: "clicked"})
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
verify(clickedSpy.valid)
// check
Fix tst_toolbutton.qml A copy-paste mistake. There's no such thing as Qt.LeftToolButton. It evaluated to undefined, and ended up using the default value Qt.LeftButton. Change-Id: Ie8d6714f663daa2bdfed2645a4fdc3e370e236ed Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-01-12 13:59:44 +00:00
mousePress(control, control.width / 2, control.height / 2, Qt.LeftButton)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(pressedSpy.count, 1)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 1)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, true)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, true)
Fix tst_toolbutton.qml A copy-paste mistake. There's no such thing as Qt.LeftToolButton. It evaluated to undefined, and ended up using the default value Qt.LeftButton. Change-Id: Ie8d6714f663daa2bdfed2645a4fdc3e370e236ed Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-01-12 13:59:44 +00:00
mouseRelease(control, control.width / 2, control.height / 2, Qt.LeftButton)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(clickedSpy.count, 1)
compare(pressedSpy.count, 2)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 2)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, false)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, false)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
// uncheck
Fix tst_toolbutton.qml A copy-paste mistake. There's no such thing as Qt.LeftToolButton. It evaluated to undefined, and ended up using the default value Qt.LeftButton. Change-Id: Ie8d6714f663daa2bdfed2645a4fdc3e370e236ed Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-01-12 13:59:44 +00:00
mousePress(control, control.width / 2, control.height / 2, Qt.LeftButton)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(pressedSpy.count, 3)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 3)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, true)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, true)
Fix tst_toolbutton.qml A copy-paste mistake. There's no such thing as Qt.LeftToolButton. It evaluated to undefined, and ended up using the default value Qt.LeftButton. Change-Id: Ie8d6714f663daa2bdfed2645a4fdc3e370e236ed Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-01-12 13:59:44 +00:00
mouseRelease(control, control.width / 2, control.height / 2, Qt.LeftButton)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(clickedSpy.count, 2)
compare(pressedSpy.count, 4)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 4)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, false)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, false)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
// release outside
Fix tst_toolbutton.qml A copy-paste mistake. There's no such thing as Qt.LeftToolButton. It evaluated to undefined, and ended up using the default value Qt.LeftButton. Change-Id: Ie8d6714f663daa2bdfed2645a4fdc3e370e236ed Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-01-12 13:59:44 +00:00
mousePress(control, control.width / 2, control.height / 2, Qt.LeftButton)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(pressedSpy.count, 5)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 5)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, true)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, true)
Merge remote-tracking branch 'origin/5.8' into dev Conflicts: src/quicktemplates2/qquickswitch.cpp src/quicktemplates2/qquickswitchdelegate.cpp tests/auto/controls/data/tst_dialogbuttonbox.qml tests/auto/controls/data/tst_toolbutton.qml Change-Id: I1da1d6de83c1d9ac854dfce1d6c9d6ba2c460404
2017-01-20 11:55:54 +00:00
mouseMove(control, control.width * 2, control.height * 2)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, false)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, false)
Fix tst_toolbutton.qml A copy-paste mistake. There's no such thing as Qt.LeftToolButton. It evaluated to undefined, and ended up using the default value Qt.LeftButton. Change-Id: Ie8d6714f663daa2bdfed2645a4fdc3e370e236ed Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2017-01-12 13:59:44 +00:00
mouseRelease(control, control.width * 2, control.height * 2, Qt.LeftButton)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(clickedSpy.count, 2)
compare(pressedSpy.count, 6)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 6)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, false)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, false)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
// right button
mousePress(control, control.width / 2, control.height / 2, Qt.RightButton)
compare(pressedSpy.count, 6)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 6)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, false)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, false)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
mouseRelease(control, control.width / 2, control.height / 2, Qt.RightButton)
compare(clickedSpy.count, 2)
compare(pressedSpy.count, 6)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(downSpy.count, 6)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
compare(control.pressed, false)
Add QQuickAbstractButton::down This property will determine whether or not the button is visually pressed. Having such a distinction allows users more control over their controls. The patch also fixes the problem with ComboBox where pressing on the ComboBox when it's open would cause a delegate in the popup to show as being pressed. Unless explicitly set, this property follows the value of the pressed property. To return to the default value, set it to undefined. Change-Id: I29ecf325ed2ede125613f0c878b0427937599866 Task-number: QTBUG-51005 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2016-04-12 14:19:58 +00:00
compare(control.down, false)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
}
function test_keys() {
tst_toolbutton: use TestCase's new createTemporaryObject functions This ensures that the appropriate objects are destroyed at the end of each test function, even if the test fails. Change-Id: Ie6e050fdd77b1711350ecc00f05d2e6bcd979fc5 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-12-20 11:48:27 +00:00
var control = createTemporaryObject(toolButton, testCase)
Cleanup & improve auto tests - always verify component creation to catch errors early - remove empty init() and cleanup() functions - remove redundant "defaults" checks Change-Id: I39f16404fa2e3d3e38348742afd8f51ea36b2f05 Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-06-29 17:14:55 +00:00
verify(control)
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
auto tests: prefer creating signal spies locally where needed It is tedious to always add new static SignalSpy instances for each tested signal. Just create signal spies locally in the same place where they are used. This makes it much more convenient to create more signal spies to achieve better coverage. This practice has been already used in newly written tests. Change-Id: I7f56c4b3cea0c55c34b85254f69a88ec73b8607f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2016-10-07 12:51:51 +00:00
var clickedSpy = signalSpy.createObject(control, {target: control, signalName: "clicked"})
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
verify(clickedSpy.valid)
control.forceActiveFocus()
verify(control.activeFocus)
// check
keyClick(Qt.Key_Space)
compare(clickedSpy.count, 1)
// uncheck
keyClick(Qt.Key_Space)
compare(clickedSpy.count, 2)
// no change
Qt Quick Controls: use QPlatformTheme::ButtonPressKeys for buttons ComboBox changes are included because it is button-like when not editable. MenuItem changes are included because it is an AbstractButton subclass. Change-Id: I30a540bc9e277cddc111cbc2400c4130dadedb3c Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2022-02-16 21:57:50 +00:00
// Not testing Key_Enter and Key_Return because QGnomeTheme uses them for
// pressing buttons and the CI uses the QGnomeTheme platform theme.
var keys = [Qt.Key_Escape, Qt.Key_Tab]
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
for (var i = 0; i < keys.length; ++i) {
keyClick(keys[i])
compare(clickedSpy.count, 2)
}
}
Specify baseline offsets Change-Id: I4845a7beac2edc0f0bcc1c810edd7d9e86f31c87 Task-number: QTBUG-49468 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-25 00:04:19 +00:00
function test_baseline() {
tst_toolbutton: use TestCase's new createTemporaryObject functions This ensures that the appropriate objects are destroyed at the end of each test function, even if the test fails. Change-Id: Ie6e050fdd77b1711350ecc00f05d2e6bcd979fc5 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2016-12-20 11:48:27 +00:00
var control = createTemporaryObject(toolButton, testCase)
Specify baseline offsets Change-Id: I4845a7beac2edc0f0bcc1c810edd7d9e86f31c87 Task-number: QTBUG-49468 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-25 00:04:19 +00:00
verify(control)
ToolButton: migrage from label to contentItem Change-Id: Iacc8ba21e48f40062d0784c76d33dbf79ce803e0 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2016-02-04 16:34:19 +00:00
compare(control.baselineOffset, control.contentItem.y + control.contentItem.baselineOffset)
Specify baseline offsets Change-Id: I4845a7beac2edc0f0bcc1c810edd7d9e86f31c87 Task-number: QTBUG-49468 Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-11-25 00:04:19 +00:00
}
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
function test_display_data() {
return [
{ "tag": "IconOnly", display: ToolButton.IconOnly },
{ "tag": "TextOnly", display: ToolButton.TextOnly },
Implement QQuickIconLabel::TextUnderIcon This will be the default for TabButton and RoundButton. Change-Id: I9ccb0d35f33a80fe7e3da26617ed6f42232afe17 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-10 13:42:03 +00:00
{ "tag": "TextUnderIcon", display: ToolButton.TextUnderIcon },
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
{ "tag": "TextBesideIcon", display: ToolButton.TextBesideIcon },
{ "tag": "IconOnly, mirrored", display: ToolButton.IconOnly, mirrored: true },
{ "tag": "TextOnly, mirrored", display: ToolButton.TextOnly, mirrored: true },
Implement QQuickIconLabel::TextUnderIcon This will be the default for TabButton and RoundButton. Change-Id: I9ccb0d35f33a80fe7e3da26617ed6f42232afe17 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-10 13:42:03 +00:00
{ "tag": "TextUnderIcon, mirrored", display: ToolButton.TextUnderIcon, mirrored: true },
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
{ "tag": "TextBesideIcon, mirrored", display: ToolButton.TextBesideIcon, mirrored: true }
]
}
function test_display(data) {
var control = createTemporaryObject(toolButton, testCase, {
text: "ToolButton",
display: data.display,
Rename "Default" style to "Basic" [ChangeLog][Styles] The Default style was renamed to Basic to account for the introduction of the platform styles (macOS, Windows), which will be used by default (where possible) when no style is specified. Fixes: QTBUG-85984 Task-number: QTBUG-68814 Task-number: QTBUG-86403 Change-Id: I22b3199c8662e4ee5d55a1be1a51c9856ac62376 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-09-01 15:49:42 +00:00
"icon.source": "qrc:/qt-project.org/imports/QtQuick/Controls/Basic/images/check.png",
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
"LayoutMirroring.enabled": !!data.mirrored
})
verify(control)
Rename "Default" style to "Basic" [ChangeLog][Styles] The Default style was renamed to Basic to account for the introduction of the platform styles (macOS, Windows), which will be used by default (where possible) when no style is specified. Fixes: QTBUG-85984 Task-number: QTBUG-68814 Task-number: QTBUG-86403 Change-Id: I22b3199c8662e4ee5d55a1be1a51c9856ac62376 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2020-09-01 15:49:42 +00:00
compare(control.icon.source, "qrc:/qt-project.org/imports/QtQuick/Controls/Basic/images/check.png")
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
var iconImage = findChild(control.contentItem, "image")
var textLabel = findChild(control.contentItem, "label")
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
switch (control.display) {
case ToolButton.IconOnly:
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
verify(iconImage)
verify(!textLabel)
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
compare(iconImage.x, (control.availableWidth - iconImage.width) / 2)
Implement QQuickIconLabel::TextUnderIcon This will be the default for TabButton and RoundButton. Change-Id: I9ccb0d35f33a80fe7e3da26617ed6f42232afe17 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-10 13:42:03 +00:00
compare(iconImage.y, (control.availableHeight - iconImage.height) / 2)
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
break;
case ToolButton.TextOnly:
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
verify(!iconImage)
verify(textLabel)
compare(textLabel.x, (control.availableWidth - textLabel.width) / 2)
compare(textLabel.y, (control.availableHeight - textLabel.height) / 2)
Implement QQuickIconLabel::TextUnderIcon This will be the default for TabButton and RoundButton. Change-Id: I9ccb0d35f33a80fe7e3da26617ed6f42232afe17 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-10 13:42:03 +00:00
break;
case ToolButton.TextUnderIcon:
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
verify(iconImage)
verify(textLabel)
Implement QQuickIconLabel::TextUnderIcon This will be the default for TabButton and RoundButton. Change-Id: I9ccb0d35f33a80fe7e3da26617ed6f42232afe17 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-10 13:42:03 +00:00
compare(iconImage.x, (control.availableWidth - iconImage.width) / 2)
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
compare(textLabel.x, (control.availableWidth - textLabel.width) / 2)
verify(iconImage.y < textLabel.y)
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
break;
case ToolButton.TextBesideIcon:
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
verify(iconImage)
verify(textLabel)
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
if (control.mirrored)
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
verify(textLabel.x < iconImage.x)
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
else
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
verify(iconImage.x < textLabel.x)
Implement QQuickIconLabel::TextUnderIcon This will be the default for TabButton and RoundButton. Change-Id: I9ccb0d35f33a80fe7e3da26617ed6f42232afe17 Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-10 13:42:03 +00:00
compare(iconImage.y, (control.availableHeight - iconImage.height) / 2)
QQuickIconLabel: create icon and label items lazily Before: Average: 120.2 frames; using samples; MedianAll=120; StdDev=0.447214, CoV=0.00372058 After: Average: 129.8 frames; using samples; MedianAll=130; StdDev=0.447214, CoV=0.00344541 Task-number: QTBUG-59746 Change-Id: I44b521688cd60e7e287968828f9d4062cc642a0d Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-04-11 14:42:12 +00:00
compare(textLabel.y, (control.availableHeight - textLabel.height) / 2)
ToolButton: add support for icons Task-number: QTBUG-49820 Change-Id: I0292ad45e9c775af3a3216266c61704fc8375d5a Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
2017-02-24 10:41:25 +00:00
break;
}
}
Import the Qt Quick Controls 2 prototype Change-Id: Ib8c0c4160958e5cfea29a6e9df1b3f1fb19715fc Reviewed-by: Jari-Pekka Nurmi <jpnurmi@theqtcompany.com>
2015-01-30 19:57:40 +00:00
}