qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
qtdeclarative/tests/auto/quick/qquickmousearea/tst_qquickmousearea.cpp

2630 lines
96 KiB
C++
Raw Normal View History

Use SPDX license identifiers Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-05-13 13:12:05 +00:00
// Copyright (C) 2020 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
#include <QtTest/QtTest>
#include <QtTest/QSignalSpy>
Add support for external drag and drop in Quick items. Add dragType enums with values of None, Automatic, Internal (default). Setting to Automatic allows startDrag to be called automatically. Setting to Internal (default) retains old behavior. Add mimeData to Drag item to enable external drags. Call startDrag to start drag manually or change from internal drag to external drag. Added events dragStarted and dragFinished that get invoked from startDrag. Mime data must be specified in the mimeData property as mime-type / data pairs. Moved QQuickDrag from qquickmousearea* files to qquickdrag* files to reduce header interdependencies that caused linking errors in other modules and also to improve code organization. Allow DropArea to receive and process external data. Introduced new variable containsDrag to QQuickDropAreaPrivate. This replaces mimeData which was previously being used to determine if a drop operation was currently occurring. The problem was that mimeData was being externally destructed. Also introduced accessor methods for getting color, html, image, text, and urls out of the drop. This facilitates dropping of external data of those types onto a DropArea. Added example quick/externaldraganddrop. Task-number: QTBUG-27498 Change-Id: I1420df7c161ea3399e49a23305273e106baa246f Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-08-26 23:15:23 +00:00
#include <QtQuick/private/qquickdrag_p.h>
MouseArea: add autotest for subtreeHoverEnabled Verify the fix in f7e462b. Task-number: QTBUG-54019 Change-Id: Ia9846f9b79473ea4f72e895320cf01d5d85cc1a3 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-06-20 09:57:43 +00:00
#include <QtQuick/private/qquickitem_p.h>
Say hello to QtQuick module This change moves the QtQuick 2 types and C++ API (including SceneGraph) to a new module (AKA library), QtQuick. 99% of this change is moving files from src/declarative to src/quick, and from tests/auto/declarative to tests/auto/qtquick2. The loading of QtQuick 2 ("import QtQuick 2.0") is now delegated to a plugin, src/imports/qtquick2, just like it's done for QtQuick 1. All tools, examples, and tests that use QtQuick C++ API have gotten "QT += quick" or "QT += quick-private" added to their .pro file. A few additional internal QtDeclarative classes had to be exported (via Q_DECLARATIVE_PRIVATE_EXPORT) since they're needed by the QtQuick 2 implementation. The old header locations (e.g. QtDeclarative/qquickitem.h) will still be supported for some time, but will produce compile-time warnings. (To avoid the QtQuick implementation using the compatibility headers (since QtDeclarative's includepath comes first), a few include statements were modified, e.g. from "#include <qsgnode.h>" to "#include <QtQuick/qsgnode.h>".) There's a change in qtbase that automatically adds QtQuick to the module list if QtDeclarative is used. Together with the compatibility headers, this should help reduce the migration pain for existing projects. In theory, simply getting an existing QtDeclarative-based project to compile and link shouldn't require any changes for now -- but porting to the new scheme is of course recommended, and will eventually become mandatory. Task-number: QTBUG-22889 Reviewed-by: Lars Knoll <lars.knoll@nokia.com> Change-Id: Ia52be9373172ba2f37e7623231ecb060316c96a7 Reviewed-by: Kent Hansen <kent.hansen@nokia.com> Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
2011-11-23 14:14:07 +00:00
#include <QtQuick/private/qquickmousearea_p.h>
#include <QtQuick/private/qquickrectangle_p.h>
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
#include <private/qquickflickable_p.h>
Say hello to QtQuick module This change moves the QtQuick 2 types and C++ API (including SceneGraph) to a new module (AKA library), QtQuick. 99% of this change is moving files from src/declarative to src/quick, and from tests/auto/declarative to tests/auto/qtquick2. The loading of QtQuick 2 ("import QtQuick 2.0") is now delegated to a plugin, src/imports/qtquick2, just like it's done for QtQuick 1. All tools, examples, and tests that use QtQuick C++ API have gotten "QT += quick" or "QT += quick-private" added to their .pro file. A few additional internal QtDeclarative classes had to be exported (via Q_DECLARATIVE_PRIVATE_EXPORT) since they're needed by the QtQuick 2 implementation. The old header locations (e.g. QtDeclarative/qquickitem.h) will still be supported for some time, but will produce compile-time warnings. (To avoid the QtQuick implementation using the compatibility headers (since QtDeclarative's includepath comes first), a few include statements were modified, e.g. from "#include <qsgnode.h>" to "#include <QtQuick/qsgnode.h>".) There's a change in qtbase that automatically adds QtQuick to the module list if QtDeclarative is used. Together with the compatibility headers, this should help reduce the migration pain for existing projects. In theory, simply getting an existing QtDeclarative-based project to compile and link shouldn't require any changes for now -- but porting to the new scheme is of course recommended, and will eventually become mandatory. Task-number: QTBUG-22889 Reviewed-by: Lars Knoll <lars.knoll@nokia.com> Change-Id: Ia52be9373172ba2f37e7623231ecb060316c96a7 Reviewed-by: Kent Hansen <kent.hansen@nokia.com> Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
2011-11-23 14:14:07 +00:00
#include <QtQuick/qquickview.h>
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
#include <QtQml/qqmlcontext.h>
#include <QtQml/qqmlengine.h>
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
#include <QtQuickTestUtils/private/qmlutils_p.h>
#include <QtQuickTestUtils/private/viewtestutils_p.h>
Improve test to use actual double click timeout. I'll keep the function marked as skip since I have no clue if this is even remotely connected to the issues it was having. Change-Id: I04b2a4f61321553804d29ef076178ea7c63b0deb Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-04-21 02:45:58 +00:00
#include <QtGui/qstylehints.h>
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
#include <QtGui/QCursor>
#include <QtGui/QScreen>
Do not rely on transitive includes in tests Change-Id: Icb68dbecab6f675352cd58333c82fa6648025367 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-02-06 16:57:33 +00:00
#include <QEvent>
#include <QQmlComponent>
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
#include <qpa/qwindowsysteminterface.h>
Don't ungrab for a TabletRelease event: wait for the synth-mouse release Many QTabletEvents are not handled, so being able to "press a button" or other kinds of basic UI interaction depend on tablet->mouse synthesis in QGuiApplicationPrivate::processTabletEvent(). If a basic mouse-handling Item like a MouseArea or Button grabs on _mouse_ press, it needs to receive the _mouse_ release too; so DeliveryAgent must not take away its grab until that happens. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-98936 Fixes: QTBUG-102764 Fixes: QTBUG-103937 Change-Id: I6d75d988d617bc3ceb8465f939d0a69485278cdf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-07-05 21:05:32 +00:00
#include <qpa/qwindowsysteminterface_p.h>
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
Fix tst_QQuickMouseArea::notPressedAfterStolenGrab again Most of the time, QQuickWindowPrivate::deliverMatchingPointsToItem() doesn't need to call item->mouseUngrabEvent() because all grab changes are notified via the connection from signal QPointingDevice::grabChanged to slot QQuickWindowPrivate::onGrabChanged(). But in this case, MouseArea only accepts the event, rather than taking the grab itself. Therefore at the time the grab is "stolen", there was not yet any grabber, because grabbing is done after delivery. But we still need to inform MouseArea that it's not getting the grab it expects to get, so that it can reset its pressed state. But we don't want it to be redundant (other tests are counting events, and we don't want repeated ungrabs to show up in those); so now we have to track whether the item on which we're about to call mouseUngrabEvent() has already gotten it. This illustrates another problem with the tradition of accepting events and being unclear about what it means. Grabbing is one thing, ending delivery is another. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Task-number: QTBUG-55325 Task-number: QTBUG-86729 Change-Id: I8150f901e00e7a71499fc98ab54f0ba75370f3ec Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 15:29:20 +00:00
Q_LOGGING_CATEGORY(lcTests, "qt.quick.tests")
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
class CircleMask : public QObject
{
Q_OBJECT
Q_PROPERTY(qreal radius READ radius WRITE setRadius NOTIFY radiusChanged)
public:
virtual ~CircleMask() {}
qreal radius() const { return m_radius; }
void setRadius(qreal radius)
{
if (m_radius == radius)
return;
m_radius = radius;
emit radiusChanged();
}
Q_INVOKABLE bool contains(const QPointF &point) const
{
QPointF center(m_radius, m_radius);
QLineF line(center, point);
return line.length() <= m_radius;
}
signals:
void radiusChanged();
private:
qreal m_radius;
};
Warn, don't crash during nested delivery of mouse or touch presses If during delivery of a mouse press, user code calls qApp->sendEvent() with another mouse press, then when delivery of the nested event is finished, we call QQuickPointerMouseEvent::reset(nullptr). Then when delivery of the original mouse press resumes, crashes are possible because most of the code assumes that QQuickPointerEvent::m_event is not null during delivery. Change-Id: Id65b1f2f64351e40d03bcd4f4d16693d616729da Fixes: QTBUG-70898 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-10-03 15:09:40 +00:00
class EventSender : public QObject {
Q_OBJECT
public:
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
Q_INVOKABLE void sendMouseClick(QWindow* w ,qreal x , qreal y) {
QTest::mouseClick(w, Qt::LeftButton, {}, QPointF(x, y).toPoint());
Warn, don't crash during nested delivery of mouse or touch presses If during delivery of a mouse press, user code calls qApp->sendEvent() with another mouse press, then when delivery of the nested event is finished, we call QQuickPointerMouseEvent::reset(nullptr). Then when delivery of the original mouse press resumes, crashes are possible because most of the code assumes that QQuickPointerEvent::m_event is not null during delivery. Change-Id: Id65b1f2f64351e40d03bcd4f4d16693d616729da Fixes: QTBUG-70898 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-10-03 15:09:40 +00:00
}
};
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
class tst_QQuickMouseArea: public QQmlDataTest
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Q_OBJECT
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
public:
tst_QQuickMouseArea()
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
: QQmlDataTest(QT_QMLTEST_DATADIR)
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
{
qmlRegisterType<CircleMask>("Test", 1, 0, "CircleMask");
Warn, don't crash during nested delivery of mouse or touch presses If during delivery of a mouse press, user code calls qApp->sendEvent() with another mouse press, then when delivery of the nested event is finished, we call QQuickPointerMouseEvent::reset(nullptr). Then when delivery of the original mouse press resumes, crashes are possible because most of the code assumes that QQuickPointerEvent::m_event is not null during delivery. Change-Id: Id65b1f2f64351e40d03bcd4f4d16693d616729da Fixes: QTBUG-70898 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-10-03 15:09:40 +00:00
qmlRegisterType<EventSender>("Test", 1, 0, "EventSender");
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
}
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
private slots:
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void dragProperties();
void resetDrag();
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void dragging_data() { acceptedButton_data(); }
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void dragging();
Fix MouseArea mouseX/mouseY coordinates while dragging When MouseArea is not anchored with the usual anchors.fill: parent, such that its position is not 0,0, calculating mouseX/mouseY as d->lastScenePos - mapToScene(position()) was wrong. It could be d->lastScenePos - mapToScene(QPointF()), but instead we use mapFromScene(d->lastScenePos) as in a few other places. Amends 8068e7b98cde09565efe27585b84e120f9c5ea99. Pick-to: 5.15 Fixes: QTBUG-85111 Task-number: QTBUG-75993 Change-Id: If1440d05ec3b75d9f9f4802fbc361756fadb559e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-06-29 08:48:27 +00:00
void selfDrag();
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
void dragSmoothed();
Revert removal of "Fixed MouseArea threshold with preventStealing" This reverts commit 9c8dab537819f0d999e680490c2d125b8836cbbb where commit e1400b5b4d8311769ad3b9f631479ee2b0271197 was removed due to the breakage of QtLocation tests. After some hours of debugging it seems that the problem in QtLocation was due to filtering of mouse move events in QDeclarativeGeoMapItemBase. See QTBUG-52075 Task-number: QTBUG-52534 Change-Id: I00f002c1d6f60f74a148b5a6ac2b9f63e93718a9 Reviewed-by: Paolo Angelelli <paolo.angelelli@theqtcompany.com> Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
2016-06-02 19:49:37 +00:00
void dragThreshold_data();
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
void dragThreshold();
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void invalidDrag_data() { rejectedButton_data(); }
void invalidDrag();
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
void cancelDragging();
MouseArea: fix bug preventing dragging from start The same bounded dragPos values were used for - moving the target item to new position; and - if dragging didn’t start yet, determining whether cursor moved over the threshold distance. It is right for moving the target item, but in the second case it led to that dragging did not start if the distance between item's left border and minimumX (right border and maximumX, top border and minimumY, bottom border and maximumY accordingly) was less than drag.threshold. Task-number: QTBUG-58347 Change-Id: If61a98bf734739323ef19dee6709560b754b2456 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2017-01-25 00:39:28 +00:00
void availableDistanceLessThanDragThreshold();
Fix setting drag properties in mousePress. Cache the dragX and dragY properties after the onPressed signal has been emitted to allow for deferred creation of the drag object or changes to the axis property in the handler. Change-Id: If154e661359c82e957fcf0cbc11ccc1f75bee919 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-05-11 01:01:33 +00:00
void setDragOnPressed();
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void updateMouseAreaPosOnClick();
void updateMouseAreaPosOnResize();
void noOnClickedWithPressAndHold();
void onMousePressRejected();
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
void pressedCanceledOnWindowDeactivate_data();
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void pressedCanceledOnWindowDeactivate();
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void doubleClick_data() { acceptedButton_data(); }
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void doubleClick();
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void clickTwice_data() { acceptedButton_data(); }
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void clickTwice();
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void invalidClick_data() { rejectedButton_data(); }
void invalidClick();
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void pressedOrdering();
void preventStealing();
MouseArea: don't override preventStealing on mouse release In setPreventStealing() we call setKeepMouseGrab(); so it does not make sense to override setKeepMouseGrab() in other places without even checking the state of the preventStealing property. Pick-to: 5.15 6.2 6.3 Fixes: QTBUG-103522 Change-Id: Ib4a2b01b814835715642aec83fac0a84debe2461 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-18 11:21:05 +00:00
void preventStealingListViewChild();
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
void clickThrough();
void hoverPosition();
void hoverPropagation();
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
void hoverVisible();
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
void hoverAfterPress();
MouseArea: add autotest for subtreeHoverEnabled Verify the fix in f7e462b. Task-number: QTBUG-54019 Change-Id: Ia9846f9b79473ea4f72e895320cf01d5d85cc1a3 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-06-20 09:57:43 +00:00
void subtreeHoverEnabled();
QQuickMouseArea: store hoverEnabled explicitly The current implementation would not explicitly store if hoverEnabled was set. Instead it would use acceptHoverEvents() directly. The problem is that the latter will also need to be set to false when a MouseArea is disabled, otherwise it will not receive a HoverLeave event. But when doing so, we will no longer know if hoverEnabled was set to true or false by setEnabled() or by setHoverEnabled(). As such, when the MouseArea is enabled again, we would no longer know if we should start to subscribe to hover events or not. This patch will therefore add en extra bool, hoverEnabled, that lets us track the hoverEnabled state explicitly. As a drive-by, also add some internal docs that explains how a MouseArea differs wrt hover compared to e.g HoverHandlers and other items. Fixes: QTBUG-46460 Pick-to: 6.4 Change-Id: I34e078b3574030572bcf770750820959e98ecc4c Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-09-16 11:13:00 +00:00
void hoverWhenDisabled();
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
void disableAfterPress();
MouseArea: don't get stuck in pressed state when disabling in press In 8ace780b5aa298e3c01903bfd57f766a42209191 we fixed the case when MouseArea hides itself on press. This time, the concern is when it becomes _effectively_ disabled by disabling its parent on press. (As explained in a comment on QTBUG-38364, the MouseArea.enabled state is independent, but we can nevertheless also find out when the effective enabled state changes.) [ChangeLog][QtQuick][MouseArea] When a MouseArea becomes effectively disabled due to a parent's enabled property being set false while the mouse is pressed, the press will now be canceled. Fixes: QTBUG-39806 Fixes: QTBUG-103788 Change-Id: I8d69b535b6e1b5d51ad1e030f52217de9ab541f1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-10-18 11:28:52 +00:00
void disableParentOnPress_data();
void disableParentOnPress();
Add mouse wheel events handler to MouseArea This patch was based on the attached patch in QTBUG-7369. It basically exposes the wheel events to MouseArea via the onWheel signal. The current API is based on the new QWheelEvent API introduced by this patch: http://codereview.qt-project.org/#change,12532 Task-number: QTBUG-7369 Change-Id: Id58513715c2d0ae81e3a69e9e1ed400bbae07507 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-01-05 18:19:26 +00:00
void onWheel();
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
void transformedMouseArea_data();
void transformedMouseArea();
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
void pressedMultipleButtons_data();
void pressedMultipleButtons();
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
void changeAxis();
Get rid of most QT_NO_FOO usages Instead use QT_CONFIG(foo). This change actually detected a few mis-spelled macros and invalid usages. Change-Id: I06ac327098dd1a458e6bc379d637b8e2dac52f85 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2016-11-16 13:22:36 +00:00
#if QT_CONFIG(cursor)
Fix resolution of cursor when items are overlapping. If MouseArea with cursorShapes are overlapping then cursor shape of the foremost item under the mouse cursor should be shown, but because the hover events are delivered to the foremost items first the opposite is occuring. This makes QQuickWindow responsible for correctly setting its own cursor instead of relying on items to work it out amongst themselves. Change-Id: Iedf144c583dfa3d1ff441e19db9601b5e171902a Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-25 04:04:47 +00:00
void cursorShape();
#endif
A MouseArea should not receive move or release events if the press was not accepted. Change-Id: If70650d7150b224f4460697a953611dd37d57af1 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-02-13 04:19:10 +00:00
void moveAndReleaseWithoutPress();
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
void nestedStopAtBounds();
void nestedStopAtBounds_data();
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
void nestedFlickableStopAtBounds();
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
void containsPress_data();
void containsPress();
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
void ignoreBySource();
Fix mouse area pressed after removal of pre-grab Qt Quick used to actively "grab" the mouse before delivering events, making the code more complex than necessary. Some items came to rely on the behavior and now lack the ungrab event. This is triggered when inside the delivery of a mouse event, some other item grabs the mouse. If the mouse grab changed to an item that was not the target of the original delivery, the grab must have been stolen, so call mouseUngrabEvent in this case. Test case by J-P Nurmi. Task-number: QTBUG-55325 Change-Id: I2f0ac9d8aed1415662196070fb763f2752004d22 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-08-24 10:40:23 +00:00
void notPressedAfterStolenGrab();
Add pressAndHoldInterval to MouseArea Introduce pressAndHoldInterval to allow setting the pressAndHold delay per-MouseArea. [ChangeLog][QtQml][MouseArea] Introduce pressAndHoldInterval property, which controls the elapsed time before pressAndHold is emitted. Task-Id: QTBUG-47662 Change-Id: Ic2173335033a6ed0d4b652333020f030de63a8e7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2016-12-07 17:57:03 +00:00
void pressAndHold_data();
void pressAndHold();
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
void pressOneAndTapAnother_data();
void pressOneAndTapAnother();
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
void mask();
Warn, don't crash during nested delivery of mouse or touch presses If during delivery of a mouse press, user code calls qApp->sendEvent() with another mouse press, then when delivery of the nested event is finished, we call QQuickPointerMouseEvent::reset(nullptr). Then when delivery of the original mouse press resumes, crashes are possible because most of the code assumes that QQuickPointerEvent::m_event is not null during delivery. Change-Id: Id65b1f2f64351e40d03bcd4f4d16693d616729da Fixes: QTBUG-70898 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-10-03 15:09:40 +00:00
void nestedEventDelivery();
Fix QQuickMouseArea getting stuck in pressed state when hiding in press In 78c1fcbc49f56463064eef738a475d9018357b24 we stopped giving the exclusive grab to hidden or disabled items with is good. But the change did not take into consideration how mouse area handles its internal state. As a simple example: A mouse area that would set itself hiddin in the press handler, would continue to have d->pressed == true, which means it would not react to any future press events. The fix is to let mouse area check in its change handler whether it has become invisible. The test also checks that enabled behaves the same way. There is no action needed, since mouse area does completely custom handling of enabled (maybe something to fix in Qt 6), disabling a mouse area doesn't disable its children for example, it doesn't invoke QQuickItem::setEnabled at all. Due to this circumventing the common behavior, by chance disabling a mouse area in the on pressed handler works. Fixes: QTBUG-74987 Change-Id: Idb8499b3e5bcb744fbba203fdea5c46695bd5077 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2020-03-28 14:14:41 +00:00
void settingHiddenInPressUngrabs();
QQuickWindow: Consider z-order of children when delivering pointer events When creating a target item list for handling pointer events, put children after the parent item if they have negative z-order value. This fixes an issue where an item does not receive a pointer event if there is a child item that accepts the event even when that child item is shown under the parent item as per the stacking order. Fixes: QTBUG-83114 Pick-to: 5.15 Change-Id: I711faa22516f5c2396b1138dc507bcaa4ba22241 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-08-16 12:32:22 +00:00
void negativeZStackingOrder();
MouseArea: fix containsMouse behavior during visibility changes QQuickItem returns whether it contains QGuiApplicationPrivate's lastCursorPosition. Since that position stores the coordinate last seen by Qt (the window border), it will always be within the window, and within an item that covers that part of the window's border. However, QQuickWindow stores the lastMousePosition as well, and resets that value when it receives a QEvent::Leave. We can use that to test whether the window that contains the item has seen a Leave event, in which case the item is definitely not under the mouse. Notes on the test: That we use QPointF() as the "reset" value leave the small possibility that the cursor might be at position 0,0 of the window (ie inside the window), and the QQuickItem there will not be under the mouse. We can't confirm this (through an expected failure test), as QTest::mouseMove interprets a QPoint(0, 0) as "center of the window". And since we can't simulate mouse moves outside a window's boundary using QTest::mouseMove, the test needs to explicitly synthesize a QEvent::Leave for the window. Fixes: QTBUG-87197 Pick-to: 6.1 6.0 5.15 Change-Id: I04870d6e914092275d9d790312fc702fb99f2935 Done-with: Ivan Solovev <ivan.solovev@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2021-02-12 16:11:47 +00:00
void containsMouseAndVisibility();
Fix masked MouseArea hovered state on visibility change This fixes the issue where given two hoverable MouseAreas A & B where B masks A, the `containsMouse` property of A will be incorrectly set to true if the cursor is positioned above both A and B and the visibility of A is toggled from true to false back to true. This patch fixes the above issue by checking if the QQuickMouseArea is marked as a hovered item in its windows QQuickDeliveryAgentPrivate(QDAP) instance. If the QQuickMouseArea is masked by another QQuickMouseArea then it will not be a in the QDAPs hovered items list and we skip setting the hovered property on QQuickMouseArea, fixing the issue. This patch also adds a test case to prevent future regressions. Fixes: QTBUG-109567 Pick-to: 6.5 6.4 Change-Id: I5f024a097b56ef5e0836ca9f8ae547983a089b44 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-12-21 15:48:07 +00:00
void containsMouseAndVisibilityMasked();
Fix mouse inside MouseArea (containsMouse) for press event In MouseArea, containsMouse (mouse inside MouseArea) flag is enabled for press event irrespective of whether its accepted or not. This creates containsMouse to be enabled always for this corresponding item leaving no option to reset. To fix this issue, containsMouse flag is enabled only if the press event is accepted for mouse handler. Fixes: QTBUG-110594 Pick-to: 6.4 6.5 Change-Id: Ibb0e89529ccebc3063330c22b8b3501b2917d78f Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-02-08 08:54:48 +00:00
void containsMouseAndHoverDisabled();
MouseArea: don't get stuck in doubleClick if handler caused ungrab The bug scenario went like this: 1) QQuickMouseArea::mouseDoubleClickEvent() emits doubleClicked 2) onDoubleClicked in QML hid the MouseArea somehow 3) QQuickMouseArea::ungrabMouse() is called; it sets d->pressed = Qt::NoButton and d->doubleClick = false (and others) 4) eventually we get back to the continuation of mouseDoubleClickEvent() which sets d->doubleClick back to true 5) mouse release: this MouseArea is not involved (no grab anymore) 6) next mouse press: QQuickMouseArea::setPressed() has if (!d->doubleClick) emit pressed(&me); pressed() is not emitted because of leftover state So either we need to avoid setting d->doubleClick to true if d->pressed has been set to Qt::NoButton in QQuickMouseArea::ungrabMouse(); or else we should reorder the statements in mouseDoubleClickEvent() to set d->doubleClick before emitting doubleClicked, so that it will not be overridden after the QML handler is called. This patch takes the first approach. Fixes: QTBUG-35995 Fixes: QTBUG-102158 Pick-to: 6.2 6.3 5.15 Change-Id: Ibe5c9bfbc9c7a70772dd5ebfbc9ce401c6c226d3 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-04-29 13:18:08 +00:00
void doubleClickToHide();
Add MouseArea autotest with second touchpoint while first is held - Touch first finger - Touch and release second finger - Release first finger QQuickMouseArea::pressed() must be emitted only once; QQuickMouseArea::released() must be emitted at the end. Pick-to: 6.3 6.2 Task-number: QTBUG-103766 Change-Id: I849bbbad67c4739bea0a241b396bf4cbbebdd2e0 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-24 13:01:37 +00:00
void releaseFirstTouchAfterSecond();
Don't ungrab for a TabletRelease event: wait for the synth-mouse release Many QTabletEvents are not handled, so being able to "press a button" or other kinds of basic UI interaction depend on tablet->mouse synthesis in QGuiApplicationPrivate::processTabletEvent(). If a basic mouse-handling Item like a MouseArea or Button grabs on _mouse_ press, it needs to receive the _mouse_ release too; so DeliveryAgent must not take away its grab until that happens. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-98936 Fixes: QTBUG-102764 Fixes: QTBUG-103937 Change-Id: I6d75d988d617bc3ceb8465f939d0a69485278cdf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-07-05 21:05:32 +00:00
#if QT_CONFIG(tabletevent)
void tabletStylusTap();
#endif
Allow OS-synthesized right clicks to be delivered Since 15337aa91b891b49ffe76c96dd6fa6cd9bead2c2 we have been blocking all OS-synthesized mouse events. But synthesizing right click from long- press is becoming more common, so Qt Quick should be able to react to those. [ChangeLog][QtQuick] In case your operating system synthesizes a right-click from a touchscreen long-press, synthetic right-button mouse events are now delivered normally, so that e.g. TapHandler can react. You can opt out by setting QT_QUICK_ALLOW_SYNTHETIC_RIGHT_CLICK=0. Fixes: QTBUG-77902 Task-number: QTBUG-84179 Change-Id: I609041daf0e3e8ce1d1f3b0c78ae3bd264fec8a3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-10-20 14:50:39 +00:00
void syntheticRightClick();
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
private:
Fix tst_QQuickMouseArea::cancelDragging for big startDragDistance Change-Id: Ia39947f7b6f42c48738af81966deb9c98f708da5 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:33:34 +00:00
int startDragDistance() const {
return QGuiApplication::styleHints()->startDragDistance();
}
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void acceptedButton_data();
void rejectedButton_data();
Use const QPointingDevices in tests When a data-driven test has QTest::addColumn<const QPointingDevice *>("device"); QTestData::append() does a type check with QTEST_ASSERT if it's not an exact match. That can result in a crash, apparently, although it's not clear then how 59d967a8fb60bb764654a857cac20196358865eb got through CI the first time. Amends 59d967a8fb60bb764654a857cac20196358865eb Task-number: QTBUG-107863 Task-number: QTBUG-107864 Change-Id: I383191b604eb504d49b0d51a23ecc45160f3383b Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-10-23 08:09:55 +00:00
QPointingDevice *device = QTest::createTouchDevice(); // TODO const after fixing QTBUG-107864
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
};
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Q_DECLARE_METATYPE(Qt::MouseButton)
Q_DECLARE_METATYPE(Qt::MouseButtons)
void tst_QQuickMouseArea::acceptedButton_data()
{
QTest::addColumn<Qt::MouseButtons>("acceptedButtons");
QTest::addColumn<Qt::MouseButton>("button");
QTest::newRow("left") << Qt::MouseButtons(Qt::LeftButton) << Qt::LeftButton;
QTest::newRow("right") << Qt::MouseButtons(Qt::RightButton) << Qt::RightButton;
QTest::newRow("middle") << Qt::MouseButtons(Qt::MiddleButton) << Qt::MiddleButton;
QTest::newRow("left (left|right)") << Qt::MouseButtons(Qt::LeftButton | Qt::RightButton) << Qt::LeftButton;
QTest::newRow("right (right|middle)") << Qt::MouseButtons(Qt::RightButton | Qt::MiddleButton) << Qt::RightButton;
QTest::newRow("middle (left|middle)") << Qt::MouseButtons(Qt::LeftButton | Qt::MiddleButton) << Qt::MiddleButton;
}
void tst_QQuickMouseArea::rejectedButton_data()
{
QTest::addColumn<Qt::MouseButtons>("acceptedButtons");
QTest::addColumn<Qt::MouseButton>("button");
QTest::newRow("middle (left|right)") << Qt::MouseButtons(Qt::LeftButton | Qt::RightButton) << Qt::MiddleButton;
QTest::newRow("left (right|middle)") << Qt::MouseButtons(Qt::RightButton | Qt::MiddleButton) << Qt::LeftButton;
QTest::newRow("right (left|middle)") << Qt::MouseButtons(Qt::LeftButton | Qt::MiddleButton) << Qt::RightButton;
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::dragProperties()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragproperties.qml")));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickDrag *drag = mouseRegion->drag();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
QVERIFY(drag != nullptr);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// target
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *rootItem = qobject_cast<QQuickItem*>(window.rootObject());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(rootItem != nullptr);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QSignalSpy targetSpy(drag, SIGNAL(targetChanged()));
drag->setTarget(rootItem);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(targetSpy.size(),1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
drag->setTarget(rootItem);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(targetSpy.size(),1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// axis
Add a hidden XandYAxis enum value For Qt 5 XandYAxis is being renamed to XAndYAxis to more consistently follow capitalization rules. Add an undocumented XandYAxis variable to ease porting. Change-Id: Id9e41dd5578373f5f557937da889a9326ff12e53 Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2012-03-01 10:09:52 +00:00
QCOMPARE(drag->axis(), QQuickDrag::XAndYAxis);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QSignalSpy axisSpy(drag, SIGNAL(axisChanged()));
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
drag->setAxis(QQuickDrag::XAxis);
QCOMPARE(drag->axis(), QQuickDrag::XAxis);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(axisSpy.size(),1);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
drag->setAxis(QQuickDrag::XAxis);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(axisSpy.size(),1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// minimum and maximum properties
QSignalSpy xminSpy(drag, SIGNAL(minimumXChanged()));
QSignalSpy xmaxSpy(drag, SIGNAL(maximumXChanged()));
QSignalSpy yminSpy(drag, SIGNAL(minimumYChanged()));
QSignalSpy ymaxSpy(drag, SIGNAL(maximumYChanged()));
QCOMPARE(drag->xmin(), 0.0);
QCOMPARE(drag->xmax(), rootItem->width()-blackRect->width());
QCOMPARE(drag->ymin(), 0.0);
QCOMPARE(drag->ymax(), rootItem->height()-blackRect->height());
drag->setXmin(10);
drag->setXmax(10);
drag->setYmin(10);
drag->setYmax(10);
QCOMPARE(drag->xmin(), 10.0);
QCOMPARE(drag->xmax(), 10.0);
QCOMPARE(drag->ymin(), 10.0);
QCOMPARE(drag->ymax(), 10.0);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(xminSpy.size(),1);
QCOMPARE(xmaxSpy.size(),1);
QCOMPARE(yminSpy.size(),1);
QCOMPARE(ymaxSpy.size(),1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
drag->setXmin(10);
drag->setXmax(10);
drag->setYmin(10);
drag->setYmax(10);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(xminSpy.size(),1);
QCOMPARE(xmaxSpy.size(),1);
QCOMPARE(yminSpy.size(),1);
QCOMPARE(ymaxSpy.size(),1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// filterChildren
QSignalSpy filterChildrenSpy(drag, SIGNAL(filterChildrenChanged()));
drag->setFilterChildren(true);
QVERIFY(drag->filterChildren());
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(filterChildrenSpy.size(), 1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
drag->setFilterChildren(true);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(filterChildrenSpy.size(), 1);
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
// threshold
QCOMPARE(int(drag->threshold()), qApp->styleHints()->startDragDistance());
QSignalSpy thresholdSpy(drag, SIGNAL(thresholdChanged()));
drag->setThreshold(0.0);
QCOMPARE(drag->threshold(), 0.0);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(thresholdSpy.size(), 1);
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
drag->setThreshold(99);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(thresholdSpy.size(), 2);
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
drag->setThreshold(99);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(thresholdSpy.size(), 2);
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
drag->resetThreshold();
QCOMPARE(int(drag->threshold()), qApp->styleHints()->startDragDistance());
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(thresholdSpy.size(), 3);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::resetDrag()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
tst_qquickmousearea: avoid calling setContextProperty Change-Id: I0ee4506d58afa5f12455410904275089638e26c0 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-10-04 12:53:31 +00:00
window.setInitialProperties({{"haveTarget", true}});
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragreset.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickDrag *drag = mouseRegion->drag();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
QVERIFY(drag != nullptr);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// target
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *rootItem = qobject_cast<QQuickItem*>(window.rootObject());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(rootItem != nullptr);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QSignalSpy targetSpy(drag, SIGNAL(targetChanged()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(drag->target() != nullptr);
tst_qquickmousearea: avoid calling setContextProperty Change-Id: I0ee4506d58afa5f12455410904275089638e26c0 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-10-04 12:53:31 +00:00
auto root = window.rootObject();
QQmlProperty haveTarget {root, "haveTarget"};
haveTarget.write(false);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(targetSpy.size(),1);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!drag->target());
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::dragging()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QFETCH(Qt::MouseButtons, acceptedButtons);
QFETCH(Qt::MouseButton, button);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragging.qml")));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickDrag *drag = mouseRegion->drag();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
QVERIFY(drag != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
mouseRegion->setAcceptedButtons(acceptedButtons);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
// target
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(!drag->active());
Fix tst_QQuickMouseArea::dragging for big startDragDistance On macOS the mouse move events go through qcursor's setPos. That in turn uses a native event, so the waits are there for a good reason. Change-Id: Icb616d303c5280f2a9ba5f78cf07032c298b84a7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:23:25 +00:00
QPoint p = QPoint(100,100);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, button, Qt::NoModifier, p);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
// First move event triggers drag, second is acted upon.
// This is due to possibility of higher stacked area taking precedence.
Smooth dragging an item with MouseArea. Calculate drag distance relative to the mouse position when a drag is detected rather than the press position so there isn't a large change in position on the first move. Task-number: QTBUG-30188 Change-Id: I5c2269c2228668a3842e18f65167637497b3beb4 Reviewed-by: Joona Petrell <joona.petrell@jollamobile.com>
2013-03-14 02:36:20 +00:00
// The item is moved relative to the position of the mouse when the drag
// was triggered, this prevents a sudden change in position when the drag
// threshold is exceeded.
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Fix tst_QQuickMouseArea::dragging for big startDragDistance On macOS the mouse move events go through qcursor's setPos. That in turn uses a native event, so the waits are there for a good reason. Change-Id: Icb616d303c5280f2a9ba5f78cf07032c298b84a7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:23:25 +00:00
int dragThreshold = QGuiApplication::styleHints()->startDragDistance();
// move the minimum distance to activate drag
p += QPoint(dragThreshold + 1, dragThreshold + 1);
QTest::mouseMove(&window, p);
QVERIFY(!drag->active());
// from here on move the item
p += QPoint(1, 1);
QTest::mouseMove(&window, p);
QTRY_VERIFY(drag->active());
// on macOS the cursor movement is going through a native event which
// means that it can actually take some time to show
QTRY_COMPARE(blackRect->x(), 50.0 + 1);
QCOMPARE(blackRect->y(), 50.0 + 1);
p += QPoint(10, 10);
QTest::mouseMove(&window, p);
Ungrab mouse when FocusAboutToChange instead of Leave Commit 7b2e2117162594a2d0234bb02408f5b5a446488b introduced a regression in mouse handling: When moving the mouse out of the window it would cancel all further mouse events. That is actually not wanted (eg scroll bars). Instead ungrab the mouse when the focus changes, that means the mouse handling with popups works and the scrollbar use case is also fixed. All the tests related to this seem quite timing sensitive, so try some more QTRY_VERIFY. Remove the parallel_test so that more cpu time will actually let the tests pass more reliably. Change-Id: I90586b05f461d3762728a466d71bcb967e03d14b Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
2013-01-11 13:48:32 +00:00
QTRY_VERIFY(drag->active());
Smooth dragging an item with MouseArea. Calculate drag distance relative to the mouse position when a drag is detected rather than the press position so there isn't a large change in position on the first move. Task-number: QTBUG-30188 Change-Id: I5c2269c2228668a3842e18f65167637497b3beb4 Reviewed-by: Joona Petrell <joona.petrell@jollamobile.com>
2013-03-14 02:36:20 +00:00
QTRY_COMPARE(blackRect->x(), 61.0);
QCOMPARE(blackRect->y(), 61.0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QQuickMouseArea: synchronize relative position after dragging [ChangeLog][QtQuick][QQuickMouseArea] mouseX and mouseY will now be synchronized after dragging the target item Fixes: QTBUG-75993 Change-Id: I0b56f6bd494791f9e2fe55a0cf059a7bad2d63dc Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-05-25 07:10:03 +00:00
qreal relativeX = mouseRegion->mouseX();
qreal relativeY = mouseRegion->mouseY();
for (int i = 0; i < 20; i++) {
p += QPoint(1, 1);
QTest::mouseMove(&window, p);
Fix MouseArea mouseX/mouseY coordinates while dragging When MouseArea is not anchored with the usual anchors.fill: parent, such that its position is not 0,0, calculating mouseX/mouseY as d->lastScenePos - mapToScene(position()) was wrong. It could be d->lastScenePos - mapToScene(QPointF()), but instead we use mapFromScene(d->lastScenePos) as in a few other places. Amends 8068e7b98cde09565efe27585b84e120f9c5ea99. Pick-to: 5.15 Fixes: QTBUG-85111 Task-number: QTBUG-75993 Change-Id: If1440d05ec3b75d9f9f4802fbc361756fadb559e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-06-29 08:48:27 +00:00
QTRY_COMPARE(mouseRegion->mouseX(), relativeX);
QCOMPARE(mouseRegion->mouseY(), relativeY);
QQuickMouseArea: synchronize relative position after dragging [ChangeLog][QtQuick][QQuickMouseArea] mouseX and mouseY will now be synchronized after dragging the target item Fixes: QTBUG-75993 Change-Id: I0b56f6bd494791f9e2fe55a0cf059a7bad2d63dc Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-05-25 07:10:03 +00:00
}
Fix MouseArea mouseX/mouseY coordinates while dragging When MouseArea is not anchored with the usual anchors.fill: parent, such that its position is not 0,0, calculating mouseX/mouseY as d->lastScenePos - mapToScene(position()) was wrong. It could be d->lastScenePos - mapToScene(QPointF()), but instead we use mapFromScene(d->lastScenePos) as in a few other places. Amends 8068e7b98cde09565efe27585b84e120f9c5ea99. Pick-to: 5.15 Fixes: QTBUG-85111 Task-number: QTBUG-75993 Change-Id: If1440d05ec3b75d9f9f4802fbc361756fadb559e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-06-29 08:48:27 +00:00
QVERIFY(drag->active());
QQuickMouseArea: synchronize relative position after dragging [ChangeLog][QtQuick][QQuickMouseArea] mouseX and mouseY will now be synchronized after dragging the target item Fixes: QTBUG-75993 Change-Id: I0b56f6bd494791f9e2fe55a0cf059a7bad2d63dc Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-05-25 07:10:03 +00:00
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, button, Qt::NoModifier, p);
Ungrab mouse when FocusAboutToChange instead of Leave Commit 7b2e2117162594a2d0234bb02408f5b5a446488b introduced a regression in mouse handling: When moving the mouse out of the window it would cancel all further mouse events. That is actually not wanted (eg scroll bars). Instead ungrab the mouse when the focus changes, that means the mouse handling with popups works and the scrollbar use case is also fixed. All the tests related to this seem quite timing sensitive, so try some more QTRY_VERIFY. Remove the parallel_test so that more cpu time will actually let the tests pass more reliably. Change-Id: I90586b05f461d3762728a466d71bcb967e03d14b Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
2013-01-11 13:48:32 +00:00
QTRY_VERIFY(!drag->active());
QQuickMouseArea: synchronize relative position after dragging [ChangeLog][QtQuick][QQuickMouseArea] mouseX and mouseY will now be synchronized after dragging the target item Fixes: QTBUG-75993 Change-Id: I0b56f6bd494791f9e2fe55a0cf059a7bad2d63dc Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-05-25 07:10:03 +00:00
QTRY_COMPARE(blackRect->x(), 81.0);
QCOMPARE(blackRect->y(), 81.0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Fix MouseArea mouseX/mouseY coordinates while dragging When MouseArea is not anchored with the usual anchors.fill: parent, such that its position is not 0,0, calculating mouseX/mouseY as d->lastScenePos - mapToScene(position()) was wrong. It could be d->lastScenePos - mapToScene(QPointF()), but instead we use mapFromScene(d->lastScenePos) as in a few other places. Amends 8068e7b98cde09565efe27585b84e120f9c5ea99. Pick-to: 5.15 Fixes: QTBUG-85111 Task-number: QTBUG-75993 Change-Id: If1440d05ec3b75d9f9f4802fbc361756fadb559e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-06-29 08:48:27 +00:00
void tst_QQuickMouseArea::selfDrag() // QTBUG-85111
{
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("selfDrag.qml")));
Fix MouseArea mouseX/mouseY coordinates while dragging When MouseArea is not anchored with the usual anchors.fill: parent, such that its position is not 0,0, calculating mouseX/mouseY as d->lastScenePos - mapToScene(position()) was wrong. It could be d->lastScenePos - mapToScene(QPointF()), but instead we use mapFromScene(d->lastScenePos) as in a few other places. Amends 8068e7b98cde09565efe27585b84e120f9c5ea99. Pick-to: 5.15 Fixes: QTBUG-85111 Task-number: QTBUG-75993 Change-Id: If1440d05ec3b75d9f9f4802fbc361756fadb559e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-06-29 08:48:27 +00:00
QQuickMouseArea *ma = window.rootObject()->findChild<QQuickMouseArea*>("ma");
QVERIFY(ma != nullptr);
QQuickDrag *drag = ma->drag();
QVERIFY(drag != nullptr);
QCOMPARE(ma, drag->target());
QQuickItem *fillRect = window.rootObject()->findChild<QQuickItem*>("fill");
QVERIFY(fillRect != nullptr);
QVERIFY(!drag->active());
QPoint p = QPoint(100,100);
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
QVERIFY(!drag->active());
QCOMPARE(ma->x(), 0);
QCOMPARE(ma->y(), 0);
int dragThreshold = QGuiApplication::styleHints()->startDragDistance();
// First move event triggers drag, second is acted upon.
// move the minimum distance to activate drag
p += QPoint(dragThreshold + 1, dragThreshold + 1);
QTest::mouseMove(&window, p);
QVERIFY(!drag->active());
// from here on move the item
p += QPoint(1, 1);
QTest::mouseMove(&window, p);
QTRY_VERIFY(drag->active());
QTRY_COMPARE(ma->x(), 1);
QCOMPARE(ma->y(), 1);
p += QPoint(10, 10);
QTest::mouseMove(&window, p);
QTRY_VERIFY(drag->active());
QTRY_COMPARE(ma->x(), 11);
QCOMPARE(ma->y(), 11);
qreal relativeX = ma->mouseX();
qreal relativeY = ma->mouseY();
for (int i = 0; i < 20; i++) {
p += QPoint(1, 1);
QTest::mouseMove(&window, p);
QVERIFY(drag->active());
QTRY_COMPARE(ma->mouseX(), relativeX);
QCOMPARE(ma->mouseY(), relativeY);
}
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, p);
QTRY_VERIFY(!drag->active());
QTRY_COMPARE(ma->x(), 31);
QCOMPARE(ma->y(), 31);
}
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
void tst_QQuickMouseArea::dragSmoothed()
{
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragging.qml")));
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
QQuickDrag *drag = mouseRegion->drag();
drag->setThreshold(5);
mouseRegion->setAcceptedButtons(Qt::LeftButton);
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
QVERIFY(!drag->active());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
QVERIFY(!drag->active());
QTest::mouseMove(&window, QPoint(100, 102), 50);
QTest::mouseMove(&window, QPoint(100, 106), 50);
QTest::mouseMove(&window, QPoint(100, 122), 50);
QTRY_COMPARE(blackRect->x(), 50.0);
QTRY_COMPARE(blackRect->y(), 66.0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,122));
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
// reset rect position
blackRect->setX(50.0);
blackRect->setY(50.0);
// now try with smoothed disabled
drag->setSmoothed(false);
QVERIFY(!drag->active());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
QVERIFY(!drag->active());
QTest::mouseMove(&window, QPoint(100, 102), 50);
QTest::mouseMove(&window, QPoint(100, 106), 50);
QTest::mouseMove(&window, QPoint(100, 122), 50);
QTRY_COMPARE(blackRect->x(), 50.0);
QTRY_COMPARE(blackRect->y(), 72.0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100, 122));
Introduce MouseArea.drag.smoothed [ChangeLog][QtQuick] Added property MouseArea.drag.smoothed for toggling whether the drag target is moved to the current mouse position after a drag operation has started. Task-number: QTBUG-38539 Change-Id: I989b51bc83fc24c64b84ac8e9a50b352e674e8f8 Reviewed-by: J-P Nurmi <jpnurmi@digia.com> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-05-07 17:01:19 +00:00
}
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
Revert removal of "Fixed MouseArea threshold with preventStealing" This reverts commit 9c8dab537819f0d999e680490c2d125b8836cbbb where commit e1400b5b4d8311769ad3b9f631479ee2b0271197 was removed due to the breakage of QtLocation tests. After some hours of debugging it seems that the problem in QtLocation was due to filtering of mouse move events in QDeclarativeGeoMapItemBase. See QTBUG-52075 Task-number: QTBUG-52534 Change-Id: I00f002c1d6f60f74a148b5a6ac2b9f63e93718a9 Reviewed-by: Paolo Angelelli <paolo.angelelli@theqtcompany.com> Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
2016-06-02 19:49:37 +00:00
void tst_QQuickMouseArea::dragThreshold_data()
{
QTest::addColumn<bool>("preventStealing");
QTest::newRow("without preventStealing") << false;
QTest::newRow("with preventStealing") << true;
}
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
void tst_QQuickMouseArea::dragThreshold()
{
Revert removal of "Fixed MouseArea threshold with preventStealing" This reverts commit 9c8dab537819f0d999e680490c2d125b8836cbbb where commit e1400b5b4d8311769ad3b9f631479ee2b0271197 was removed due to the breakage of QtLocation tests. After some hours of debugging it seems that the problem in QtLocation was due to filtering of mouse move events in QDeclarativeGeoMapItemBase. See QTBUG-52075 Task-number: QTBUG-52534 Change-Id: I00f002c1d6f60f74a148b5a6ac2b9f63e93718a9 Reviewed-by: Paolo Angelelli <paolo.angelelli@theqtcompany.com> Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
2016-06-02 19:49:37 +00:00
QFETCH(bool, preventStealing);
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragging.qml")));
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
Revert removal of "Fixed MouseArea threshold with preventStealing" This reverts commit 9c8dab537819f0d999e680490c2d125b8836cbbb where commit e1400b5b4d8311769ad3b9f631479ee2b0271197 was removed due to the breakage of QtLocation tests. After some hours of debugging it seems that the problem in QtLocation was due to filtering of mouse move events in QDeclarativeGeoMapItemBase. See QTBUG-52075 Task-number: QTBUG-52534 Change-Id: I00f002c1d6f60f74a148b5a6ac2b9f63e93718a9 Reviewed-by: Paolo Angelelli <paolo.angelelli@theqtcompany.com> Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
2016-06-02 19:49:37 +00:00
mouseRegion->setPreventStealing(preventStealing);
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QQuickDrag *drag = mouseRegion->drag();
drag->setThreshold(5);
mouseRegion->setAcceptedButtons(Qt::LeftButton);
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QVERIFY(!drag->active());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
QTest::mouseMove(&window, QPoint(100, 102), 50);
QVERIFY(!drag->active());
QTest::mouseMove(&window, QPoint(100, 100), 50);
QVERIFY(!drag->active());
QTest::mouseMove(&window, QPoint(100, 104), 50);
QTest::mouseMove(&window, QPoint(100, 105), 50);
QVERIFY(!drag->active());
QTest::mouseMove(&window, QPoint(100, 106), 50);
QTest::mouseMove(&window, QPoint(100, 108), 50);
QVERIFY(drag->active());
QTest::mouseMove(&window, QPoint(100, 116), 50);
QTest::mouseMove(&window, QPoint(100, 122), 50);
QTRY_VERIFY(drag->active());
QTRY_COMPARE(blackRect->x(), 50.0);
QTRY_COMPARE(blackRect->y(), 66.0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(122,122));
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QTRY_VERIFY(!drag->active());
// Immediate drag threshold
drag->setThreshold(0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QTest::mouseMove(&window, QPoint(100, 122), 50);
QVERIFY(!drag->active());
QTest::mouseMove(&window, QPoint(100, 123), 50);
QVERIFY(drag->active());
QTest::mouseMove(&window, QPoint(100, 124), 50);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100, 124));
Expose drag threshold in MouseArea In several cases such as for creating a Slider, it is useful to have a 0 pixel threshold in order to initiate a drag operation. We have previously hardcoded this to a platform dependent (usually 10 pixel) value for MouseArea. Note that we have no way of indicating the version/revision number in a grouped property for documentation at the moment. In addition we deliberately had to remove the REVISION from the property because it is blocked by QTBUG-33179. However, since this is not a user-creatable type it should not cause any issues in practice. This patch adds MouseArea.drag.threshold in order to improve on this. Change-Id: Ia4871e64fab39e30c4494f00be99ad38cdd630df Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
2013-08-22 15:20:52 +00:00
QTRY_VERIFY(!drag->active());
drag->resetThreshold();
}
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void tst_QQuickMouseArea::invalidDrag()
{
QFETCH(Qt::MouseButtons, acceptedButtons);
QFETCH(Qt::MouseButton, button);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragging.qml")));
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QQuickDrag *drag = mouseRegion->drag();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
QVERIFY(drag != nullptr);
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
mouseRegion->setAcceptedButtons(acceptedButtons);
// target
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QVERIFY(!drag->active());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, button, Qt::NoModifier, QPoint(100,100));
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
// First move event triggers drag, second is acted upon.
// This is due to possibility of higher stacked area taking precedence.
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(111,111));
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QTest::qWait(50);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(122,122));
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QTest::qWait(50);
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, button, Qt::NoModifier, QPoint(122,122));
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QTest::qWait(50);
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
}
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
void tst_QQuickMouseArea::cancelDragging()
{
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragging.qml")));
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
QQuickDrag *drag = mouseRegion->drag();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
QVERIFY(drag != nullptr);
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
mouseRegion->setAcceptedButtons(Qt::LeftButton);
// target
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
QVERIFY(!drag->active());
Fix tst_QQuickMouseArea::cancelDragging for big startDragDistance Change-Id: Ia39947f7b6f42c48738af81966deb9c98f708da5 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:33:34 +00:00
QPoint p = QPoint(100,100);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
Fix tst_QQuickMouseArea::cancelDragging for big startDragDistance Change-Id: Ia39947f7b6f42c48738af81966deb9c98f708da5 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:33:34 +00:00
p += QPoint(startDragDistance() + 1, 0);
QTest::mouseMove(&window, p);
p += QPoint(11, 11);
QTest::mouseMove(&window, p);
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
QTRY_VERIFY(drag->active());
QTRY_COMPARE(blackRect->x(), 61.0);
QCOMPARE(blackRect->y(), 61.0);
mouseRegion->QQuickItem::ungrabMouse();
QTRY_VERIFY(!drag->active());
QCOMPARE(blackRect->x(), 61.0);
QCOMPARE(blackRect->y(), 61.0);
QTest::mouseMove(&window, QPoint(132,132), 50);
QTRY_VERIFY(!drag->active());
QCOMPARE(blackRect->x(), 61.0);
QCOMPARE(blackRect->y(), 61.0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(122,122));
When the MouseArea loses grab, an active drag should be cancelled. Change-Id: Icc784dd3265c211d9b077b692464591a41976354 Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
2013-11-25 22:55:22 +00:00
}
MouseArea: fix bug preventing dragging from start The same bounded dragPos values were used for - moving the target item to new position; and - if dragging didn’t start yet, determining whether cursor moved over the threshold distance. It is right for moving the target item, but in the second case it led to that dragging did not start if the distance between item's left border and minimumX (right border and maximumX, top border and minimumY, bottom border and maximumY accordingly) was less than drag.threshold. Task-number: QTBUG-58347 Change-Id: If61a98bf734739323ef19dee6709560b754b2456 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2017-01-25 00:39:28 +00:00
// QTBUG-58347
void tst_QQuickMouseArea::availableDistanceLessThanDragThreshold()
{
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("availableDistanceLessThanDragThreshold.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea*>("mouseArea");
MouseArea: fix bug preventing dragging from start The same bounded dragPos values were used for - moving the target item to new position; and - if dragging didn’t start yet, determining whether cursor moved over the threshold distance. It is right for moving the target item, but in the second case it led to that dragging did not start if the distance between item's left border and minimumX (right border and maximumX, top border and minimumY, bottom border and maximumY accordingly) was less than drag.threshold. Task-number: QTBUG-58347 Change-Id: If61a98bf734739323ef19dee6709560b754b2456 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2017-01-25 00:39:28 +00:00
QVERIFY(mouseArea);
QPoint position(100, 100);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, position);
MouseArea: fix bug preventing dragging from start The same bounded dragPos values were used for - moving the target item to new position; and - if dragging didn’t start yet, determining whether cursor moved over the threshold distance. It is right for moving the target item, but in the second case it led to that dragging did not start if the distance between item's left border and minimumX (right border and maximumX, top border and minimumY, bottom border and maximumY accordingly) was less than drag.threshold. Task-number: QTBUG-58347 Change-Id: If61a98bf734739323ef19dee6709560b754b2456 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2017-01-25 00:39:28 +00:00
QTest::qWait(10);
position.setX(301);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
MouseArea: fix bug preventing dragging from start The same bounded dragPos values were used for - moving the target item to new position; and - if dragging didn’t start yet, determining whether cursor moved over the threshold distance. It is right for moving the target item, but in the second case it led to that dragging did not start if the distance between item's left border and minimumX (right border and maximumX, top border and minimumY, bottom border and maximumY accordingly) was less than drag.threshold. Task-number: QTBUG-58347 Change-Id: If61a98bf734739323ef19dee6709560b754b2456 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2017-01-25 00:39:28 +00:00
position.setX(501);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
MouseArea: fix bug preventing dragging from start The same bounded dragPos values were used for - moving the target item to new position; and - if dragging didn’t start yet, determining whether cursor moved over the threshold distance. It is right for moving the target item, but in the second case it led to that dragging did not start if the distance between item's left border and minimumX (right border and maximumX, top border and minimumY, bottom border and maximumY accordingly) was less than drag.threshold. Task-number: QTBUG-58347 Change-Id: If61a98bf734739323ef19dee6709560b754b2456 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2017-01-25 00:39:28 +00:00
QVERIFY(mouseArea->drag()->active());
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, position);
MouseArea: fix bug preventing dragging from start The same bounded dragPos values were used for - moving the target item to new position; and - if dragging didn’t start yet, determining whether cursor moved over the threshold distance. It is right for moving the target item, but in the second case it led to that dragging did not start if the distance between item's left border and minimumX (right border and maximumX, top border and minimumY, bottom border and maximumY accordingly) was less than drag.threshold. Task-number: QTBUG-58347 Change-Id: If61a98bf734739323ef19dee6709560b754b2456 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2017-01-25 00:39:28 +00:00
QVERIFY(!mouseArea->drag()->active());
QCOMPARE(mouseArea->x(), 200.0);
}
Fix setting drag properties in mousePress. Cache the dragX and dragY properties after the onPressed signal has been emitted to allow for deferred creation of the drag object or changes to the axis property in the handler. Change-Id: If154e661359c82e957fcf0cbc11ccc1f75bee919 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-05-11 01:01:33 +00:00
void tst_QQuickMouseArea::setDragOnPressed()
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("setDragOnPressed.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = qobject_cast<QQuickMouseArea *>(window.rootObject());
Fix setting drag properties in mousePress. Cache the dragX and dragY properties after the onPressed signal has been emitted to allow for deferred creation of the drag object or changes to the axis property in the handler. Change-Id: If154e661359c82e957fcf0cbc11ccc1f75bee919 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-05-11 01:01:33 +00:00
QVERIFY(mouseArea);
// target
QQuickItem *target = mouseArea->findChild<QQuickItem*>("target");
QVERIFY(target);
Fix tst_QQuickMouseArea::setDragOnPressed for big startDragDistance Change-Id: I9f2795bcaaec2b126a41c6a6a12a2d5e55d0beee Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:39:12 +00:00
QPoint p = QPoint(100, 100);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
Fix setting drag properties in mousePress. Cache the dragX and dragY properties after the onPressed signal has been emitted to allow for deferred creation of the drag object or changes to the axis property in the handler. Change-Id: If154e661359c82e957fcf0cbc11ccc1f75bee919 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-05-11 01:01:33 +00:00
QQuickDrag *drag = mouseArea->drag();
QVERIFY(drag);
QVERIFY(!drag->active());
QCOMPARE(target->x(), 50.0);
QCOMPARE(target->y(), 50.0);
// First move event triggers drag, second is acted upon.
// This is due to possibility of higher stacked area taking precedence.
Fix tst_QQuickMouseArea::setDragOnPressed for big startDragDistance Change-Id: I9f2795bcaaec2b126a41c6a6a12a2d5e55d0beee Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:39:12 +00:00
p += QPoint(startDragDistance() + 1, 0);
QTest::mouseMove(&window, p);
Fix setting drag properties in mousePress. Cache the dragX and dragY properties after the onPressed signal has been emitted to allow for deferred creation of the drag object or changes to the axis property in the handler. Change-Id: If154e661359c82e957fcf0cbc11ccc1f75bee919 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-05-11 01:01:33 +00:00
Fix tst_QQuickMouseArea::setDragOnPressed for big startDragDistance Change-Id: I9f2795bcaaec2b126a41c6a6a12a2d5e55d0beee Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:39:12 +00:00
p += QPoint(11, 0);
QTest::mouseMove(&window, p);
QTRY_VERIFY(drag->active());
QTRY_COMPARE(target->x(), 61.0);
Fix setting drag properties in mousePress. Cache the dragX and dragY properties after the onPressed signal has been emitted to allow for deferred creation of the drag object or changes to the axis property in the handler. Change-Id: If154e661359c82e957fcf0cbc11ccc1f75bee919 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-05-11 01:01:33 +00:00
QCOMPARE(target->y(), 50.0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, p);
Fix tst_QQuickMouseArea::setDragOnPressed for big startDragDistance Change-Id: I9f2795bcaaec2b126a41c6a6a12a2d5e55d0beee Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:39:12 +00:00
QTRY_VERIFY(!drag->active());
Smooth dragging an item with MouseArea. Calculate drag distance relative to the mouse position when a drag is detected rather than the press position so there isn't a large change in position on the first move. Task-number: QTBUG-30188 Change-Id: I5c2269c2228668a3842e18f65167637497b3beb4 Reviewed-by: Joona Petrell <joona.petrell@jollamobile.com>
2013-03-14 02:36:20 +00:00
QCOMPARE(target->x(), 61.0);
Fix setting drag properties in mousePress. Cache the dragX and dragY properties after the onPressed signal has been emitted to allow for deferred creation of the drag object or changes to the axis property in the handler. Change-Id: If154e661359c82e957fcf0cbc11ccc1f75bee919 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-05-11 01:01:33 +00:00
QCOMPARE(target->y(), 50.0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::updateMouseAreaPosOnClick()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("updateMousePosOnClick.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
Cancel mousearea pressed state when window is deactivated Change-Id: I1cc21c338576a2ac3b1e8e282e8e4de3bc63759a Task-number:QTBUG-19904 Reviewed-on: http://codereview.qt.nokia.com/2357 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 00:38:35 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickRectangle *rect = window.rootObject()->findChild<QQuickRectangle*>("ball");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(rect != nullptr);
Cancel mousearea pressed state when window is deactivated Change-Id: I1cc21c338576a2ac3b1e8e282e8e4de3bc63759a Task-number:QTBUG-19904 Reviewed-on: http://codereview.qt.nokia.com/2357 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 00:38:35 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(mouseRegion->mouseX(), rect->x());
QCOMPARE(mouseRegion->mouseY(), rect->y());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Cancel mousearea pressed state when window is deactivated Change-Id: I1cc21c338576a2ac3b1e8e282e8e4de3bc63759a Task-number:QTBUG-19904 Reviewed-on: http://codereview.qt.nokia.com/2357 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 00:38:35 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(mouseRegion->mouseX(), 100.0);
QCOMPARE(mouseRegion->mouseY(), 100.0);
Cancel mousearea pressed state when window is deactivated Change-Id: I1cc21c338576a2ac3b1e8e282e8e4de3bc63759a Task-number:QTBUG-19904 Reviewed-on: http://codereview.qt.nokia.com/2357 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 00:38:35 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(mouseRegion->mouseX(), rect->x());
QCOMPARE(mouseRegion->mouseY(), rect->y());
}
Cancel mousearea pressed state when window is deactivated Change-Id: I1cc21c338576a2ac3b1e8e282e8e4de3bc63759a Task-number:QTBUG-19904 Reviewed-on: http://codereview.qt.nokia.com/2357 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 00:38:35 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::updateMouseAreaPosOnResize()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("updateMousePosOnResize.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickRectangle *rect = window.rootObject()->findChild<QQuickRectangle*>("brother");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(rect != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(mouseRegion->mouseX(), 0.0);
QCOMPARE(mouseRegion->mouseY(), 0.0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent event(QEvent::MouseButtonPress, rect->position().toPoint(),
window.mapToGlobal(rect->position().toPoint()),
Qt::LeftButton, Qt::LeftButton, {});
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &event);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QVERIFY(!mouseRegion->property("emitPositionChanged").toBool());
QVERIFY(mouseRegion->property("mouseMatchesPos").toBool());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Remove ints from mouse event handling. Change-Id: Icda13ae3644dc274e08e626545df75d3e561cf87 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-11-25 05:22:09 +00:00
QCOMPARE(mouseRegion->property("x1").toReal(), 0.0);
QCOMPARE(mouseRegion->property("y1").toReal(), 0.0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Remove ints from mouse event handling. Change-Id: Icda13ae3644dc274e08e626545df75d3e561cf87 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-11-25 05:22:09 +00:00
QCOMPARE(mouseRegion->property("x2").toReal(), rect->x());
QCOMPARE(mouseRegion->property("y2").toReal(), rect->y());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(mouseRegion->mouseX(), rect->x());
QCOMPARE(mouseRegion->mouseY(), rect->y());
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::noOnClickedWithPressAndHold()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
{
// We handle onPressAndHold, therefore no onClicked
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("clickandhold.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = qobject_cast<QQuickMouseArea*>(window.rootObject()->children().first());
Ungrab mouse when FocusAboutToChange instead of Leave Commit 7b2e2117162594a2d0234bb02408f5b5a446488b introduced a regression in mouse handling: When moving the mouse out of the window it would cancel all further mouse events. That is actually not wanted (eg scroll bars). Instead ungrab the mouse when the focus changes, that means the mouse handling with popups works and the scrollbar use case is also fixed. All the tests related to this seem quite timing sensitive, so try some more QTRY_VERIFY. Remove the parallel_test so that more cpu time will actually let the tests pass more reliably. Change-Id: I90586b05f461d3762728a466d71bcb967e03d14b Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
2013-01-11 13:48:32 +00:00
QVERIFY(mouseArea);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(mouseArea->pressedButtons(), Qt::LeftButton);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("clicked").toBool());
QVERIFY(!window.rootObject()->property("held").toBool());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Ungrab mouse when FocusAboutToChange instead of Leave Commit 7b2e2117162594a2d0234bb02408f5b5a446488b introduced a regression in mouse handling: When moving the mouse out of the window it would cancel all further mouse events. That is actually not wanted (eg scroll bars). Instead ungrab the mouse when the focus changes, that means the mouse handling with popups works and the scrollbar use case is also fixed. All the tests related to this seem quite timing sensitive, so try some more QTRY_VERIFY. Remove the parallel_test so that more cpu time will actually let the tests pass more reliably. Change-Id: I90586b05f461d3762728a466d71bcb967e03d14b Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
2013-01-11 13:48:32 +00:00
// timeout is 800 (in qquickmousearea.cpp)
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QTest::qWait(1000);
Ungrab mouse when FocusAboutToChange instead of Leave Commit 7b2e2117162594a2d0234bb02408f5b5a446488b introduced a regression in mouse handling: When moving the mouse out of the window it would cancel all further mouse events. That is actually not wanted (eg scroll bars). Instead ungrab the mouse when the focus changes, that means the mouse handling with popups works and the scrollbar use case is also fixed. All the tests related to this seem quite timing sensitive, so try some more QTRY_VERIFY. Remove the parallel_test so that more cpu time will actually let the tests pass more reliably. Change-Id: I90586b05f461d3762728a466d71bcb967e03d14b Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
2013-01-11 13:48:32 +00:00
QCoreApplication::processEvents();
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("clicked").toBool());
QVERIFY(window.rootObject()->property("held").toBool());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTRY_VERIFY(window.rootObject()->property("held").toBool());
QVERIFY(!window.rootObject()->property("clicked").toBool());
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
// We do not handle onPressAndHold, therefore we get onClicked
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("noclickandhold.qml")));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("clicked").toBool());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QTest::qWait(1000);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(window.rootObject()->property("clicked").toBool());
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::onMousePressRejected()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("rejectEvent.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(window.rootObject()->property("enabled").toBool());
QVERIFY(!window.rootObject()->property("mr1_pressed").toBool());
QVERIFY(!window.rootObject()->property("mr1_released").toBool());
QVERIFY(!window.rootObject()->property("mr1_canceled").toBool());
QVERIFY(!window.rootObject()->property("mr2_pressed").toBool());
QVERIFY(!window.rootObject()->property("mr2_released").toBool());
QVERIFY(!window.rootObject()->property("mr2_canceled").toBool());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(window.rootObject()->property("mr1_pressed").toBool());
QVERIFY(!window.rootObject()->property("mr1_released").toBool());
QVERIFY(!window.rootObject()->property("mr1_canceled").toBool());
QVERIFY(window.rootObject()->property("mr2_pressed").toBool());
QVERIFY(!window.rootObject()->property("mr2_released").toBool());
MouseArea: press not accepted means not pressed This changes that items that explicitly do not accept a press event, will no longer get a cancel event. [ChangeLog][QtQuick] MouseArea no longer thinks it's pressed when it does not accept the press event. When a press event is not accepted, MouseArea also no longer receives a cancel event. Change-Id: I8419cef60d7cc32aab15e9027fafb73cc08001ba Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2016-07-26 23:00:28 +00:00
QVERIFY(!window.rootObject()->property("mr2_canceled").toBool());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTRY_VERIFY(window.rootObject()->property("mr1_released").toBool());
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("mr1_canceled").toBool());
QVERIFY(!window.rootObject()->property("mr2_released").toBool());
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
void tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate_data()
{
QTest::addColumn<bool>("doubleClick");
QTest::newRow("simple click") << false;
QTest::newRow("double click") << true;
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QFETCH(bool, doubleClick);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("pressedCanceled.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("pressed").toBool());
QVERIFY(!window.rootObject()->property("canceled").toBool());
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
int expectedRelease = 0;
int expectedClicks = 0;
QCOMPARE(window.rootObject()->property("released").toInt(), expectedRelease);
QCOMPARE(window.rootObject()->property("clicked").toInt(), expectedClicks);
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent(QEvent::MouseButtonPress, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), Qt::LeftButton, Qt::LeftButton, {});
QMouseEvent releaseEvent(QEvent::MouseButtonRelease, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), Qt::LeftButton, Qt::LeftButton, {});
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &pressEvent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Improve tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate Make it more reliable and faster - average run time goes down by ~400 ms while the test passes reliable for me after this change. Most QTRY_* will return instantly since the condition will be good in any case. On my laptop the test tended to fail roughly every 4th run without this patch. The failure was the second click on the new window not working without the QTRY_VERIFY. Removing the extra 200 ms wait time is what makes it faster - I see no good reason for the wait here. Change-Id: I5f45da91ef04a9b807ff0e9362c9d9b3881c227d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-04 21:36:39 +00:00
QTRY_VERIFY(window.rootObject()->property("pressed").toBool());
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("canceled").toBool());
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QCOMPARE(window.rootObject()->property("released").toInt(), expectedRelease);
QCOMPARE(window.rootObject()->property("clicked").toInt(), expectedClicks);
if (doubleClick) {
QGuiApplication::sendEvent(&window, &releaseEvent);
Improve tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate Make it more reliable and faster - average run time goes down by ~400 ms while the test passes reliable for me after this change. Most QTRY_* will return instantly since the condition will be good in any case. On my laptop the test tended to fail roughly every 4th run without this patch. The failure was the second click on the new window not working without the QTRY_VERIFY. Removing the extra 200 ms wait time is what makes it faster - I see no good reason for the wait here. Change-Id: I5f45da91ef04a9b807ff0e9362c9d9b3881c227d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-04 21:36:39 +00:00
QTRY_VERIFY(!window.rootObject()->property("pressed").toBool());
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QVERIFY(!window.rootObject()->property("canceled").toBool());
QCOMPARE(window.rootObject()->property("released").toInt(), ++expectedRelease);
QCOMPARE(window.rootObject()->property("clicked").toInt(), ++expectedClicks);
QGuiApplication::sendEvent(&window, &pressEvent);
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent2(QEvent::MouseButtonDblClick, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), Qt::LeftButton, Qt::LeftButton, {});
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QGuiApplication::sendEvent(&window, &pressEvent2);
Improve tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate Make it more reliable and faster - average run time goes down by ~400 ms while the test passes reliable for me after this change. Most QTRY_* will return instantly since the condition will be good in any case. On my laptop the test tended to fail roughly every 4th run without this patch. The failure was the second click on the new window not working without the QTRY_VERIFY. Removing the extra 200 ms wait time is what makes it faster - I see no good reason for the wait here. Change-Id: I5f45da91ef04a9b807ff0e9362c9d9b3881c227d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-04 21:36:39 +00:00
QTRY_VERIFY(window.rootObject()->property("pressed").toBool());
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QVERIFY(!window.rootObject()->property("canceled").toBool());
QCOMPARE(window.rootObject()->property("released").toInt(), expectedRelease);
QCOMPARE(window.rootObject()->property("clicked").toInt(), expectedClicks);
QCOMPARE(window.rootObject()->property("doubleClicked").toInt(), 1);
}
tst_ma::pressedCanceledOnWindowDeactivate: don't pop up second window I guess I must have thought it would be more realistic that way; but sending an explicit WindowDeactivate as we had it in early Qt 5 seems to keep the test passing now, and is probably more reliable. The original purpose of the test seems to be to verify the recursive delivery to all items via virtual QQuickItem::windowDeactivateEvent(), which MouseArea (and no other item!) overrides to ungrab the mouse. This mostly reverts commit 1c451b40aee66a38ca3d61e5beec4ae8c986c8ed. Change-Id: I0c6f953514095a491120a0aac9944dc8b04ca17d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2020-11-18 22:11:37 +00:00
QEvent windowDeactivateEvent(QEvent::WindowDeactivate);
QGuiApplication::sendEvent(&window, &windowDeactivateEvent);
Improve tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate Make it more reliable and faster - average run time goes down by ~400 ms while the test passes reliable for me after this change. Most QTRY_* will return instantly since the condition will be good in any case. On my laptop the test tended to fail roughly every 4th run without this patch. The failure was the second click on the new window not working without the QTRY_VERIFY. Removing the extra 200 ms wait time is what makes it faster - I see no good reason for the wait here. Change-Id: I5f45da91ef04a9b807ff0e9362c9d9b3881c227d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-04 21:36:39 +00:00
QTRY_VERIFY(!window.rootObject()->property("pressed").toBool());
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(window.rootObject()->property("canceled").toBool());
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QCOMPARE(window.rootObject()->property("released").toInt(), expectedRelease);
QCOMPARE(window.rootObject()->property("clicked").toInt(), expectedClicks);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
//press again
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Improve tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate Make it more reliable and faster - average run time goes down by ~400 ms while the test passes reliable for me after this change. Most QTRY_* will return instantly since the condition will be good in any case. On my laptop the test tended to fail roughly every 4th run without this patch. The failure was the second click on the new window not working without the QTRY_VERIFY. Removing the extra 200 ms wait time is what makes it faster - I see no good reason for the wait here. Change-Id: I5f45da91ef04a9b807ff0e9362c9d9b3881c227d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-04 21:36:39 +00:00
QTRY_VERIFY(window.rootObject()->property("pressed").toBool());
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("canceled").toBool());
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QCOMPARE(window.rootObject()->property("released").toInt(), expectedRelease);
QCOMPARE(window.rootObject()->property("clicked").toInt(), expectedClicks);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
//release
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Improve tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate Make it more reliable and faster - average run time goes down by ~400 ms while the test passes reliable for me after this change. Most QTRY_* will return instantly since the condition will be good in any case. On my laptop the test tended to fail roughly every 4th run without this patch. The failure was the second click on the new window not working without the QTRY_VERIFY. Removing the extra 200 ms wait time is what makes it faster - I see no good reason for the wait here. Change-Id: I5f45da91ef04a9b807ff0e9362c9d9b3881c227d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-04 21:36:39 +00:00
QTRY_VERIFY(!window.rootObject()->property("pressed").toBool());
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QVERIFY(!window.rootObject()->property("canceled").toBool());
MouseArea: Fix cancelling the double click when the windows loses focus Without this, the next click is not received after the windows loses focus while we double clicked but not released the mouse. This may happen if the onDoubleClicked opens a new window Change-Id: I86742de2bb1ea4c9657b9d5e90472d093293177d Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2014-09-03 18:42:04 +00:00
QCOMPARE(window.rootObject()->property("released").toInt(), ++expectedRelease);
QCOMPARE(window.rootObject()->property("clicked").toInt(), ++expectedClicks);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::doubleClick()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QFETCH(Qt::MouseButtons, acceptedButtons);
QFETCH(Qt::MouseButton, button);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("doubleclick.qml")));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>("mousearea");
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QVERIFY(mouseArea);
mouseArea->setAcceptedButtons(acceptedButtons);
Fix MouseArea autotest. The hover test seems to be simply wrong. The double click tests worked before due to the obscure handling of double click but were somewhat incorrect in any case. Change-Id: Ie5690e26eb5921fe149e128d24d331f52a5a9075 Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2012-03-12 06:40:52 +00:00
// The sequence for a double click is:
// press, release, (click), press, double click, release
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent(QEvent::MouseButtonPress, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &pressEvent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent releaseEvent(QEvent::MouseButtonRelease, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &releaseEvent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("released").toInt(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &pressEvent);
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent2 = QMouseEvent(QEvent::MouseButtonDblClick, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
QGuiApplication::sendEvent(&window, &pressEvent2);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &releaseEvent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("clicked").toInt(), 1);
QCOMPARE(window.rootObject()->property("doubleClicked").toInt(), 1);
QCOMPARE(window.rootObject()->property("released").toInt(), 2);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// QTBUG-14832
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::clickTwice()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QFETCH(Qt::MouseButtons, acceptedButtons);
QFETCH(Qt::MouseButton, button);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("clicktwice.qml")));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>("mousearea");
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QVERIFY(mouseArea);
mouseArea->setAcceptedButtons(acceptedButtons);
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent(QEvent::MouseButtonPress, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &pressEvent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent releaseEvent(QEvent::MouseButtonRelease, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &releaseEvent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("pressed").toInt(), 1);
QCOMPARE(window.rootObject()->property("released").toInt(), 1);
QCOMPARE(window.rootObject()->property("clicked").toInt(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &pressEvent);
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent2 = QMouseEvent(QEvent::MouseButtonDblClick, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
QGuiApplication::sendEvent(&window, &pressEvent2);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &releaseEvent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("pressed").toInt(), 2);
QCOMPARE(window.rootObject()->property("released").toInt(), 2);
QCOMPARE(window.rootObject()->property("clicked").toInt(), 2);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
void tst_QQuickMouseArea::invalidClick()
{
QFETCH(Qt::MouseButtons, acceptedButtons);
QFETCH(Qt::MouseButton, button);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("doubleclick.qml")));
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>("mousearea");
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
QVERIFY(mouseArea);
mouseArea->setAcceptedButtons(acceptedButtons);
// The sequence for a double click is:
// press, release, (click), press, double click, release
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent(QEvent::MouseButtonPress, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &pressEvent);
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent releaseEvent(QEvent::MouseButtonRelease, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &releaseEvent);
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("released").toInt(), 0);
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &pressEvent);
Stop using deprecated QMouseEvent and QContextMenuEvent ctors Needed after qtbase 6b2c9b81afdb3d1d9b7a2e87819e9545b14810f3 Change-Id: I117cd4d09b4219ddc97dd019419b4b971f9dbb8e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-01-31 20:05:39 +00:00
QMouseEvent pressEvent2 = QMouseEvent(QEvent::MouseButtonDblClick, QPoint(100, 100),
window.mapToGlobal(QPoint(100, 100)), button, button, {});
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
QGuiApplication::sendEvent(&window, &pressEvent2);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &releaseEvent);
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("clicked").toInt(), 0);
QCOMPARE(window.rootObject()->property("doubleClicked").toInt(), 0);
QCOMPARE(window.rootObject()->property("released").toInt(), 0);
Add tests for clicking and dragging with right and middle buttons. Task-number: QTBUG-24461 Change-Id: I2c8b3455cb3aead5df7dfd85f65eb633a552b881 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-06-21 05:49:10 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::pressedOrdering()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("pressedOrdering.qml")));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("value").toString(), QLatin1String("base"));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("value").toString(), QLatin1String("pressed"));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("value").toString(), QLatin1String("toggled"));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, {100, 100});
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QCOMPARE(window.rootObject()->property("value").toString(), QLatin1String("pressed"));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::preventStealing()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("preventstealing.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickFlickable *flickable = qobject_cast<QQuickFlickable*>(window.rootObject());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(flickable != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea*>("mousearea");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseArea != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QSignalSpy mousePositionSpy(mouseArea, SIGNAL(positionChanged(QQuickMouseEvent*)));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Fix tst_QQuickMouseArea::preventStealing for big startDragDistance Change-Id: I38c3a663409633bd7020c2630bf11c2e46082435 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:53:39 +00:00
QPoint p = QPoint(80, 80);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// Without preventStealing, mouse movement over MouseArea would
// cause the Flickable to steal mouse and trigger content movement.
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Fix tst_QQuickMouseArea::preventStealing for big startDragDistance Change-Id: I38c3a663409633bd7020c2630bf11c2e46082435 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:53:39 +00:00
p += QPoint(-startDragDistance() * 2, -startDragDistance() * 2);
QTest::mouseMove(&window, p);
p += QPoint(-10, -10);
QTest::mouseMove(&window, p);
p += QPoint(-10, -10);
QTest::mouseMove(&window, p);
p += QPoint(-10, -10);
QTest::mouseMove(&window, p);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Fix tst_QQuickMouseArea::preventStealing for big startDragDistance Change-Id: I38c3a663409633bd7020c2630bf11c2e46082435 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:53:39 +00:00
// We should have received all four move events
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(mousePositionSpy.size(), 4);
Fix tst_QQuickMouseArea::preventStealing for big startDragDistance Change-Id: I38c3a663409633bd7020c2630bf11c2e46082435 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:53:39 +00:00
mousePositionSpy.clear();
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QVERIFY(mouseArea->isPressed());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// Flickable content should not have moved.
QCOMPARE(flickable->contentX(), 0.);
QCOMPARE(flickable->contentY(), 0.);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, p);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// Now allow stealing and confirm Flickable does its thing.
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
window.rootObject()->setProperty("stealing", false);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Fix tst_QQuickMouseArea::preventStealing for big startDragDistance Change-Id: I38c3a663409633bd7020c2630bf11c2e46082435 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:53:39 +00:00
p = QPoint(80, 80);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// Without preventStealing, mouse movement over MouseArea would
// cause the Flickable to steal mouse and trigger content movement.
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Fix tst_QQuickMouseArea::preventStealing for big startDragDistance Change-Id: I38c3a663409633bd7020c2630bf11c2e46082435 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:53:39 +00:00
p += QPoint(-startDragDistance() * 2, -startDragDistance() * 2);
QTest::mouseMove(&window, p);
p += QPoint(-10, -10);
QTest::mouseMove(&window, p);
p += QPoint(-10, -10);
QTest::mouseMove(&window, p);
p += QPoint(-10, -10);
QTest::mouseMove(&window, p);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// We should only have received the first move event
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(mousePositionSpy.size(), 1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
// Our press should be taken away
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QVERIFY(!mouseArea->isPressed());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Fix tst_QQuickMouseArea::preventStealing for big startDragDistance Change-Id: I38c3a663409633bd7020c2630bf11c2e46082435 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 11:53:39 +00:00
// Flickable swallows the first move, then moves 2*10 px
QTRY_COMPARE(flickable->contentX(), 20.);
QCOMPARE(flickable->contentY(), 20.);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, p);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Allow descendant chains to simultaneously be hovered. Matches GV behaviour. Also fixes a bug in QSGMouseArea, which we aren't fixing for QtQuick 1. Task-number: QTBUG-18175 Change-Id: I4ecac7b908504f28de830732c731281407d7b0bc Reviewed-on: http://codereview.qt.nokia.com/2422 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-01 06:20:26 +00:00
MouseArea: don't override preventStealing on mouse release In setPreventStealing() we call setKeepMouseGrab(); so it does not make sense to override setKeepMouseGrab() in other places without even checking the state of the preventStealing property. Pick-to: 5.15 6.2 6.3 Fixes: QTBUG-103522 Change-Id: Ib4a2b01b814835715642aec83fac0a84debe2461 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-18 11:21:05 +00:00
// QTBUG-103522
void tst_QQuickMouseArea::preventStealingListViewChild()
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("preventStealingListViewChild.qml")));
QQuickFlickable *flickable = qobject_cast<QQuickFlickable*>(window.rootObject());
QVERIFY(flickable);
QQuickMouseArea *mouseArea = flickable->findChild<QQuickMouseArea*>();
QVERIFY(mouseArea);
QPoint p = mouseArea->mapToScene(mouseArea->boundingRect().center()).toPoint();
const int threshold = qApp->styleHints()->startDragDistance();
flickable->flick(0, -10000);
for (int i = 0; i < 2; ++i) {
QVERIFY(flickable->isMovingVertically());
QTest::touchEvent(&window, device).press(0, p);
QQuickTouchUtils::flush(&window);
for (int j = 0; j < 4 && !mouseArea->drag()->active(); ++j) {
p += QPoint(0, threshold);
QTest::touchEvent(&window, device).move(0, p);
QQuickTouchUtils::flush(&window);
}
// MouseArea should be dragged because of preventStealing; ListView does not steal the grab.
QVERIFY(mouseArea->drag()->active());
QCOMPARE(flickable->isDragging(), false);
QTest::touchEvent(&window, device).release(0, p);
QCOMPARE(mouseArea->drag()->active(), false);
}
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::clickThrough()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
// timestamp delay to avoid generating a double click
Fix test failure: wait between mouse events the proper way Apparently, QTest::mouseEvent() disregards the wall time for the time stamps for events, but synthesizes the timestamps instead. The proper way is to specify the waiting time in the delay argument. This will adjust both the timestamp and perform a qWait() before the event handler is called. Without this patch, the qWait(doubleClickInterval) was disregarded, which lead to that a doubleclick event was generated, and it failed with the following message: Actual (((window->rootObject()->property("doubleClicks").toInt()))): 2 Expected (1) : 1 tst_qquickmousearea.cpp(1105) : failure location Change-Id: Ieda3b670d3cda0bd522db2f9677dad5745c88a21 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-08-12 11:38:54 +00:00
const int doubleClickInterval = qApp->styleHints()->mouseDoubleClickInterval() + 10;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("clickThrough.qml")));
QQuickItem *root = window.rootObject();
QVERIFY(root);
Fix test failure: wait between mouse events the proper way Apparently, QTest::mouseEvent() disregards the wall time for the time stamps for events, but synthesizes the timestamps instead. The proper way is to specify the waiting time in the delay argument. This will adjust both the timestamp and perform a qWait() before the event handler is called. Without this patch, the qWait(doubleClickInterval) was disregarded, which lead to that a doubleclick event was generated, and it failed with the following message: Actual (((window->rootObject()->property("doubleClicks").toInt()))): 2 Expected (1) : 1 tst_qquickmousearea.cpp(1105) : failure location Change-Id: Ieda3b670d3cda0bd522db2f9677dad5745c88a21 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-08-12 11:38:54 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
// With no handlers defined, click, doubleClick and PressAndHold should propagate to those with handlers
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTRY_COMPARE(root->property("presses").toInt(), 0);
QTRY_COMPARE(root->property("clicks").toInt(), 1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("doubleClicks").toInt(), 0);
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::qWait(1000);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTRY_COMPARE(root->property("presses").toInt(), 0);
QTRY_COMPARE(root->property("clicks").toInt(), 1);
QTRY_COMPARE(root->property("pressAndHolds").toInt(), 1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseDClick(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::qWait(100);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QTRY_COMPARE(root->property("clicks").toInt(), 2);
QTRY_COMPARE(root->property("doubleClicks").toInt(), 1);
QCOMPARE(root->property("pressAndHolds").toInt(), 1);
}
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("clickThrough2.qml")));
QQuickItem *root = window.rootObject();
QVERIFY(root);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
// With handlers defined, click, doubleClick and PressAndHold should propagate only when explicitly ignored
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QCOMPARE(root->property("clicks").toInt(), 0);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::qWait(1000);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::qWait(100);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QCOMPARE(root->property("clicks").toInt(), 0);
QCOMPARE(root->property("pressAndHolds").toInt(), 0);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseDClick(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::qWait(100);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QCOMPARE(root->property("clicks").toInt(), 0);
QCOMPARE(root->property("doubleClicks").toInt(), 0);
QCOMPARE(root->property("pressAndHolds").toInt(), 0);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
root->setProperty("letThrough", QVariant(true));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QTRY_COMPARE(root->property("clicks").toInt(), 1);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::qWait(1000);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::qWait(100);
Add propagateComposedEvents property to MouseArea While necessary, advanced event propagation isn't the common use case. Now needs to be explicitly enabled. Task-number: QTBUG-21081 Change-Id: Ibd8b4974934116dbfa32cc5e72037fd9b11015b4 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-11-15 01:51:50 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QCOMPARE(root->property("clicks").toInt(), 1);
QCOMPARE(root->property("pressAndHolds").toInt(), 1);
Add propagateComposedEvents property to MouseArea While necessary, advanced event propagation isn't the common use case. Now needs to be explicitly enabled. Task-number: QTBUG-21081 Change-Id: Ibd8b4974934116dbfa32cc5e72037fd9b11015b4 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-11-15 01:51:50 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseDClick(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::qWait(100);
Add propagateComposedEvents property to MouseArea While necessary, advanced event propagation isn't the common use case. Now needs to be explicitly enabled. Task-number: QTBUG-21081 Change-Id: Ibd8b4974934116dbfa32cc5e72037fd9b11015b4 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-11-15 01:51:50 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QTRY_COMPARE(root->property("clicks").toInt(), 2);
QCOMPARE(root->property("doubleClicks").toInt(), 1);
QCOMPARE(root->property("pressAndHolds").toInt(), 1);
Add propagateComposedEvents property to MouseArea While necessary, advanced event propagation isn't the common use case. Now needs to be explicitly enabled. Task-number: QTBUG-21081 Change-Id: Ibd8b4974934116dbfa32cc5e72037fd9b11015b4 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-11-15 01:51:50 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
root->setProperty("noPropagation", QVariant(true));
Don't propagate mouse events to disabled MouseAreas Task-number: QTBUG-34368 Change-Id: I28d4f57e51300f12a7bab5d215933762102f3916 Reviewed-by: Michael Brasser <michael.brasser@live.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
2013-11-04 21:29:12 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Don't propagate mouse events to disabled MouseAreas Task-number: QTBUG-34368 Change-Id: I28d4f57e51300f12a7bab5d215933762102f3916 Reviewed-by: Michael Brasser <michael.brasser@live.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
2013-11-04 21:29:12 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::qWait(1000);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::qWait(100);
Don't propagate mouse events to disabled MouseAreas Task-number: QTBUG-34368 Change-Id: I28d4f57e51300f12a7bab5d215933762102f3916 Reviewed-by: Michael Brasser <michael.brasser@live.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
2013-11-04 21:29:12 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseDClick(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::qWait(100);
Don't propagate mouse events to disabled MouseAreas Task-number: QTBUG-34368 Change-Id: I28d4f57e51300f12a7bab5d215933762102f3916 Reviewed-by: Michael Brasser <michael.brasser@live.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
2013-11-04 21:29:12 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("presses").toInt(), 0);
QTRY_COMPARE(root->property("clicks").toInt(), 2);
QCOMPARE(root->property("doubleClicks").toInt(), 1);
QCOMPARE(root->property("pressAndHolds").toInt(), 1);
}
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("qtbug34368.qml")));
QQuickItem *root = window.rootObject();
QVERIFY(root);
Don't propagate mouse events to disabled MouseAreas Task-number: QTBUG-34368 Change-Id: I28d4f57e51300f12a7bab5d215933762102f3916 Reviewed-by: Michael Brasser <michael.brasser@live.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
2013-11-04 21:29:12 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
// QTBUG-34368 - Shouldn't propagate to disabled mouse areas
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Don't propagate mouse events to disabled MouseAreas Task-number: QTBUG-34368 Change-Id: I28d4f57e51300f12a7bab5d215933762102f3916 Reviewed-by: Michael Brasser <michael.brasser@live.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
2013-11-04 21:29:12 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("clicksEnabled").toInt(), 1);
QCOMPARE(root->property("clicksDisabled").toInt(), 1); //Not disabled yet
Don't propagate mouse events to disabled MouseAreas Task-number: QTBUG-34368 Change-Id: I28d4f57e51300f12a7bab5d215933762102f3916 Reviewed-by: Michael Brasser <michael.brasser@live.com> Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
2013-11-04 21:29:12 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
root->setProperty("disableLower", QVariant(true));
MouseArea: fixed a crash in propagate() Should not propagate without window. Task-number: QTBUG-49100 Change-Id: Ieda3a8357283f8d07d4ffc0cc62c4e15645d7e5a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-26 06:37:17 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100), doubleClickInterval);
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
MouseArea: fixed a crash in propagate() Should not propagate without window. Task-number: QTBUG-49100 Change-Id: Ieda3a8357283f8d07d4ffc0cc62c4e15645d7e5a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-26 06:37:17 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(root->property("clicksEnabled").toInt(), 2);
QCOMPARE(root->property("clicksDisabled").toInt(), 1); //disabled, shouldn't increment
}
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("qtbug49100.qml")));
QQuickItem *root = window.rootObject();
QVERIFY(root);
MouseArea: fixed a crash in propagate() Should not propagate without window. Task-number: QTBUG-49100 Change-Id: Ieda3a8357283f8d07d4ffc0cc62c4e15645d7e5a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-26 06:37:17 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
// QTBUG-49100
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
MouseArea: fixed a crash in propagate() Should not propagate without window. Task-number: QTBUG-49100 Change-Id: Ieda3a8357283f8d07d4ffc0cc62c4e15645d7e5a Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
2015-11-26 06:37:17 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(window.rootObject());
}
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::hoverPosition()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("hoverPosition.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(root->property("mouseX").toReal(), qreal(0));
QCOMPARE(root->property("mouseY").toReal(), qreal(0));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window,QPoint(10,32));
fixed autotest removed debug statements Change-Id: Id09e3a6a43b5d5170d8b50b10cc35eb8c4e1f3d0 Reviewed-on: http://codereview.qt-project.org/4472 Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 14:46:54 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(root->property("mouseX").toReal(), qreal(10));
QCOMPARE(root->property("mouseY").toReal(), qreal(32));
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickMouseArea::hoverPropagation()
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("hoverPropagation.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
// QTBUG-18175, to behave like GV did.
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(root->property("point1").toBool(), false);
QCOMPARE(root->property("point2").toBool(), false);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, {32, 32});
fixed autotest removed debug statements Change-Id: Id09e3a6a43b5d5170d8b50b10cc35eb8c4e1f3d0 Reviewed-on: http://codereview.qt-project.org/4472 Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 14:46:54 +00:00
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(root->property("point1").toBool(), true);
QCOMPARE(root->property("point2").toBool(), false);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, {232, 32});
uncomment tests Change-Id: I8aea71cfddb38fe1a24a74ca736a39e3f8817a5b Reviewed-on: http://codereview.qt-project.org/4464 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2011-09-08 13:58:13 +00:00
QCOMPARE(root->property("point1").toBool(), false);
QCOMPARE(root->property("point2").toBool(), true);
}
Allow descendant chains to simultaneously be hovered. Matches GV behaviour. Also fixes a bug in QSGMouseArea, which we aren't fixing for QtQuick 1. Task-number: QTBUG-18175 Change-Id: I4ecac7b908504f28de830732c731281407d7b0bc Reviewed-on: http://codereview.qt.nokia.com/2422 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-01 06:20:26 +00:00
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
void tst_QQuickMouseArea::hoverVisible()
{
Enable passing tests that were skipped on offscreen grabWindow is now implemented for the offscreen plugin, so a large number of tests relying on that functionality don't need to be skipped any longer. Change-Id: I85bfc9e4b327389055041b6187a54f88d9cf81d2 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-02-06 23:16:22 +00:00
if (QGuiApplication::platformName() == QLatin1String("minimal"))
QSKIP("Skipping due to grabWindow not functional on minimal platforms");
Enable tests for boot2qt Some tests needed fixing - Disabled tests too heavy for qemu - Skipped tests requiring OpenGL without support from the platform - Skipped tests requiring functionality on broken offscreen platform - Skipped tests that take too long on qemu + software renderer - Blacklisted tests for created bugs QTBUG-63049, QTBUG-63053 QTBUG-63055 and QTBUG-63057 Task-number: QTBUG-60268 Change-Id: I0346b0e436cf286d7d9cbc140acf324a4087cfb9 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-30 12:39:28 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("hoverVisible.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickMouseArea *mouseTracker = root->findChild<QQuickMouseArea*>("mousetracker");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseTracker != nullptr);
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
QSignalSpy enteredSpy(mouseTracker, SIGNAL(entered()));
Fix MouseArea autotest. The hover test seems to be simply wrong. The double click tests worked before due to the obscure handling of double click but were somewhat incorrect in any case. Change-Id: Ie5690e26eb5921fe149e128d24d331f52a5a9075 Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2012-03-12 06:40:52 +00:00
// Note: We need to use a position that is different from the position in the last event
// generated in the previous test case. Otherwise it is not interpreted as a move.
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window,QPoint(11,33));
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
QCOMPARE(mouseTracker->hovered(), false);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(enteredSpy.size(), 0);
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
mouseTracker->setVisible(true);
QCOMPARE(mouseTracker->hovered(), true);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(enteredSpy.size(), 1);
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
Replace usage of QCursor, and update hoverVisible test. QCursor::pos() doesn't work well with mouse events generated by the test framework. Change-Id: I62ee2228c194f21cf17f6271c662056a90c5ef2d Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
2012-03-28 06:46:31 +00:00
QCOMPARE(QPointF(mouseTracker->mouseX(), mouseTracker->mouseY()), QPointF(11,33));
QQuickMouseArea: fix containsMouse when mousearea become visible If enabled is false, then containsMouse will not become true when hovering on mousearea, even if hoverEnabled is true. However when an invisible mousearea become visible, the value of enabled isn't checked. In this case, the value of containsMouse is not affected by enabled. [ChangeLog][QtQuick][QQuickMouseArea] containsMouse property will not become true when the an invisible mousearea become visible, if the enabled property is false or its parent item is not enabled Fixes: QTBUG-77983 Change-Id: I923bdcf3eda813aea51a04515d530093d6eb77b2 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-09-19 10:04:55 +00:00
// QTBUG-77983
mouseTracker->setVisible(false);
mouseTracker->setEnabled(false);
QCOMPARE(mouseTracker->hovered(), false);
mouseTracker->setVisible(true);
// if the enabled property is false, the containsMouse property shouldn't become true
// when an invisible mousearea become visible
QCOMPARE(mouseTracker->hovered(), false);
mouseTracker->parentItem()->setEnabled(false);
mouseTracker->setVisible(false);
mouseTracker->setEnabled(true);
QCOMPARE(mouseTracker->hovered(), false);
mouseTracker->setVisible(true);
// if the parent item is not enabled, the containsMouse property will be false, even if
// the mousearea is enabled
QCOMPARE(mouseTracker->hovered(), false);
mouseTracker->parentItem()->setEnabled(true);
mouseTracker->setVisible(false);
mouseTracker->setEnabled(true);
QCOMPARE(mouseTracker->hovered(), false);
mouseTracker->setVisible(true);
QCOMPARE(mouseTracker->hovered(), true);
Ensure visibility changes are communicated through itemChange. Also added MouseArea test that depends on this functionality. Change-Id: I1c303504ffd63d6b9dbdf95ab63e8426dc09c02d Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-02-15 06:27:36 +00:00
}
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
void tst_QQuickMouseArea::hoverAfterPress()
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("hoverAfterPress.qml")));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea*>("mouseArea");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseArea != nullptr);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(22,33));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
QCOMPARE(mouseArea->hovered(), false);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(200,200));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
QCOMPARE(mouseArea->hovered(), true);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(22,33));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
QCOMPARE(mouseArea->hovered(), false);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(200,200));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
QCOMPARE(mouseArea->hovered(), true);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(200,200));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
QCOMPARE(mouseArea->hovered(), true);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(200,200));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
QCOMPARE(mouseArea->hovered(), true);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(22,33));
Fix hover after press event When a mouse press event was rejected, we would unconditionally cancel the hover and claim that the mouse is not contained any more. Instead check if the mouse left and only then cancel the hover state. Task-number: QTBUG-30783 Change-Id: I5fac6f3a1f2807ef03e07982c603492d40d2a249 Reviewed-by: Florian Boucault <florian@boucault.net> Reviewed-by: Alan Alpert <aalpert@blackberry.com>
2013-04-26 14:18:54 +00:00
QCOMPARE(mouseArea->hovered(), false);
}
MouseArea: add autotest for subtreeHoverEnabled Verify the fix in f7e462b. Task-number: QTBUG-54019 Change-Id: Ia9846f9b79473ea4f72e895320cf01d5d85cc1a3 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-06-20 09:57:43 +00:00
void tst_QQuickMouseArea::subtreeHoverEnabled()
{
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("qtbug54019.qml")));
MouseArea: add autotest for subtreeHoverEnabled Verify the fix in f7e462b. Task-number: QTBUG-54019 Change-Id: Ia9846f9b79473ea4f72e895320cf01d5d85cc1a3 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-06-20 09:57:43 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
MouseArea: add autotest for subtreeHoverEnabled Verify the fix in f7e462b. Task-number: QTBUG-54019 Change-Id: Ia9846f9b79473ea4f72e895320cf01d5d85cc1a3 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-06-20 09:57:43 +00:00
QQuickMouseArea *mouseArea = root->findChild<QQuickMouseArea*>();
QQuickItemPrivate *rootPrivate = QQuickItemPrivate::get(root);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseArea != nullptr);
MouseArea: add autotest for subtreeHoverEnabled Verify the fix in f7e462b. Task-number: QTBUG-54019 Change-Id: Ia9846f9b79473ea4f72e895320cf01d5d85cc1a3 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-06-20 09:57:43 +00:00
QTest::mouseMove(&window, QPoint(10, 160));
QCOMPARE(mouseArea->hovered(), false);
QVERIFY(rootPrivate->subtreeHoverEnabled);
QTest::mouseMove(&window, QPoint(10, 10));
QCOMPARE(mouseArea->hovered(), true);
QTest::mouseMove(&window, QPoint(160, 10));
QCOMPARE(mouseArea->hovered(), false);
}
QQuickMouseArea: store hoverEnabled explicitly The current implementation would not explicitly store if hoverEnabled was set. Instead it would use acceptHoverEvents() directly. The problem is that the latter will also need to be set to false when a MouseArea is disabled, otherwise it will not receive a HoverLeave event. But when doing so, we will no longer know if hoverEnabled was set to true or false by setEnabled() or by setHoverEnabled(). As such, when the MouseArea is enabled again, we would no longer know if we should start to subscribe to hover events or not. This patch will therefore add en extra bool, hoverEnabled, that lets us track the hoverEnabled state explicitly. As a drive-by, also add some internal docs that explains how a MouseArea differs wrt hover compared to e.g HoverHandlers and other items. Fixes: QTBUG-46460 Pick-to: 6.4 Change-Id: I34e078b3574030572bcf770750820959e98ecc4c Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-09-16 11:13:00 +00:00
void tst_QQuickMouseArea::hoverWhenDisabled()
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("hoverVisible.qml")));
QQuickItem *root = window.rootObject();
QVERIFY(root);
QQuickMouseArea *mouseArea = root->findChild<QQuickMouseArea*>();
QVERIFY(mouseArea);
mouseArea->setVisible(true);
QTest::mouseMove(&window, QPoint(50, 50));
QVERIFY(mouseArea->hovered());
mouseArea->setEnabled(false);
QTest::mouseMove(&window, QPoint(51, 50));
QVERIFY(!mouseArea->hovered());
mouseArea->setEnabled(true);
QTest::mouseMove(&window, QPoint(50, 50));
QVERIFY(mouseArea->hovered());
mouseArea->setHoverEnabled(false);
QTest::mouseMove(&window, QPoint(51, 50));
QVERIFY(!mouseArea->hovered());
mouseArea->setHoverEnabled(true);
QTest::mouseMove(&window, QPoint(50, 50));
QVERIFY(mouseArea->hovered());
}
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
void tst_QQuickMouseArea::disableAfterPress()
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("dragging.qml")));
QQuickItem *root = window.rootObject();
QVERIFY(root);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickMouseArea *mouseArea = root->findChild<QQuickMouseArea*>("mouseregion");
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QQuickDrag *drag = mouseArea->drag();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseArea != nullptr);
QVERIFY(drag != nullptr);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QSignalSpy mousePositionSpy(mouseArea, SIGNAL(positionChanged(QQuickMouseEvent*)));
QSignalSpy mousePressSpy(mouseArea, SIGNAL(pressed(QQuickMouseEvent*)));
QSignalSpy mouseReleaseSpy(mouseArea, SIGNAL(released(QQuickMouseEvent*)));
// target
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickItem *blackRect = root->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QVERIFY(!drag->active());
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
QPoint p = QPoint(100,100);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(mousePressSpy.size(), 1);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
// First move event triggers drag, second is acted upon.
// This is due to possibility of higher stacked area taking precedence.
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p += QPoint(startDragDistance() + 1, 0);
QTest::mouseMove(&window, p);
p += QPoint(11, 11);
QTest::mouseMove(&window, p);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(mousePositionSpy.size(), 2);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
QTRY_VERIFY(drag->active());
QTRY_COMPARE(blackRect->x(), 61.0);
Smooth dragging an item with MouseArea. Calculate drag distance relative to the mouse position when a drag is detected rather than the press position so there isn't a large change in position on the first move. Task-number: QTBUG-30188 Change-Id: I5c2269c2228668a3842e18f65167637497b3beb4 Reviewed-by: Joona Petrell <joona.petrell@jollamobile.com>
2013-03-14 02:36:20 +00:00
QCOMPARE(blackRect->y(), 61.0);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
mouseArea->setEnabled(false);
// move should still be acted upon
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p += QPoint(11, 11);
QTest::mouseMove(&window, p);
p += QPoint(11, 11);
QTest::mouseMove(&window, p);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(mousePositionSpy.size(), 4);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QVERIFY(drag->active());
Smooth dragging an item with MouseArea. Calculate drag distance relative to the mouse position when a drag is detected rather than the press position so there isn't a large change in position on the first move. Task-number: QTBUG-30188 Change-Id: I5c2269c2228668a3842e18f65167637497b3beb4 Reviewed-by: Joona Petrell <joona.petrell@jollamobile.com>
2013-03-14 02:36:20 +00:00
QCOMPARE(blackRect->x(), 83.0);
QCOMPARE(blackRect->y(), 83.0);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QVERIFY(mouseArea->isPressed());
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QVERIFY(mouseArea->hovered());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, p);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(mouseReleaseSpy.size(), 1);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QVERIFY(!drag->active());
Smooth dragging an item with MouseArea. Calculate drag distance relative to the mouse position when a drag is detected rather than the press position so there isn't a large change in position on the first move. Task-number: QTBUG-30188 Change-Id: I5c2269c2228668a3842e18f65167637497b3beb4 Reviewed-by: Joona Petrell <joona.petrell@jollamobile.com>
2013-03-14 02:36:20 +00:00
QCOMPARE(blackRect->x(), 83.0);
QCOMPARE(blackRect->y(), 83.0);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QVERIFY(!mouseArea->isPressed());
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QVERIFY(!mouseArea->hovered()); // since hover is not enabled
// Next press will be ignored
blackRect->setX(50);
blackRect->setY(50);
mousePressSpy.clear();
mousePositionSpy.clear();
mouseReleaseSpy.clear();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QTest::qWait(50);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(mousePressSpy.size(), 0);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(111,111));
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QTest::qWait(50);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(122,122));
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QTest::qWait(50);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(mousePositionSpy.size(), 0);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(122,122));
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
QTest::qWait(50);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(mouseReleaseSpy.size(), 0);
Handle MouseArea.enabled = false after mouse is pressed. Currently this leaves the MouseArea in a broken state, i.e. still in pressed state, and the next press after it is re-enabled is ignored. In this case we now allow subsequent mouse move or release events to continue. Following the release, no further press will be accepted. Change-Id: I65a890da90e2166ad568505fffdbd3db6c97165b Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-05 05:07:27 +00:00
}
MouseArea: don't get stuck in pressed state when disabling in press In 8ace780b5aa298e3c01903bfd57f766a42209191 we fixed the case when MouseArea hides itself on press. This time, the concern is when it becomes _effectively_ disabled by disabling its parent on press. (As explained in a comment on QTBUG-38364, the MouseArea.enabled state is independent, but we can nevertheless also find out when the effective enabled state changes.) [ChangeLog][QtQuick][MouseArea] When a MouseArea becomes effectively disabled due to a parent's enabled property being set false while the mouse is pressed, the press will now be canceled. Fixes: QTBUG-39806 Fixes: QTBUG-103788 Change-Id: I8d69b535b6e1b5d51ad1e030f52217de9ab541f1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-10-18 11:28:52 +00:00
void tst_QQuickMouseArea::disableParentOnPress_data()
{
QTest::addColumn<const QPointingDevice *>("device");
QTest::newRow("core pointer") << QPointingDevice::primaryPointingDevice();
Use const QPointingDevices in tests When a data-driven test has QTest::addColumn<const QPointingDevice *>("device"); QTestData::append() does a type check with QTEST_ASSERT if it's not an exact match. That can result in a crash, apparently, although it's not clear then how 59d967a8fb60bb764654a857cac20196358865eb got through CI the first time. Amends 59d967a8fb60bb764654a857cac20196358865eb Task-number: QTBUG-107863 Task-number: QTBUG-107864 Change-Id: I383191b604eb504d49b0d51a23ecc45160f3383b Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-10-23 08:09:55 +00:00
QTest::newRow("touch") << static_cast<const QPointingDevice *>(device); // TODO QTBUG-107864
MouseArea: don't get stuck in pressed state when disabling in press In 8ace780b5aa298e3c01903bfd57f766a42209191 we fixed the case when MouseArea hides itself on press. This time, the concern is when it becomes _effectively_ disabled by disabling its parent on press. (As explained in a comment on QTBUG-38364, the MouseArea.enabled state is independent, but we can nevertheless also find out when the effective enabled state changes.) [ChangeLog][QtQuick][MouseArea] When a MouseArea becomes effectively disabled due to a parent's enabled property being set false while the mouse is pressed, the press will now be canceled. Fixes: QTBUG-39806 Fixes: QTBUG-103788 Change-Id: I8d69b535b6e1b5d51ad1e030f52217de9ab541f1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-10-18 11:28:52 +00:00
}
void tst_QQuickMouseArea::disableParentOnPress() // QTBUG-39806 and QTBUG-103788
{
QFETCH(const QPointingDevice *, device);
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("disableParentOnPress.qml")));
QQuickItem *root = window.rootObject();
QVERIFY(root);
QQuickMouseArea *mouseArea = root->findChild<QQuickMouseArea*>();
QVERIFY(mouseArea);
QSignalSpy pressedChangedSpy(mouseArea, &QQuickMouseArea::pressedChanged);
QSignalSpy canceledSpy(mouseArea, &QQuickMouseArea::canceled);
QSignalSpy enabledSpy(mouseArea, &QQuickMouseArea::enabledChanged);
QSignalSpy parentEnabledSpy(root, &QQuickItem::enabledChanged);
const QPoint p(100, 100);
QQuickTest::pointerPress(device, &window, 0, p);
QTRY_COMPARE(parentEnabledSpy.size(), 1);
Tests: Silence compiler warnings when checking bitfields MSVC complains about us comparing a bool to a quint32, which is the underlying type for the bitfields in QQuickItemPrivate. Fix that by replacing QCOMPARE(A, true/false) with the corresponding QVERIFY. Pick-to: 6.5 Change-Id: I7f50e6276b592c9abe8ceaea95c9283a0c431c78 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Øystein Heskestad <oystein.heskestad@qt.io>
2023-04-21 13:04:41 +00:00
QVERIFY(!root->isEnabled());
QVERIFY(mouseArea->isEnabled()); // enabled is independent, unfortunately (inverse of QTBUG-38364)
QVERIFY(!QQuickItemPrivate::get(mouseArea)->effectiveEnable);
MouseArea: don't get stuck in pressed state when disabling in press In 8ace780b5aa298e3c01903bfd57f766a42209191 we fixed the case when MouseArea hides itself on press. This time, the concern is when it becomes _effectively_ disabled by disabling its parent on press. (As explained in a comment on QTBUG-38364, the MouseArea.enabled state is independent, but we can nevertheless also find out when the effective enabled state changes.) [ChangeLog][QtQuick][MouseArea] When a MouseArea becomes effectively disabled due to a parent's enabled property being set false while the mouse is pressed, the press will now be canceled. Fixes: QTBUG-39806 Fixes: QTBUG-103788 Change-Id: I8d69b535b6e1b5d51ad1e030f52217de9ab541f1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-10-18 11:28:52 +00:00
// bug fix: it knows it got effectively disabled, so now it's no longer pressed
Tests: Silence compiler warnings when checking bitfields MSVC complains about us comparing a bool to a quint32, which is the underlying type for the bitfields in QQuickItemPrivate. Fix that by replacing QCOMPARE(A, true/false) with the corresponding QVERIFY. Pick-to: 6.5 Change-Id: I7f50e6276b592c9abe8ceaea95c9283a0c431c78 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Øystein Heskestad <oystein.heskestad@qt.io>
2023-04-21 13:04:41 +00:00
QVERIFY(!mouseArea->isPressed());
MouseArea: don't get stuck in pressed state when disabling in press In 8ace780b5aa298e3c01903bfd57f766a42209191 we fixed the case when MouseArea hides itself on press. This time, the concern is when it becomes _effectively_ disabled by disabling its parent on press. (As explained in a comment on QTBUG-38364, the MouseArea.enabled state is independent, but we can nevertheless also find out when the effective enabled state changes.) [ChangeLog][QtQuick][MouseArea] When a MouseArea becomes effectively disabled due to a parent's enabled property being set false while the mouse is pressed, the press will now be canceled. Fixes: QTBUG-39806 Fixes: QTBUG-103788 Change-Id: I8d69b535b6e1b5d51ad1e030f52217de9ab541f1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-10-18 11:28:52 +00:00
QCOMPARE(canceledSpy.size(), 1); // ...because the press was canceled
QCOMPARE(pressedChangedSpy.size(), 2); // kerchunk
QQuickTest::pointerRelease(device, &window, 0, p);
// now re-enable it and try again
root->setEnabled(true);
QQuickTest::pointerPress(device, &window, 0, p);
Tests: Silence compiler warnings when checking bitfields MSVC complains about us comparing a bool to a quint32, which is the underlying type for the bitfields in QQuickItemPrivate. Fix that by replacing QCOMPARE(A, true/false) with the corresponding QVERIFY. Pick-to: 6.5 Change-Id: I7f50e6276b592c9abe8ceaea95c9283a0c431c78 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Øystein Heskestad <oystein.heskestad@qt.io>
2023-04-21 13:04:41 +00:00
QTRY_VERIFY(!root->isEnabled());
QVERIFY(!QQuickItemPrivate::get(mouseArea)->effectiveEnable);
QVERIFY(!mouseArea->isPressed());
MouseArea: don't get stuck in pressed state when disabling in press In 8ace780b5aa298e3c01903bfd57f766a42209191 we fixed the case when MouseArea hides itself on press. This time, the concern is when it becomes _effectively_ disabled by disabling its parent on press. (As explained in a comment on QTBUG-38364, the MouseArea.enabled state is independent, but we can nevertheless also find out when the effective enabled state changes.) [ChangeLog][QtQuick][MouseArea] When a MouseArea becomes effectively disabled due to a parent's enabled property being set false while the mouse is pressed, the press will now be canceled. Fixes: QTBUG-39806 Fixes: QTBUG-103788 Change-Id: I8d69b535b6e1b5d51ad1e030f52217de9ab541f1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-10-18 11:28:52 +00:00
QCOMPARE(canceledSpy.size(), 2);
QCOMPARE(pressedChangedSpy.size(), 4);
QQuickTest::pointerRelease(device, &window, 0, p);
}
Add mouse wheel events handler to MouseArea This patch was based on the attached patch in QTBUG-7369. It basically exposes the wheel events to MouseArea via the onWheel signal. The current API is based on the new QWheelEvent API introduced by this patch: http://codereview.qt-project.org/#change,12532 Task-number: QTBUG-7369 Change-Id: Id58513715c2d0ae81e3a69e9e1ed400bbae07507 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-01-05 18:19:26 +00:00
void tst_QQuickMouseArea::onWheel()
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("wheel.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
Add mouse wheel events handler to MouseArea This patch was based on the attached patch in QTBUG-7369. It basically exposes the wheel events to MouseArea via the onWheel signal. The current API is based on the new QWheelEvent API introduced by this patch: http://codereview.qt-project.org/#change,12532 Task-number: QTBUG-7369 Change-Id: Id58513715c2d0ae81e3a69e9e1ed400bbae07507 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-01-05 18:19:26 +00:00
QWheelEvent wheelEvent(QPoint(10, 32), QPoint(10, 32), QPoint(60, 20), QPoint(0, 120),
Remove usages of deprecated APIs of QWheelEvent Task-number: QTBUG-76491 Change-Id: I69b0c4ec7c03f9421b18828516e064eff2b45518 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-08-02 12:41:10 +00:00
Qt::NoButton, Qt::ControlModifier, Qt::NoScrollPhase, false);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QGuiApplication::sendEvent(&window, &wheelEvent);
Add mouse wheel events handler to MouseArea This patch was based on the attached patch in QTBUG-7369. It basically exposes the wheel events to MouseArea via the onWheel signal. The current API is based on the new QWheelEvent API introduced by this patch: http://codereview.qt-project.org/#change,12532 Task-number: QTBUG-7369 Change-Id: Id58513715c2d0ae81e3a69e9e1ed400bbae07507 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-01-05 18:19:26 +00:00
QCOMPARE(root->property("angleDeltaY").toInt(), 120);
QCOMPARE(root->property("mouseX").toReal(), qreal(10));
QCOMPARE(root->property("mouseY").toReal(), qreal(32));
QCOMPARE(root->property("controlPressed").toBool(), true);
}
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
void tst_QQuickMouseArea::transformedMouseArea_data()
{
QTest::addColumn<bool>("insideTarget");
QTest::addColumn<QList<QPoint> >("points");
QList<QPoint> pointsInside;
pointsInside << QPoint(200, 140)
<< QPoint(140, 200)
<< QPoint(200, 200)
<< QPoint(260, 200)
<< QPoint(200, 260);
QTest::newRow("checking points inside") << true << pointsInside;
QList<QPoint> pointsOutside;
pointsOutside << QPoint(140, 140)
<< QPoint(260, 140)
<< QPoint(120, 200)
<< QPoint(280, 200)
<< QPoint(140, 260)
<< QPoint(260, 260);
QTest::newRow("checking points outside") << false << pointsOutside;
}
void tst_QQuickMouseArea::transformedMouseArea()
{
QFETCH(bool, insideTarget);
QFETCH(QList<QPoint>, points);
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("transformedMouseArea.qml")));
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>("mouseArea");
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(mouseArea);
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
for (const QPoint &point : points) {
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
// check hover
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, point);
Dragging MouseArea nested in Flickable does not work with touch to mouse A MouseArea with a drag target nested in a Flickable does not work. This is due to QQuickWindow calling childMouseEventFilter() twice - once in sendFilteredTouchEvent() and later in sendEvent(). Since childMouseEventFilter() has already been called, deliver the mouse event directly in sendFilteredTouchEvent(). Task-number: QTBUG-32920 Change-Id: I22acee3c66ee6c06e71c9c876fb02dbcb6119a8d Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2013-08-12 03:28:17 +00:00
QTRY_COMPARE(mouseArea->property("containsMouse").toBool(), insideTarget);
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
// check mouse press
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, point);
Dragging MouseArea nested in Flickable does not work with touch to mouse A MouseArea with a drag target nested in a Flickable does not work. This is due to QQuickWindow calling childMouseEventFilter() twice - once in sendFilteredTouchEvent() and later in sendEvent(). Since childMouseEventFilter() has already been called, deliver the mouse event directly in sendFilteredTouchEvent(). Task-number: QTBUG-32920 Change-Id: I22acee3c66ee6c06e71c9c876fb02dbcb6119a8d Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2013-08-12 03:28:17 +00:00
QTRY_COMPARE(mouseArea->property("pressed").toBool(), insideTarget);
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
// check mouse release
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, point);
Dragging MouseArea nested in Flickable does not work with touch to mouse A MouseArea with a drag target nested in a Flickable does not work. This is due to QQuickWindow calling childMouseEventFilter() twice - once in sendFilteredTouchEvent() and later in sendEvent(). Since childMouseEventFilter() has already been called, deliver the mouse event directly in sendFilteredTouchEvent(). Task-number: QTBUG-32920 Change-Id: I22acee3c66ee6c06e71c9c876fb02dbcb6119a8d Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2013-08-12 03:28:17 +00:00
QTRY_COMPARE(mouseArea->property("pressed").toBool(), false);
Adjust MouseArea autotest to check mouse events with transformations Tests mouse events with graphical transformations applied to the element. Change-Id: I4b69e35cde4125aa047fa18357b22b898da92c20 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
2012-02-26 16:27:34 +00:00
}
}
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
struct MouseEvent {
QEvent::Type type;
Qt::MouseButton button;
};
Q_DECLARE_METATYPE(MouseEvent)
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
void tst_QQuickMouseArea::pressedMultipleButtons_data()
{
QTest::addColumn<Qt::MouseButtons>("accepted");
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
QTest::addColumn<QList<MouseEvent> >("mouseEvents");
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
QTest::addColumn<QList<bool> >("pressed");
QTest::addColumn<QList<Qt::MouseButtons> >("pressedButtons");
QTest::addColumn<int>("changeCount");
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
Qt::MouseButtons accepted;
QList<MouseEvent> mouseEvents;
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
QList<bool> pressed;
QList<Qt::MouseButtons> pressedButtons;
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
int changeCount;
MouseEvent leftPress = { QEvent::MouseButtonPress, Qt::LeftButton };
MouseEvent leftRelease = { QEvent::MouseButtonRelease, Qt::LeftButton };
MouseEvent rightPress = { QEvent::MouseButtonPress, Qt::RightButton };
MouseEvent rightRelease = { QEvent::MouseButtonRelease, Qt::RightButton };
auto addRowWithFormattedTitleAndReset = [&]() {
QByteArray title;
title.append("Accept:");
if (accepted & Qt::LeftButton)
title.append(" LeftButton");
if (accepted & Qt::RightButton)
title.append(" RightButton");
title.append(" | Events:");
for (MouseEvent event : mouseEvents) {
title.append(event.type == QEvent::MouseButtonPress ? " Press" : " Release");
title.append(event.button == Qt::LeftButton ? " Left," : " Right,");
}
title.chop(1); // remove last comma
QTest::newRow(title) << accepted << mouseEvents << pressed << pressedButtons << changeCount;
mouseEvents.clear();
pressed.clear();
pressedButtons.clear();
};
accepted = Qt::LeftButton;
changeCount = 2;
mouseEvents << leftPress << rightPress << rightRelease << leftRelease;
pressed << true << true << true << false;
pressedButtons << Qt::LeftButton << Qt::LeftButton << Qt::LeftButton << Qt::NoButton;
addRowWithFormattedTitleAndReset();
accepted = Qt::LeftButton;
changeCount = 2;
mouseEvents << leftPress << rightPress << leftRelease << rightRelease;
pressed << true << true << false << false;
pressedButtons << Qt::LeftButton << Qt::LeftButton << Qt::NoButton << Qt::NoButton;
addRowWithFormattedTitleAndReset();
accepted = Qt::LeftButton | Qt::RightButton;
changeCount = 4;
mouseEvents << leftPress << rightPress << rightRelease << leftRelease;
pressed << true << true << true << false;
pressedButtons << Qt::LeftButton << (Qt::LeftButton | Qt::RightButton) << Qt::LeftButton
<< Qt::NoButton;
addRowWithFormattedTitleAndReset();
accepted = Qt::RightButton;
changeCount = 2;
mouseEvents << rightPress << leftPress << rightRelease << leftRelease;
pressed << true << true << false << false;
pressedButtons << Qt::RightButton << Qt::RightButton << Qt::NoButton << Qt::NoButton;
addRowWithFormattedTitleAndReset();
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
}
void tst_QQuickMouseArea::pressedMultipleButtons()
{
QFETCH(Qt::MouseButtons, accepted);
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
QFETCH(QList<MouseEvent>, mouseEvents);
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
QFETCH(QList<bool>, pressed);
QFETCH(QList<Qt::MouseButtons>, pressedButtons);
QFETCH(int, changeCount);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("simple.qml")));
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>("mousearea");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseArea != nullptr);
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
QSignalSpy pressedSpy(mouseArea, SIGNAL(pressedChanged()));
QSignalSpy pressedButtonsSpy(mouseArea, SIGNAL(pressedButtonsChanged()));
mouseArea->setAcceptedMouseButtons(accepted);
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
QPoint point(10, 10);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
for (int i = 0; i < mouseEvents.size(); ++i) {
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
const MouseEvent mouseEvent = mouseEvents.at(i);
if (mouseEvent.type == QEvent::MouseButtonPress)
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, mouseEvent.button, Qt::NoModifier, point);
tests: refactor and un-blacklist tst_QQuickMouseArea::pressedMultipleButtons It seems that qtestlib has never really supported mouse state handling for multiple buttons (see QTBUG-64030). And the current implementation of this test relied on QGuiApplication to generate mouse releases when necessary. Since a37785ec7638e7485112b87dd7e767881fecc114, qtestlib does not rely on QGuiApplication to deduce mouse button state, but requires explicit mouse press/release events via QTest::mouse* APIs, thus causing this auto test to fail. Refactor the auto test to use QTest::mouse* APIs. This change depends on a fix for QTBUG-64030. Task-number: QTBUG-63786 Change-Id: Id24526714ec9716a0126e8288e5e8974074ebc9e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-26 15:54:51 +00:00
else
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, mouseEvent.button, Qt::NoModifier, point);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QCOMPARE(mouseArea->isPressed(), pressed.at(i));
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
QCOMPARE(mouseArea->pressedButtons(), pressedButtons.at(i));
}
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(pressedSpy.size(), 2);
QCOMPARE(pressedButtonsSpy.size(), changeCount);
pressed and pressedButtons don't work when multiple buttons are pressed The pressed property would react to any mouse event, regardless of whether it was in acceptedButtons, or there were other buttons still pressed. It will now remain true while any button in acceptedButtons is pressed. The pressedButtons property could contain buttons not in the acceptedButtons mask. It will now only contain buttons that are in the acceptedButtons mask. Task-number: QTBUG-26458 Change-Id: I6b25cc36a58c113de062d530761dc179d7ef4a5a Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-07-10 06:40:06 +00:00
}
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
void tst_QQuickMouseArea::changeAxis()
{
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("changeAxis.qml")));
QQuickMouseArea *mouseRegion = window.rootObject()->findChild<QQuickMouseArea*>("mouseregion");
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
QQuickDrag *drag = mouseRegion->drag();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseRegion != nullptr);
QVERIFY(drag != nullptr);
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
mouseRegion->setAcceptedButtons(Qt::LeftButton);
// target
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickItem *blackRect = window.rootObject()->findChild<QQuickItem*>("blackrect");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(blackRect != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(blackRect, drag->target());
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
QVERIFY(!drag->active());
// Start a diagonal drag
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
QPoint p = QPoint(100, 100);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
QVERIFY(!drag->active());
QCOMPARE(blackRect->x(), 50.0);
QCOMPARE(blackRect->y(), 50.0);
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p += QPoint(startDragDistance() + 1, startDragDistance() + 1);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, p);
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p += QPoint(11, 11);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, p);
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
QTRY_VERIFY(drag->active());
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
QTRY_COMPARE(blackRect->x(), 61.0);
Smooth dragging an item with MouseArea. Calculate drag distance relative to the mouse position when a drag is detected rather than the press position so there isn't a large change in position on the first move. Task-number: QTBUG-30188 Change-Id: I5c2269c2228668a3842e18f65167637497b3beb4 Reviewed-by: Joona Petrell <joona.petrell@jollamobile.com>
2013-03-14 02:36:20 +00:00
QCOMPARE(blackRect->y(), 61.0);
Add a hidden XandYAxis enum value For Qt 5 XandYAxis is being renamed to XAndYAxis to more consistently follow capitalization rules. Add an undocumented XandYAxis variable to ease porting. Change-Id: Id9e41dd5578373f5f557937da889a9326ff12e53 Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2012-03-01 10:09:52 +00:00
QCOMPARE(drag->axis(), QQuickDrag::XAndYAxis);
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
/* When blackRect.x becomes bigger than 75, the drag axis is changed to
* Drag.YAxis by the QML code. Verify that this happens, and that the drag
* movement is effectively constrained to the Y axis. */
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p += QPoint(22, 22);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, p);
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
QTRY_COMPARE(blackRect->x(), 83.0);
QTRY_COMPARE(blackRect->y(), 83.0);
QTRY_COMPARE(drag->axis(), QQuickDrag::YAxis);
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p += QPoint(11, 11);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, p);
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
QTRY_COMPARE(blackRect->y(), 94.0);
QCOMPARE(blackRect->x(), 83.0);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, p);
MouseArea: use current value of drag.axis If the drag.axis is changed while a drag operation is in progress, put it into action immediately. This allows, for example, start a dragging operation out of an item in a scrollable ListView to anywhere on the screen. See the linked bug number for an example. Task-number: QTBUG-26440 Change-Id: Id4219d44d1066dd962319086ac1f2a2a75bb2525 Reviewed-by: Damian Jansen <damian.jansen@nokia.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-05 14:10:34 +00:00
QTRY_VERIFY(!drag->active());
QCOMPARE(blackRect->x(), 83.0);
QCOMPARE(blackRect->y(), 94.0);
}
Get rid of most QT_NO_FOO usages Instead use QT_CONFIG(foo). This change actually detected a few mis-spelled macros and invalid usages. Change-Id: I06ac327098dd1a458e6bc379d637b8e2dac52f85 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2016-11-16 13:22:36 +00:00
#if QT_CONFIG(cursor)
Fix resolution of cursor when items are overlapping. If MouseArea with cursorShapes are overlapping then cursor shape of the foremost item under the mouse cursor should be shown, but because the hover events are delivered to the foremost items first the opposite is occuring. This makes QQuickWindow responsible for correctly setting its own cursor instead of relying on items to work it out amongst themselves. Change-Id: Iedf144c583dfa3d1ff441e19db9601b5e171902a Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-25 04:04:47 +00:00
void tst_QQuickMouseArea::cursorShape()
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.setData("import QtQuick 2.0\n MouseArea {}", QUrl());
QScopedPointer<QObject> object(component.create());
QQuickMouseArea *mouseArea = qobject_cast<QQuickMouseArea *>(object.data());
QVERIFY(mouseArea);
QSignalSpy spy(mouseArea, SIGNAL(cursorShapeChanged()));
QCOMPARE(mouseArea->cursorShape(), Qt::ArrowCursor);
QCOMPARE(mouseArea->cursor().shape(), Qt::ArrowCursor);
mouseArea->setCursorShape(Qt::IBeamCursor);
QCOMPARE(mouseArea->cursorShape(), Qt::IBeamCursor);
QCOMPARE(mouseArea->cursor().shape(), Qt::IBeamCursor);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(spy.size(), 1);
Fix resolution of cursor when items are overlapping. If MouseArea with cursorShapes are overlapping then cursor shape of the foremost item under the mouse cursor should be shown, but because the hover events are delivered to the foremost items first the opposite is occuring. This makes QQuickWindow responsible for correctly setting its own cursor instead of relying on items to work it out amongst themselves. Change-Id: Iedf144c583dfa3d1ff441e19db9601b5e171902a Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-25 04:04:47 +00:00
mouseArea->setCursorShape(Qt::IBeamCursor);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(spy.size(), 1);
Fix resolution of cursor when items are overlapping. If MouseArea with cursorShapes are overlapping then cursor shape of the foremost item under the mouse cursor should be shown, but because the hover events are delivered to the foremost items first the opposite is occuring. This makes QQuickWindow responsible for correctly setting its own cursor instead of relying on items to work it out amongst themselves. Change-Id: Iedf144c583dfa3d1ff441e19db9601b5e171902a Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-25 04:04:47 +00:00
mouseArea->setCursorShape(Qt::WaitCursor);
QCOMPARE(mouseArea->cursorShape(), Qt::WaitCursor);
QCOMPARE(mouseArea->cursor().shape(), Qt::WaitCursor);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(spy.size(), 2);
Fix resolution of cursor when items are overlapping. If MouseArea with cursorShapes are overlapping then cursor shape of the foremost item under the mouse cursor should be shown, but because the hover events are delivered to the foremost items first the opposite is occuring. This makes QQuickWindow responsible for correctly setting its own cursor instead of relying on items to work it out amongst themselves. Change-Id: Iedf144c583dfa3d1ff441e19db9601b5e171902a Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-07-25 04:04:47 +00:00
}
#endif
A MouseArea should not receive move or release events if the press was not accepted. Change-Id: If70650d7150b224f4460697a953611dd37d57af1 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-02-13 04:19:10 +00:00
void tst_QQuickMouseArea::moveAndReleaseWithoutPress()
{
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("moveAndReleaseWithoutPress.qml")));
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QObject *root = window.rootObject();
A MouseArea should not receive move or release events if the press was not accepted. Change-Id: If70650d7150b224f4460697a953611dd37d57af1 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-02-13 04:19:10 +00:00
QVERIFY(root);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
A MouseArea should not receive move or release events if the press was not accepted. Change-Id: If70650d7150b224f4460697a953611dd37d57af1 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-02-13 04:19:10 +00:00
Add explanation to tst_QQuickMouseArea::moveAndReleaseWithoutPress The test makes sure that no events are delivered after the initial press is released. In this context QTRY_* makes little sense, since we are confirming that the defaults have not changed. Thus rather spin the event loop 11 times and hope that if we would accidentally deliver events that we shouldn't, it will be caught in that time. Change-Id: Iadeed07a81978aa6679e5513c1fe0aebcaeeb997 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-08 08:57:25 +00:00
// the press was not accepted, make sure there is no move or release event
Stabilize tst_qquickmousearea. Replace createView() by initView(), instantiate windows on stack or use QScopedPointer. Center view in available geometry and make sure the mouse cursor is outside, since otherwise it can interfere with drag->active(). Remove insignification introduced by c1fbee270f50c44f47d4eb287765ad60f362c87a . Task-number: QTBUG-33006 Change-Id: I8fc661444bc42899dfa3d87887c594270483e508 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-08-23 08:38:08 +00:00
QTest::mouseMove(&window, QPoint(110,110), 50);
Add explanation to tst_QQuickMouseArea::moveAndReleaseWithoutPress The test makes sure that no events are delivered after the initial press is released. In this context QTRY_* makes little sense, since we are confirming that the defaults have not changed. Thus rather spin the event loop 11 times and hope that if we would accidentally deliver events that we shouldn't, it will be caught in that time. Change-Id: Iadeed07a81978aa6679e5513c1fe0aebcaeeb997 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-08 08:57:25 +00:00
// use qwait here because we want to make sure an event does NOT happen
// the test fails if the default state changes, while it shouldn't
QTest::qWait(100);
QCOMPARE(root->property("hadMove").toBool(), false);
A MouseArea should not receive move or release events if the press was not accepted. Change-Id: If70650d7150b224f4460697a953611dd37d57af1 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-02-13 04:19:10 +00:00
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(110,110));
Add explanation to tst_QQuickMouseArea::moveAndReleaseWithoutPress The test makes sure that no events are delivered after the initial press is released. In this context QTRY_* makes little sense, since we are confirming that the defaults have not changed. Thus rather spin the event loop 11 times and hope that if we would accidentally deliver events that we shouldn't, it will be caught in that time. Change-Id: Iadeed07a81978aa6679e5513c1fe0aebcaeeb997 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-08 08:57:25 +00:00
QTest::qWait(100);
QCOMPARE(root->property("hadRelease").toBool(), false);
A MouseArea should not receive move or release events if the press was not accepted. Change-Id: If70650d7150b224f4460697a953611dd37d57af1 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
2013-02-13 04:19:10 +00:00
}
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
void tst_QQuickMouseArea::nestedStopAtBounds_data()
{
QTest::addColumn<bool>("transpose");
QTest::addColumn<bool>("invert");
QTest::newRow("left") << false << false;
QTest::newRow("right") << false << true;
QTest::newRow("top") << true << false;
QTest::newRow("bottom") << true << true;
}
void tst_QQuickMouseArea::nestedStopAtBounds()
{
QFETCH(bool, transpose);
QFETCH(bool, invert);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("nestedStopAtBounds.qml")));
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickMouseArea *outer = window.rootObject()->findChild<QQuickMouseArea*>("outer");
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
QVERIFY(outer);
QQuickMouseArea *inner = outer->findChild<QQuickMouseArea*>("inner");
QVERIFY(inner);
inner->drag()->setAxis(transpose ? QQuickDrag::YAxis : QQuickDrag::XAxis);
inner->setX(invert ? 100 : 0);
inner->setY(invert ? 100 : 0);
const int threshold = qApp->styleHints()->startDragDistance();
QPoint position(200, 200);
int &axis = transpose ? position.ry() : position.rx();
// drag toward the aligned boundary. Outer mouse area dragged.
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, position);
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
QTest::qWait(10);
axis += invert ? threshold * 2 : -threshold * 2;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
axis += invert ? threshold : -threshold;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Skip nestedStopAtBounds when stolen focus cannot be re-gained The test has been blacklisted on openSUSE Leap due to flakiness. The flakiness results from system tray messages popping up, stealing focus from test widgets and interfering with mouse emulation. This patch adds functionality that tries to regain focus in case of an interference. The test will time out, if that attempt fails. Fixes: QTBUG-78153 Change-Id: Ifcab3990166bdf6b6fbc8a8cd4554b22130336c2 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-10-18 08:48:22 +00:00
// outer drag will not receive mouse event, when the focus has been stolen.
// => try to regain and time out if it fails.
while (!QTest::qWaitFor([&outer]() { return outer->drag()->active(); }))
window.raise();
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
QCOMPARE(inner->drag()->active(), false);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, position);
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
QVERIFY(!outer->drag()->active());
axis = 200;
outer->setX(50);
outer->setY(50);
// drag away from the aligned boundary. Inner mouse area dragged.
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, position);
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
QTest::qWait(10);
axis += invert ? -threshold * 2 : threshold * 2;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
axis += invert ? -threshold : threshold;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Dragging MouseArea nested in Flickable does not work with touch to mouse A MouseArea with a drag target nested in a Flickable does not work. This is due to QQuickWindow calling childMouseEventFilter() twice - once in sendFilteredTouchEvent() and later in sendEvent(). Since childMouseEventFilter() has already been called, deliver the mouse event directly in sendFilteredTouchEvent(). Task-number: QTBUG-32920 Change-Id: I22acee3c66ee6c06e71c9c876fb02dbcb6119a8d Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2013-08-12 03:28:17 +00:00
QTRY_COMPARE(outer->drag()->active(), false);
QTRY_COMPARE(inner->drag()->active(), true);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, position);
MouseArea shouldn't grab the mouse until there is an effective drag. A MouseArea shouldn't prevent a parent MouseArea or Flickable from handling a drag event unless it is going to do something useful with it. Task-number: 29717 Change-Id: I24016994f6cf9116382ef7faeb50b10e5716e10e Reviewed-by: Alan Alpert <aalpert@rim.com>
2013-02-15 11:29:32 +00:00
}
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
void tst_QQuickMouseArea::nestedFlickableStopAtBounds()
{
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("nestedFlickableStopAtBounds.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea*>("mouseArea");
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QVERIFY(mouseArea);
QQuickFlickable *flickable = mouseArea->findChild<QQuickFlickable*>("flickable");
QVERIFY(flickable);
const int threshold = qApp->styleHints()->startDragDistance();
QPoint position(200, 280);
int &pos = position.ry();
// Drag up - should move the Flickable to end
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos -= threshold * 2;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
pos -= threshold * 2;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos -= 150;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QVERIFY(flickable->isDragging());
QVERIFY(!mouseArea->drag()->active());
QCOMPARE(flickable->isAtYEnd(), true);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTRY_VERIFY(!flickable->isMoving());
pos = 280;
// Drag up again - should activate MouseArea drag
QVERIFY(!mouseArea->drag()->active());
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos -= threshold * 2;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
pos -= threshold * 2;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos -= 20;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QVERIFY(mouseArea->drag()->active());
QCOMPARE(flickable->isAtYEnd(), true);
QVERIFY(!flickable->isDragging());
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
// Drag to the top and verify that the MouseArea doesn't steal the grab when we drag back (QTBUG-56036)
pos = 50;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos += threshold;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
pos += threshold;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos += 150;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QVERIFY(flickable->isDragging());
QVERIFY(!mouseArea->drag()->active());
QCOMPARE(flickable->isAtYBeginning(), true);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTRY_VERIFY(!flickable->isMoving());
pos = 280;
// Drag up again - should not activate MouseArea drag
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos -= threshold;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
pos -= threshold;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QTest::qWait(10);
pos -= 100;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseMove(&window, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
QVERIFY(flickable->isDragging());
QVERIFY(!mouseArea->drag()->active());
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, position);
Fix MouseArea sticky grab with drag.filterChildren enabled Task-number: QTBUG-56036 Change-Id: Iad776f42cc776e0d397173b3d2f3922eb7914392 Reviewed-by: Andrew den Exter <andrew.den.exter@qinetic.com.au>
2016-09-16 07:32:58 +00:00
}
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
void tst_QQuickMouseArea::containsPress_data()
{
QTest::addColumn<bool>("hoverEnabled");
QTest::newRow("hover enabled") << true;
QTest::newRow("hover disaabled") << false;
}
void tst_QQuickMouseArea::containsPress()
{
QFETCH(bool, hoverEnabled);
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("containsPress.qml")));
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea*>("mouseArea");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseArea != nullptr);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QSignalSpy containsPressSpy(mouseArea, SIGNAL(containsPressChanged()));
mouseArea->setHoverEnabled(hoverEnabled);
QTest::mouseMove(&window, QPoint(22,33));
QCOMPARE(mouseArea->hovered(), false);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QCOMPARE(mouseArea->isPressed(), false);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QCOMPARE(mouseArea->containsPress(), false);
QTest::mouseMove(&window, QPoint(200,200));
QCOMPARE(mouseArea->hovered(), hoverEnabled);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QCOMPARE(mouseArea->isPressed(), false);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QCOMPARE(mouseArea->containsPress(), false);
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(200,200));
QCOMPARE(mouseArea->hovered(), true);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(mouseArea->isPressed(), true);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QCOMPARE(mouseArea->containsPress(), true);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(containsPressSpy.size(), 1);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QTest::mouseMove(&window, QPoint(22,33));
QCOMPARE(mouseArea->hovered(), false);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QCOMPARE(mouseArea->isPressed(), true);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QCOMPARE(mouseArea->containsPress(), false);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(containsPressSpy.size(), 2);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QTest::mouseMove(&window, QPoint(200,200));
QCOMPARE(mouseArea->hovered(), true);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QCOMPARE(mouseArea->isPressed(), true);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QCOMPARE(mouseArea->containsPress(), true);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(containsPressSpy.size(), 3);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(200,200));
QCOMPARE(mouseArea->hovered(), hoverEnabled);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QCOMPARE(mouseArea->isPressed(), false);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
QCOMPARE(mouseArea->containsPress(), false);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(containsPressSpy.size(), 4);
Add containsPress property to MouseArea It is very common to use pressed and containsMouse properties together to highlight a pressed item, e.g. property bool highlighted: pressed && containsMouse The containsPress property allows simplification and optimization of user code. [ChangeLog][QtQuick] Add containsPress property to MouseArea Task-number: QTBUG-40130 Change-Id: Ie286d431154eb37a99e57e4cf881d68d7cbbe31d Reviewed-by: Martin Jones <martin.jones@jollamobile.com>
2014-07-11 04:10:49 +00:00
}
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
void tst_QQuickMouseArea::ignoreBySource()
{
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("ignoreBySource.qml")));
auto mouseDevPriv = QPointingDevicePrivate::get(QPointingDevice::primaryPointingDevice());
auto touchDevPriv = QPointingDevicePrivate::get(device);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QQuickItem *root = qobject_cast<QQuickItem*>(window.rootObject());
QVERIFY(root);
QQuickMouseArea *mouseArea = root->findChild<QQuickMouseArea*>("mousearea");
QVERIFY(mouseArea);
QQuickFlickable *flickable = root->findChild<QQuickFlickable*>("flickable");
QVERIFY(flickable);
// MouseArea should grab the press because it's interested in non-synthesized mouse events
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
QPoint p = QPoint(80, 80);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(mouseDevPriv->firstPointExclusiveGrabber(), mouseArea);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
// That was a real mouse event
Prefer QCOMPARE over QVERIFY Change-Id: Id57e576653cd66d1b36685737ba477c8b3ff6258 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2016-07-28 16:26:54 +00:00
QCOMPARE(root->property("lastEventSource").toInt(), int(Qt::MouseEventNotSynthesized));
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
// Flickable content should not move
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p -= QPoint(startDragDistance() + 1, startDragDistance() + 1);
QTest::mouseMove(&window, p);
p -= QPoint(11, 11);
QTest::mouseMove(&window, p);
p -= QPoint(11, 11);
QTest::mouseMove(&window, p);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QCOMPARE(flickable->contentX(), 0.);
QCOMPARE(flickable->contentY(), 0.);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, p);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(mouseDevPriv->firstPointExclusiveGrabber(), nullptr);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
// Now try touch events and confirm that MouseArea ignores them, while Flickable does its thing
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p = QPoint(80, 80);
QTest::touchEvent(&window, device).press(0, p, &window);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QQuickTouchUtils::flush(&window);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(touchDevPriv->firstPointExclusiveGrabber(), flickable);
Prefer QCOMPARE over QVERIFY Change-Id: Id57e576653cd66d1b36685737ba477c8b3ff6258 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2016-07-28 16:26:54 +00:00
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
// That was a fake mouse event
QCOMPARE(root->property("lastEventSource").toInt(), int(Qt::MouseEventSynthesizedByQt));
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p -= QPoint(startDragDistance() + 1, startDragDistance() + 1);
QTest::touchEvent(&window, device).move(0, p, &window);
p -= QPoint(11, 11);
QTest::touchEvent(&window, device).move(0, p, &window);
p -= QPoint(11, 11);
QTest::touchEvent(&window, device).move(0, p, &window);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QQuickTouchUtils::flush(&window);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(touchDevPriv->firstPointExclusiveGrabber(), flickable);
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
QTest::touchEvent(&window, device).release(0, p, &window);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QQuickTouchUtils::flush(&window);
// Flickable content should have moved
QTRY_VERIFY(flickable->contentX() > 1);
QVERIFY(flickable->contentY() > 1);
// Now tell the MouseArea to accept only synthesized events, and repeat the tests
root->setProperty("allowedSource", Qt::MouseEventSynthesizedByQt);
flickable->setContentX(0);
flickable->setContentY(0);
// MouseArea should ignore the press because it's interested in synthesized mouse events
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p = QPoint(80, 80);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, p);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(mouseDevPriv->firstPointExclusiveGrabber() != mouseArea);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
// That was a real mouse event
QVERIFY(root->property("lastEventSource").toInt() == Qt::MouseEventNotSynthesized);
// Flickable content should move
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p -= QPoint(startDragDistance() + 1, startDragDistance() + 1);
QTest::mouseMove(&window, p);
p -= QPoint(11, 11);
QTest::mouseMove(&window, p);
p -= QPoint(11, 11);
QTest::mouseMove(&window, p);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QTRY_VERIFY(flickable->contentX() > 1);
QVERIFY(flickable->contentY() > 1);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(47, 47));
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
flickable->setContentX(0);
flickable->setContentY(0);
// Now try touch events and confirm that MouseArea gets them, while Flickable doesn't
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p = QPoint(80, 80);
QTest::touchEvent(&window, device).press(0, p, &window);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QQuickTouchUtils::flush(&window);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(touchDevPriv->firstPointExclusiveGrabber(), mouseArea);
Fix tests in tst_QQuickMouseArea for big startDragDistance Change-Id: I8610887e7d1d3b0c6bd9ab60e55ce1e9209bcae7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-07-02 12:16:34 +00:00
p -= QPoint(startDragDistance() + 1, startDragDistance() + 1);
QTest::touchEvent(&window, device).move(0, p, &window);
p -= QPoint(11, 11);
QTest::touchEvent(&window, device).move(0, p, &window);
p -= QPoint(11, 11);
QTest::touchEvent(&window, device).move(0, p, &window);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QQuickTouchUtils::flush(&window);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(touchDevPriv->firstPointExclusiveGrabber(), mouseArea);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
QTest::touchEvent(&window, device).release(0, QPoint(47,47), &window);
QQuickTouchUtils::flush(&window);
// Flickable content should not have moved
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QCOMPARE(flickable->contentX(), 0);
QCOMPARE(flickable->contentY(), 0);
MouseArea: add source property to mouse event It comes from the source() of the QMouseEvent which triggered it. This makes it possible to distinguish real mouse events from those that are synthesized from touch or tablet. And for this we need to import QtQuick 2.7 [ChangeLog][QtQuick][MouseArea] Added mouse.source property to enable distinguishing genuine mouse events from those that are synthesized from touch or tablet events. Change-Id: I568964f63981703bd23e05daac5288518f09d837 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
2016-03-04 10:02:54 +00:00
}
Fix tst_QQuickMouseArea::notPressedAfterStolenGrab again Most of the time, QQuickWindowPrivate::deliverMatchingPointsToItem() doesn't need to call item->mouseUngrabEvent() because all grab changes are notified via the connection from signal QPointingDevice::grabChanged to slot QQuickWindowPrivate::onGrabChanged(). But in this case, MouseArea only accepts the event, rather than taking the grab itself. Therefore at the time the grab is "stolen", there was not yet any grabber, because grabbing is done after delivery. But we still need to inform MouseArea that it's not getting the grab it expects to get, so that it can reset its pressed state. But we don't want it to be redundant (other tests are counting events, and we don't want repeated ungrabs to show up in those); so now we have to track whether the item on which we're about to call mouseUngrabEvent() has already gotten it. This illustrates another problem with the tradition of accepting events and being unclear about what it means. Grabbing is one thing, ending delivery is another. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Task-number: QTBUG-55325 Task-number: QTBUG-86729 Change-Id: I8150f901e00e7a71499fc98ab54f0ba75370f3ec Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 15:29:20 +00:00
void tst_QQuickMouseArea::notPressedAfterStolenGrab() // QTBUG-55325
Fix mouse area pressed after removal of pre-grab Qt Quick used to actively "grab" the mouse before delivering events, making the code more complex than necessary. Some items came to rely on the behavior and now lack the ungrab event. This is triggered when inside the delivery of a mouse event, some other item grabs the mouse. If the mouse grab changed to an item that was not the target of the original delivery, the grab must have been stolen, so call mouseUngrabEvent in this case. Test case by J-P Nurmi. Task-number: QTBUG-55325 Change-Id: I2f0ac9d8aed1415662196070fb763f2752004d22 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-08-24 10:40:23 +00:00
{
QQuickWindow window;
window.resize(200, 200);
window.show();
tests: Wrap qWaitForWindow{Active,Exposed} in QVERIFY The functions are marked Q_REQUIRED_RESULT, so they give compilation warnings when not handling the bool return value. Failing the test early at an unexpected event is also better behavior anyway. Task-number: QTBUG-66559 Change-Id: I6c4db29379ec01528208c3e4ee54346b4230616c Reviewed-by: Sami Nurmenniemi <sami.nurmenniemi@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-21 08:16:14 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&window));
Fix mouse area pressed after removal of pre-grab Qt Quick used to actively "grab" the mouse before delivering events, making the code more complex than necessary. Some items came to rely on the behavior and now lack the ungrab event. This is triggered when inside the delivery of a mouse event, some other item grabs the mouse. If the mouse grab changed to an item that was not the target of the original delivery, the grab must have been stolen, so call mouseUngrabEvent in this case. Test case by J-P Nurmi. Task-number: QTBUG-55325 Change-Id: I2f0ac9d8aed1415662196070fb763f2752004d22 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-08-24 10:40:23 +00:00
QQuickMouseArea *ma = new QQuickMouseArea(window.contentItem());
ma->setSize(window.size());
QObject::connect(ma,
static_cast<void (QQuickMouseArea::*)(QQuickMouseEvent*)>(&QQuickMouseArea::pressed),
Fix tst_QQuickMouseArea::notPressedAfterStolenGrab again Most of the time, QQuickWindowPrivate::deliverMatchingPointsToItem() doesn't need to call item->mouseUngrabEvent() because all grab changes are notified via the connection from signal QPointingDevice::grabChanged to slot QQuickWindowPrivate::onGrabChanged(). But in this case, MouseArea only accepts the event, rather than taking the grab itself. Therefore at the time the grab is "stolen", there was not yet any grabber, because grabbing is done after delivery. But we still need to inform MouseArea that it's not getting the grab it expects to get, so that it can reset its pressed state. But we don't want it to be redundant (other tests are counting events, and we don't want repeated ungrabs to show up in those); so now we have to track whether the item on which we're about to call mouseUngrabEvent() has already gotten it. This illustrates another problem with the tradition of accepting events and being unclear about what it means. Grabbing is one thing, ending delivery is another. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Task-number: QTBUG-55325 Task-number: QTBUG-86729 Change-Id: I8150f901e00e7a71499fc98ab54f0ba75370f3ec Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 15:29:20 +00:00
[&]() { qCDebug(lcTests) << "stealing grab now"; window.contentItem()->grabMouse(); });
Fix mouse area pressed after removal of pre-grab Qt Quick used to actively "grab" the mouse before delivering events, making the code more complex than necessary. Some items came to rely on the behavior and now lack the ungrab event. This is triggered when inside the delivery of a mouse event, some other item grabs the mouse. If the mouse grab changed to an item that was not the target of the original delivery, the grab must have been stolen, so call mouseUngrabEvent in this case. Test case by J-P Nurmi. Task-number: QTBUG-55325 Change-Id: I2f0ac9d8aed1415662196070fb763f2752004d22 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-08-24 10:40:23 +00:00
QTest::mouseClick(&window, Qt::LeftButton);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QVERIFY(!ma->isPressed());
Fix mouse area pressed after removal of pre-grab Qt Quick used to actively "grab" the mouse before delivering events, making the code more complex than necessary. Some items came to rely on the behavior and now lack the ungrab event. This is triggered when inside the delivery of a mouse event, some other item grabs the mouse. If the mouse grab changed to an item that was not the target of the original delivery, the grab must have been stolen, so call mouseUngrabEvent in this case. Test case by J-P Nurmi. Task-number: QTBUG-55325 Change-Id: I2f0ac9d8aed1415662196070fb763f2752004d22 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-08-24 10:40:23 +00:00
}
Add pressAndHoldInterval to MouseArea Introduce pressAndHoldInterval to allow setting the pressAndHold delay per-MouseArea. [ChangeLog][QtQml][MouseArea] Introduce pressAndHoldInterval property, which controls the elapsed time before pressAndHold is emitted. Task-Id: QTBUG-47662 Change-Id: Ic2173335033a6ed0d4b652333020f030de63a8e7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2016-12-07 17:57:03 +00:00
void tst_QQuickMouseArea::pressAndHold_data()
{
QTest::addColumn<int>("pressAndHoldInterval");
QTest::addColumn<int>("waitTime");
QTest::newRow("default") << -1 << QGuiApplication::styleHints()->mousePressAndHoldInterval();
QTest::newRow("short") << 500 << 500;
QTest::newRow("long") << 1000 << 1000;
}
void tst_QQuickMouseArea::pressAndHold()
{
QFETCH(int, pressAndHoldInterval);
QFETCH(int, waitTime);
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("pressAndHold.qml")));
Add pressAndHoldInterval to MouseArea Introduce pressAndHoldInterval to allow setting the pressAndHold delay per-MouseArea. [ChangeLog][QtQml][MouseArea] Introduce pressAndHoldInterval property, which controls the elapsed time before pressAndHold is emitted. Task-Id: QTBUG-47662 Change-Id: Ic2173335033a6ed0d4b652333020f030de63a8e7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2016-12-07 17:57:03 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
Add pressAndHoldInterval to MouseArea Introduce pressAndHoldInterval to allow setting the pressAndHold delay per-MouseArea. [ChangeLog][QtQml][MouseArea] Introduce pressAndHoldInterval property, which controls the elapsed time before pressAndHold is emitted. Task-Id: QTBUG-47662 Change-Id: Ic2173335033a6ed0d4b652333020f030de63a8e7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2016-12-07 17:57:03 +00:00
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea*>("mouseArea");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(mouseArea != nullptr);
Add pressAndHoldInterval to MouseArea Introduce pressAndHoldInterval to allow setting the pressAndHold delay per-MouseArea. [ChangeLog][QtQml][MouseArea] Introduce pressAndHoldInterval property, which controls the elapsed time before pressAndHold is emitted. Task-Id: QTBUG-47662 Change-Id: Ic2173335033a6ed0d4b652333020f030de63a8e7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2016-12-07 17:57:03 +00:00
QSignalSpy pressAndHoldSpy(mouseArea, &QQuickMouseArea::pressAndHold);
if (pressAndHoldInterval > -1)
mouseArea->setPressAndHoldInterval(pressAndHoldInterval);
else
mouseArea->resetPressAndHoldInterval();
QElapsedTimer t;
t.start();
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(50, 50));
QVERIFY(pressAndHoldSpy.wait());
// should be off by no more than 20% of waitTime
QVERIFY(qAbs(t.elapsed() - waitTime) < (waitTime * 0.2));
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(50, 50));
}
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
void tst_QQuickMouseArea::pressOneAndTapAnother_data()
{
QTest::addColumn<bool>("pressMouseFirst");
QTest::addColumn<bool>("releaseMouseFirst");
QTest::newRow("press mouse, tap touch, release mouse") << true << false; // QTBUG-64249 as written
QTest::newRow("press touch, press mouse, release touch, release mouse") << false << false;
QTest::newRow("press mouse, press touch, release mouse, release touch") << true << true;
Merge remote-tracking branch 'origin/5.9' into 5.10 Conflicts: src/qml/memory/qv4mm.cpp src/qml/memory/qv4mmdefs_p.h src/quick/items/qquickwindow.cpp src/quick/items/qquickwindow_p.h tests/auto/qml/debugger/qqmlprofilerservice/qqmlprofilerservice.pro tests/auto/qml/debugger/qqmlprofilerservice/tst_qqmlprofilerservice.cpp Change-Id: I7021fa1edf076627a67048f41f7b201220262b09
2017-12-12 09:35:21 +00:00
// TODO fix in a separate patch after the 5.9->5.10 merge
// QTest::newRow("press touch, click mouse, release touch") << false << true;
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
}
void tst_QQuickMouseArea::pressOneAndTapAnother()
{
QFETCH(bool, pressMouseFirst);
QFETCH(bool, releaseMouseFirst);
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("twoMouseAreas.qml")));
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
QQuickItem *root = window.rootObject();
QVERIFY(root);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickMouseArea *bottomMA = root->findChild<QQuickMouseArea*>("bottom");
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
QVERIFY(bottomMA);
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QQuickMouseArea *topMA = root->findChild<QQuickMouseArea*>("top");
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
QVERIFY(topMA);
QPoint upper(32, 32);
QPoint lower(32, window.height() - 32);
// press them both
if (pressMouseFirst) {
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, lower);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(bottomMA->isPressed(), true);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
QTest::touchEvent(&window, device).press(0, lower, &window);
QQuickTouchUtils::flush(&window);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(bottomMA->isPressed(), true);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
} else {
QTest::touchEvent(&window, device).press(0, lower, &window);
QQuickTouchUtils::flush(&window);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(bottomMA->isPressed(), true);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, lower);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(bottomMA->isPressed(), true);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
}
// release them both and make sure neither one gets stuck
if (releaseMouseFirst) {
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, lower);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(bottomMA->isPressed(), false);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
QTest::touchEvent(&window, device).release(0, upper, &window);
QQuickTouchUtils::flush(&window);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(topMA->isPressed(), false);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
} else {
QTest::touchEvent(&window, device).release(0, upper, &window);
QQuickTouchUtils::flush(&window);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(topMA->isPressed(), false);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, lower);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(bottomMA->isPressed(), false);
grabMouse() and QQWPriv::removeGrabber(): be clear whether mouse or touch The bug was that a MouseArea could be stuck in pressed state if a touch tap occurred simultaneously on a second MouseArea while the first was held pressed by the actual mouse. QQuickWindowPrivate::setMouseGrabber(QQuickItem *) had too little information to make the right choice in case the given item argument is null. It should not mean ungrab everything: in this use case, the mouse and the touchpoint can be pressing two different MouseAreas, and releasing either one should ungrab only the MouseArea that is being released. However the only place it was called with nullptr was in removeGrabber(), and in that context we are given all the information: which item to ungrab and whether we want to ungrab mouse, touch or both. It's better to have a little code duplication between QQuickItem::grabMouse() and QQuickWindowPrivate::removeGrabber() than to lose this information about which device(s) and Item to ungrab. Task-number: QTBUG-64249 Change-Id: I0710534a05f3ceeb66105a03ab0f32a61df8a522 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 13:12:17 +00:00
}
}
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
void tst_QQuickMouseArea::mask()
{
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("mask.qml")));
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
// click inside the mask, and verify it registers
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100,100));
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
QCOMPARE(window.rootObject()->property("pressed").toInt(), 1);
QCOMPARE(window.rootObject()->property("released").toInt(), 1);
QCOMPARE(window.rootObject()->property("clicked").toInt(), 1);
// click outside the mask (but inside the MouseArea), and verify it doesn't register
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(10,10));
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, QPoint(10,10));
Support masking of QQuickItems Adding a new property, containsMask, to QQuickItem, that can be set to any QObject defining a Q_INVOKABLE bool contains(const QPointF &point). When this property is set, the mask object contains method is used in place of the item own contains method. [ChangeLog][QtQuick][QQuickItem] Added containsMask property. Task-number: QTBUG-20524 Change-Id: I5b0696e2cddc6ae3e217ce149c5f44980fdb69aa Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-09-22 16:46:36 +00:00
QCOMPARE(window.rootObject()->property("pressed").toInt(), 1);
QCOMPARE(window.rootObject()->property("released").toInt(), 1);
QCOMPARE(window.rootObject()->property("clicked").toInt(), 1);
}
Warn, don't crash during nested delivery of mouse or touch presses If during delivery of a mouse press, user code calls qApp->sendEvent() with another mouse press, then when delivery of the nested event is finished, we call QQuickPointerMouseEvent::reset(nullptr). Then when delivery of the original mouse press resumes, crashes are possible because most of the code assumes that QQuickPointerEvent::m_event is not null during delivery. Change-Id: Id65b1f2f64351e40d03bcd4f4d16693d616729da Fixes: QTBUG-70898 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-10-03 15:09:40 +00:00
void tst_QQuickMouseArea::nestedEventDelivery() // QTBUG-70898
{
skip tst_QQuickMouseArea::nestedEventDelivery on macOS It has blocked integrating anything in CI because of crashing, so blacklisting is not enough. Does not crash locally for me on macOS 10.15 Task-number: QTBUG-86729 Change-Id: Iddae9edb09fd7b7fdadd122779832c80d0376b2d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2020-10-02 08:00:23 +00:00
#ifdef Q_OS_MACOS
QSKIP("this test currently crashes on MacOS 10.14 in CI. See QTBUG-86729");
#endif
Warn, don't crash during nested delivery of mouse or touch presses If during delivery of a mouse press, user code calls qApp->sendEvent() with another mouse press, then when delivery of the nested event is finished, we call QQuickPointerMouseEvent::reset(nullptr). Then when delivery of the original mouse press resumes, crashes are possible because most of the code assumes that QQuickPointerEvent::m_event is not null during delivery. Change-Id: Id65b1f2f64351e40d03bcd4f4d16693d616729da Fixes: QTBUG-70898 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-10-03 15:09:40 +00:00
QQmlEngine engine;
QQmlComponent c(&engine, testFileUrl("nestedSendEvent.qml"));
QScopedPointer<QQuickWindow> window(qmlobject_cast<QQuickWindow *>(c.create()));
QVERIFY(window.data());
// Click each MouseArea and verify that it doesn't crash
QTest::mouseClick(window.data(), Qt::LeftButton, Qt::NoModifier, QPoint(50,50));
QTest::mouseClick(window.data(), Qt::LeftButton, Qt::NoModifier, QPoint(50,150));
}
Fix QQuickMouseArea getting stuck in pressed state when hiding in press In 78c1fcbc49f56463064eef738a475d9018357b24 we stopped giving the exclusive grab to hidden or disabled items with is good. But the change did not take into consideration how mouse area handles its internal state. As a simple example: A mouse area that would set itself hiddin in the press handler, would continue to have d->pressed == true, which means it would not react to any future press events. The fix is to let mouse area check in its change handler whether it has become invisible. The test also checks that enabled behaves the same way. There is no action needed, since mouse area does completely custom handling of enabled (maybe something to fix in Qt 6), disabling a mouse area doesn't disable its children for example, it doesn't invoke QQuickItem::setEnabled at all. Due to this circumventing the common behavior, by chance disabling a mouse area in the on pressed handler works. Fixes: QTBUG-74987 Change-Id: Idb8499b3e5bcb744fbba203fdea5c46695bd5077 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2020-03-28 14:14:41 +00:00
void tst_QQuickMouseArea::settingHiddenInPressUngrabs()
{
// When an item sets itself hidden, while handling pressed, it doesn't receive the grab.
// But that in turn means it doesn't see any release events, so we need to make sure it
// receives an ungrab event.
QQmlEngine engine;
QQmlComponent c(&engine, testFileUrl("settingHiddenInPressUngrabs.qml"));
QScopedPointer<QQuickWindow> window(qmlobject_cast<QQuickWindow *>(c.create()));
QVERIFY(window.data());
window->show();
window->requestActivate();
QVERIFY(QTest::qWaitForWindowExposed(window.data()));
QQuickMouseArea *catArea = window->findChild<QQuickMouseArea*>("cat");
QVERIFY(catArea != nullptr);
auto pointOnCatArea = catArea->mapToScene(QPointF(5.0, 5.0)).toPoint();
QTest::mouseClick(window.data(), Qt::LeftButton, Qt::NoModifier, pointOnCatArea);
QCoreApplication::processEvents();
// The click hides the cat area
QTRY_VERIFY(!catArea->isVisible());
// The cat area is not stuck in pressed state.
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QVERIFY(!catArea->isPressed());
Fix QQuickMouseArea getting stuck in pressed state when hiding in press In 78c1fcbc49f56463064eef738a475d9018357b24 we stopped giving the exclusive grab to hidden or disabled items with is good. But the change did not take into consideration how mouse area handles its internal state. As a simple example: A mouse area that would set itself hiddin in the press handler, would continue to have d->pressed == true, which means it would not react to any future press events. The fix is to let mouse area check in its change handler whether it has become invisible. The test also checks that enabled behaves the same way. There is no action needed, since mouse area does completely custom handling of enabled (maybe something to fix in Qt 6), disabling a mouse area doesn't disable its children for example, it doesn't invoke QQuickItem::setEnabled at all. Due to this circumventing the common behavior, by chance disabling a mouse area in the on pressed handler works. Fixes: QTBUG-74987 Change-Id: Idb8499b3e5bcb744fbba203fdea5c46695bd5077 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2020-03-28 14:14:41 +00:00
QQuickMouseArea *mouseArea = window->findChild<QQuickMouseArea*>("mouse");
QVERIFY(mouseArea != nullptr);
auto pointOnMouseArea = mouseArea->mapToScene(QPointF(5.0, 5.0)).toPoint();
QTest::mouseClick(window.data(), Qt::LeftButton, Qt::NoModifier, pointOnMouseArea);
QCoreApplication::processEvents();
// The click disables the mouse area
QTRY_VERIFY(!mouseArea->isEnabled());
// The mouse area is not stuck in pressed state.
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QVERIFY(!mouseArea->isPressed());
Fix QQuickMouseArea getting stuck in pressed state when hiding in press In 78c1fcbc49f56463064eef738a475d9018357b24 we stopped giving the exclusive grab to hidden or disabled items with is good. But the change did not take into consideration how mouse area handles its internal state. As a simple example: A mouse area that would set itself hiddin in the press handler, would continue to have d->pressed == true, which means it would not react to any future press events. The fix is to let mouse area check in its change handler whether it has become invisible. The test also checks that enabled behaves the same way. There is no action needed, since mouse area does completely custom handling of enabled (maybe something to fix in Qt 6), disabling a mouse area doesn't disable its children for example, it doesn't invoke QQuickItem::setEnabled at all. Due to this circumventing the common behavior, by chance disabling a mouse area in the on pressed handler works. Fixes: QTBUG-74987 Change-Id: Idb8499b3e5bcb744fbba203fdea5c46695bd5077 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2020-03-28 14:14:41 +00:00
}
QQuickWindow: Consider z-order of children when delivering pointer events When creating a target item list for handling pointer events, put children after the parent item if they have negative z-order value. This fixes an issue where an item does not receive a pointer event if there is a child item that accepts the event even when that child item is shown under the parent item as per the stacking order. Fixes: QTBUG-83114 Pick-to: 5.15 Change-Id: I711faa22516f5c2396b1138dc507bcaa4ba22241 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-08-16 12:32:22 +00:00
void tst_QQuickMouseArea::negativeZStackingOrder() // QTBUG-83114
{
QQuickView window;
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(QQuickTest::showView(window, testFileUrl("mouseAreasOverlapped.qml")));
QQuickWindow: Consider z-order of children when delivering pointer events When creating a target item list for handling pointer events, put children after the parent item if they have negative z-order value. This fixes an issue where an item does not receive a pointer event if there is a child item that accepts the event even when that child item is shown under the parent item as per the stacking order. Fixes: QTBUG-83114 Pick-to: 5.15 Change-Id: I711faa22516f5c2396b1138dc507bcaa4ba22241 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-08-16 12:32:22 +00:00
QQuickItem *root = window.rootObject();
Clean up and un-blacklist tst_QQuickMouseArea tests - Use QQuickTest::showView() consistently to reduce boilerplate - Use QTest::mouse*() where possible rather than constructing QMouseEvents (and potentially getting them wrong) - Use QPointingDevicePrivate::firstPointExclusiveGrabber() on a specific device to check grab state rather than QQWindow::mouseGrabberItem() - The warning "event went missing during delivery!" has been removed, so tst_QQuickMouseArea::nestedEventDelivery() shouldn't expect it Pick-to: 6.0 Pick-to: 6.0.0 Task-number: QTBUG-86729 Change-Id: Ieb1af38c118dadf8cdf8ae19f92002207d71d5b5 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2020-11-19 16:22:37 +00:00
QVERIFY(root);
QQuickWindow: Consider z-order of children when delivering pointer events When creating a target item list for handling pointer events, put children after the parent item if they have negative z-order value. This fixes an issue where an item does not receive a pointer event if there is a child item that accepts the event even when that child item is shown under the parent item as per the stacking order. Fixes: QTBUG-83114 Pick-to: 5.15 Change-Id: I711faa22516f5c2396b1138dc507bcaa4ba22241 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-08-16 12:32:22 +00:00
QQuickMouseArea *parentMouseArea = root->findChild<QQuickMouseArea*>("parentMouseArea");
QVERIFY(parentMouseArea != nullptr);
QSignalSpy clickSpyParent(parentMouseArea, &QQuickMouseArea::clicked);
QQuickMouseArea *childMouseArea = root->findChild<QQuickMouseArea*>("childMouseArea");
QVERIFY(childMouseArea != nullptr);
QSignalSpy clickSpyChild(childMouseArea, &QQuickMouseArea::clicked);
QTest::mouseClick(&window, Qt::LeftButton, Qt::NoModifier, QPoint(150, 100));
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(clickSpyChild.size(), 1);
QCOMPARE(clickSpyParent.size(), 0);
QQuickWindow: Consider z-order of children when delivering pointer events When creating a target item list for handling pointer events, put children after the parent item if they have negative z-order value. This fixes an issue where an item does not receive a pointer event if there is a child item that accepts the event even when that child item is shown under the parent item as per the stacking order. Fixes: QTBUG-83114 Pick-to: 5.15 Change-Id: I711faa22516f5c2396b1138dc507bcaa4ba22241 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-08-16 12:32:22 +00:00
auto order = root->property("clicks").toList();
QVERIFY(order.at(0) == "childMouseArea");
// Now change stacking order and try again.
childMouseArea->parentItem()->setZ(-1);
root->setProperty("clicks", QVariantList());
QTest::mouseClick(&window, Qt::LeftButton, Qt::NoModifier, QPoint(150, 100));
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(clickSpyChild.size(), 1);
QCOMPARE(clickSpyParent.size(), 1);
QQuickWindow: Consider z-order of children when delivering pointer events When creating a target item list for handling pointer events, put children after the parent item if they have negative z-order value. This fixes an issue where an item does not receive a pointer event if there is a child item that accepts the event even when that child item is shown under the parent item as per the stacking order. Fixes: QTBUG-83114 Pick-to: 5.15 Change-Id: I711faa22516f5c2396b1138dc507bcaa4ba22241 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2019-08-16 12:32:22 +00:00
order = root->property("clicks").toList();
QVERIFY(order.at(0) == "parentMouseArea");
}
MouseArea: fix containsMouse behavior during visibility changes QQuickItem returns whether it contains QGuiApplicationPrivate's lastCursorPosition. Since that position stores the coordinate last seen by Qt (the window border), it will always be within the window, and within an item that covers that part of the window's border. However, QQuickWindow stores the lastMousePosition as well, and resets that value when it receives a QEvent::Leave. We can use that to test whether the window that contains the item has seen a Leave event, in which case the item is definitely not under the mouse. Notes on the test: That we use QPointF() as the "reset" value leave the small possibility that the cursor might be at position 0,0 of the window (ie inside the window), and the QQuickItem there will not be under the mouse. We can't confirm this (through an expected failure test), as QTest::mouseMove interprets a QPoint(0, 0) as "center of the window". And since we can't simulate mouse moves outside a window's boundary using QTest::mouseMove, the test needs to explicitly synthesize a QEvent::Leave for the window. Fixes: QTBUG-87197 Pick-to: 6.1 6.0 5.15 Change-Id: I04870d6e914092275d9d790312fc702fb99f2935 Done-with: Ivan Solovev <ivan.solovev@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2021-02-12 16:11:47 +00:00
// QTBUG-87197
void tst_QQuickMouseArea::containsMouseAndVisibility()
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("containsMouse.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea*>("mouseArea");
QVERIFY(mouseArea != nullptr);
QVERIFY(!mouseArea->isVisible());
QTest::mouseMove(&window, QPoint(10, 10));
QTRY_VERIFY(!mouseArea->hovered());
mouseArea->setVisible(true);
QVERIFY(mouseArea->isVisible());
QTRY_VERIFY(mouseArea->hovered());
/* we (ab-)use QPointF() as the 'reset' value in QQuickWindow's leave-event handling,
but can't verify that this leaves an invalid interpretation of states for position
QPoint(0, 0) as QTest::mouseMove interprets a null-position as "center of the window".
So instead, verify the current (unexpectedly expected) behavior as far as testing is
concern.
*/
QTest::mouseMove(&window, QPoint(0, 0));
QTRY_VERIFY(mouseArea->hovered());
QTRY_VERIFY(mouseArea->isUnderMouse());
// move to the edge (can't move outside)
QTest::mouseMove(&window, QPoint(window.width() - 1, window.height() / 2));
// then pretend we left
QEvent event(QEvent::Leave);
QGuiApplication::sendEvent(&window, &event);
QVERIFY(!mouseArea->hovered());
// toggle mouse area visibility - the hover state should not change
mouseArea->setVisible(false);
QVERIFY(!mouseArea->isVisible());
QVERIFY(!mouseArea->hovered());
mouseArea->setVisible(true);
QVERIFY(mouseArea->isVisible());
QVERIFY(!mouseArea->hovered());
}
Fix masked MouseArea hovered state on visibility change This fixes the issue where given two hoverable MouseAreas A & B where B masks A, the `containsMouse` property of A will be incorrectly set to true if the cursor is positioned above both A and B and the visibility of A is toggled from true to false back to true. This patch fixes the above issue by checking if the QQuickMouseArea is marked as a hovered item in its windows QQuickDeliveryAgentPrivate(QDAP) instance. If the QQuickMouseArea is masked by another QQuickMouseArea then it will not be a in the QDAPs hovered items list and we skip setting the hovered property on QQuickMouseArea, fixing the issue. This patch also adds a test case to prevent future regressions. Fixes: QTBUG-109567 Pick-to: 6.5 6.4 Change-Id: I5f024a097b56ef5e0836ca9f8ae547983a089b44 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-12-21 15:48:07 +00:00
// QTBUG-109567
void tst_QQuickMouseArea::containsMouseAndVisibilityMasked()
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("containsMouseMasked.qml")));
QQuickMouseArea *mouseArea1 = window.rootObject()->findChild<QQuickMouseArea *>("mouseArea1");
QVERIFY(mouseArea1 != nullptr);
QVERIFY(mouseArea1->isVisible());
QQuickMouseArea *mouseArea2 = window.rootObject()->findChild<QQuickMouseArea *>("mouseArea2");
QVERIFY(mouseArea2 != nullptr);
QVERIFY(mouseArea2->isVisible());
QTest::mouseMove(&window, QPoint(window.width() / 2, window.height() / 2));
// Check that mouseArea" (i.e. the masking MouseArea) is the only hovered MouseArea.
QTRY_VERIFY(!mouseArea1->hovered());
QTRY_VERIFY(mouseArea2->hovered());
// Toggle the visibility of the masked MouseArea (mouseArea1).
mouseArea1->setVisible(false);
QVERIFY(!mouseArea1->isVisible());
mouseArea1->setVisible(true);
QVERIFY(mouseArea1->isVisible());
// Check that the masked MouseArea is not now hovered depite being under the mouse after
// changing the visibility to visible. mouseArea2 should be the only hovered MouseArea still.
QTRY_VERIFY(!mouseArea1->hovered());
QTRY_VERIFY(mouseArea2->hovered());
QTest::mouseMove(&window, QPoint(10, 10));
QTRY_VERIFY(mouseArea1->hovered());
QTRY_VERIFY(!mouseArea2->hovered());
// Toggle the visibility of the masked MouseArea (mouseArea1).
mouseArea1->setVisible(false);
QVERIFY(!mouseArea1->isVisible());
mouseArea1->setVisible(true);
QVERIFY(mouseArea1->isVisible());
QTRY_VERIFY(mouseArea1->hovered());
QTRY_VERIFY(!mouseArea2->hovered());
}
Fix mouse inside MouseArea (containsMouse) for press event In MouseArea, containsMouse (mouse inside MouseArea) flag is enabled for press event irrespective of whether its accepted or not. This creates containsMouse to be enabled always for this corresponding item leaving no option to reset. To fix this issue, containsMouse flag is enabled only if the press event is accepted for mouse handler. Fixes: QTBUG-110594 Pick-to: 6.4 6.5 Change-Id: Ibb0e89529ccebc3063330c22b8b3501b2917d78f Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-02-08 08:54:48 +00:00
// QTBUG-110594
void tst_QQuickMouseArea::containsMouseAndHoverDisabled()
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("containsMouseAndHoverDisabled.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>("mouseArea");
QVERIFY(mouseArea != nullptr);
QVERIFY(!mouseArea->hoverEnabled());
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, QPoint(100, 100));
QTRY_VERIFY(!mouseArea->hovered());
}
MouseArea: don't get stuck in doubleClick if handler caused ungrab The bug scenario went like this: 1) QQuickMouseArea::mouseDoubleClickEvent() emits doubleClicked 2) onDoubleClicked in QML hid the MouseArea somehow 3) QQuickMouseArea::ungrabMouse() is called; it sets d->pressed = Qt::NoButton and d->doubleClick = false (and others) 4) eventually we get back to the continuation of mouseDoubleClickEvent() which sets d->doubleClick back to true 5) mouse release: this MouseArea is not involved (no grab anymore) 6) next mouse press: QQuickMouseArea::setPressed() has if (!d->doubleClick) emit pressed(&me); pressed() is not emitted because of leftover state So either we need to avoid setting d->doubleClick to true if d->pressed has been set to Qt::NoButton in QQuickMouseArea::ungrabMouse(); or else we should reorder the statements in mouseDoubleClickEvent() to set d->doubleClick before emitting doubleClicked, so that it will not be overridden after the QML handler is called. This patch takes the first approach. Fixes: QTBUG-35995 Fixes: QTBUG-102158 Pick-to: 6.2 6.3 5.15 Change-Id: Ibe5c9bfbc9c7a70772dd5ebfbc9ce401c6c226d3 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-04-29 13:18:08 +00:00
// QTBUG-35995 and QTBUG-102158
void tst_QQuickMouseArea::doubleClickToHide()
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("doubleClickToHide.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>();
QVERIFY(mouseArea);
QTest::mouseDClick(&window, Qt::LeftButton, Qt::NoModifier, {10, 10});
QCOMPARE(window.rootObject()->property("clicked").toInt(), 1);
QCOMPARE(window.rootObject()->property("doubleClicked").toInt(), 1);
QCOMPARE(mouseArea->isVisible(), false);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QCOMPARE(mouseArea->isPressed(), false);
MouseArea: don't get stuck in doubleClick if handler caused ungrab The bug scenario went like this: 1) QQuickMouseArea::mouseDoubleClickEvent() emits doubleClicked 2) onDoubleClicked in QML hid the MouseArea somehow 3) QQuickMouseArea::ungrabMouse() is called; it sets d->pressed = Qt::NoButton and d->doubleClick = false (and others) 4) eventually we get back to the continuation of mouseDoubleClickEvent() which sets d->doubleClick back to true 5) mouse release: this MouseArea is not involved (no grab anymore) 6) next mouse press: QQuickMouseArea::setPressed() has if (!d->doubleClick) emit pressed(&me); pressed() is not emitted because of leftover state So either we need to avoid setting d->doubleClick to true if d->pressed has been set to Qt::NoButton in QQuickMouseArea::ungrabMouse(); or else we should reorder the statements in mouseDoubleClickEvent() to set d->doubleClick before emitting doubleClicked, so that it will not be overridden after the QML handler is called. This patch takes the first approach. Fixes: QTBUG-35995 Fixes: QTBUG-102158 Pick-to: 6.2 6.3 5.15 Change-Id: Ibe5c9bfbc9c7a70772dd5ebfbc9ce401c6c226d3 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-04-29 13:18:08 +00:00
QCOMPARE(mouseArea->pressedButtons(), Qt::NoButton);
mouseArea->setVisible(true);
QTest::mouseClick(&window, Qt::LeftButton, Qt::NoModifier, {10, 10});
QCOMPARE(window.rootObject()->property("clicked").toInt(), 2);
}
Add MouseArea autotest with second touchpoint while first is held - Touch first finger - Touch and release second finger - Release first finger QQuickMouseArea::pressed() must be emitted only once; QQuickMouseArea::released() must be emitted at the end. Pick-to: 6.3 6.2 Task-number: QTBUG-103766 Change-Id: I849bbbad67c4739bea0a241b396bf4cbbebdd2e0 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-24 13:01:37 +00:00
void tst_QQuickMouseArea::releaseFirstTouchAfterSecond() // QTBUG-103766
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("simple.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>();
QVERIFY(mouseArea);
QSignalSpy pressSpy(mouseArea, SIGNAL(pressed(QQuickMouseEvent*)));
QSignalSpy releaseSpy(mouseArea, &QQuickMouseArea::released);
QTest::touchEvent(&window, device).press(0, {20, 20});
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(pressSpy.size(), 1);
Add MouseArea autotest with second touchpoint while first is held - Touch first finger - Touch and release second finger - Release first finger QQuickMouseArea::pressed() must be emitted only once; QQuickMouseArea::released() must be emitted at the end. Pick-to: 6.3 6.2 Task-number: QTBUG-103766 Change-Id: I849bbbad67c4739bea0a241b396bf4cbbebdd2e0 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-24 13:01:37 +00:00
QTest::touchEvent(&window, device).stationary(0).press(1, {100, 20});
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(pressSpy.size(), 1); // touchpoint 0 is the touchmouse, touchpoint 1 is ignored
Add MouseArea autotest with second touchpoint while first is held - Touch first finger - Touch and release second finger - Release first finger QQuickMouseArea::pressed() must be emitted only once; QQuickMouseArea::released() must be emitted at the end. Pick-to: 6.3 6.2 Task-number: QTBUG-103766 Change-Id: I849bbbad67c4739bea0a241b396bf4cbbebdd2e0 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-24 13:01:37 +00:00
QTest::touchEvent(&window, device).stationary(0).release(1, {100, 20});
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(releaseSpy.size(), 0); // touchpoint 0 is the touchmouse, and remains pressed
Add MouseArea autotest with second touchpoint while first is held - Touch first finger - Touch and release second finger - Release first finger QQuickMouseArea::pressed() must be emitted only once; QQuickMouseArea::released() must be emitted at the end. Pick-to: 6.3 6.2 Task-number: QTBUG-103766 Change-Id: I849bbbad67c4739bea0a241b396bf4cbbebdd2e0 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-24 13:01:37 +00:00
QTest::touchEvent(&window, device).release(0, {20, 20});
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(releaseSpy.size(), 1);
Add MouseArea autotest with second touchpoint while first is held - Touch first finger - Touch and release second finger - Release first finger QQuickMouseArea::pressed() must be emitted only once; QQuickMouseArea::released() must be emitted at the end. Pick-to: 6.3 6.2 Task-number: QTBUG-103766 Change-Id: I849bbbad67c4739bea0a241b396bf4cbbebdd2e0 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-05-24 13:01:37 +00:00
}
Don't ungrab for a TabletRelease event: wait for the synth-mouse release Many QTabletEvents are not handled, so being able to "press a button" or other kinds of basic UI interaction depend on tablet->mouse synthesis in QGuiApplicationPrivate::processTabletEvent(). If a basic mouse-handling Item like a MouseArea or Button grabs on _mouse_ press, it needs to receive the _mouse_ release too; so DeliveryAgent must not take away its grab until that happens. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-98936 Fixes: QTBUG-102764 Fixes: QTBUG-103937 Change-Id: I6d75d988d617bc3ceb8465f939d0a69485278cdf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-07-05 21:05:32 +00:00
#if QT_CONFIG(tabletevent)
void tst_QQuickMouseArea::tabletStylusTap()
{
QVERIFY(qApp->testAttribute(Qt::AA_SynthesizeMouseForUnhandledTabletEvents)); // MouseArea depends on it
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("simple.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>();
QVERIFY(mouseArea);
QSignalSpy pressSpy(mouseArea, SIGNAL(pressed(QQuickMouseEvent*)));
QSignalSpy releaseSpy(mouseArea, &QQuickMouseArea::released);
QSignalSpy clickSpy(mouseArea, &QQuickMouseArea::clicked);
const qint64 stylusId = 1234567890;
const QPoint point(100,100);
QWindowSystemInterface::handleTabletEvent(&window, point, window.mapToGlobal(point),
int(QInputDevice::DeviceType::Stylus), int(QPointingDevice::PointerType::Pen),
Qt::LeftButton, 0.5, 0, 0, 0, 0, 0, stylusId, Qt::NoModifier);
if (QWindowSystemInterfacePrivate::TabletEvent::platformSynthesizesMouse)
QTest::mousePress(&window, Qt::LeftButton, Qt::NoModifier, point); // simulate what the platform does
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(pressSpy.size(), 1);
Don't ungrab for a TabletRelease event: wait for the synth-mouse release Many QTabletEvents are not handled, so being able to "press a button" or other kinds of basic UI interaction depend on tablet->mouse synthesis in QGuiApplicationPrivate::processTabletEvent(). If a basic mouse-handling Item like a MouseArea or Button grabs on _mouse_ press, it needs to receive the _mouse_ release too; so DeliveryAgent must not take away its grab until that happens. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-98936 Fixes: QTBUG-102764 Fixes: QTBUG-103937 Change-Id: I6d75d988d617bc3ceb8465f939d0a69485278cdf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-07-05 21:05:32 +00:00
QWindowSystemInterface::handleTabletEvent(&window, point, window.mapToGlobal(point),
int(QInputDevice::DeviceType::Stylus), int(QPointingDevice::PointerType::Pen),
Qt::NoButton, 0.5, 0, 0, 0, 0, 0, stylusId, Qt::NoModifier);
if (QWindowSystemInterfacePrivate::TabletEvent::platformSynthesizesMouse)
QTest::mouseRelease(&window, Qt::LeftButton, Qt::NoModifier, point);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QTRY_COMPARE(releaseSpy.size(), 1);
QCOMPARE(clickSpy.size(), 1);
QCOMPARE(pressSpy.size(), 1);
Don't ungrab for a TabletRelease event: wait for the synth-mouse release Many QTabletEvents are not handled, so being able to "press a button" or other kinds of basic UI interaction depend on tablet->mouse synthesis in QGuiApplicationPrivate::processTabletEvent(). If a basic mouse-handling Item like a MouseArea or Button grabs on _mouse_ press, it needs to receive the _mouse_ release too; so DeliveryAgent must not take away its grab until that happens. Amends a97759a336c597327cb82eebc9f45c793aec32c9 Pick-to: 6.2 6.3 6.4 Fixes: QTBUG-98936 Fixes: QTBUG-102764 Fixes: QTBUG-103937 Change-Id: I6d75d988d617bc3ceb8465f939d0a69485278cdf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-07-05 21:05:32 +00:00
}
#endif
Allow OS-synthesized right clicks to be delivered Since 15337aa91b891b49ffe76c96dd6fa6cd9bead2c2 we have been blocking all OS-synthesized mouse events. But synthesizing right click from long- press is becoming more common, so Qt Quick should be able to react to those. [ChangeLog][QtQuick] In case your operating system synthesizes a right-click from a touchscreen long-press, synthetic right-button mouse events are now delivered normally, so that e.g. TapHandler can react. You can opt out by setting QT_QUICK_ALLOW_SYNTHETIC_RIGHT_CLICK=0. Fixes: QTBUG-77902 Task-number: QTBUG-84179 Change-Id: I609041daf0e3e8ce1d1f3b0c78ae3bd264fec8a3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-10-20 14:50:39 +00:00
void tst_QQuickMouseArea::syntheticRightClick()
{
QQuickView window;
QVERIFY(QQuickTest::showView(window, testFileUrl("simple.qml")));
QQuickMouseArea *mouseArea = window.rootObject()->findChild<QQuickMouseArea *>();
QVERIFY(mouseArea);
mouseArea->setAcceptedButtons(Qt::RightButton);
QSignalSpy clickSpy(mouseArea, &QQuickMouseArea::clicked);
const QPointF p(20, 20);
quint64 timestamp = 10;
// The right-click is probably synthesized from a touch long-press IRL, but it doesn't matter for the DA's logic.
// We could set QT_QUICK_ALLOW_SYNTHETIC_RIGHT_CLICK=0 to opt out, but otherwise it's allowed.
QMouseEvent press(QEvent::MouseButtonPress, p, mouseArea->mapToScene(p), mouseArea->mapToGlobal(p),
Qt::RightButton, Qt::RightButton, Qt::NoModifier, Qt::MouseEventSynthesizedBySystem);
press.setTimestamp(timestamp++);
QGuiApplication::sendEvent(&window, &press);
QCOMPARE(mouseArea->pressedButtons(), Qt::RightButton);
QMouseEvent release(QEvent::MouseButtonRelease, p, mouseArea->mapToScene(p), mouseArea->mapToGlobal(p),
Qt::RightButton, Qt::RightButton, Qt::NoModifier, Qt::MouseEventSynthesizedBySystem);
release.setTimestamp(timestamp);
QGuiApplication::sendEvent(&window, &release);
QCOMPARE(mouseArea->pressedButtons(), Qt::NoButton);
QCOMPARE(clickSpy.size(), 1);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QTEST_MAIN(tst_QQuickMouseArea)
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
#include "tst_qquickmousearea.moc"