qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
qtdeclarative/tests/auto/quick/qquickloader/tst_qquickloader.cpp

1514 lines
57 KiB
C++
Raw Normal View History

Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
/****************************************************************************
**
Updated license headers From Qt 5.7 -> tools & applications are lisenced under GPL v3 with some exceptions, see http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/ Updated license headers to use new GPL-EXCEPT header instead of LGPL21 one (in those files which will be under GPL 3 with exceptions) Change-Id: I04760a0801837cfc516d1c7c02d4f503f6bb70b6 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
2016-01-19 11:23:05 +00:00
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
**
** This file is part of the test suite of the Qt Toolkit.
**
Updated license headers From Qt 5.7 -> tools & applications are lisenced under GPL v3 with some exceptions, see http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/ Updated license headers to use new GPL-EXCEPT header instead of LGPL21 one (in those files which will be under GPL 3 with exceptions) Change-Id: I04760a0801837cfc516d1c7c02d4f503f6bb70b6 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
2016-01-19 11:23:05 +00:00
** $QT_BEGIN_LICENSE:GPL-EXCEPT$
Change copyrights from Nokia to Digia Change copyrights and license headers from Nokia to Digia Change-Id: Ie7f5d49ed8235d7a7845ab68f99ad1c220e64d5c Reviewed-by: Lars Knoll <lars.knoll@digia.com>
2012-09-20 05:21:40 +00:00
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
Update copyright headers Qt copyrights are now in The Qt Company, so we could update the source code headers accordingly. In the same go we should also fix the links to point to qt.io. Change-Id: I61120571787870c0ed17066afb31779b1e6e30e9 Reviewed-by: Iikka Eklund <iikka.eklund@theqtcompany.com>
2015-01-28 11:55:39 +00:00
** a written agreement between you and The Qt Company. For licensing terms
Updated license headers From Qt 5.7 -> tools & applications are lisenced under GPL v3 with some exceptions, see http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/ Updated license headers to use new GPL-EXCEPT header instead of LGPL21 one (in those files which will be under GPL 3 with exceptions) Change-Id: I04760a0801837cfc516d1c7c02d4f503f6bb70b6 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
2016-01-19 11:23:05 +00:00
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
Change copyrights from Nokia to Digia Change copyrights and license headers from Nokia to Digia Change-Id: Ie7f5d49ed8235d7a7845ab68f99ad1c220e64d5c Reviewed-by: Lars Knoll <lars.knoll@digia.com>
2012-09-20 05:21:40 +00:00
**
Updated license headers From Qt 5.7 -> tools & applications are lisenced under GPL v3 with some exceptions, see http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/ Updated license headers to use new GPL-EXCEPT header instead of LGPL21 one (in those files which will be under GPL 3 with exceptions) Change-Id: I04760a0801837cfc516d1c7c02d4f503f6bb70b6 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
2016-01-19 11:23:05 +00:00
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <qtest.h>
#include <QSignalSpy>
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
When deactivating a loader, do not immediately clear its context In 2eb2d6386da304cd1164264ae0bff685c796d89c, deactivating/clearing the loader would now prevent any subsequent bindings from being evaluated. The problem there was that the item created by the loader wouldn't have a parent item (among things) anymore, so references to it in the bindings would result in errors. The way to prevent it was done by invalidating the context of the item, which in turn would detach it from the root context. This is a problem if objects in the root context are referenced after deactivating/clearing the loader: onSomethingChanged: { loader.source = "" objectInRootContext.doIt() } This would result in a ReferenceError when resolving objectInRootContext and break the behavior present before the fix mentioned above. The correct way is to recursively clear the context set on all bindings, but leave everything in place. This way, no subsequent bindings will be evaluated, but the currently "running" scripts will still be able to reach the root context. Task-number: QTBUG-66822 Change-Id: Ic9c2ab0a752093a26967da4783cb4c29cf83d2ca Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Michael Brasser <michael.brasser@live.com>
2018-03-08 14:02:45 +00:00
#include <QtQml/QQmlContext>
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
#include <QtQml/qqmlengine.h>
#include <QtQml/qqmlcomponent.h>
#include <QtQml/qqmlincubator.h>
If Loader loads Window, set its transient parent to the Loader's window This makes the Item { Loader { sourceComponent: Window { } } } case consistent with the Item { Window { } } case: the inner Window is transient for the outer Window. It works even if the Loader's Window has a visible: true declaration: in that case, until now, the Loader's Window would become visible at component creation time, before the outer Item became visible. So the test to check whether it had a transient parent did not work. We now change the delayed-visibility mechanism in QQuickWindowQmlImpl to wait for the parent Item to acquire a window of its own rather than waiting for the transient-parent-if-any to become visible. It should still take care of all the old cases too, e.g. in the Window { Window { } } case, the inner Window's QObject parent is actually the QQuickRootItem. (Amends 701255c76f671f100338a799f0194bf10e26c9d1) [ChangeLog][QtQuick][QQuickWindow] When a Window is declared inside another Item or Window, the window will not be created until the parent window is created. This allows it to have the correct transientParent and be managed as a transient window. Task-number: QTBUG-52944 Change-Id: Iaf4aafbd696f6e8dd0eec1d02db8bd181483bd07 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-12-15 12:26:28 +00:00
#include <QtQuick/qquickview.h>
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
#include <private/qquickloader_p.h>
If Loader loads Window, set its transient parent to the Loader's window This makes the Item { Loader { sourceComponent: Window { } } } case consistent with the Item { Window { } } case: the inner Window is transient for the outer Window. It works even if the Loader's Window has a visible: true declaration: in that case, until now, the Loader's Window would become visible at component creation time, before the outer Item became visible. So the test to check whether it had a transient parent did not work. We now change the delayed-visibility mechanism in QQuickWindowQmlImpl to wait for the parent Item to acquire a window of its own rather than waiting for the transient-parent-if-any to become visible. It should still take care of all the old cases too, e.g. in the Window { Window { } } case, the inner Window's QObject parent is actually the QQuickRootItem. (Amends 701255c76f671f100338a799f0194bf10e26c9d1) [ChangeLog][QtQuick][QQuickWindow] When a Window is declared inside another Item or Window, the window will not be created until the parent window is created. This allows it to have the correct transientParent and be managed as a transient window. Task-number: QTBUG-52944 Change-Id: Iaf4aafbd696f6e8dd0eec1d02db8bd181483bd07 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-12-15 12:26:28 +00:00
#include <private/qquickwindowmodule_p.h>
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
#include "testhttpserver.h"
Say hello to QtQuick module This change moves the QtQuick 2 types and C++ API (including SceneGraph) to a new module (AKA library), QtQuick. 99% of this change is moving files from src/declarative to src/quick, and from tests/auto/declarative to tests/auto/qtquick2. The loading of QtQuick 2 ("import QtQuick 2.0") is now delegated to a plugin, src/imports/qtquick2, just like it's done for QtQuick 1. All tools, examples, and tests that use QtQuick C++ API have gotten "QT += quick" or "QT += quick-private" added to their .pro file. A few additional internal QtDeclarative classes had to be exported (via Q_DECLARATIVE_PRIVATE_EXPORT) since they're needed by the QtQuick 2 implementation. The old header locations (e.g. QtDeclarative/qquickitem.h) will still be supported for some time, but will produce compile-time warnings. (To avoid the QtQuick implementation using the compatibility headers (since QtDeclarative's includepath comes first), a few include statements were modified, e.g. from "#include <qsgnode.h>" to "#include <QtQuick/qsgnode.h>".) There's a change in qtbase that automatically adds QtQuick to the module list if QtDeclarative is used. Together with the compatibility headers, this should help reduce the migration pain for existing projects. In theory, simply getting an existing QtDeclarative-based project to compile and link shouldn't require any changes for now -- but porting to the new scheme is of course recommended, and will eventually become mandatory. Task-number: QTBUG-22889 Reviewed-by: Lars Knoll <lars.knoll@nokia.com> Change-Id: Ia52be9373172ba2f37e7623231ecb060316c96a7 Reviewed-by: Kent Hansen <kent.hansen@nokia.com> Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
2011-11-23 14:14:07 +00:00
#include "../../shared/util.h"
QQuickLoader: Use setSize() to resize item Sequential call of setWidth() and setHeight() results in outdated height on widthChanged() signal. Use setSize() to set width and height at once. Change-Id: I86ff5cef2da912a8855c66a614d5d7d2e71f1de8 Reviewed-by: Risto Avila <risto.avila@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-06-16 05:40:12 +00:00
#include "../shared/geometrytestutil.h"
QQuickLoader: store status This allows us to emit the change signal only when the status has actually changed. Due to alignment restrictions, this does not even change the size of the class. Fixes: QTBUG-82002 Change-Id: I2192bf80e72b92108046780811c3acdab39af518 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2020-02-12 12:29:08 +00:00
#include <QQmlApplicationEngine>
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
If Loader loads Window, set its transient parent to the Loader's window This makes the Item { Loader { sourceComponent: Window { } } } case consistent with the Item { Window { } } case: the inner Window is transient for the outer Window. It works even if the Loader's Window has a visible: true declaration: in that case, until now, the Loader's Window would become visible at component creation time, before the outer Item became visible. So the test to check whether it had a transient parent did not work. We now change the delayed-visibility mechanism in QQuickWindowQmlImpl to wait for the parent Item to acquire a window of its own rather than waiting for the transient-parent-if-any to become visible. It should still take care of all the old cases too, e.g. in the Window { Window { } } case, the inner Window's QObject parent is actually the QQuickRootItem. (Amends 701255c76f671f100338a799f0194bf10e26c9d1) [ChangeLog][QtQuick][QQuickWindow] When a Window is declared inside another Item or Window, the window will not be created until the parent window is created. This allows it to have the correct transientParent and be managed as a transient window. Task-number: QTBUG-52944 Change-Id: Iaf4aafbd696f6e8dd0eec1d02db8bd181483bd07 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-12-15 12:26:28 +00:00
Q_LOGGING_CATEGORY(lcTests, "qt.quick.tests")
Improve timer dependent tests. tst_QQuickLoader::loadedSignal depended on sharing the engine with simultaneousSyncAsync and that function being run before it. After each test run call clearComponentCache() as that is important for caching of the network tests. The test server would send the item after 500ms. Sometimes the CI would be faster or slower. Instead of relying on timing, simply call a function when the reply should be sent. Change-Id: Ifb0447041197e1cba103570597a62a2510d31aab Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-03-06 17:47:17 +00:00
class SlowComponent : public QQmlComponent
{
Q_OBJECT
public:
SlowComponent() {
QTest::qSleep(500);
}
};
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
class PeriodicIncubationController : public QObject,
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
public QQmlIncubationController
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
{
public:
init variables where they are declared when possible (clang-tidy) clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f Reviewed-by: Johan Helsing <johan.helsing@qt.io>
2018-02-21 10:52:59 +00:00
PeriodicIncubationController() {}
Stabilize tst_qquickloader test case Ensure cases are not affected by timer events of incubation controllers created in previous cases. Change-Id: Ia633ed142242d000de5f497896a685ca2f26e143 Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-07-30 01:10:28 +00:00
void start() { startTimer(20); }
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
init variables where they are declared when possible (clang-tidy) clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f Reviewed-by: Johan Helsing <johan.helsing@qt.io>
2018-02-21 10:52:59 +00:00
bool incubated = false;
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
protected:
virtual void timerEvent(QTimerEvent *) {
incubateFor(15);
}
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
virtual void incubatingObjectCountChanged(int count) {
if (count)
incubated = true;
}
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
};
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
class tst_QQuickLoader : public QQmlDataTest
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Q_OBJECT
public:
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
tst_QQuickLoader();
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
private slots:
void sourceOrComponent();
void sourceOrComponent_data();
void clear();
void urlToComponent();
void componentToUrl();
void anchoredLoader();
void sizeLoaderToItem();
void sizeItemToLoader();
void noResize();
void networkRequestUrl();
void failNetworkRequest();
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
void networkComponent();
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
void active();
void initialPropertyValues_data();
void initialPropertyValues();
void initialPropertyValuesBinding();
void initialPropertyValuesError_data();
void initialPropertyValuesError();
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
void deleteComponentCrash();
void nonItem();
void vmeErrors();
void creationContext();
void QTBUG_16928();
void implicitSize();
void QTBUG_17114();
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
void asynchronous_data();
void asynchronous();
void asynchronous_clear();
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
void simultaneousSyncAsync();
Allow forced completion of asynchronous Loader. Setting Loader::asynchronous from true to false will attempt to force complete any operations in progress. This allows the user to begin loading something in the background, and then force the load to complete once the Loader's content must be viewed. Change-Id: I056dcc20faacb38b3529c967245416da9949e64a Task-number: QTBUG-29789 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-07 21:29:55 +00:00
void asyncToSync1();
void asyncToSync2();
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
void loadedSignal();
tst_qquickloader: Test setting source from component works Not verifying this works before has caused regressions. Change-Id: I4b99928bb6993d511349aec782660d24a134f67d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-10-30 10:35:00 +00:00
void selfSetSource();
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
autotest for setting parent in a component created by Loader. Change-Id: I1b6850ce5e4a820b5ab7b2d06a877307104478a1 Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2011-11-14 03:00:31 +00:00
void parented();
Allow binding the size of a Loader to its item. If the size of the Loader is bound to the item, the item was resized before the binding was evaluated, resulting in an item height of 0. This change allows bindings to the item to be evaluated before we apply the resize logic. Task-number: QTBUG-22628 Change-Id: I30acdb54214b422a9d4aa4e7e02a0af3674322db Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-02-16 03:45:02 +00:00
void sizeBound();
QQuickLoader: fix the recursion guard for size updates Task-number: QTBUG-30183 Change-Id: Ic8720e1e35bf2f349d74d2021dd202849da67852 Reviewed-by: Jan Arve Sæther <jan-arve.saether@digia.com> Reviewed-by: Caroline Chao <caroline.chao@digia.com> Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
2013-03-13 17:31:57 +00:00
void QTBUG_30183();
If Loader loads Window, set its transient parent to the Loader's window This makes the Item { Loader { sourceComponent: Window { } } } case consistent with the Item { Window { } } case: the inner Window is transient for the outer Window. It works even if the Loader's Window has a visible: true declaration: in that case, until now, the Loader's Window would become visible at component creation time, before the outer Item became visible. So the test to check whether it had a transient parent did not work. We now change the delayed-visibility mechanism in QQuickWindowQmlImpl to wait for the parent Item to acquire a window of its own rather than waiting for the transient-parent-if-any to become visible. It should still take care of all the old cases too, e.g. in the Window { Window { } } case, the inner Window's QObject parent is actually the QQuickRootItem. (Amends 701255c76f671f100338a799f0194bf10e26c9d1) [ChangeLog][QtQuick][QQuickWindow] When a Window is declared inside another Item or Window, the window will not be created until the parent window is created. This allows it to have the correct transientParent and be managed as a transient window. Task-number: QTBUG-52944 Change-Id: Iaf4aafbd696f6e8dd0eec1d02db8bd181483bd07 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-12-15 12:26:28 +00:00
void transientWindow();
void nestedTransientWindow();
autotest for setting parent in a component created by Loader. Change-Id: I1b6850ce5e4a820b5ab7b2d06a877307104478a1 Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2011-11-14 03:00:31 +00:00
Fix crash in QQuickLoader when source component is garbage collected It may happen that the QQuickLoader is the last entity left in the system holding a reference to the QQmlComponent *sourceComponent. We have to let the garbage collector know about that by keeping a persistent value for it. Task-number: QTBUG-35334 Change-Id: I715864440378fd9dd4f2d5ef8ff2f171c81ed7ef Reviewed-by: Lars Knoll <lars.knoll@digia.com>
2013-12-05 15:21:03 +00:00
void sourceComponentGarbageCollection();
Prevent errors when unloading Loader Invalidate the context of the object so that destruction is signaled and bindings no longer run. Task-number: QTBUG-47321 Task-number: QTBUG-51995 Task-number: QTBUG-60344 Change-Id: I194a2fefe4e769a58c9ce022d39fe76cbe230de7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2017-10-24 01:45:00 +00:00
void bindings();
void parentErrors();
When deactivating a loader, do not immediately clear its context In 2eb2d6386da304cd1164264ae0bff685c796d89c, deactivating/clearing the loader would now prevent any subsequent bindings from being evaluated. The problem there was that the item created by the loader wouldn't have a parent item (among things) anymore, so references to it in the bindings would result in errors. The way to prevent it was done by invalidating the context of the item, which in turn would detach it from the root context. This is a problem if objects in the root context are referenced after deactivating/clearing the loader: onSomethingChanged: { loader.source = "" objectInRootContext.doIt() } This would result in a ReferenceError when resolving objectInRootContext and break the behavior present before the fix mentioned above. The correct way is to recursively clear the context set on all bindings, but leave everything in place. This way, no subsequent bindings will be evaluated, but the currently "running" scripts will still be able to reach the root context. Task-number: QTBUG-66822 Change-Id: Ic9c2ab0a752093a26967da4783cb4c29cf83d2ca Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Michael Brasser <michael.brasser@live.com>
2018-03-08 14:02:45 +00:00
void rootContext();
Don't leak components in QQuickLoader Only create source component in loadFromSource if it does not already exist. Previously toggling the active status when loading from source would create a new source component every time active became true. [ChangeLog][QtQuick][Loader] Don't leak components when changing source url. Change-Id: I1e4cfd5613e3851fcb4f3f55e78981f7c070cc77 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-06-02 10:35:07 +00:00
void sourceURLKeepComponent();
QQuickLoader: store status This allows us to emit the change signal only when the status has actually changed. Due to alignment restrictions, this does not even change the size of the class. Fixes: QTBUG-82002 Change-Id: I2192bf80e72b92108046780811c3acdab39af518 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2020-02-12 12:29:08 +00:00
void statusChangeOnlyEmittedOnce();
QQuickLoader: make sure the status property change properly Since the invocation of [setSource] in qml will clear the old source url first, it is hard to decide whether we have changed the source url, especially when we call [setSource] with an empty string, and the loader's status won't change properly. Pick-to: 5.15 Fixes: QTBUG-85938 Change-Id: If61a33c790a4fd6562611c4c50756bc5e213363a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-08-15 06:57:06 +00:00
void setSourceAndCheckStatus();
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
};
Prevent errors when unloading Loader Invalidate the context of the object so that destruction is signaled and bindings no longer run. Task-number: QTBUG-47321 Task-number: QTBUG-51995 Task-number: QTBUG-60344 Change-Id: I194a2fefe4e769a58c9ce022d39fe76cbe230de7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2017-10-24 01:45:00 +00:00
Q_DECLARE_METATYPE(QList<QQmlError>)
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
tst_QQuickLoader::tst_QQuickLoader()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Improve timer dependent tests. tst_QQuickLoader::loadedSignal depended on sharing the engine with simultaneousSyncAsync and that function being run before it. After each test run call clearComponentCache() as that is important for caching of the network tests. The test server would send the item after 500ms. Sometimes the CI would be faster or slower. Instead of relying on timing, simply call a function when the reply should be sent. Change-Id: Ifb0447041197e1cba103570597a62a2510d31aab Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-03-06 17:47:17 +00:00
qmlRegisterType<SlowComponent>("LoaderTest", 1, 0, "SlowComponent");
Prevent errors when unloading Loader Invalidate the context of the object so that destruction is signaled and bindings no longer run. Task-number: QTBUG-47321 Task-number: QTBUG-51995 Task-number: QTBUG-60344 Change-Id: I194a2fefe4e769a58c9ce022d39fe76cbe230de7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2017-10-24 01:45:00 +00:00
qRegisterMetaType<QList<QQmlError>>();
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::sourceOrComponent()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Add sourceComponentChanged signal to Loader When setting the 'sourceComponent' property in Loader, we emit a sourceChanged signal with source == "". We should emit sourceComponentChanged instead. Task-number: QTBUG-20628 Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee Reviewed-on: http://codereview.qt.nokia.com/2371 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 04:41:16 +00:00
QFETCH(QString, sourceOrComponent);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QFETCH(QString, sourceDefinition);
QFETCH(QUrl, sourceUrl);
QFETCH(QString, errorString);
bool error = !errorString.isEmpty();
if (error)
QTest::ignoreMessage(QtWarningMsg, errorString.toUtf8().constData());
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
component.setData(QByteArray(
"import QtQuick 2.0\n"
"Loader {\n"
" property int onItemChangedCount: 0\n"
" property int onSourceChangedCount: 0\n"
Add sourceComponentChanged signal to Loader When setting the 'sourceComponent' property in Loader, we emit a sourceChanged signal with source == "". We should emit sourceComponentChanged instead. Task-number: QTBUG-20628 Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee Reviewed-on: http://codereview.qt.nokia.com/2371 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 04:41:16 +00:00
" property int onSourceComponentChangedCount: 0\n"
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
" property int onStatusChangedCount: 0\n"
" property int onProgressChangedCount: 0\n"
" property int onLoadedCount: 0\n")
+ sourceDefinition.toUtf8()
+ QByteArray(
" onItemChanged: onItemChangedCount += 1\n"
" onSourceChanged: onSourceChangedCount += 1\n"
Add sourceComponentChanged signal to Loader When setting the 'sourceComponent' property in Loader, we emit a sourceChanged signal with source == "". We should emit sourceComponentChanged instead. Task-number: QTBUG-20628 Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee Reviewed-on: http://codereview.qt.nokia.com/2371 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 04:41:16 +00:00
" onSourceComponentChanged: onSourceComponentChangedCount += 1\n"
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
" onStatusChanged: onStatusChangedCount += 1\n"
" onProgressChanged: onProgressChangedCount += 1\n"
" onLoaded: onLoadedCount += 1\n"
"}")
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
, dataDirectoryUrl());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
QCOMPARE(loader->item() == nullptr, error);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->source(), sourceUrl);
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), error ? QQuickLoader::Error : QQuickLoader::Ready);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader.data())->childItems().count(), error ? 0: 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
if (!error) {
QSGLoader shouldn't load component when active is false Previously, QSGLoader still loaded the component specified, but didn't instantiate the item. This commit ensures that no component is loaded from the source, and that the onLoaded signal is emitted only when loading occurs (when the loader is active). Task-number: QTBUG-21710 Change-Id: I2d83603ef84d6942fb84141e9e146d2cf9654fc4 Reviewed-on: http://codereview.qt-project.org/5915 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-10-06 04:37:09 +00:00
bool sourceComponentIsChildOfLoader = false;
for (int ii = 0; ii < loader->children().size(); ++ii) {
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent *c = qobject_cast<QQmlComponent*>(loader->children().at(ii));
QSGLoader shouldn't load component when active is false Previously, QSGLoader still loaded the component specified, but didn't instantiate the item. This commit ensures that no component is loaded from the source, and that the onLoaded signal is emitted only when loading occurs (when the loader is active). Task-number: QTBUG-21710 Change-Id: I2d83603ef84d6942fb84141e9e146d2cf9654fc4 Reviewed-on: http://codereview.qt-project.org/5915 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-10-06 04:37:09 +00:00
if (c && c == loader->sourceComponent()) {
sourceComponentIsChildOfLoader = true;
}
}
QVERIFY(sourceComponentIsChildOfLoader);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Add sourceComponentChanged signal to Loader When setting the 'sourceComponent' property in Loader, we emit a sourceChanged signal with source == "". We should emit sourceComponentChanged instead. Task-number: QTBUG-20628 Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee Reviewed-on: http://codereview.qt.nokia.com/2371 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 04:41:16 +00:00
if (sourceOrComponent == "component") {
QCOMPARE(loader->property("onSourceComponentChangedCount").toInt(), 1);
QCOMPARE(loader->property("onSourceChangedCount").toInt(), 0);
} else {
QCOMPARE(loader->property("onSourceComponentChangedCount").toInt(), 0);
QCOMPARE(loader->property("onSourceChangedCount").toInt(), 1);
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->property("onStatusChangedCount").toInt(), 1);
QCOMPARE(loader->property("onProgressChangedCount").toInt(), 1);
Emit itemChanged when Loader fails to load a source. As per the source comment, it is not actually tracked whether item was null before. This is consistent with the behaviour in loadFromSource, where setting a source to null always emits item changed. This is reasonable behaviour, because it only occurs in unexpected error states where the program logic likely expects a changed signal anyways. Change-Id: I160ab04dc1b5c578ee508f4adbca65e8da5b16be Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-06-12 01:47:13 +00:00
QCOMPARE(loader->property("onItemChangedCount").toInt(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->property("onLoadedCount").toInt(), error ? 0 : 1);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::sourceOrComponent_data()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Add sourceComponentChanged signal to Loader When setting the 'sourceComponent' property in Loader, we emit a sourceChanged signal with source == "". We should emit sourceComponentChanged instead. Task-number: QTBUG-20628 Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee Reviewed-on: http://codereview.qt.nokia.com/2371 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 04:41:16 +00:00
QTest::addColumn<QString>("sourceOrComponent");
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QTest::addColumn<QString>("sourceDefinition");
QTest::addColumn<QUrl>("sourceUrl");
QTest::addColumn<QString>("errorString");
Do not resolve URLs when assigning them to a property We don't know in advance if a URL is part of the source code and should be relative to the current element, or if it is part of the application data and should not be touched. [ChangeLog][QtQml][Important Behavior Changes] URLs are not resolved or intercepted anymore when assigning them to a "url" property. Instead they are resolved and possibly intercepted when used to access an actual resource. Fixes: QTBUG-76879 Change-Id: Iaa2385aff2c13aa71a12e57385d9afb5dc60a073 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-06-15 15:53:16 +00:00
QTest::newRow("source") << "source" << "source: 'Rect120x60.qml'\n" << QUrl("Rect120x60.qml") << "";
QTest::newRow("source with subdir") << "source" << "source: 'subdir/Test.qml'\n" << QUrl("subdir/Test.qml") << "";
QTest::newRow("source with encoded subdir literal") << "source" << "source: 'subdir%2fTest.qml'\n" << QUrl("subdir%2FTest.qml") << "";
QTest::newRow("source with encoded subdir optimized binding") << "source" << "source: 'subdir' + '%2fTest.qml'\n" << QUrl("subdir%2FTest.qml") << "";
QTest::newRow("source with encoded subdir binding") << "source" << "source: encodeURIComponent('subdir/Test.qml')\n" << QUrl("subdir%2FTest.qml") << "";
Add sourceComponentChanged signal to Loader When setting the 'sourceComponent' property in Loader, we emit a sourceChanged signal with source == "". We should emit sourceComponentChanged instead. Task-number: QTBUG-20628 Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee Reviewed-on: http://codereview.qt.nokia.com/2371 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2011-07-29 04:41:16 +00:00
QTest::newRow("sourceComponent") << "component" << "Component { id: comp; Rectangle { width: 100; height: 50 } }\n sourceComponent: comp\n" << QUrl() << "";
Do not resolve URLs when assigning them to a property We don't know in advance if a URL is part of the source code and should be relative to the current element, or if it is part of the application data and should not be touched. [ChangeLog][QtQml][Important Behavior Changes] URLs are not resolved or intercepted anymore when assigning them to a "url" property. Instead they are resolved and possibly intercepted when used to access an actual resource. Fixes: QTBUG-76879 Change-Id: Iaa2385aff2c13aa71a12e57385d9afb5dc60a073 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-06-15 15:53:16 +00:00
QTest::newRow("invalid source") << "source" << "source: 'IDontExist.qml'\n" << QUrl("IDontExist.qml")
Clean up file/error handling in the type loader Fold the functionality of reading QFile contents via QQmlFile into QQmlDataBlob::Data. This reduces the dependency on QQmlFile - which is scheduled for removal - and it makes it possible in the future to avoid reading the file altogether if we have a cached compilation unit on disk. Change-Id: Ieeaf52b6fb1d25665cd3c3b196819e25aba3dd15 Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2016-06-17 11:21:07 +00:00
<< QString(testFileUrl("IDontExist.qml").toString() + ": No such file or directory");
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::clear()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
component.setData(QByteArray(
"import QtQuick 2.0\n"
" Loader { id: loader\n"
" source: 'Rect120x60.qml'\n"
" Timer { interval: 200; running: true; onTriggered: loader.source = '' }\n"
" }")
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
, dataDirectoryUrl());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader.data())->childItems().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QTRY_VERIFY(!loader->item());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->progress(), 0.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Null);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader.data())->childItems().count(), 0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("/SetSourceComponent.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = qobject_cast<QQuickLoader*>(item->QQuickItem::childItems().at(0));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader);
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
loader->setSourceComponent(nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->progress(), 0.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Null);
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("/SetSourceComponent.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = qobject_cast<QQuickLoader*>(item->QQuickItem::childItems().at(0));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader);
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(item.data(), "clear");
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->progress(), 0.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Null);
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::urlToComponent()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
component.setData(QByteArray("import QtQuick 2.0\n"
"Loader {\n"
" id: loader\n"
" Component { id: myComp; Rectangle { width: 10; height: 10 } }\n"
" source: \"Rect120x60.qml\"\n"
" Timer { interval: 100; running: true; onTriggered: loader.sourceComponent = myComp }\n"
"}" )
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
, dataDirectoryUrl());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QTest::qWait(200);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QTRY_VERIFY(loader != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader.data())->childItems().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->width(), 10.0);
QCOMPARE(loader->height(), 10.0);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::componentToUrl()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("/SetSourceComponent.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = qobject_cast<QQuickLoader*>(item->QQuickItem::childItems().at(0));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader);
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
loader->setSource(testFileUrl("/Rect120x60.qml"));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->width(), 120.0);
QCOMPARE(loader->height(), 60.0);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::anchoredLoader()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("/AnchoredLoader.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> rootItem(qobject_cast<QQuickItem*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(rootItem != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickItem *loader = rootItem->findChild<QQuickItem*>("loader");
QQuickItem *sourceElement = rootItem->findChild<QQuickItem*>("sourceElement");
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
QVERIFY(sourceElement != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(rootItem->width(), 300.0);
QCOMPARE(rootItem->height(), 200.0);
QCOMPARE(loader->width(), 300.0);
QCOMPARE(loader->height(), 200.0);
QCOMPARE(sourceElement->width(), 300.0);
QCOMPARE(sourceElement->height(), 200.0);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::sizeLoaderToItem()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("/SizeToItem.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->width(), 120.0);
QCOMPARE(loader->height(), 60.0);
// Check resize
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickItem *rect = qobject_cast<QQuickItem*>(loader->item());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(rect);
rect->setWidth(150);
rect->setHeight(45);
QCOMPARE(loader->width(), 150.0);
QCOMPARE(loader->height(), 45.0);
// Check explicit width
loader->setWidth(200.0);
QCOMPARE(loader->width(), 200.0);
QCOMPARE(rect->width(), 200.0);
rect->setWidth(100.0); // when rect changes ...
QCOMPARE(rect->width(), 100.0); // ... it changes
QCOMPARE(loader->width(), 200.0); // ... but loader stays the same
// Check explicit height
loader->setHeight(200.0);
QCOMPARE(loader->height(), 200.0);
QCOMPARE(rect->height(), 200.0);
rect->setHeight(100.0); // when rect changes ...
QCOMPARE(rect->height(), 100.0); // ... it changes
QCOMPARE(loader->height(), 200.0); // ... but loader stays the same
// Switch mode
loader->setWidth(180);
loader->setHeight(30);
QCOMPARE(rect->width(), 180.0);
QCOMPARE(rect->height(), 30.0);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::sizeItemToLoader()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("/SizeToLoader.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->width(), 200.0);
QCOMPARE(loader->height(), 80.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickItem *rect = qobject_cast<QQuickItem*>(loader->item());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(rect);
QCOMPARE(rect->width(), 200.0);
QCOMPARE(rect->height(), 80.0);
// Check resize
QQuickLoader: Use setSize() to resize item Sequential call of setWidth() and setHeight() results in outdated height on widthChanged() signal. Use setSize() to set width and height at once. Change-Id: I86ff5cef2da912a8855c66a614d5d7d2e71f1de8 Reviewed-by: Risto Avila <risto.avila@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2016-06-16 05:40:12 +00:00
QSizeChangeListener sizeListener(rect);
const QSizeF size(180, 30);
loader->setSize(size);
QVERIFY2(!sizeListener.isEmpty(), "There should be at least one signal about the size changed");
for (const QSizeF sizeOnGeometryChanged : sizeListener) {
// Check that we have the correct size on all signals
QCOMPARE(sizeOnGeometryChanged, size);
}
QCOMPARE(rect->width(), size.width());
QCOMPARE(rect->height(), size.height());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
// Switch mode
loader->resetWidth(); // reset explicit size
loader->resetHeight();
rect->setWidth(160);
rect->setHeight(45);
QCOMPARE(loader->width(), 160.0);
QCOMPARE(loader->height(), 45.0);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::noResize()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("/NoResize.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(item != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(item->width(), 200.0);
QCOMPARE(item->height(), 80.0);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::networkRequestUrl()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Provide a threaded TestHTTPServer This allows us to do blocking operations that interact with the test server in the main thread. The threaded server is used in tests that don't explicitly require asynchronous operation. Change-Id: Ibcb28e79a1114cb9cfb812e86aae0a1af71c569e Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-25 08:30:59 +00:00
ThreadedTestHTTPServer server(dataDirectory());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine);
Prospective fix for flakey "network" related QML tests Replace hard-coded server ports with dynamically allocated ports. Change-Id: Iab8f9a88343a9f2c49af3cd700c954c13c3bf121 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
2015-04-22 15:15:30 +00:00
const QString qml = "import QtQuick 2.0\nLoader { property int signalCount : 0; source: \"" + server.baseUrl().toString() + "/Rect120x60.qml\"; onLoaded: signalCount += 1 }";
component.setData(qml.toUtf8(), testFileUrl("../dummy.qml"));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
if (component.isError())
qDebug() << component.errors();
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QTRY_COMPARE(loader->status(), QQuickLoader::Ready);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
QCOMPARE(loader->property("signalCount").toInt(), 1);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader.data())->childItems().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
/* XXX Component waits until all dependencies are loaded. Is this actually possible? */
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::networkComponent()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Provide a threaded TestHTTPServer This allows us to do blocking operations that interact with the test server in the main thread. The threaded server is used in tests that don't explicitly require asynchronous operation. Change-Id: Ibcb28e79a1114cb9cfb812e86aae0a1af71c569e Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-25 08:30:59 +00:00
ThreadedTestHTTPServer server(dataDirectory(), TestHTTPServer::Delay);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine);
Prospective fix for flakey "network" related QML tests Replace hard-coded server ports with dynamically allocated ports. Change-Id: Iab8f9a88343a9f2c49af3cd700c954c13c3bf121 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
2015-04-22 15:15:30 +00:00
const QString qml = "import QtQuick 2.0\n"
"import \"" + server.baseUrl().toString() + "/\" as NW\n"
"Item {\n"
" Component { id: comp; NW.Rect120x60 {} }\n"
" Loader { sourceComponent: comp } }";
component.setData(qml.toUtf8(), dataDirectory());
Provide a threaded TestHTTPServer This allows us to do blocking operations that interact with the test server in the main thread. The threaded server is used in tests that don't explicitly require asynchronous operation. Change-Id: Ibcb28e79a1114cb9cfb812e86aae0a1af71c569e Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-25 08:30:59 +00:00
// The component may be loaded synchronously or asynchronously, so we cannot test for
// status == Loading here. Also, it makes no sense to instruct the server to send here
// because in the synchronous case we're already done loading.
Stabilize QQuickLoader test on Windows. Wait until the component is ready in network tests. Task-number: QTBUG-28611 Change-Id: I3f880ee585199a3c8ba2d672bb365fa60c472499 Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
2012-12-17 13:00:10 +00:00
QTRY_COMPARE(component.status(), QQmlComponent::Ready);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Do not leak the item, and use a QScopedPointer to guarantee cleanup Change-Id: Ib4160f418686cef6d85dfd64657d25836f66778e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-01-19 15:10:09 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
Improve timer dependent tests. tst_QQuickLoader::loadedSignal depended on sharing the engine with simultaneousSyncAsync and that function being run before it. After each test run call clearComponentCache() as that is important for caching of the network tests. The test server would send the item after 500ms. Sometimes the CI would be faster or slower. Instead of relying on timing, simply call a function when the reply should be sent. Change-Id: Ifb0447041197e1cba103570597a62a2510d31aab Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-03-06 17:47:17 +00:00
QQuickLoader *loader = qobject_cast<QQuickLoader*>(item->children().at(1));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QTRY_COMPARE(loader->status(), QQuickLoader::Ready);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Ready);
QCOMPARE(static_cast<QQuickItem*>(loader)->children().count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::failNetworkRequest()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
Provide a threaded TestHTTPServer This allows us to do blocking operations that interact with the test server in the main thread. The threaded server is used in tests that don't explicitly require asynchronous operation. Change-Id: Ibcb28e79a1114cb9cfb812e86aae0a1af71c569e Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-25 08:30:59 +00:00
ThreadedTestHTTPServer server(dataDirectory());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Prospective fix for flakey "network" related QML tests Replace hard-coded server ports with dynamically allocated ports. Change-Id: Iab8f9a88343a9f2c49af3cd700c954c13c3bf121 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
2015-04-22 15:15:30 +00:00
QTest::ignoreMessage(QtWarningMsg, QString(server.baseUrl().toString() + "/IDontExist.qml: File not found").toUtf8());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine);
Prospective fix for flakey "network" related QML tests Replace hard-coded server ports with dynamically allocated ports. Change-Id: Iab8f9a88343a9f2c49af3cd700c954c13c3bf121 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
2015-04-22 15:15:30 +00:00
const QString qml = "import QtQuick 2.0\nLoader { property int did_load: 123; source: \"" + server.baseUrl().toString() + "/IDontExist.qml\"; onLoaded: did_load=456 }";
component.setData(qml.toUtf8(), server.url("/dummy.qml"));
Stabilize QQuickLoader test on Windows. Wait until the component is ready in network tests. Task-number: QTBUG-28611 Change-Id: I3f880ee585199a3c8ba2d672bb365fa60c472499 Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
2012-12-17 13:00:10 +00:00
QTRY_COMPARE(component.status(), QQmlComponent::Ready);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QTRY_COMPARE(loader->status(), QQuickLoader::Error);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QCOMPARE(loader->progress(), 1.0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(loader->property("did_load").toInt(), 123);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(static_cast<QQuickItem*>(loader.data())->childItems().count(), 0);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::active()
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
// check that the item isn't instantiated until active is set to true
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.1.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(loader->active() == false); // set manually to false
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetSourceComponent");
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetSource");
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetActive");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader->item() != nullptr);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
}
// check that the status is Null if active is set to false
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.2.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(loader->active() == true); // active is true by default
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Ready);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
int currStatusChangedCount = loader->property("statusChangedCount").toInt();
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetInactive");
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Null);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QCOMPARE(loader->property("statusChangedCount").toInt(), (currStatusChangedCount+1));
}
// check that the source is not cleared if active is set to false
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.3.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(loader->active() == true); // active is true by default
QVERIFY(!loader->source().isEmpty());
int currSourceChangedCount = loader->property("sourceChangedCount").toInt();
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetInactive");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(!loader->source().isEmpty());
QCOMPARE(loader->property("sourceChangedCount").toInt(), currSourceChangedCount);
}
// check that the sourceComponent is not cleared if active is set to false
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.4.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(loader->active() == true); // active is true by default
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader->sourceComponent() != nullptr);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
int currSourceComponentChangedCount = loader->property("sourceComponentChangedCount").toInt();
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetInactive");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader->sourceComponent() != nullptr);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QCOMPARE(loader->property("sourceComponentChangedCount").toInt(), currSourceComponentChangedCount);
}
// check that the item is released if active is set to false
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.5.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(loader->active() == true); // active is true by default
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader->item() != nullptr);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
int currItemChangedCount = loader->property("itemChangedCount").toInt();
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetInactive");
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QCOMPARE(loader->property("itemChangedCount").toInt(), (currItemChangedCount+1));
}
// check that the activeChanged signal is emitted correctly
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.6.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(loader->active() == true); // active is true by default
loader->setActive(true); // no effect
QCOMPARE(loader->property("activeChangedCount").toInt(), 0);
loader->setActive(false); // change signal should be emitted
QCOMPARE(loader->property("activeChangedCount").toInt(), 1);
loader->setActive(false); // no effect
QCOMPARE(loader->property("activeChangedCount").toInt(), 1);
loader->setActive(true); // change signal should be emitted
QCOMPARE(loader->property("activeChangedCount").toInt(), 2);
loader->setActive(false); // change signal should be emitted
QCOMPARE(loader->property("activeChangedCount").toInt(), 3);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetActive");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QCOMPARE(loader->property("activeChangedCount").toInt(), 4);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetActive");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QCOMPARE(loader->property("activeChangedCount").toInt(), 4);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(object.data(), "doSetInactive");
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QCOMPARE(loader->property("activeChangedCount").toInt(), 5);
loader->setActive(true); // change signal should be emitted
QCOMPARE(loader->property("activeChangedCount").toInt(), 6);
}
QSGLoader shouldn't load component when active is false Previously, QSGLoader still loaded the component specified, but didn't instantiate the item. This commit ensures that no component is loaded from the source, and that the onLoaded signal is emitted only when loading occurs (when the loader is active). Task-number: QTBUG-21710 Change-Id: I2d83603ef84d6942fb84141e9e146d2cf9654fc4 Reviewed-on: http://codereview.qt-project.org/5915 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-10-06 04:37:09 +00:00
// check that the component isn't loaded until active is set to true
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.7.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
QSGLoader shouldn't load component when active is false Previously, QSGLoader still loaded the component specified, but didn't instantiate the item. This commit ensures that no component is loaded from the source, and that the onLoaded signal is emitted only when loading occurs (when the loader is active). Task-number: QTBUG-21710 Change-Id: I2d83603ef84d6942fb84141e9e146d2cf9654fc4 Reviewed-on: http://codereview.qt-project.org/5915 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-10-06 04:37:09 +00:00
QCOMPARE(object->property("success").toBool(), true);
}
// check that the component is loaded if active is not set (true by default)
{
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("active.8.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
QSGLoader shouldn't load component when active is false Previously, QSGLoader still loaded the component specified, but didn't instantiate the item. This commit ensures that no component is loaded from the source, and that the onLoaded signal is emitted only when loading occurs (when the loader is active). Task-number: QTBUG-21710 Change-Id: I2d83603ef84d6942fb84141e9e146d2cf9654fc4 Reviewed-on: http://codereview.qt-project.org/5915 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-10-06 04:37:09 +00:00
QCOMPARE(object->property("success").toBool(), true);
}
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::initialPropertyValues_data()
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
{
QTest::addColumn<QUrl>("qmlFile");
QTest::addColumn<QStringList>("expectedWarnings");
QTest::addColumn<QStringList>("propertyNames");
QTest::addColumn<QVariantList>("propertyValues");
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("source url with value set in onLoaded, initially active = true") << testFileUrl("initialPropertyValues.1.qml")
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
<< QStringList()
<< (QStringList() << "initialValue" << "behaviorCount")
<< (QVariantList() << 1 << 1);
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("set source with initial property values specified, active = true") << testFileUrl("initialPropertyValues.2.qml")
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
<< QStringList()
<< (QStringList() << "initialValue" << "behaviorCount")
<< (QVariantList() << 2 << 0);
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("set source with initial property values specified, active = false") << testFileUrl("initialPropertyValues.3.qml")
Windows: Fix file URL issues in declarative autotests Fixed by using testFileUrl() shared utility function where appropriate instead of testFile() or various other ways file URLs were being incorrectly used. Task-number: QTBUG-24779 Change-Id: I48cbd297d419238f42ea45132344b7e5a487b6f1 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2012-03-14 14:42:58 +00:00
<< (QStringList() << QString(testFileUrl("initialPropertyValues.3.qml").toString() + QLatin1String(":16: TypeError: Cannot read property 'canary' of null")))
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
<< (QStringList())
<< (QVariantList());
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("set source with initial property values specified, active = false, with active set true later") << testFileUrl("initialPropertyValues.4.qml")
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
<< QStringList()
<< (QStringList() << "initialValue" << "behaviorCount")
<< (QVariantList() << 4 << 0);
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("set source without initial property values specified, active = true") << testFileUrl("initialPropertyValues.5.qml")
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
<< QStringList()
<< (QStringList() << "initialValue" << "behaviorCount")
<< (QVariantList() << 0 << 0);
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("set source with initial property values specified with binding, active = true") << testFileUrl("initialPropertyValues.6.qml")
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
<< QStringList()
<< (QStringList() << "initialValue" << "behaviorCount")
<< (QVariantList() << 6 << 0);
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("ensure initial property value semantics mimic createObject") << testFileUrl("initialPropertyValues.7.qml")
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
<< QStringList()
<< (QStringList() << "loaderValue" << "createObjectValue")
<< (QVariantList() << 1 << 1);
Fix v8 handle management in QSGLoader Previously, setting the source to a remote url and specified some initial property values while active was false, and then setting active to true, would cause undefined behaviour. This commit ensures that the handles are managed correctly, and that an appropriate v8 context exists during object creation with initial property values specified. Task-number: QTBUG-21868 Change-Id: I101c6546537aa05aaeb420195aca670bc71f31e1 Reviewed-on: http://codereview.qt-project.org/6109 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-06 06:29:52 +00:00
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("ensure initial property values aren't disposed prior to component completion") << testFileUrl("initialPropertyValues.8.qml")
Fix v8 handle management in QSGLoader Previously, setting the source to a remote url and specified some initial property values while active was false, and then setting active to true, would cause undefined behaviour. This commit ensures that the handles are managed correctly, and that an appropriate v8 context exists during object creation with initial property values specified. Task-number: QTBUG-21868 Change-Id: I101c6546537aa05aaeb420195aca670bc71f31e1 Reviewed-on: http://codereview.qt-project.org/6109 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-06 06:29:52 +00:00
<< QStringList()
<< (QStringList() << "initialValue")
<< (QVariantList() << 6);
Introduce required properties to QML [ChangeLog][QtQml] "required" is now a (contextual) keyword in QML, and users can mark properties with it to specify that those properties must be set when the component gets instantiated. This can be done either declaratively via standard property bindings from QML, or imperatively by using the functions to set initial properties (QQmlCompoent::setInitalProperties and related functions in C++, Qt.createObject, Loader.setSource,... in QML/JS). Logic has been added to QQmlComponent::create and the various QQmlIncubator classes to verify that the required properties were set. If properties marked as required are not set, a warning will be printed at runtime, and the component will not be created. Change-Id: I8e38227fc8f173b053b689c1597dc7fd40e835e7 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-09-05 11:03:59 +00:00
QTest::newRow("ensure required properties are set correctly") << testFileUrl("initialPropertyValues.9.qml")
<< QStringList()
<< (QStringList() << "i" << "s")
<< (QVariantList() << 42 << QLatin1String("hello world"));
QTest::newRow("required properties only partially set =") << testFileUrl("initialPropertyValues.10.qml")
<< (QStringList() << QString(testFileUrl("RequiredPropertyValuesComponent.qml").toString() + QLatin1String(":6:5: Required property s was not initialized")))
<< (QStringList() << "i" << "s")
<< (QVariantList() << 0 << QLatin1String(""));
Merge remote-tracking branch 'origin/5.14' into 5.15 Conflicts: tests/auto/qml/qqmlproperty/tst_qqmlproperty.cpp tests/auto/quick/qquickloader/tst_qquickloader.cpp Change-Id: I85fd38cfa00cd60197a1c981bfcc16fcb896cfe9
2019-11-07 06:17:40 +00:00
Loader: Actually clear initial properties when changing source Fixes: QTBUG-79435 Change-Id: Ic99a3b1a9d64426a64117b90a3e11fe99af0d260 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2019-10-23 08:25:23 +00:00
QTest::newRow("source url changed, previously initial properties are discared") << testFileUrl("initialPropertyValues.11.qml")
<< QStringList()
<< (QStringList() << "oldi" << "i")
<< (QVariantList() << 12 << 42);
QQuickLoader: prevent clearing initial properties after active = true After commit b6d88c73, we implement the method [disposeInitialPropertyValues] and clear the cache of initial properties actually. Since we also call this method after source loaded, it will cause loss of initial properties after active = true. Fixes: QTBUG-83895 Change-Id: Iaa500fff14dcaad79a9e68dcbac9f65fa8720456 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Simon Hausmann <hausmann@gmail.com>
2020-05-04 03:09:13 +00:00
QTest::newRow("ensure initial properties aren't disposed after active = true") << testFileUrl("initialPropertyValues.12.qml")
<< QStringList()
<< (QStringList() << "i")
<< (QVariantList() << 12);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::initialPropertyValues()
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
{
QFETCH(QUrl, qmlFile);
QFETCH(QStringList, expectedWarnings);
QFETCH(QStringList, propertyNames);
QFETCH(QVariantList, propertyValues);
Provide a threaded TestHTTPServer This allows us to do blocking operations that interact with the test server in the main thread. The threaded server is used in tests that don't explicitly require asynchronous operation. Change-Id: Ibcb28e79a1114cb9cfb812e86aae0a1af71c569e Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-25 08:30:59 +00:00
ThreadedTestHTTPServer server(dataDirectory());
Fix v8 handle management in QSGLoader Previously, setting the source to a remote url and specified some initial property values while active was false, and then setting active to true, would cause undefined behaviour. This commit ensures that the handles are managed correctly, and that an appropriate v8 context exists during object creation with initial property values specified. Task-number: QTBUG-21868 Change-Id: I101c6546537aa05aaeb420195aca670bc71f31e1 Reviewed-on: http://codereview.qt-project.org/6109 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-06 06:29:52 +00:00
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
foreach (const QString &warning, expectedWarnings)
Change uses of {to,from}Ascii to {to,from}Latin1 This operation should be a no-op anyway, since at this point in time, the fromAscii and toAscii functions simply call their fromLatin1 and toLatin1 counterparts. Task-number: QTBUG-21872 Change-Id: I03084595ddc425a988374b8352fd23e9504ffba6 Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-05-03 12:42:53 +00:00
QTest::ignoreMessage(QtWarningMsg, warning.toLatin1().constData());
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, qmlFile);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.beginCreate(engine.rootContext()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Prospective fix for flakey "network" related QML tests Replace hard-coded server ports with dynamically allocated ports. Change-Id: Iab8f9a88343a9f2c49af3cd700c954c13c3bf121 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
2015-04-22 15:15:30 +00:00
const int serverBaseUrlPropertyIndex = object->metaObject()->indexOfProperty("serverBaseUrl");
if (serverBaseUrlPropertyIndex != -1) {
QMetaProperty prop = object->metaObject()->property(serverBaseUrlPropertyIndex);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QVERIFY(prop.write(object.data(), server.baseUrl().toString()));
Prospective fix for flakey "network" related QML tests Replace hard-coded server ports with dynamically allocated ports. Change-Id: Iab8f9a88343a9f2c49af3cd700c954c13c3bf121 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
2015-04-22 15:15:30 +00:00
}
component.completeCreate();
Stabilize Loader test. Wait for Loader to load its item, rather than using a fixed timeout value. Change-Id: I97ee56d0d7161c9c71a5524f108b0f56d92cc3f3 Reviewed-by: Matthew Vogt <matthew.vogt@nokia.com>
2012-07-10 03:10:28 +00:00
if (expectedWarnings.isEmpty()) {
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
QTRY_VERIFY(loader->item());
}
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
for (int i = 0; i < propertyNames.size(); ++i)
Change uses of {to,from}Ascii to {to,from}Latin1 This operation should be a no-op anyway, since at this point in time, the fromAscii and toAscii functions simply call their fromLatin1 and toLatin1 counterparts. Task-number: QTBUG-21872 Change-Id: I03084595ddc425a988374b8352fd23e9504ffba6 Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-05-03 12:42:53 +00:00
QCOMPARE(object->property(propertyNames.at(i).toLatin1().constData()), propertyValues.at(i));
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::initialPropertyValuesBinding()
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("initialPropertyValues.binding.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QVERIFY(object->setProperty("bindable", QVariant(8)));
QCOMPARE(object->property("canaryValue").toInt(), 8);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::initialPropertyValuesError_data()
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
{
QTest::addColumn<QUrl>("qmlFile");
QTest::addColumn<QStringList>("expectedWarnings");
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("invalid initial property values object") << testFileUrl("initialPropertyValues.error.1.qml")
<< (QStringList() << QString(testFileUrl("initialPropertyValues.error.1.qml").toString() + ":6:5: QML Loader: setSource: value is not an object"));
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("nonexistent source url") << testFileUrl("initialPropertyValues.error.2.qml")
Clean up file/error handling in the type loader Fold the functionality of reading QFile contents via QQmlFile into QQmlDataBlob::Data. This reduces the dependency on QQmlFile - which is scheduled for removal - and it makes it possible in the future to avoid reading the file altogether if we have a cached compilation unit on disk. Change-Id: Ieeaf52b6fb1d25665cd3c3b196819e25aba3dd15 Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2016-06-17 11:21:07 +00:00
<< (QStringList() << QString(testFileUrl("NonexistentSourceComponent.qml").toString() + ": No such file or directory"));
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("invalid source url") << testFileUrl("initialPropertyValues.error.3.qml")
Adjust expected error message to new parser The new QML/JS parser does sometimes give slightly different error messages. Change-Id: I7fbec77214df2830d5965d8959874b51a410694a Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-05-01 16:06:52 +00:00
<< (QStringList() << QString(testFileUrl("InvalidSourceComponent.qml").toString() + ":5:1: Expected token `:'"));
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("invalid initial property values object with invalid property access") << testFileUrl("initialPropertyValues.error.4.qml")
<< (QStringList() << QString(testFileUrl("initialPropertyValues.error.4.qml").toString() + ":7:5: QML Loader: setSource: value is not an object")
<< QString(testFileUrl("initialPropertyValues.error.4.qml").toString() + ":5: TypeError: Cannot read property 'canary' of null"));
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::initialPropertyValuesError()
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
{
QFETCH(QUrl, qmlFile);
QFETCH(QStringList, expectedWarnings);
foreach (const QString &warning, expectedWarnings)
QTest::ignoreMessage(QtWarningMsg, warning.toUtf8().constData());
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, qmlFile);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> object(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(object != nullptr);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = object->findChild<QQuickLoader*>("loader");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
Allow initial property values to be defined with QSGLoader This commit adds an "active" property to QSGLoader, which can be used to delay instantiation of the item until the user wishes to activate the loader. The property is true by default in order to maintain compatibility with previous behaviour. The commit also adds a "setSource(v8object)" function to QSGLoader, which behaves identically to setSource() property mutator except that it takes a JavaScript object parameter which defines the initial property values of the item (in a manner similar to that of QDeclarativeComponent::createObject()). Task-number: QTBUG-17009 Change-Id: Ifd824b518b60ef7aa3017c384835abb552e65cf1 Reviewed-on: http://codereview.qt.nokia.com/3364 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2011-08-17 07:46:54 +00:00
}
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
// QTBUG-9241
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::deleteComponentCrash()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("crash.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
item->metaObject()->invokeMethod(item.data(), "setLoaderSource");
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = qobject_cast<QQuickLoader*>(item->QQuickItem::childItems().at(0));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader);
QVERIFY(loader->item());
QCOMPARE(loader->item()->objectName(), QLatin1String("blue"));
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Ready);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QCoreApplication::sendPostedEvents(nullptr, QEvent::DeferredDelete);
Fixed compile. QEventLoop::DeferredDeletion was deprecated long ago, and finally has been removed. Replace it with QCoreApplication::sendPostedEvents(0, QEvent::DeferredDelete) Change-Id: Ic03f26a57efeb35aefab67a913f56001303aa3e4 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-01-24 00:30:57 +00:00
QCoreApplication::processEvents();
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QTRY_COMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
Do not resolve URLs when assigning them to a property We don't know in advance if a URL is part of the source code and should be relative to the current element, or if it is part of the application data and should not be touched. [ChangeLog][QtQml][Important Behavior Changes] URLs are not resolved or intercepted anymore when assigning them to a "url" property. Instead they are resolved and possibly intercepted when used to access an actual resource. Fixes: QTBUG-76879 Change-Id: Iaa2385aff2c13aa71a12e57385d9afb5dc60a073 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-06-15 15:53:16 +00:00
QCOMPARE(loader->source(), QUrl("BlueRect.qml"));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::nonItem()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("nonItem.qml"));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader);
Allow Loader to load non-Item types. Loader has a more convenient API for loading/unloading components than the dynamic object creation APIs. Remove the Item-only restriction. Change-Id: I6f9ecc8514ff1e814f7e56a3386814ba211b7e4f Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-06-12 00:16:47 +00:00
QVERIFY(loader->item());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(loader.data(), loader->item()->parent());
Allow Loader to load non-Item types. Loader has a more convenient API for loading/unloading components than the dynamic object creation APIs. Remove the Item-only restriction. Change-Id: I6f9ecc8514ff1e814f7e56a3386814ba211b7e4f Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-06-12 00:16:47 +00:00
QPointer<QObject> item = loader->item();
loader->setActive(false);
QVERIFY(!loader->item());
QTRY_VERIFY(!item);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::vmeErrors()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("vmeErrors.qml"));
Add a column to the default method error message This brings both compilers in sync by reporting line and column if doing a signal object assignment without a default method. Change-Id: I8b1bf90c4ce3cd7b117ad7eecdbfe319b07b1191 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
2014-02-26 17:43:28 +00:00
QString err = testFileUrl("VmeError.qml").toString() + ":6:26: Cannot assign object type QObject with no default method";
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QTest::ignoreMessage(QtWarningMsg, err.toLatin1().constData());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(loader);
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QVERIFY(!loader->item());
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
// QTBUG-13481
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::creationContext()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("creationContext.qml"));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> o(component.create());
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(o != nullptr);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QCOMPARE(o->property("test").toBool(), true);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::QTBUG_16928()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("QTBUG_16928.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
QCOMPARE(item->width(), 250.);
QCOMPARE(item->height(), 250.);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::implicitSize()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("implicitSize.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
QCOMPARE(item->width(), 150.);
QCOMPARE(item->height(), 150.);
QCOMPARE(item->property("implHeight").toReal(), 100.);
QCOMPARE(item->property("implWidth").toReal(), 100.);
Size loaded item before bindings are evaluated If the Loader size is set explicitly we can set the item size before the bindings are run, and avoiding an additional anchor layout. Also ensure item implict size changes are propagated/notified in the Loader. Change-Id: Ie22b018b22be8457ccf30b907a26e44260b9cef7 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-03-30 00:48:50 +00:00
QQuickLoader *loader = item->findChild<QQuickLoader*>("loader");
QSignalSpy implWidthSpy(loader, SIGNAL(implicitWidthChanged()));
QSignalSpy implHeightSpy(loader, SIGNAL(implicitHeightChanged()));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(item.data(), "changeImplicitSize");
Size loaded item before bindings are evaluated If the Loader size is set explicitly we can set the item size before the bindings are run, and avoiding an additional anchor layout. Also ensure item implict size changes are propagated/notified in the Loader. Change-Id: Ie22b018b22be8457ccf30b907a26e44260b9cef7 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
2012-03-30 00:48:50 +00:00
QCOMPARE(loader->property("implicitWidth").toReal(), 200.);
QCOMPARE(loader->property("implicitHeight").toReal(), 300.);
QCOMPARE(implWidthSpy.count(), 1);
QCOMPARE(implHeightSpy.count(), 1);
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::QTBUG_17114()
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("QTBUG_17114.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> item(qobject_cast<QQuickItem*>(component.create()));
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
QVERIFY(item);
QCOMPARE(item->property("loaderWidth").toReal(), 32.);
QCOMPARE(item->property("loaderHeight").toReal(), 32.);
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::asynchronous_data()
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
{
QTest::addColumn<QUrl>("qmlFile");
QTest::addColumn<QStringList>("expectedWarnings");
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("Valid component") << testFileUrl("BigComponent.qml")
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
<< QStringList();
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QTest::newRow("Non-existent component") << testFileUrl("IDoNotExist.qml")
Clean up file/error handling in the type loader Fold the functionality of reading QFile contents via QQmlFile into QQmlDataBlob::Data. This reduces the dependency on QQmlFile - which is scheduled for removal - and it makes it possible in the future to avoid reading the file altogether if we have a cached compilation unit on disk. Change-Id: Ieeaf52b6fb1d25665cd3c3b196819e25aba3dd15 Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2016-06-17 11:21:07 +00:00
<< (QStringList() << QString(testFileUrl("IDoNotExist.qml").toString() + ": No such file or directory"));
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QDeclarative tests: Introduce base class for data tests. In tests/auto/shared/util.* replace macros/find functions by a base class QDeclarativeDataTest with accessors for the data directory helper functions to create URLs from it. The class relies on QFINDTESTDATA, which is the standard way of locating test data. Using the class should reduce the number of calls to QFileInfo.exists(), etc significantly. In addition, provide utility functions for messages. Reviewed-by: Michael Brasser <michael.brasser@nokia.com> Change-Id: Id2beacb157922ee9412f9e45cf9695cec1f8379a Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-12-21 08:06:26 +00:00
QTest::newRow("Invalid component") << testFileUrl("InvalidSourceComponent.qml")
Adjust expected error message to new parser The new QML/JS parser does sometimes give slightly different error messages. Change-Id: I7fbec77214df2830d5965d8959874b51a410694a Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-05-01 16:06:52 +00:00
<< (QStringList() << QString(testFileUrl("InvalidSourceComponent.qml").toString() + ":5:1: Expected token `:'"));
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::asynchronous()
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
{
QFETCH(QUrl, qmlFile);
QFETCH(QStringList, expectedWarnings);
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Stabilize tst_qquickloader test case Ensure cases are not affected by timer events of incubation controllers created in previous cases. Change-Id: Ia633ed142242d000de5f497896a685ca2f26e143 Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-07-30 01:10:28 +00:00
PeriodicIncubationController *controller = new PeriodicIncubationController;
QQmlIncubationController *previous = engine.incubationController();
engine.setIncubationController(controller);
delete previous;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("asynchronous.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> root(qobject_cast<QQuickItem*>(component.create()));
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(root);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = root->findChild<QQuickLoader*>("loader");
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(loader);
foreach (const QString &warning, expectedWarnings)
QTest::ignoreMessage(QtWarningMsg, warning.toUtf8().constData());
QVERIFY(!loader->item());
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QCOMPARE(loader->progress(), 0.0);
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
root->setProperty("comp", qmlFile.toString());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "loadComponent");
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(!loader->item());
if (expectedWarnings.isEmpty()) {
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Loading);
Stabilize tst_qquickloader test case Ensure cases are not affected by timer events of incubation controllers created in previous cases. Change-Id: Ia633ed142242d000de5f497896a685ca2f26e143 Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-07-30 01:10:28 +00:00
controller->start();
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QVERIFY(!controller->incubated); // asynchronous compilation means not immediately compiled/incubating.
QTRY_VERIFY(controller->incubated); // but should start incubating once compilation is complete.
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QTRY_VERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Ready);
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
} else {
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QTRY_COMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QTRY_COMPARE(loader->status(), QQuickLoader::Error);
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
}
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
void tst_QQuickLoader::asynchronous_clear()
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Stabilize tst_qquickloader test case Ensure cases are not affected by timer events of incubation controllers created in previous cases. Change-Id: Ia633ed142242d000de5f497896a685ca2f26e143 Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-07-30 01:10:28 +00:00
PeriodicIncubationController *controller = new PeriodicIncubationController;
QQmlIncubationController *previous = engine.incubationController();
engine.setIncubationController(controller);
delete previous;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("asynchronous.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> root(qobject_cast<QQuickItem*>(component.create()));
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(root);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QQuickLoader *loader = root->findChild<QQuickLoader*>("loader");
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(loader);
QVERIFY(!loader->item());
root->setProperty("comp", "BigComponent.qml");
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "loadComponent");
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(!loader->item());
Stabilize tst_qquickloader test case Ensure cases are not affected by timer events of incubation controllers created in previous cases. Change-Id: Ia633ed142242d000de5f497896a685ca2f26e143 Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-07-30 01:10:28 +00:00
controller->start();
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Loading);
Loader could leak qml contexts if interrupted If Loader was either destroyed, or its source changed while it was incubating the itemContext could be leaked. Change-Id: I5b749062552954d92bf2851250f942b20ebbfe68 Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-20 01:58:09 +00:00
QTRY_COMPARE(engine.incubationController()->incubatingObjectCount(), 1);
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
// clear before component created
root->setProperty("comp", "");
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "loadComponent");
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(!loader->item());
QCOMPARE(engine.incubationController()->incubatingObjectCount(), 0);
QCOMPARE(loader->progress(), 0.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Null);
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 0);
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
// check loading component
Loader could leak qml contexts if interrupted If Loader was either destroyed, or its source changed while it was incubating the itemContext could be leaked. Change-Id: I5b749062552954d92bf2851250f942b20ebbfe68 Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
2012-03-20 01:58:09 +00:00
root->setProperty("comp", "BigComponent.qml");
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "loadComponent");
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QVERIFY(!loader->item());
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Loading);
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
QCOMPARE(engine.incubationController()->incubatingObjectCount(), 1);
QTRY_VERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QCOMPARE(loader->status(), QQuickLoader::Ready);
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
}
void tst_QQuickLoader::simultaneousSyncAsync()
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Stabilize tst_qquickloader test case Ensure cases are not affected by timer events of incubation controllers created in previous cases. Change-Id: Ia633ed142242d000de5f497896a685ca2f26e143 Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-07-30 01:10:28 +00:00
PeriodicIncubationController *controller = new PeriodicIncubationController;
QQmlIncubationController *previous = engine.incubationController();
engine.setIncubationController(controller);
delete previous;
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QQmlComponent component(&engine, testFileUrl("simultaneous.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> root(qobject_cast<QQuickItem*>(component.create()));
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QVERIFY(root);
QQuickLoader *asyncLoader = root->findChild<QQuickLoader*>("asyncLoader");
QQuickLoader *syncLoader = root->findChild<QQuickLoader*>("syncLoader");
QVERIFY(asyncLoader);
QVERIFY(syncLoader);
QVERIFY(!asyncLoader->item());
QVERIFY(!syncLoader->item());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "loadComponents");
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QVERIFY(!asyncLoader->item());
QVERIFY(syncLoader->item());
Stabilize tst_qquickloader test case Ensure cases are not affected by timer events of incubation controllers created in previous cases. Change-Id: Ia633ed142242d000de5f497896a685ca2f26e143 Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-07-30 01:10:28 +00:00
controller->start();
Allow threaded compilation in an async Loader Enables threaded compilation for a Loader "source". Change-Id: I2d60a3ace07aab58f3b8f069e45a2864178c959f Reviewed-by: Chris Adams <christopher.adams@nokia.com>
2012-03-06 08:03:33 +00:00
QCOMPARE(asyncLoader->status(), QQuickLoader::Loading);
QVERIFY(!controller->incubated); // asynchronous compilation means not immediately compiled/incubating.
QTRY_VERIFY(controller->incubated); // but should start incubating once compilation is complete.
QTRY_VERIFY(asyncLoader->item());
QCOMPARE(asyncLoader->progress(), 1.0);
QCOMPARE(asyncLoader->status(), QQuickLoader::Ready);
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
}
Allow forced completion of asynchronous Loader. Setting Loader::asynchronous from true to false will attempt to force complete any operations in progress. This allows the user to begin loading something in the background, and then force the load to complete once the Loader's content must be viewed. Change-Id: I056dcc20faacb38b3529c967245416da9949e64a Task-number: QTBUG-29789 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-07 21:29:55 +00:00
void tst_QQuickLoader::asyncToSync1()
{
QQmlEngine engine;
PeriodicIncubationController *controller = new PeriodicIncubationController;
QQmlIncubationController *previous = engine.incubationController();
engine.setIncubationController(controller);
delete previous;
QQmlComponent component(&engine, testFileUrl("asynchronous.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> root(qobject_cast<QQuickItem*>(component.create()));
Allow forced completion of asynchronous Loader. Setting Loader::asynchronous from true to false will attempt to force complete any operations in progress. This allows the user to begin loading something in the background, and then force the load to complete once the Loader's content must be viewed. Change-Id: I056dcc20faacb38b3529c967245416da9949e64a Task-number: QTBUG-29789 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-07 21:29:55 +00:00
QVERIFY(root);
QQuickLoader *loader = root->findChild<QQuickLoader*>("loader");
QVERIFY(loader);
QVERIFY(!loader->item());
root->setProperty("comp", "BigComponent.qml");
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "loadComponent");
Allow forced completion of asynchronous Loader. Setting Loader::asynchronous from true to false will attempt to force complete any operations in progress. This allows the user to begin loading something in the background, and then force the load to complete once the Loader's content must be viewed. Change-Id: I056dcc20faacb38b3529c967245416da9949e64a Task-number: QTBUG-29789 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-07 21:29:55 +00:00
QVERIFY(!loader->item());
controller->start();
QCOMPARE(loader->status(), QQuickLoader::Loading);
QCOMPARE(engine.incubationController()->incubatingObjectCount(), 0);
// force completion before component created
loader->setAsynchronous(false);
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
QCOMPARE(loader->status(), QQuickLoader::Ready);
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
}
void tst_QQuickLoader::asyncToSync2()
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Allow forced completion of asynchronous Loader. Setting Loader::asynchronous from true to false will attempt to force complete any operations in progress. This allows the user to begin loading something in the background, and then force the load to complete once the Loader's content must be viewed. Change-Id: I056dcc20faacb38b3529c967245416da9949e64a Task-number: QTBUG-29789 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-07 21:29:55 +00:00
PeriodicIncubationController *controller = new PeriodicIncubationController;
QQmlIncubationController *previous = engine.incubationController();
engine.setIncubationController(controller);
delete previous;
QQmlComponent component(&engine, testFileUrl("asynchronous.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> root(qobject_cast<QQuickItem*>(component.create()));
Allow forced completion of asynchronous Loader. Setting Loader::asynchronous from true to false will attempt to force complete any operations in progress. This allows the user to begin loading something in the background, and then force the load to complete once the Loader's content must be viewed. Change-Id: I056dcc20faacb38b3529c967245416da9949e64a Task-number: QTBUG-29789 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-07 21:29:55 +00:00
QVERIFY(root);
QQuickLoader *loader = root->findChild<QQuickLoader*>("loader");
QVERIFY(loader);
QVERIFY(!loader->item());
root->setProperty("comp", "BigComponent.qml");
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "loadComponent");
Allow forced completion of asynchronous Loader. Setting Loader::asynchronous from true to false will attempt to force complete any operations in progress. This allows the user to begin loading something in the background, and then force the load to complete once the Loader's content must be viewed. Change-Id: I056dcc20faacb38b3529c967245416da9949e64a Task-number: QTBUG-29789 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
2015-09-07 21:29:55 +00:00
QVERIFY(!loader->item());
controller->start();
QCOMPARE(loader->status(), QQuickLoader::Loading);
QTRY_COMPARE(engine.incubationController()->incubatingObjectCount(), 1);
// force completion after component created but before incubation complete
loader->setAsynchronous(false);
QVERIFY(loader->item());
QCOMPARE(loader->progress(), 1.0);
QCOMPARE(loader->status(), QQuickLoader::Ready);
QCOMPARE(static_cast<QQuickItem*>(loader)->childItems().count(), 1);
}
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
void tst_QQuickLoader::loadedSignal()
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Improve timer dependent tests. tst_QQuickLoader::loadedSignal depended on sharing the engine with simultaneousSyncAsync and that function being run before it. After each test run call clearComponentCache() as that is important for caching of the network tests. The test server would send the item after 500ms. Sometimes the CI would be faster or slower. Instead of relying on timing, simply call a function when the reply should be sent. Change-Id: Ifb0447041197e1cba103570597a62a2510d31aab Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-03-06 17:47:17 +00:00
PeriodicIncubationController *controller = new PeriodicIncubationController;
QQmlIncubationController *previous = engine.incubationController();
engine.setIncubationController(controller);
delete previous;
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
{
// ensure that triggering loading (by setting active = true)
// and then immediately setting active to false, causes the
// loader to be deactivated, including disabling the incubator.
QQmlComponent component(&engine, testFileUrl("loadedSignal.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> obj(component.create());
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(obj.data(), "triggerLoading");
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
QTest::qWait(100); // ensure that loading would have finished if it wasn't deactivated
QCOMPARE(obj->property("loadCount").toInt(), 0);
QVERIFY(obj->property("success").toBool());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(obj.data(), "triggerLoading");
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
QTest::qWait(100);
QCOMPARE(obj->property("loadCount").toInt(), 0);
QVERIFY(obj->property("success").toBool());
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(obj.data(), "triggerMultipleLoad");
Improve timer dependent tests. tst_QQuickLoader::loadedSignal depended on sharing the engine with simultaneousSyncAsync and that function being run before it. After each test run call clearComponentCache() as that is important for caching of the network tests. The test server would send the item after 500ms. Sometimes the CI would be faster or slower. Instead of relying on timing, simply call a function when the reply should be sent. Change-Id: Ifb0447041197e1cba103570597a62a2510d31aab Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-03-06 17:47:17 +00:00
controller->start();
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
QTest::qWait(100);
Improve timer dependent tests. tst_QQuickLoader::loadedSignal depended on sharing the engine with simultaneousSyncAsync and that function being run before it. After each test run call clearComponentCache() as that is important for caching of the network tests. The test server would send the item after 500ms. Sometimes the CI would be faster or slower. Instead of relying on timing, simply call a function when the reply should be sent. Change-Id: Ifb0447041197e1cba103570597a62a2510d31aab Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
2013-03-06 17:47:17 +00:00
QTRY_COMPARE(obj->property("loadCount").toInt(), 1); // only one loaded signal should be emitted.
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
QVERIFY(obj->property("success").toBool());
}
{
// ensure that an error doesn't result in the onLoaded signal being emitted.
QQmlComponent component(&engine, testFileUrl("loadedSignal.2.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QObject> obj(component.create());
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(obj.data(), "triggerLoading");
Fix erroneous signal emission in Loader Previously, the incubator wasn't cleared when a Loader was deactivated. This commit clears it on deactivate, and also ensures that the loadedSignal isn't emitted on error. Finally, it re-enables a network-loading-related unit test. Change-Id: I5dac92aead2c221c5d45011accf59077f7c9b402 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-03-29 01:14:59 +00:00
QTest::qWait(100);
QCOMPARE(obj->property("loadCount").toInt(), 0);
QVERIFY(obj->property("success").toBool());
}
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
}
tst_qquickloader: Test setting source from component works Not verifying this works before has caused regressions. Change-Id: I4b99928bb6993d511349aec782660d24a134f67d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-10-30 10:35:00 +00:00
void tst_QQuickLoader::selfSetSource()
{
QQmlEngine engine;
QQmlComponent component(&engine, testFileUrl("selfSetSourceTest.qml"));
QScopedPointer<QObject> obj(component.create());
QVERIFY(obj);
QTRY_COMPARE(obj->property("source").toUrl(), testFileUrl("empty.qml"));
}
autotest for setting parent in a component created by Loader. Change-Id: I1b6850ce5e4a820b5ab7b2d06a877307104478a1 Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2011-11-14 03:00:31 +00:00
void tst_QQuickLoader::parented()
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("parented.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> root(qobject_cast<QQuickItem*>(component.create()));
autotest for setting parent in a component created by Loader. Change-Id: I1b6850ce5e4a820b5ab7b2d06a877307104478a1 Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2011-11-14 03:00:31 +00:00
QVERIFY(root);
QQuickItem *item = root->findChild<QQuickItem*>("comp");
QVERIFY(item);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QCOMPARE(item->parentItem(), root.data());
autotest for setting parent in a component created by Loader. Change-Id: I1b6850ce5e4a820b5ab7b2d06a877307104478a1 Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2011-11-14 03:00:31 +00:00
QCOMPARE(item->width(), 300.);
QCOMPARE(item->height(), 300.);
}
Allow binding the size of a Loader to its item. If the size of the Loader is bound to the item, the item was resized before the binding was evaluated, resulting in an item height of 0. This change allows bindings to the item to be evaluated before we apply the resize logic. Task-number: QTBUG-22628 Change-Id: I30acdb54214b422a9d4aa4e7e02a0af3674322db Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-02-16 03:45:02 +00:00
void tst_QQuickLoader::sizeBound()
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Rename QDeclarative symbols to QQuick and QQml Symbols beginning with QDeclarative are already exported by the quick1 module. Users can apply the bin/rename-qtdeclarative-symbols.sh script to modify client code using the previous names of the renamed symbols. Task-number: QTBUG-23737 Change-Id: Ifaa482663767634931e8711a8e9bf6e404859e66 Reviewed-by: Martin Jones <martin.jones@nokia.com>
2012-02-16 04:43:03 +00:00
QQmlComponent component(&engine, testFileUrl("sizebound.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickItem> root(qobject_cast<QQuickItem*>(component.create()));
Allow binding the size of a Loader to its item. If the size of the Loader is bound to the item, the item was resized before the binding was evaluated, resulting in an item height of 0. This change allows bindings to the item to be evaluated before we apply the resize logic. Task-number: QTBUG-22628 Change-Id: I30acdb54214b422a9d4aa4e7e02a0af3674322db Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-02-16 03:45:02 +00:00
QVERIFY(root);
QQuickLoader *loader = root->findChild<QQuickLoader*>("loader");
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
Allow binding the size of a Loader to its item. If the size of the Loader is bound to the item, the item was resized before the binding was evaluated, resulting in an item height of 0. This change allows bindings to the item to be evaluated before we apply the resize logic. Task-number: QTBUG-22628 Change-Id: I30acdb54214b422a9d4aa4e7e02a0af3674322db Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-02-16 03:45:02 +00:00
QVERIFY(loader->item());
QCOMPARE(loader->width(), 50.0);
QCOMPARE(loader->height(), 60.0);
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QMetaObject::invokeMethod(root.data(), "switchComponent");
Allow binding the size of a Loader to its item. If the size of the Loader is bound to the item, the item was resized before the binding was evaluated, resulting in an item height of 0. This change allows bindings to the item to be evaluated before we apply the resize logic. Task-number: QTBUG-22628 Change-Id: I30acdb54214b422a9d4aa4e7e02a0af3674322db Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
2012-02-16 03:45:02 +00:00
QCOMPARE(loader->width(), 80.0);
QCOMPARE(loader->height(), 90.0);
}
QQuickLoader: fix the recursion guard for size updates Task-number: QTBUG-30183 Change-Id: Ic8720e1e35bf2f349d74d2021dd202849da67852 Reviewed-by: Jan Arve Sæther <jan-arve.saether@digia.com> Reviewed-by: Caroline Chao <caroline.chao@digia.com> Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
2013-03-13 17:31:57 +00:00
void tst_QQuickLoader::QTBUG_30183()
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
QQuickLoader: fix the recursion guard for size updates Task-number: QTBUG-30183 Change-Id: Ic8720e1e35bf2f349d74d2021dd202849da67852 Reviewed-by: Jan Arve Sæther <jan-arve.saether@digia.com> Reviewed-by: Caroline Chao <caroline.chao@digia.com> Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
2013-03-13 17:31:57 +00:00
QQmlComponent component(&engine, testFileUrl("/QTBUG_30183.qml"));
tst_qquickloader: use QScopedPointer instead of manual deletion This helps keep the memory usage down on test machines in case of failed tests, and may also prevent a failed test from interfering with the results of subsequent tests. Change-Id: I4284b068f94ce990e6a0c5a2f12185739dfdf5d7 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:31:24 +00:00
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QVERIFY(loader != nullptr);
QQuickLoader: fix the recursion guard for size updates Task-number: QTBUG-30183 Change-Id: Ic8720e1e35bf2f349d74d2021dd202849da67852 Reviewed-by: Jan Arve Sæther <jan-arve.saether@digia.com> Reviewed-by: Caroline Chao <caroline.chao@digia.com> Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
2013-03-13 17:31:57 +00:00
QCOMPARE(loader->width(), 240.0);
QCOMPARE(loader->height(), 120.0);
// the loaded item must follow the size
QQuickItem *rect = qobject_cast<QQuickItem*>(loader->item());
QVERIFY(rect);
QCOMPARE(rect->width(), 240.0);
QCOMPARE(rect->height(), 120.0);
}
Add "asynchronous" property to Loader. Use an incubator to perform non-blocking instantiation of components. Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c Fixes: QTBUG-21791 Reviewed-on: http://codereview.qt-project.org/6216 Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
2011-10-07 06:20:39 +00:00
If Loader loads Window, set its transient parent to the Loader's window This makes the Item { Loader { sourceComponent: Window { } } } case consistent with the Item { Window { } } case: the inner Window is transient for the outer Window. It works even if the Loader's Window has a visible: true declaration: in that case, until now, the Loader's Window would become visible at component creation time, before the outer Item became visible. So the test to check whether it had a transient parent did not work. We now change the delayed-visibility mechanism in QQuickWindowQmlImpl to wait for the parent Item to acquire a window of its own rather than waiting for the transient-parent-if-any to become visible. It should still take care of all the old cases too, e.g. in the Window { Window { } } case, the inner Window's QObject parent is actually the QQuickRootItem. (Amends 701255c76f671f100338a799f0194bf10e26c9d1) [ChangeLog][QtQuick][QQuickWindow] When a Window is declared inside another Item or Window, the window will not be created until the parent window is created. This allows it to have the correct transientParent and be managed as a transient window. Task-number: QTBUG-52944 Change-Id: Iaf4aafbd696f6e8dd0eec1d02db8bd181483bd07 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-12-15 12:26:28 +00:00
void tst_QQuickLoader::transientWindow() // QTBUG-52944
{
QQuickView view;
view.setSource(testFileUrl("itemLoaderWindow.qml"));
QQuickItem *root = qobject_cast<QQuickItem*>(view.rootObject());
QVERIFY(root);
QQuickLoader *loader = root->findChild<QQuickLoader *>();
QVERIFY(loader);
QTRY_COMPARE(loader->status(), QQuickLoader::Ready);
QQuickWindowQmlImpl *loadedWindow = qobject_cast<QQuickWindowQmlImpl *>(loader->item());
QVERIFY(loadedWindow);
QCOMPARE(loadedWindow->visibility(), QWindow::Hidden);
QElapsedTimer timer;
qint64 viewVisibleTime = -1;
qint64 loadedWindowVisibleTime = -1;
connect(&view, &QWindow::visibleChanged,
[&viewVisibleTime, &timer]() { viewVisibleTime = timer.elapsed(); } );
connect(loadedWindow, &QQuickWindowQmlImpl::visibilityChanged,
[&loadedWindowVisibleTime, &timer]() { loadedWindowVisibleTime = timer.elapsed(); } );
timer.start();
view.show();
tests: Wrap qWaitForWindow{Active,Exposed} in QVERIFY The functions are marked Q_REQUIRED_RESULT, so they give compilation warnings when not handling the bool return value. Failing the test early at an unexpected event is also better behavior anyway. Task-number: QTBUG-66559 Change-Id: I6c4db29379ec01528208c3e4ee54346b4230616c Reviewed-by: Sami Nurmenniemi <sami.nurmenniemi@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-21 08:16:14 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&view));
If Loader loads Window, set its transient parent to the Loader's window This makes the Item { Loader { sourceComponent: Window { } } } case consistent with the Item { Window { } } case: the inner Window is transient for the outer Window. It works even if the Loader's Window has a visible: true declaration: in that case, until now, the Loader's Window would become visible at component creation time, before the outer Item became visible. So the test to check whether it had a transient parent did not work. We now change the delayed-visibility mechanism in QQuickWindowQmlImpl to wait for the parent Item to acquire a window of its own rather than waiting for the transient-parent-if-any to become visible. It should still take care of all the old cases too, e.g. in the Window { Window { } } case, the inner Window's QObject parent is actually the QQuickRootItem. (Amends 701255c76f671f100338a799f0194bf10e26c9d1) [ChangeLog][QtQuick][QQuickWindow] When a Window is declared inside another Item or Window, the window will not be created until the parent window is created. This allows it to have the correct transientParent and be managed as a transient window. Task-number: QTBUG-52944 Change-Id: Iaf4aafbd696f6e8dd0eec1d02db8bd181483bd07 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-12-15 12:26:28 +00:00
QTRY_VERIFY(loadedWindowVisibleTime >= 0);
QVERIFY(viewVisibleTime >= 0);
// now that we're sure they are both visible, which one became visible first?
qCDebug(lcTests) << "transient Window became visible" << (loadedWindowVisibleTime - viewVisibleTime) << "ms after the root Item";
QVERIFY((loadedWindowVisibleTime - viewVisibleTime) >= 0);
QWindowList windows = QGuiApplication::topLevelWindows();
QTRY_COMPARE(windows.size(), 2);
// TODO Ideally we would now close the outer window and make sure the transient window closes too.
// It works during manual testing because of QWindowPrivate::maybeQuitOnLastWindowClosed()
// but quitting an autotest doesn't make sense.
}
void tst_QQuickLoader::nestedTransientWindow() // QTBUG-52944
{
QQuickView view;
view.setSource(testFileUrl("itemLoaderItemWindow.qml"));
QQuickItem *root = qobject_cast<QQuickItem*>(view.rootObject());
QVERIFY(root);
QQuickLoader *loader = root->findChild<QQuickLoader *>();
QVERIFY(loader);
QTRY_COMPARE(loader->status(), QQuickLoader::Ready);
QQuickItem *loadedItem = qobject_cast<QQuickItem *>(loader->item());
QVERIFY(loadedItem);
QQuickWindowQmlImpl *loadedWindow = loadedItem->findChild<QQuickWindowQmlImpl *>();
QVERIFY(loadedWindow);
QCOMPARE(loadedWindow->visibility(), QWindow::Hidden);
QElapsedTimer timer;
qint64 viewVisibleTime = -1;
qint64 loadedWindowVisibleTime = -1;
connect(&view, &QWindow::visibleChanged,
[&viewVisibleTime, &timer]() { viewVisibleTime = timer.elapsed(); } );
connect(loadedWindow, &QQuickWindowQmlImpl::visibilityChanged,
[&loadedWindowVisibleTime, &timer]() { loadedWindowVisibleTime = timer.elapsed(); } );
timer.start();
view.show();
tests: Wrap qWaitForWindow{Active,Exposed} in QVERIFY The functions are marked Q_REQUIRED_RESULT, so they give compilation warnings when not handling the bool return value. Failing the test early at an unexpected event is also better behavior anyway. Task-number: QTBUG-66559 Change-Id: I6c4db29379ec01528208c3e4ee54346b4230616c Reviewed-by: Sami Nurmenniemi <sami.nurmenniemi@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-02-21 08:16:14 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&view));
If Loader loads Window, set its transient parent to the Loader's window This makes the Item { Loader { sourceComponent: Window { } } } case consistent with the Item { Window { } } case: the inner Window is transient for the outer Window. It works even if the Loader's Window has a visible: true declaration: in that case, until now, the Loader's Window would become visible at component creation time, before the outer Item became visible. So the test to check whether it had a transient parent did not work. We now change the delayed-visibility mechanism in QQuickWindowQmlImpl to wait for the parent Item to acquire a window of its own rather than waiting for the transient-parent-if-any to become visible. It should still take care of all the old cases too, e.g. in the Window { Window { } } case, the inner Window's QObject parent is actually the QQuickRootItem. (Amends 701255c76f671f100338a799f0194bf10e26c9d1) [ChangeLog][QtQuick][QQuickWindow] When a Window is declared inside another Item or Window, the window will not be created until the parent window is created. This allows it to have the correct transientParent and be managed as a transient window. Task-number: QTBUG-52944 Change-Id: Iaf4aafbd696f6e8dd0eec1d02db8bd181483bd07 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-12-15 12:26:28 +00:00
QTRY_VERIFY(loadedWindowVisibleTime >= 0);
QVERIFY(viewVisibleTime >= 0);
// now that we're sure they are both visible, which one became visible first?
qCDebug(lcTests) << "transient Window became visible" << (loadedWindowVisibleTime - viewVisibleTime) << "ms after the root Item";
QVERIFY((loadedWindowVisibleTime - viewVisibleTime) >= 0);
QWindowList windows = QGuiApplication::topLevelWindows();
QTRY_COMPARE(windows.size(), 2);
// TODO Ideally we would now close the outer window and make sure the transient window closes too.
// It works during manual testing because of QWindowPrivate::maybeQuitOnLastWindowClosed()
// but quitting an autotest doesn't make sense.
}
Fix crash in QQuickLoader when source component is garbage collected It may happen that the QQuickLoader is the last entity left in the system holding a reference to the QQmlComponent *sourceComponent. We have to let the garbage collector know about that by keeping a persistent value for it. Task-number: QTBUG-35334 Change-Id: I715864440378fd9dd4f2d5ef8ff2f171c81ed7ef Reviewed-by: Lars Knoll <lars.knoll@digia.com>
2013-12-05 15:21:03 +00:00
void tst_QQuickLoader::sourceComponentGarbageCollection()
{
tst_qquickloader: use local engines instead of one global engine Reusing the same engine was causing new tests that I was going to add to pass unexpectedly. By using one engine per test, we also make warnings like QWARN : tst_QQuickLoader::loadedSignal() "There are still \"1\" items in the process of being created at engine destruction." show up at the end of the test that caused them, rather than after the entire testcase has finished, which should make fixing the warnings easier. Change-Id: I821d4feb74e7e837177c9463c65936f90b3b20d8 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
2017-12-22 10:06:13 +00:00
QQmlEngine engine;
Fix crash in QQuickLoader when source component is garbage collected It may happen that the QQuickLoader is the last entity left in the system holding a reference to the QQmlComponent *sourceComponent. We have to let the garbage collector know about that by keeping a persistent value for it. Task-number: QTBUG-35334 Change-Id: I715864440378fd9dd4f2d5ef8ff2f171c81ed7ef Reviewed-by: Lars Knoll <lars.knoll@digia.com>
2013-12-05 15:21:03 +00:00
QQmlComponent component(&engine, testFileUrl("sourceComponentGarbageCollection.qml"));
QScopedPointer<QObject> obj(component.create());
QVERIFY(!obj.isNull());
QMetaObject::invokeMethod(obj.data(), "setSourceComponent");
engine.collectGarbage();
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QCoreApplication::sendPostedEvents(nullptr, QEvent::DeferredDelete);
Fix crash in QQuickLoader when source component is garbage collected It may happen that the QQuickLoader is the last entity left in the system holding a reference to the QQmlComponent *sourceComponent. We have to let the garbage collector know about that by keeping a persistent value for it. Task-number: QTBUG-35334 Change-Id: I715864440378fd9dd4f2d5ef8ff2f171c81ed7ef Reviewed-by: Lars Knoll <lars.knoll@digia.com>
2013-12-05 15:21:03 +00:00
QSignalSpy spy(obj.data(), SIGNAL(loaded()));
obj->setProperty("active", true);
if (spy.isEmpty())
QVERIFY(spy.wait());
QCOMPARE(spy.count(), 1);
}
Prevent errors when unloading Loader Invalidate the context of the object so that destruction is signaled and bindings no longer run. Task-number: QTBUG-47321 Task-number: QTBUG-51995 Task-number: QTBUG-60344 Change-Id: I194a2fefe4e769a58c9ce022d39fe76cbe230de7 Reviewed-by: Michael Brasser <michael.brasser@live.com>
2017-10-24 01:45:00 +00:00
// QTBUG-51995
void tst_QQuickLoader::bindings()
{
QQmlEngine engine;
QQmlComponent component(&engine, testFileUrl("bindings.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY(!object.isNull());
QQuickItem *game = object->property("game").value<QQuickItem*>();
QVERIFY(game);
QQuickLoader *loader = object->property("loader").value<QQuickLoader*>();
QVERIFY(loader);
QSignalSpy warningsSpy(&engine, SIGNAL(warnings(QList<QQmlError>)));
// Causes the Loader to become active
game->setState(QLatin1String("running"));
QTRY_VERIFY(loader->item());
// Causes the Loader to become inactive - should not cause binding errors
game->setState(QLatin1String("invalid"));
QTRY_VERIFY(!loader->item());
QString failureMessage;
if (!warningsSpy.isEmpty()) {
QDebug stream(&failureMessage);
stream << warningsSpy.first().first().value<QList<QQmlError>>();
}
QVERIFY2(warningsSpy.isEmpty(), qPrintable(failureMessage));
}
// QTBUG-47321
void tst_QQuickLoader::parentErrors()
{
QQmlEngine engine;
QQmlComponent component(&engine, testFileUrl("parentErrors.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY(!object.isNull());
QQuickLoader *loader = object->property("loader").value<QQuickLoader*>();
QVERIFY(loader);
QSignalSpy warningsSpy(&engine, SIGNAL(warnings(QList<QQmlError>)));
// Give the loader a component
loader->setSourceComponent(object->property("component").value<QQmlComponent*>());
QTRY_VERIFY(loader->item());
// Clear the loader's component; should not cause binding errors
loader->setSourceComponent(nullptr);
QTRY_VERIFY(!loader->item());
QString failureMessage;
if (!warningsSpy.isEmpty()) {
QDebug stream(&failureMessage);
stream << warningsSpy.first().first().value<QList<QQmlError>>();
}
QVERIFY2(warningsSpy.isEmpty(), qPrintable(failureMessage));
}
When deactivating a loader, do not immediately clear its context In 2eb2d6386da304cd1164264ae0bff685c796d89c, deactivating/clearing the loader would now prevent any subsequent bindings from being evaluated. The problem there was that the item created by the loader wouldn't have a parent item (among things) anymore, so references to it in the bindings would result in errors. The way to prevent it was done by invalidating the context of the item, which in turn would detach it from the root context. This is a problem if objects in the root context are referenced after deactivating/clearing the loader: onSomethingChanged: { loader.source = "" objectInRootContext.doIt() } This would result in a ReferenceError when resolving objectInRootContext and break the behavior present before the fix mentioned above. The correct way is to recursively clear the context set on all bindings, but leave everything in place. This way, no subsequent bindings will be evaluated, but the currently "running" scripts will still be able to reach the root context. Task-number: QTBUG-66822 Change-Id: Ic9c2ab0a752093a26967da4783cb4c29cf83d2ca Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Michael Brasser <michael.brasser@live.com>
2018-03-08 14:02:45 +00:00
class ObjectInRootContext: public QObject
{
Q_OBJECT
public:
int didIt = 0;
public slots:
void doIt() {
didIt += 1;
}
};
void tst_QQuickLoader::rootContext()
{
QQmlEngine engine;
ObjectInRootContext objectInRootContext;
engine.rootContext()->setContextProperty("objectInRootContext", &objectInRootContext);
QQmlComponent component(&engine, testFileUrl("rootContext.qml"));
QScopedPointer<QObject> object(component.create());
QVERIFY(!object.isNull());
QQuickLoader *loader = object->property("loader").value<QQuickLoader*>();
QVERIFY(loader);
QSignalSpy warningsSpy(&engine, SIGNAL(warnings(QList<QQmlError>)));
// Give the loader a component
loader->setSourceComponent(object->property("component").value<QQmlComponent*>());
QTRY_VERIFY(loader->active());
QTRY_VERIFY(loader->item());
QString failureMessage;
if (!warningsSpy.isEmpty()) {
QDebug stream(&failureMessage);
stream << warningsSpy.first().first().value<QList<QQmlError>>();
}
QVERIFY2(warningsSpy.isEmpty(), qPrintable(failureMessage));
QCOMPARE(objectInRootContext.didIt, 0);
// Deactivate the loader, which deletes the item.
// Check that a) there are no errors, and b) the objectInRootContext can still be resolved even
// after deactivating the loader. If it cannot, a ReferenceError for objectInRootContext is
// generated (and the 'doIt' counter in objectInRootContext will be 1 for the call before
// the deactivation).
loader->item()->setProperty("trigger", true);
QTRY_VERIFY(!loader->active());
QTRY_VERIFY(!loader->item());
if (!warningsSpy.isEmpty()) {
QDebug stream(&failureMessage);
stream << warningsSpy.first().first().value<QList<QQmlError>>();
}
QVERIFY2(warningsSpy.isEmpty(), qPrintable(failureMessage));
QCOMPARE(objectInRootContext.didIt, 2);
}
Don't leak components in QQuickLoader Only create source component in loadFromSource if it does not already exist. Previously toggling the active status when loading from source would create a new source component every time active became true. [ChangeLog][QtQuick][Loader] Don't leak components when changing source url. Change-Id: I1e4cfd5613e3851fcb4f3f55e78981f7c070cc77 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2017-06-02 10:35:07 +00:00
void tst_QQuickLoader::sourceURLKeepComponent()
{
QQmlEngine engine;
QQmlComponent component(&engine);
component.setData(QByteArray(
"import QtQuick 2.0\n"
" Loader { id: loader\n }"),
dataDirectoryUrl());
QScopedPointer<QQuickLoader> loader(qobject_cast<QQuickLoader*>(component.create()));
loader->setSource(testFileUrl("/Rect120x60.qml"));
QVERIFY(loader);
QVERIFY(loader->item());
QVERIFY(loader->sourceComponent());
QCOMPARE(loader->progress(), 1.0);
const QPointer<QQmlComponent> sourceComponent = loader->sourceComponent();
//Ensure toggling active status does not recreate component
loader->setActive(false);
QVERIFY(!loader->item());
QVERIFY(loader->sourceComponent());
QCOMPARE(sourceComponent.data(), loader->sourceComponent());
loader->setActive(true);
QVERIFY(loader->item());
QVERIFY(loader->sourceComponent());
QCOMPARE(sourceComponent.data(), loader->sourceComponent());
loader->setActive(false);
QVERIFY(!loader->item());
QVERIFY(loader->sourceComponent());
QCOMPARE(sourceComponent.data(), loader->sourceComponent());
//Ensure changing source url causes component to be recreated when inactive
loader->setSource(testFileUrl("/BlueRect.qml"));
loader->setActive(true);
QVERIFY(loader->item());
QVERIFY(loader->sourceComponent());
const QPointer<QQmlComponent> newSourceComponent = loader->sourceComponent();
QVERIFY(sourceComponent.data() != newSourceComponent.data());
//Ensure changing source url causes component to be recreated when active
loader->setSource(testFileUrl("/Rect120x60.qml"));
QVERIFY(loader->sourceComponent() != newSourceComponent.data());
}
QQuickLoader: store status This allows us to emit the change signal only when the status has actually changed. Due to alignment restrictions, this does not even change the size of the class. Fixes: QTBUG-82002 Change-Id: I2192bf80e72b92108046780811c3acdab39af518 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2020-02-12 12:29:08 +00:00
// QTBUG-82002
void tst_QQuickLoader::statusChangeOnlyEmittedOnce()
{
QQmlApplicationEngine engine;
auto url = testFileUrl("statusChanged.qml");
engine.load(url);
auto root = engine.rootObjects().at(0);
QVERIFY(root);
QTRY_COMPARE(QQuickLoader::Status(root->property("status").toInt()), QQuickLoader::Ready);
QCOMPARE(root->property("statusChangedCounter").toInt(), 2); // 1xLoading + 1xReady*/
}
QQuickLoader: make sure the status property change properly Since the invocation of [setSource] in qml will clear the old source url first, it is hard to decide whether we have changed the source url, especially when we call [setSource] with an empty string, and the loader's status won't change properly. Pick-to: 5.15 Fixes: QTBUG-85938 Change-Id: If61a33c790a4fd6562611c4c50756bc5e213363a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-08-15 06:57:06 +00:00
void tst_QQuickLoader::setSourceAndCheckStatus()
{
QQmlApplicationEngine engine;
auto url = testFileUrl("setSourceAndCheckStatus.qml");
engine.load(url);
auto root = engine.rootObjects().at(0);
QVERIFY(root);
QQuickLoader *loader = root->findChild<QQuickLoader *>();
QMetaObject::invokeMethod(loader, "load", Q_ARG(QVariant, QVariant::fromValue(QStringLiteral("./RedRect.qml"))));
QCOMPARE(loader->status(), QQuickLoader::Ready);
QMetaObject::invokeMethod(loader, "load", Q_ARG(QVariant, QVariant::fromValue(QStringLiteral(""))));
QCOMPARE(loader->status(), QQuickLoader::Null);
QQuickLoader: make sure the status property change properly When we call [setSource] in qml, we will try to convert a qml value to a string which indicate the url we want to load. However, if this value is undefined, it will convert to a string with content "undefined", and then cause loading error. More worse, if there is a qml file named "undefined", it will be loaded to the Loader. Pick-to: 5.15 Fixes: QTBUG-85938 Change-Id: I5b192ba84aa29532e547349bbf37d413c107d8e4 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-08-15 07:26:51 +00:00
QMetaObject::invokeMethod(loader, "load", Q_ARG(QVariant, QVariant()));
QCOMPARE(loader->status(), QQuickLoader::Null);
QQuickLoader: make sure the status property change properly Since the invocation of [setSource] in qml will clear the old source url first, it is hard to decide whether we have changed the source url, especially when we call [setSource] with an empty string, and the loader's status won't change properly. Pick-to: 5.15 Fixes: QTBUG-85938 Change-Id: If61a33c790a4fd6562611c4c50756bc5e213363a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2020-08-15 06:57:06 +00:00
}
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
QTEST_MAIN(tst_QQuickLoader)
Initial import from qtquick2. Branched from the monolithic repo, Qt qtquick2 branch, at commit a4a585d2ee907746682846ae6e8a48e19deef469
2011-04-27 12:13:26 +00:00
Rename Qt Quick-specific classes to QQuick* The QSG (SceneGraph) prefix is too generic for Qt Quick(2)-specific classes. All the classes and files in the declarative/items directory have been renamed. In particular, for classes that are currently public, the renaming is as follows: QSGView --> QQuickView QSGCanvas --> QQuickCanvas QSGItem --> QQuickItem QSGPaintedItem --> QQuickPaintedItem The header files have been renamed accordingly (e.g. qsgview.h --> qquickview.h). Change-Id: Iac937fff81db20bb639486a793c3aeb5230b038c Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
2011-10-14 08:51:42 +00:00
#include "tst_qquickloader.moc"