qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
qtdeclarative/tests/auto/quickwidgets/qquickwidget/tst_qquickwidget.cpp

1053 lines
35 KiB
C++
Raw Normal View History

Use SPDX license identifiers Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2022-05-13 13:12:05 +00:00
// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
#include <qtest.h>
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
#include <qtesttouch.h>
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
#include <QtTest/QSignalSpy>
Android: partly re-enable tst_qquickwidget This test does the following: - QSKIP reparentToNewWindow() because it crashes on Android - QSKIP enterLeave() because Android does not support cursor - Fix resizeOverlay() and focusOnClickInProxyWidget() by using QTestPrivate::androidCompatibleShow() that takes desired widget size and position into account while showing on Android. Task-number: QTBUG-100173 Pick-to: 6.3 6.2 Change-Id: I383d7d80ca645ca50c7a843d4906a99e1bb0d0ea Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-08 15:35:03 +00:00
#include <QtTest/private/qtesthelpers_p.h>
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
#include <QtQml/qqmlcomponent.h>
#include <QtQml/qqmlcontext.h>
#include <QtQuick/qquickview.h>
#include <QtQuick/qquickitem.h>
Resize offscreen window when QQuickWidget is resized In a typical Qt Quick application, when a window is resized, the contentItem of that window is resized with it, and then the root item. QQuickOverlay in qtquickcontrols2 listens to size changes in the contentItem (QQuickRootItem) via addItemChangeListener(), as a cheap way (e.g. no signals) of knowing when to resize background dimming effects. It resizes the dimmer item to the size of the window. The first problem with QQuickWidget is that it only ever resizes the root item when using the SizeRootObjectToView resize mode, and not the contentItem. The second problem is that the root item is resized (via updateSize()) before the window itself even has a size (which happens in QQuickWidget::createFramebufferObject() via the call to d->offscreenWindow->setGeometry()). To demonstrate the second problem in detail, consider the following widget hierarchy (written in everybody's favorite language: QML): QMainWindow { QQuickWidget { QQuickWindow { // QQuickWidgetPrivate::offscreenWindow QQuickRootItem { // QQuickWindowPrivate::contentItem Page {} // QQuickWidgetPrivate::root } } } } The QMainWindow starts off as 200x200. When the window is resized, QQuickWidget::resizeEvent() is called. The first thing it does is call updateSize(), which in the case of SizeRootObjectToView, resizes the root item to 300x300. This causes QQuickOverlayPrivate::itemGeometryChanged() to be called, and the dimmers are resized to the size of the window, but the window still has its 200x200 size, as it is only updated later, when QQuickWidget::createFramebufferObject() is called. This patch fixes these issues by ensuring that contentItem and the window itself are resized along with the root item. As to why such manual intervention is necessary: from what I can see, it is because it's an "offscreen" window. This means that QWindowPrivate::platformWindow is null, and setGeometry() takes a different path that presumably results in no QResizeEvent being sent to the QQuickWindow. As QQuickWindow relies on resizeEvent() being called to resize its contentItem, the contentItem is never resized. With a typical Qt Quick application, all of this works as expected. Change-Id: I7401aa7a9b209096183416ab53014f67cceccbe4 Fixes: QTBUG-78323 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2020-03-05 15:00:04 +00:00
#include <QtQuick/private/qquickitem_p.h>
Test MouseArea in QQuickWidget Task-number: QTBUG-101736 Pick-to: 6.2 6.4 6.5 Change-Id: Iecbe6b4da75851cb94c4c2bae41bb0cb50f0ed30 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-03-18 12:13:24 +00:00
#include <QtQuick/private/qquickmousearea_p.h>
QQuickWidget: always accept touch events and grabbed event points A QQuickWidget contains a Quick UI, which can be expected to handle touch events, and it handles touch events by forwarding them to the QQuickWindow. So set the AcceptTouchEvents attribute and let the Qt Quick delivery machinery deal with the touch-mouse synthesis within the scene. Also, Qt Quick's event delivery might return event points as ignored after setting the exclusive grabber. Qt Widgets touch event delivery logic doesn't care about exclusive grabbers, and relies on the event points being accepted to make the widget that received the TouchBegin an implicit grabber. QQuickWidget needs to translate those states back, so accept all points that come back with a grabber. Add a test that verifies that a button in a popup gets all events, and that those events are translated correctly - without the fix, the "clicked" test fails, as the release is delivered, but with coordinates outside of the button. Also test that we can have two QQuickWidgets where each gets one touch point. Fixes: QTBUG-101736 Pick-to: 6.5 6.4 6.2 Change-Id: I3a2bf05fd297ae4d72b6e236ecd8e5ddac37ce06 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2022-12-14 08:52:51 +00:00
#include <QtQuickTemplates2/private/qquickbutton_p.h>
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
#include <QtQuickTestUtils/private/qmlutils_p.h>
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
#include <QtGui/QWindow>
tst_qquickwidget::enterLeave(): Handle varying screen setups Take the available screen geometry and window borders into account when positioning windows and moving cursors. Task-number: QTBUG-64397 Fixes: QTBUG-72305 Change-Id: Ia2b35a0deb144ab7194f7658d599888ff9d4a706 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-12-05 10:28:47 +00:00
#include <QtGui/QScreen>
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
#include <QtGui/QImage>
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
#include <QtCore/QDebug>
#include <QtQml/qqmlengine.h>
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
#include <QtCore/QLoggingCategory>
Pass on tab presses to the offscreen window to handle first When pressing tab/backtab then the offscreen window needs to pass it on to the item in case it will handle this for changing focus. If it does not handle the event, it will pass it back for QWidget handling. [ChangeLog][QQuickWidget] Tab presses are now passed on to the root item to be handled first. When not handled by the root item, it will be handled like a standard QWidget. Task-number: QTBUG-45641 Change-Id: Ief0552ba496c87ab0b6e12aa8e67ef44b5a20ae2 Reviewed-by: Liang Qi <liang.qi@qt.io>
2017-11-01 14:40:14 +00:00
#include <QtGui/qstylehints.h>
Update layout when QQuickWidget changes size Task-number: QTBUG-47722 Change-Id: I612f89945961a3995878c424bf27dbbedf8375c8 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2017-08-14 08:29:53 +00:00
#include <QtWidgets/QBoxLayout>
#include <QtWidgets/QLabel>
Fix problem with subFocusItem on non-OpenGL QSG The subFocusItem state was forgotten because the old parent was deleted, before its focused child was reparented. The test doesn't pass on Android and makes the test process exit with error. Since it prints warnings that indicate issues further down in the RHI stack, we'll skip it for now on that platform. Task-number: QTBUG-112696 Pick-to: 6.5 6.2 Change-Id: Ibb32a11564ff6fbb2091c241d508f12479b234b0 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2023-04-05 15:12:07 +00:00
#include <QtWidgets/private/qapplication_p.h>
Update layout when QQuickWidget changes size Task-number: QTBUG-47722 Change-Id: I612f89945961a3995878c424bf27dbbedf8375c8 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2017-08-14 08:29:53 +00:00
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
#include <QtQuickWidgets/QQuickWidget>
Fix focus for items inside a QQuickWidget in a QGraphicsProxyWidget QQuickWidgetRenderControl::renderWindowFor() did not take the proxy widget into account, making it impossible to give focus to items inside a QGraphicsProxyWidget by clicking on the item. This patch is based on a patch by Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>, which fixed renderWindowFor(), but did not handle the case where a proxy widget was in multiple views. This version of the patch adds QQuickRenderControlPrivate::isRenderWindowFor(), which allows all the views of the proxy widget to handle focus. This patch also carefully preserves the non-obvious feature of the previous implementation where all windows are considered to have focus if QGuiApplication::focusWindow() == nullptr. [ChangeLog][QuickWidget][Quick items inside a QuickWidget that is inside a QGraphicsProxyWidget can now get focus by clicking.] Fixes: QTBUG-91479 Pick-to: 6.2 Change-Id: I4a6fbbbeda2d14b5a6d8eb8218d5b14a3404d9c3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-11-29 16:23:18 +00:00
#if QT_CONFIG(graphicsview)
# include <QtWidgets/QGraphicsView>
# include <QtWidgets/QGraphicsProxyWidget>
#endif
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
Q_LOGGING_CATEGORY(lcTests, "qt.quick.tests")
class MouseRecordingQQWidget : public QQuickWidget
{
public:
explicit MouseRecordingQQWidget(QWidget *parent = nullptr) : QQuickWidget(parent) {
setAttribute(Qt::WA_AcceptTouchEvents);
}
protected:
void mousePressEvent(QMouseEvent *event) override {
qCDebug(lcTests) << event;
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
m_mouseEvents << event->source();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
QQuickWidget::mousePressEvent(event);
}
void mouseMoveEvent(QMouseEvent *event) override {
qCDebug(lcTests) << event;
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
m_mouseEvents << event->source();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
QQuickWidget::mouseMoveEvent(event);
}
void mouseReleaseEvent(QMouseEvent *event) override {
qCDebug(lcTests) << event;
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
m_mouseEvents << event->source();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
QQuickWidget::mouseReleaseEvent(event);
}
public:
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
QList<Qt::MouseEventSource> m_mouseEvents;
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
};
class MouseRecordingItem : public QQuickItem
{
public:
Fix and un-blacklist tst_qquickwidget::synthMouseFromTouch In Qt 6, any QQuickItem that wants to handle touch events needs to explicitly enable them by calling setAcceptTouchEvents(true). This was anticipated in 1457df74f4c1d770e1e820de8cd082be1bd2489e and ab91e7fa02a562d80fd0747f28a60e00c3b45a01 If an Item calls setAcceptTouchEvents(true), it will not receive synth-mouse events, even if it calls ignore() on a particular touch press event. So now in this test, when we want to test synth-mouse events, we call setAcceptTouchEvents(false). Task-number: QTBUG-86729 Task-number: QTBUG-101736 Pick-to: 6.4 6.3 6.2 Change-Id: I71d2f213bc62206c190c94de5e4d39ce17504a0d Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-03-17 16:41:59 +00:00
MouseRecordingItem(bool acceptTouch, bool acceptTouchPress, QQuickItem *parent = nullptr)
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
: QQuickItem(parent)
Fix and un-blacklist tst_qquickwidget::synthMouseFromTouch In Qt 6, any QQuickItem that wants to handle touch events needs to explicitly enable them by calling setAcceptTouchEvents(true). This was anticipated in 1457df74f4c1d770e1e820de8cd082be1bd2489e and ab91e7fa02a562d80fd0747f28a60e00c3b45a01 If an Item calls setAcceptTouchEvents(true), it will not receive synth-mouse events, even if it calls ignore() on a particular touch press event. So now in this test, when we want to test synth-mouse events, we call setAcceptTouchEvents(false). Task-number: QTBUG-86729 Task-number: QTBUG-101736 Pick-to: 6.4 6.3 6.2 Change-Id: I71d2f213bc62206c190c94de5e4d39ce17504a0d Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-03-17 16:41:59 +00:00
, m_acceptTouchPress(acceptTouchPress)
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
{
setSize(QSizeF(300, 300));
setAcceptedMouseButtons(Qt::LeftButton);
Fix and un-blacklist tst_qquickwidget::synthMouseFromTouch In Qt 6, any QQuickItem that wants to handle touch events needs to explicitly enable them by calling setAcceptTouchEvents(true). This was anticipated in 1457df74f4c1d770e1e820de8cd082be1bd2489e and ab91e7fa02a562d80fd0747f28a60e00c3b45a01 If an Item calls setAcceptTouchEvents(true), it will not receive synth-mouse events, even if it calls ignore() on a particular touch press event. So now in this test, when we want to test synth-mouse events, we call setAcceptTouchEvents(false). Task-number: QTBUG-86729 Task-number: QTBUG-101736 Pick-to: 6.4 6.3 6.2 Change-Id: I71d2f213bc62206c190c94de5e4d39ce17504a0d Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-03-17 16:41:59 +00:00
setAcceptTouchEvents(acceptTouch);
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
}
protected:
void touchEvent(QTouchEvent* event) override {
Fix and un-blacklist tst_qquickwidget::synthMouseFromTouch In Qt 6, any QQuickItem that wants to handle touch events needs to explicitly enable them by calling setAcceptTouchEvents(true). This was anticipated in 1457df74f4c1d770e1e820de8cd082be1bd2489e and ab91e7fa02a562d80fd0747f28a60e00c3b45a01 If an Item calls setAcceptTouchEvents(true), it will not receive synth-mouse events, even if it calls ignore() on a particular touch press event. So now in this test, when we want to test synth-mouse events, we call setAcceptTouchEvents(false). Task-number: QTBUG-86729 Task-number: QTBUG-101736 Pick-to: 6.4 6.3 6.2 Change-Id: I71d2f213bc62206c190c94de5e4d39ce17504a0d Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-03-17 16:41:59 +00:00
event->setAccepted(m_acceptTouchPress);
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
m_touchEvents << event->type();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
qCDebug(lcTests) << "accepted?" << event->isAccepted() << event;
}
void mousePressEvent(QMouseEvent *event) override {
qCDebug(lcTests) << event;
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
m_mouseEvents << event->source();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
}
void mouseMoveEvent(QMouseEvent *event) override {
qCDebug(lcTests) << event;
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
m_mouseEvents << event->source();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
}
void mouseReleaseEvent(QMouseEvent *event) override {
qCDebug(lcTests) << event;
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
m_mouseEvents << event->source();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
}
public:
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
QList<Qt::MouseEventSource> m_mouseEvents;
QList<QEvent::Type> m_touchEvents;
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
private:
Fix and un-blacklist tst_qquickwidget::synthMouseFromTouch In Qt 6, any QQuickItem that wants to handle touch events needs to explicitly enable them by calling setAcceptTouchEvents(true). This was anticipated in 1457df74f4c1d770e1e820de8cd082be1bd2489e and ab91e7fa02a562d80fd0747f28a60e00c3b45a01 If an Item calls setAcceptTouchEvents(true), it will not receive synth-mouse events, even if it calls ignore() on a particular touch press event. So now in this test, when we want to test synth-mouse events, we call setAcceptTouchEvents(false). Task-number: QTBUG-86729 Task-number: QTBUG-101736 Pick-to: 6.4 6.3 6.2 Change-Id: I71d2f213bc62206c190c94de5e4d39ce17504a0d Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-03-17 16:41:59 +00:00
bool m_acceptTouchPress;
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
};
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
class tst_qquickwidget : public QQmlDataTest
{
Q_OBJECT
public:
tst_qquickwidget();
private slots:
void showHide();
void reparentAfterShow();
void changeGeometry();
void resizemodeitem();
Update layout when QQuickWidget changes size Task-number: QTBUG-47722 Change-Id: I612f89945961a3995878c424bf27dbbedf8375c8 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2017-08-14 08:29:53 +00:00
void layoutSizeChange();
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
void errors();
void engine();
void readback();
QQuickWidget: expose the underlying QQuickWindow There's a number of APIs (such as all the scenegraph-related signals) that are currently missing from QQuickWidget. Instead of duplicating every API in QQuickWidget, simply expose the underlying offscreen QQuickWindow. Task-number: QTBUG-45260 Change-Id: I1a89fe600ce675963ea24ee6dd56d6ca4fea9cd2 Reviewed-by: Andy Shaw <andy.shaw@digia.com> Reviewed-by: Gunnar Sletta <gunnar@sletta.org> Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
2015-03-26 20:34:42 +00:00
void renderingSignals();
Add a unit-test for QQuickWidget::grab() Test that it actually didn't grab a blank pixmap, as happened with QOpenGLWidget in the past. Change-Id: Iee8e7ff2f3fa2f2223a2a284fec96d96f62e36a6 Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
2017-06-20 20:15:48 +00:00
void grab();
Fix crash when grabbing a QQuickWidget before it is shown. Do not access null share contexts. Task-number: QTBUG-49929 Change-Id: I1c88563df71dd6c5d186b6f2ae147614fcc6ded9 Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
2015-12-14 08:44:40 +00:00
void grabBeforeShow();
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
void reparentToNewWindow();
Create QmlEngine lazy in case one is not needed QQuickWidget may be used with just a root item, and won't need a QmlEngine in that case. So if one isn't given to the constructor, only create one when one is needed for evaluating source. Change-Id: I96cfe5e2473d5d53fc2d52d4646d36c43f4ccb8a Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2016-06-24 08:22:47 +00:00
void nullEngine();
Make keyboard events work in QQuickWidget Right now many cases outside of text input fields are simply broken, e.g. one cannot use a TableView or other controls with the keyboard. Removing the seemingly unnecessary focusObject() solves all problems since this way key events get delivered to the QQuickWidget which in turn forwards to the QQuickWindow. Directly routing into the QQuickWindow's focusObject(), which can be any item in the scene is wrong since it skips a big part of QQuickWindow's event handling logic. Task-number: QTBUG-45757 Change-Id: Ie53b9003d156ab019fa4b9cf461e209990e738f7 Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2017-02-22 15:16:14 +00:00
void keyEvents();
Forward ShortcutOverride in QQuickWidget This is now essential since otherwise these events are simply lost. Amends 0dbc575c1a8359534761167a5f5f1e29abedd51d Task-number: QTBUG-60988 Change-Id: Ib1d99d8fcd5bb92c9b52977796f2910f0fe71c48 Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2017-05-23 12:34:23 +00:00
void shortcuts();
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
void enterLeave();
Use localPos for windowPos when passing mouse events to QQuickWidget QQuickWidget thinks of itself as a toplevel window, so it cannot process the offsets in a parent window. Amends 41293196b4db1aa7a0c616af312875c484639644. Task-number: QTBUG-65800 Change-Id: I8c5dcb8f44a6cbdb58bcc956d8263e68d8180bec Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2018-01-16 13:29:40 +00:00
void mouseEventWindowPos();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
void synthMouseFromTouch_data();
void synthMouseFromTouch();
Test MouseArea in QQuickWidget Task-number: QTBUG-101736 Pick-to: 6.2 6.4 6.5 Change-Id: Iecbe6b4da75851cb94c4c2bae41bb0cb50f0ed30 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-03-18 12:13:24 +00:00
void touchTapMouseArea();
QQuickWidget: always accept touch events and grabbed event points A QQuickWidget contains a Quick UI, which can be expected to handle touch events, and it handles touch events by forwarding them to the QQuickWindow. So set the AcceptTouchEvents attribute and let the Qt Quick delivery machinery deal with the touch-mouse synthesis within the scene. Also, Qt Quick's event delivery might return event points as ignored after setting the exclusive grabber. Qt Widgets touch event delivery logic doesn't care about exclusive grabbers, and relies on the event points being accepted to make the widget that received the TouchBegin an implicit grabber. QQuickWidget needs to translate those states back, so accept all points that come back with a grabber. Add a test that verifies that a button in a popup gets all events, and that those events are translated correctly - without the fix, the "clicked" test fails, as the release is delivered, but with coordinates outside of the button. Also test that we can have two QQuickWidgets where each gets one touch point. Fixes: QTBUG-101736 Pick-to: 6.5 6.4 6.2 Change-Id: I3a2bf05fd297ae4d72b6e236ecd8e5ddac37ce06 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2022-12-14 08:52:51 +00:00
void touchTapButton();
void touchMultipleWidgets();
Pass on tab presses to the offscreen window to handle first When pressing tab/backtab then the offscreen window needs to pass it on to the item in case it will handle this for changing focus. If it does not handle the event, it will pass it back for QWidget handling. [ChangeLog][QQuickWidget] Tab presses are now passed on to the root item to be handled first. When not handled by the root item, it will be handled like a standard QWidget. Task-number: QTBUG-45641 Change-Id: Ief0552ba496c87ab0b6e12aa8e67ef44b5a20ae2 Reviewed-by: Liang Qi <liang.qi@qt.io>
2017-11-01 14:40:14 +00:00
void tabKey();
Resize offscreen window when QQuickWidget is resized In a typical Qt Quick application, when a window is resized, the contentItem of that window is resized with it, and then the root item. QQuickOverlay in qtquickcontrols2 listens to size changes in the contentItem (QQuickRootItem) via addItemChangeListener(), as a cheap way (e.g. no signals) of knowing when to resize background dimming effects. It resizes the dimmer item to the size of the window. The first problem with QQuickWidget is that it only ever resizes the root item when using the SizeRootObjectToView resize mode, and not the contentItem. The second problem is that the root item is resized (via updateSize()) before the window itself even has a size (which happens in QQuickWidget::createFramebufferObject() via the call to d->offscreenWindow->setGeometry()). To demonstrate the second problem in detail, consider the following widget hierarchy (written in everybody's favorite language: QML): QMainWindow { QQuickWidget { QQuickWindow { // QQuickWidgetPrivate::offscreenWindow QQuickRootItem { // QQuickWindowPrivate::contentItem Page {} // QQuickWidgetPrivate::root } } } } The QMainWindow starts off as 200x200. When the window is resized, QQuickWidget::resizeEvent() is called. The first thing it does is call updateSize(), which in the case of SizeRootObjectToView, resizes the root item to 300x300. This causes QQuickOverlayPrivate::itemGeometryChanged() to be called, and the dimmers are resized to the size of the window, but the window still has its 200x200 size, as it is only updated later, when QQuickWidget::createFramebufferObject() is called. This patch fixes these issues by ensuring that contentItem and the window itself are resized along with the root item. As to why such manual intervention is necessary: from what I can see, it is because it's an "offscreen" window. This means that QWindowPrivate::platformWindow is null, and setGeometry() takes a different path that presumably results in no QResizeEvent being sent to the QQuickWindow. As QQuickWindow relies on resizeEvent() being called to resize its contentItem, the contentItem is never resized. With a typical Qt Quick application, all of this works as expected. Change-Id: I7401aa7a9b209096183416ab53014f67cceccbe4 Fixes: QTBUG-78323 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2020-03-05 15:00:04 +00:00
void resizeOverlay();
Handle redirected rendering better in styles Unlike in the QWidget-based desktop world, Qt Quick scenes can be rendered in a variety of ways, some completely offscreen wthout any native windows on screen, whereas some (most notably, QQuickWidget) work offscreen but in association with an on-screen window that is not the QQuickWindow. Therefore, every time a QQuickWindow is accessed, typically from QQuickStyleItem, it needs to be considered if further resolution is needed. For devicePixelRatio, there is a handy helper available in form of QQuickWindow::effectiveDevicePixelRatio(). This picks up the dpr from either the QQuickWindow or the QQuickWidget's associated top-level QWidget window (or whatever window a custom QQuickRenderControl implementation reports). Elsewhere, where we need a QWindow in order to do native window things, QQuickRenderControl::renderWindowFor() must be called to see if there is another QWindow we should be using in place of the QQuickWindow. Pick-to: 6.2 Fixes: QTBUG-95937 Change-Id: I0690915d995ebb5f5cc0c48f565dfaf978e849ea Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
2021-08-20 08:43:34 +00:00
void controls();
Fix focus for items inside a QQuickWidget in a QGraphicsProxyWidget QQuickWidgetRenderControl::renderWindowFor() did not take the proxy widget into account, making it impossible to give focus to items inside a QGraphicsProxyWidget by clicking on the item. This patch is based on a patch by Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>, which fixed renderWindowFor(), but did not handle the case where a proxy widget was in multiple views. This version of the patch adds QQuickRenderControlPrivate::isRenderWindowFor(), which allows all the views of the proxy widget to handle focus. This patch also carefully preserves the non-obvious feature of the previous implementation where all windows are considered to have focus if QGuiApplication::focusWindow() == nullptr. [ChangeLog][QuickWidget][Quick items inside a QuickWidget that is inside a QGraphicsProxyWidget can now get focus by clicking.] Fixes: QTBUG-91479 Pick-to: 6.2 Change-Id: I4a6fbbbeda2d14b5a6d8eb8218d5b14a3404d9c3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-11-29 16:23:18 +00:00
void focusOnClick();
#if QT_CONFIG(graphicsview)
void focusOnClickInProxyWidget();
#endif
Fix problem with subFocusItem on non-OpenGL QSG The subFocusItem state was forgotten because the old parent was deleted, before its focused child was reparented. The test doesn't pass on Android and makes the test process exit with error. Since it prints warnings that indicate issues further down in the RHI stack, we'll skip it for now on that platform. Task-number: QTBUG-112696 Pick-to: 6.5 6.2 Change-Id: Ibb32a11564ff6fbb2091c241d508f12479b234b0 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2023-04-05 15:12:07 +00:00
void focusPreserved();
QQuickWidget: don't crash in accessibility when reparenting QAccessibleQuickWidget delegates all calls to the QAccessibleQuickWindow, which it had as a member that was initialized at construction time to the offscreenWindow backing the QQuickWidget. Both are QAccessibleObject subclasses, and QAccessibleObject stores the object it wraps as a QPointer. The QAccessibleQuickWindow's object becomes null when that offscreen window gets destroyed (for instance, when reparenting). We might get called by the accessibility framework in that situation, as we are clicking a button and the hierarchy changes. To prevent crashes, we need to test for nullptr in QAccessibleQuickWindow. However, that alone would leave us with a useless QAccessibleQuickWindow, and in turn with a useless QAccessibleQuickWidget instance. The QAccessibleQuickWindow is not directly exposed to the accessibility framework, and all calls to it are dispatched through its QAccessibleQuickWidget owner. We can't repair the QAccessibleQuickWindow but we can replace it entirely if we manage it as a heap-allocated object. Use a std::unique_ptr for that, which we can reset with a new instance created from a new offscreen window in order to repair things. We can now either test in all functions whether the window's window is still alive. Or we can handle the destroyed() signal of the offscreen window. The latter solution is a bit more involved, but generally more scalable as we don't have to remember to check, and possibly repair, in each QAccessibleQuickWidget function. Pick-to: 6.5 Fixes: QTBUG-108226 Change-Id: Ib19c07d3679c0af28cb5aab4c80691cc57c4e514 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2023-04-08 16:53:14 +00:00
void accessibilityHandlesViewChange();
QQuickWidget: Clean up if RHI goes away under our feet The QQuickWidget doesn't normally own the RHI; the QWidgetRepaintManager does, via QBackingStoreRhiSupport. If the top level widget is destroyed, so is its QBackingStore, and the corresponding RHI. But the QQuickWidget may outlive its top level parent, in which case it needs to update its cached reference to the RHI, and do proper cleanup before it goes away. QRhiWidget already does the same thing, for the same use-case. This was observed when recreating the top level QWidget via destroy/create as part of the RHI widget compositor logic. Fixes: QTBUG-119760 Pick-to: 6.6 6.5 Change-Id: Ic44449abcfe4271660a3ac4e132d0c4a71a21b65 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 0d342e83123b27befde95fc35760a358dbff0b16) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
2023-12-19 20:52:05 +00:00
void cleanupRhi();
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
private:
Remove QQuickPointerDevice in favor of QPointingDevice ...and generally deal with changes immediately required after adding QInputDevice and QPointingDevice. Also fixed a few usages of deprecated accessors that weren't taken care of in 212c2bffbb041aee0e3c9a7f0551ef151ed2d3ad. Task-number: QTBUG-46412 Task-number: QTBUG-69433 Task-number: QTBUG-72167 Change-Id: I93a2643162878afa216556f10808fd92e0b20071 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2020-03-26 15:50:40 +00:00
QPointingDevice *device = QTest::createTouchDevice();
tst_qquickwidget::enterLeave(): Handle varying screen setups Take the available screen geometry and window borders into account when positioning windows and moving cursors. Task-number: QTBUG-64397 Fixes: QTBUG-72305 Change-Id: Ia2b35a0deb144ab7194f7658d599888ff9d4a706 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-12-05 10:28:47 +00:00
const QRect m_availableGeometry = QGuiApplication::primaryScreen()->availableGeometry();
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
};
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
tst_qquickwidget::tst_qquickwidget()
Consolidate test helpers into private libraries Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-08-06 10:27:35 +00:00
: QQmlDataTest(QT_QMLTEST_DATADIR)
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
{
Make QQuickWidget QRhi-based When it comes to examples, quickwidget has the direct OpenGL usage removed because we want this example to be working with any graphics API. qquickviewcomparison, which features direct OpenGL usage within its Qt Quick scene, is renamed to a more descriptive name and is also getting a doc landing page. It continues to be requesting OpenGL (via QRhi) explicitly. Change-Id: Iae5b835441f3af229e9746e14dedbe9d1a62b2b9 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-11-08 15:16:16 +00:00
}
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
void tst_qquickwidget::showHide()
{
QWidget window;
QQuickWidget *childView = new QQuickWidget(&window);
childView->setSource(testFileUrl("rectangle.qml"));
window.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&window));
Quick fix for not working input handling for eglfs On eglfs platform input events are driven by libinput and do not have window information as such. They are simply delivered based on QGuiApplication::topLevelAt window selection. In case of WebEnigne, QQuickWindow is returned as top level window. QQuickWidget uses this QQuickWindow as an offscreen window, however since 561b932 we fake 'visible' and 'visibility' values so windows api in qml can use those properties. This ends up with broken event delivery on eglfs, since window is offscreen and therefore not really visible. Make a minimalistic change to fix the issue, without braking QTBUG-49054, which requires 'visibility' to have fake values, and 'visible' will keep window as not visible for event delivery system. Fix encapsulation of setVisible(), prevent accidental window creation when setVsiible() called from qml via binding. The proper fix would require for example adding some new flag to underlying offscreen window, which could be used by event window selection mechanism or rework of qquickwidget offscreen window parameters expose to qml. Task-number: QTBUG-65761 Task-number: QTBUG-49054 Change-Id: I2a307ee5613771adf6d31f1c3cc4b4a25d7620df Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-04-02 14:07:34 +00:00
QVERIFY(!childView->quickWindow()->isVisible()); // this window is always not visible see QTBUG-65761
QQuickWidget: Emulate visibility for offscreen window The "visibility" and "visible" properties are exported to QML and should return useful values. Task-number: QTBUG-49054 Change-Id: I3c474885653c4b57659b02f183293e3186edc972 Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
2015-11-16 10:21:00 +00:00
QVERIFY(childView->quickWindow()->visibility() != QWindow::Hidden);
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QQuickWidget: Emulate visibility for offscreen window The "visibility" and "visible" properties are exported to QML and should return useful values. Task-number: QTBUG-49054 Change-Id: I3c474885653c4b57659b02f183293e3186edc972 Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
2015-11-16 10:21:00 +00:00
window.hide();
QVERIFY(!childView->quickWindow()->isVisible());
QCOMPARE(childView->quickWindow()->visibility(), QWindow::Hidden);
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
}
void tst_qquickwidget::reparentAfterShow()
{
QWidget window;
QQuickWidget *childView = new QQuickWidget(&window);
childView->setSource(testFileUrl("rectangle.qml"));
window.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&window));
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QScopedPointer<QQuickWidget> toplevelView(new QQuickWidget);
toplevelView->setParent(&window);
toplevelView->setSource(testFileUrl("rectangle.qml"));
toplevelView->show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&window));
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
}
void tst_qquickwidget::changeGeometry()
{
QWidget window;
QQuickWidget *childView = new QQuickWidget(&window);
childView->setSource(testFileUrl("rectangle.qml"));
window.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&window));
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
childView->setGeometry(100,100,100,100);
}
void tst_qquickwidget::resizemodeitem()
{
QWidget window;
tst_qquickwidget::enterLeave(): Handle varying screen setups Take the available screen geometry and window borders into account when positioning windows and moving cursors. Task-number: QTBUG-64397 Fixes: QTBUG-72305 Change-Id: Ia2b35a0deb144ab7194f7658d599888ff9d4a706 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-12-05 10:28:47 +00:00
window.setGeometry(m_availableGeometry.left(), m_availableGeometry.top(), 400, 400);
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QScopedPointer<QQuickWidget> view(new QQuickWidget);
view->setParent(&window);
view->setResizeMode(QQuickWidget::SizeRootObjectToView);
QCOMPARE(QSize(0,0), view->initialSize());
view->setSource(testFileUrl("resizemodeitem.qml"));
QQuickItem* item = qobject_cast<QQuickItem*>(view->rootObject());
QVERIFY(item);
window.show();
view->showNormal();
// initial size from root object
QCOMPARE(item->width(), 200.0);
QCOMPARE(item->height(), 200.0);
QCOMPARE(view->size(), QSize(200, 200));
QCOMPARE(view->size(), view->sizeHint());
QCOMPARE(view->size(), view->initialSize());
// size update from view
view->resize(QSize(80,100));
QTRY_COMPARE(item->width(), 80.0);
QCOMPARE(item->height(), 100.0);
QCOMPARE(view->size(), QSize(80, 100));
QCOMPARE(view->size(), view->sizeHint());
view->setResizeMode(QQuickWidget::SizeViewToRootObject);
// size update from view disabled
view->resize(QSize(60,80));
QCOMPARE(item->width(), 80.0);
QCOMPARE(item->height(), 100.0);
QTRY_COMPARE(view->size(), QSize(60, 80));
// size update from root object
item->setWidth(250);
item->setHeight(350);
QCOMPARE(item->width(), 250.0);
QCOMPARE(item->height(), 350.0);
QTRY_COMPARE(view->size(), QSize(250, 350));
QCOMPARE(view->size(), QSize(250, 350));
QCOMPARE(view->size(), view->sizeHint());
// reset window
window.hide();
view.reset(new QQuickWidget(&window));
view->setResizeMode(QQuickWidget::SizeViewToRootObject);
view->setSource(testFileUrl("resizemodeitem.qml"));
item = qobject_cast<QQuickItem*>(view->rootObject());
QVERIFY(item);
window.show();
view->showNormal();
// initial size for root object
QCOMPARE(item->width(), 200.0);
QCOMPARE(item->height(), 200.0);
QCOMPARE(view->size(), view->sizeHint());
QCOMPARE(view->size(), view->initialSize());
// size update from root object
item->setWidth(80);
item->setHeight(100);
QCOMPARE(item->width(), 80.0);
QCOMPARE(item->height(), 100.0);
QTRY_COMPARE(view->size(), QSize(80, 100));
QCOMPARE(view->size(), view->sizeHint());
// size update from root object disabled
view->setResizeMode(QQuickWidget::SizeRootObjectToView);
item->setWidth(60);
item->setHeight(80);
QCOMPARE(view->width(), 80);
QCOMPARE(view->height(), 100);
QCOMPARE(QSize(item->width(), item->height()), view->sizeHint());
// size update from view
view->resize(QSize(200,300));
QTRY_COMPARE(item->width(), 200.0);
QCOMPARE(item->height(), 300.0);
QCOMPARE(view->size(), QSize(200, 300));
QCOMPARE(view->size(), view->sizeHint());
window.hide();
// if we set a specific size for the view then it should keep that size
// for SizeRootObjectToView mode.
view.reset(new QQuickWidget(&window));
view->resize(300, 300);
view->setResizeMode(QQuickWidget::SizeRootObjectToView);
QCOMPARE(QSize(0,0), view->initialSize());
view->setSource(testFileUrl("resizemodeitem.qml"));
view->resize(300, 300);
item = qobject_cast<QQuickItem*>(view->rootObject());
QVERIFY(item);
window.show();
view->showNormal();
// initial size from root object
QCOMPARE(item->width(), 300.0);
QCOMPARE(item->height(), 300.0);
QTRY_COMPARE(view->size(), QSize(300, 300));
QCOMPARE(view->size(), view->sizeHint());
QCOMPARE(view->initialSize(), QSize(200, 200)); // initial object size
}
Update layout when QQuickWidget changes size Task-number: QTBUG-47722 Change-Id: I612f89945961a3995878c424bf27dbbedf8375c8 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2017-08-14 08:29:53 +00:00
void tst_qquickwidget::layoutSizeChange()
{
QWidget window;
window.resize(400, 400);
QVBoxLayout *layout = new QVBoxLayout(&window);
layout->setContentsMargins(0,0,0,0);
layout->setSpacing(0);
QScopedPointer<QQuickWidget> view(new QQuickWidget);
layout->addWidget(view.data());
QLabel *label = new QLabel("Label");
layout->addWidget(label);
layout->addStretch(1);
view->resize(300,300);
view->setResizeMode(QQuickWidget::SizeViewToRootObject);
QCOMPARE(QSize(0,0), view->initialSize());
view->setSource(testFileUrl("rectangle.qml"));
QQuickItem* item = qobject_cast<QQuickItem*>(view->rootObject());
QVERIFY(item);
QCOMPARE(item->height(), 200.0);
window.show();
QVERIFY(QTest::qWaitForWindowExposed(&window, 5000));
QTRY_COMPARE(view->height(), 200);
QTRY_COMPARE(label->y(), 200);
item->setSize(QSizeF(100,100));
QCOMPARE(item->height(), 100.0);
QTRY_COMPARE(view->height(), 100);
QTRY_COMPARE(label->y(), 100);
}
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
void tst_qquickwidget::errors()
{
QQuickWidget *view = new QQuickWidget;
QScopedPointer<QQuickWidget> cleanupView(view);
QQuickView/QQuickWidget::errors(): fix crash Change-Id: Ie37ed5fac642931b658d2b738ddd45d23cda54c6 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net> Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-09-01 16:04:44 +00:00
QVERIFY(view->errors().isEmpty()); // don't crash
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QQmlTestMessageHandler messageHandler;
view->setSource(testFileUrl("error1.qml"));
tests/quick: Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b). - Replace Q[TRY]_VERIFY(pointer == 0) by Q[TRY]_VERIFY(!pointer). - Replace Q[TRY]_VERIFY(smartPointer == 0) by Q[TRY]_VERIFY(smartPointer.isNull()). - Replace Q[TRY]_VERIFY(a == b) by Q[TRY]_COMPARE(a, b) and add casts where necessary. The values will then be logged should a test fail. Change-Id: Ib9f4c2486af23c47990be4b9e004b965de226dcc Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
2015-07-24 13:32:22 +00:00
QCOMPARE(view->status(), QQuickWidget::Error);
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(view->errors().size(), 1);
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
}
void tst_qquickwidget::engine()
{
QScopedPointer<QQmlEngine> engine(new QQmlEngine);
use nullptr consistently (clang-tidy) From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2018-02-21 09:41:54 +00:00
QScopedPointer<QQuickWidget> view(new QQuickWidget(engine.data(), nullptr));
QScopedPointer<QQuickWidget> view2(new QQuickWidget(view->engine(), nullptr));
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QVERIFY(view->engine());
QVERIFY(view2->engine());
QCOMPARE(view->engine(), view2->engine());
}
void tst_qquickwidget::readback()
{
QScopedPointer<QQuickWidget> view(new QQuickWidget);
view->setSource(testFileUrl("rectangle.qml"));
view->show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(view.data()));
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QImage img = view->grabFramebuffer();
QVERIFY(!img.isNull());
Port from devicePixelRatioF() to devicePixelRatio() This ports all of QtDeclarative. Change-Id: Ie6eb4d96b4d49fbed1e8be514d03e331549cd712 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2020-08-06 19:40:01 +00:00
QCOMPARE(img.width(), qCeil(view->width() * view->devicePixelRatio()));
QCOMPARE(img.height(), qCeil(view->height() * view->devicePixelRatio()));
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QRgb pix = img.pixel(5, 5);
QCOMPARE(pix, qRgb(255, 0, 0));
}
QQuickWidget: expose the underlying QQuickWindow There's a number of APIs (such as all the scenegraph-related signals) that are currently missing from QQuickWidget. Instead of duplicating every API in QQuickWidget, simply expose the underlying offscreen QQuickWindow. Task-number: QTBUG-45260 Change-Id: I1a89fe600ce675963ea24ee6dd56d6ca4fea9cd2 Reviewed-by: Andy Shaw <andy.shaw@digia.com> Reviewed-by: Gunnar Sletta <gunnar@sletta.org> Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
2015-03-26 20:34:42 +00:00
void tst_qquickwidget::renderingSignals()
{
QQuickWidget widget;
QQuickWindow *window = widget.quickWindow();
QVERIFY(window);
QSignalSpy beforeRenderingSpy(window, &QQuickWindow::beforeRendering);
QSignalSpy beforeSyncSpy(window, &QQuickWindow::beforeSynchronizing);
QSignalSpy afterRenderingSpy(window, &QQuickWindow::afterRendering);
QVERIFY(beforeRenderingSpy.isValid());
QVERIFY(beforeSyncSpy.isValid());
QVERIFY(afterRenderingSpy.isValid());
QCOMPARE(beforeRenderingSpy.size(), 0);
QCOMPARE(beforeSyncSpy.size(), 0);
QCOMPARE(afterRenderingSpy.size(), 0);
widget.setSource(testFileUrl("rectangle.qml"));
QCOMPARE(beforeRenderingSpy.size(), 0);
QCOMPARE(beforeSyncSpy.size(), 0);
QCOMPARE(afterRenderingSpy.size(), 0);
widget.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&widget));
QQuickWidget: expose the underlying QQuickWindow There's a number of APIs (such as all the scenegraph-related signals) that are currently missing from QQuickWidget. Instead of duplicating every API in QQuickWidget, simply expose the underlying offscreen QQuickWindow. Task-number: QTBUG-45260 Change-Id: I1a89fe600ce675963ea24ee6dd56d6ca4fea9cd2 Reviewed-by: Andy Shaw <andy.shaw@digia.com> Reviewed-by: Gunnar Sletta <gunnar@sletta.org> Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
2015-03-26 20:34:42 +00:00
QTRY_VERIFY(beforeRenderingSpy.size() > 0);
QTRY_VERIFY(beforeSyncSpy.size() > 0);
QTRY_VERIFY(afterRenderingSpy.size() > 0);
}
Add a unit-test for QQuickWidget::grab() Test that it actually didn't grab a blank pixmap, as happened with QOpenGLWidget in the past. Change-Id: Iee8e7ff2f3fa2f2223a2a284fec96d96f62e36a6 Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
2017-06-20 20:15:48 +00:00
void tst_qquickwidget::grab()
{
QQuickWidget view;
view.setSource(testFileUrl("rectangle.qml"));
QPixmap pixmap = view.grab();
QRgb pixel = pixmap.toImage().pixel(5, 5);
QCOMPARE(pixel, qRgb(255, 0, 0));
}
Fix crash when grabbing a QQuickWidget before it is shown. Do not access null share contexts. Task-number: QTBUG-49929 Change-Id: I1c88563df71dd6c5d186b6f2ae147614fcc6ded9 Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
2015-12-14 08:44:40 +00:00
// QTBUG-49929, verify that Qt Designer grabbing the contents before drag
// does not crash due to missing GL contexts or similar.
void tst_qquickwidget::grabBeforeShow()
{
QQuickWidget widget;
QVERIFY(!widget.grab().isNull());
}
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
void tst_qquickwidget::reparentToNewWindow()
{
Android: partly re-enable tst_qquickwidget This test does the following: - QSKIP reparentToNewWindow() because it crashes on Android - QSKIP enterLeave() because Android does not support cursor - Fix resizeOverlay() and focusOnClickInProxyWidget() by using QTestPrivate::androidCompatibleShow() that takes desired widget size and position into account while showing on Android. Task-number: QTBUG-100173 Pick-to: 6.3 6.2 Change-Id: I383d7d80ca645ca50c7a843d4906a99e1bb0d0ea Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-08 15:35:03 +00:00
#ifdef Q_OS_ANDROID
QSKIP("This test crashes on Android (see QTBUG-100173)");
#endif
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
QWidget window1;
QWidget window2;
QQuickWidget *qqw = new QQuickWidget(&window1);
qqw->setSource(testFileUrl("rectangle.qml"));
window1.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&window1));
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
window2.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&window2));
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
qqw->setParent(&window2);
Enable QQuickWidget with OpenGL over RHI Also adapts to new NativeTexture format, where the actual handle is passed around instead of a pointer to it. [ChangeLog][QQuickWidget][Important Behavioral Changes] In earlier versions, the returned value from QQuickWidget::quickWindow() would persist for the life time of the widget. This is no longer the case, so if you are connecting to its signals, make sure you also connect to its destroyed() signal and update the connections when it is destroyed. Fixes: QTBUG-78638 Change-Id: I33cee8543ef1ff5d31555ed3ac18ba78c9c45102 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2020-04-30 15:37:27 +00:00
QSignalSpy afterRenderingSpy(qqw->quickWindow(), &QQuickWindow::afterRendering);
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
qqw->show();
Enable tests for boot2qt Some tests needed fixing - Disabled tests too heavy for qemu - Skipped tests requiring OpenGL without support from the platform - Skipped tests requiring functionality on broken offscreen platform - Skipped tests that take too long on qemu + software renderer - Blacklisted tests for created bugs QTBUG-63049, QTBUG-63053 QTBUG-63055 and QTBUG-63057 Task-number: QTBUG-60268 Change-Id: I0346b0e436cf286d7d9cbc140acf324a4087cfb9 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
2017-08-30 12:39:28 +00:00
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
QTRY_VERIFY(afterRenderingSpy.size() > 0);
QImage img = qqw->grabFramebuffer();
Enable QQuickWidget with OpenGL over RHI Also adapts to new NativeTexture format, where the actual handle is passed around instead of a pointer to it. [ChangeLog][QQuickWidget][Important Behavioral Changes] In earlier versions, the returned value from QQuickWidget::quickWindow() would persist for the life time of the widget. This is no longer the case, so if you are connecting to its signals, make sure you also connect to its destroyed() signal and update the connections when it is destroyed. Fixes: QTBUG-78638 Change-Id: I33cee8543ef1ff5d31555ed3ac18ba78c9c45102 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2020-04-30 15:37:27 +00:00
Handle AA_ShareOpenGLContexts consistently in QQuickWidget QOpenGLWidget has offered a lot more fine-grained control over the lifetime of the OpenGL context it uses for rendering. In practice QQuickWidget also requires at least a part of this. To unify the behavior when it comes to reparenting to a different top-level window, add the bail out condition for AA_ShareOpenGLContexts to QQuickWidget as well. [ChangeLog][QtQuick][Important Behavior Changes] QQuickWidget now behaves identically to QOpenGLWidget when it comes to handling window changes when reparenting the widget into a hierarchy belonging to another top-level widget. Previously the OpenGL context always got destroyed and recreated in order to ensure texture resource sharing with the new top-level widget. From now on this is only true when when AA_ShareOpenGLContexts it not set. Task-number: QTBUG-54133 Change-Id: Ifda0db76fdf71dae1b9606fb5d59cee6edc2f5a4 Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2016-06-22 10:17:15 +00:00
QCOMPARE(img.pixel(5, 5), qRgb(255, 0, 0));
}
Create QmlEngine lazy in case one is not needed QQuickWidget may be used with just a root item, and won't need a QmlEngine in that case. So if one isn't given to the constructor, only create one when one is needed for evaluating source. Change-Id: I96cfe5e2473d5d53fc2d52d4646d36c43f4ccb8a Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2016-06-24 08:22:47 +00:00
void tst_qquickwidget::nullEngine()
{
QQuickWidget widget;
Lazy create QmlEngine on accessing rootContext A common usecase appears to be to set variables in the rootContext before loading a url in a QQuickWidget. We there need to ensure there is a QmlEngine to set variables on when this is attempted. Change-Id: I07aff2104313eeb3fab902ea3c6043c3c82c50f7 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2016-06-27 09:55:33 +00:00
// Default should have no errors, even with a null qml engine
Create QmlEngine lazy in case one is not needed QQuickWidget may be used with just a root item, and won't need a QmlEngine in that case. So if one isn't given to the constructor, only create one when one is needed for evaluating source. Change-Id: I96cfe5e2473d5d53fc2d52d4646d36c43f4ccb8a Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2016-06-24 08:22:47 +00:00
QVERIFY(widget.errors().isEmpty());
QCOMPARE(widget.status(), QQuickWidget::Null);
Lazy create QmlEngine on accessing rootContext A common usecase appears to be to set variables in the rootContext before loading a url in a QQuickWidget. We there need to ensure there is a QmlEngine to set variables on when this is attempted. Change-Id: I07aff2104313eeb3fab902ea3c6043c3c82c50f7 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2016-06-27 09:55:33 +00:00
// A QML engine should be created lazily.
QVERIFY(widget.rootContext());
QVERIFY(widget.engine());
Create QmlEngine lazy in case one is not needed QQuickWidget may be used with just a root item, and won't need a QmlEngine in that case. So if one isn't given to the constructor, only create one when one is needed for evaluating source. Change-Id: I96cfe5e2473d5d53fc2d52d4646d36c43f4ccb8a Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2016-06-24 08:22:47 +00:00
}
Make keyboard events work in QQuickWidget Right now many cases outside of text input fields are simply broken, e.g. one cannot use a TableView or other controls with the keyboard. Removing the seemingly unnecessary focusObject() solves all problems since this way key events get delivered to the QQuickWidget which in turn forwards to the QQuickWindow. Directly routing into the QQuickWindow's focusObject(), which can be any item in the scene is wrong since it skips a big part of QQuickWindow's event handling logic. Task-number: QTBUG-45757 Change-Id: Ie53b9003d156ab019fa4b9cf461e209990e738f7 Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2017-02-22 15:16:14 +00:00
class KeyHandlingWidget : public QQuickWidget
{
public:
void keyPressEvent(QKeyEvent *e) override {
if (e->key() == Qt::Key_A)
ok = true;
}
bool ok = false;
};
void tst_qquickwidget::keyEvents()
{
// A QQuickWidget should behave like a normal widget when it comes to event handling.
// Verify that key events actually reach the widget. (QTBUG-45757)
KeyHandlingWidget widget;
widget.setSource(testFileUrl("rectangle.qml"));
widget.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(widget.window()));
Make keyboard events work in QQuickWidget Right now many cases outside of text input fields are simply broken, e.g. one cannot use a TableView or other controls with the keyboard. Removing the seemingly unnecessary focusObject() solves all problems since this way key events get delivered to the QQuickWidget which in turn forwards to the QQuickWindow. Directly routing into the QQuickWindow's focusObject(), which can be any item in the scene is wrong since it skips a big part of QQuickWindow's event handling logic. Task-number: QTBUG-45757 Change-Id: Ie53b9003d156ab019fa4b9cf461e209990e738f7 Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2017-02-22 15:16:14 +00:00
// Note: send the event to the QWindow, not the QWidget, in order
// to simulate the full event processing chain.
QTest::keyClick(widget.window()->windowHandle(), Qt::Key_A);
QTRY_VERIFY(widget.ok);
}
Forward ShortcutOverride in QQuickWidget This is now essential since otherwise these events are simply lost. Amends 0dbc575c1a8359534761167a5f5f1e29abedd51d Task-number: QTBUG-60988 Change-Id: Ib1d99d8fcd5bb92c9b52977796f2910f0fe71c48 Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2017-05-23 12:34:23 +00:00
class ShortcutEventFilter : public QObject
{
public:
bool eventFilter(QObject *obj, QEvent *e) override {
if (e->type() == QEvent::ShortcutOverride)
shortcutOk = true;
return QObject::eventFilter(obj, e);
}
bool shortcutOk = false;
};
void tst_qquickwidget::shortcuts()
{
// Verify that ShortcutOverride events do not get lost. (QTBUG-60988)
KeyHandlingWidget widget;
widget.setSource(testFileUrl("rectangle.qml"));
widget.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(widget.window()));
Forward ShortcutOverride in QQuickWidget This is now essential since otherwise these events are simply lost. Amends 0dbc575c1a8359534761167a5f5f1e29abedd51d Task-number: QTBUG-60988 Change-Id: Ib1d99d8fcd5bb92c9b52977796f2910f0fe71c48 Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Andy Nichols <andy.nichols@qt.io>
2017-05-23 12:34:23 +00:00
// Send to the widget, verify that the QQuickWindow sees it.
ShortcutEventFilter filter;
widget.quickWindow()->installEventFilter(&filter);
QKeyEvent e(QEvent::ShortcutOverride, Qt::Key_A, Qt::ControlModifier);
QCoreApplication::sendEvent(&widget, &e);
QTRY_VERIFY(filter.shortcutOk);
}
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
void tst_qquickwidget::enterLeave()
{
Android: partly re-enable tst_qquickwidget This test does the following: - QSKIP reparentToNewWindow() because it crashes on Android - QSKIP enterLeave() because Android does not support cursor - Fix resizeOverlay() and focusOnClickInProxyWidget() by using QTestPrivate::androidCompatibleShow() that takes desired widget size and position into account while showing on Android. Task-number: QTBUG-100173 Pick-to: 6.3 6.2 Change-Id: I383d7d80ca645ca50c7a843d4906a99e1bb0d0ea Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-08 15:35:03 +00:00
#ifdef Q_OS_ANDROID
QSKIP("Android has no cursor");
#endif
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
QQuickWidget view;
view.setSource(testFileUrl("enterleave.qml"));
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
// Ensure the cursor is away from the window first
tst_qquickwidget::enterLeave(): Handle varying screen setups Take the available screen geometry and window borders into account when positioning windows and moving cursors. Task-number: QTBUG-64397 Fixes: QTBUG-72305 Change-Id: Ia2b35a0deb144ab7194f7658d599888ff9d4a706 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-12-05 10:28:47 +00:00
const auto outside = m_availableGeometry.topLeft() + QPoint(50, 50);
QCursor::setPos(outside);
QTRY_VERIFY(QCursor::pos() == outside);
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
tst_qquickwidget::enterLeave(): Handle varying screen setups Take the available screen geometry and window borders into account when positioning windows and moving cursors. Task-number: QTBUG-64397 Fixes: QTBUG-72305 Change-Id: Ia2b35a0deb144ab7194f7658d599888ff9d4a706 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-12-05 10:28:47 +00:00
view.move(m_availableGeometry.topLeft() + QPoint(100, 100));
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
view.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&view));
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
QQuickItem *rootItem = view.rootObject();
QVERIFY(rootItem);
tst_qquickwidget::enterLeave(): Handle varying screen setups Take the available screen geometry and window borders into account when positioning windows and moving cursors. Task-number: QTBUG-64397 Fixes: QTBUG-72305 Change-Id: Ia2b35a0deb144ab7194f7658d599888ff9d4a706 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-12-05 10:28:47 +00:00
const QPoint frameOffset = view.geometry().topLeft() - view.frameGeometry().topLeft();
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
QTRY_VERIFY(!rootItem->property("hasMouse").toBool());
// Check the enter
tst_qquickwidget::enterLeave(): Handle varying screen setups Take the available screen geometry and window borders into account when positioning windows and moving cursors. Task-number: QTBUG-64397 Fixes: QTBUG-72305 Change-Id: Ia2b35a0deb144ab7194f7658d599888ff9d4a706 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-12-05 10:28:47 +00:00
QCursor::setPos(view.pos() + QPoint(50, 50) + frameOffset);
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
QTRY_VERIFY(rootItem->property("hasMouse").toBool());
// Now check the leave
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QCursor::setPos(outside);
QQuickWidget: pass enter and leave events to the offscreen window By passing the enter and leave events to the offscreen window it will enable mouse areas inside a QQuickWidget to know when the mouse has actually entered or left the area if it is covering the whole item. Task-number: QTBUG-45557 Change-Id: I670ebe30e367e919c73fed449bf2bed7ca42b5fd Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
2015-12-02 08:51:35 +00:00
QTRY_VERIFY(!rootItem->property("hasMouse").toBool());
}
Use localPos for windowPos when passing mouse events to QQuickWidget QQuickWidget thinks of itself as a toplevel window, so it cannot process the offsets in a parent window. Amends 41293196b4db1aa7a0c616af312875c484639644. Task-number: QTBUG-65800 Change-Id: I8c5dcb8f44a6cbdb58bcc956d8263e68d8180bec Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2018-01-16 13:29:40 +00:00
void tst_qquickwidget::mouseEventWindowPos()
{
QWidget widget;
widget.resize(100, 100);
QQuickWidget *quick = new QQuickWidget(&widget);
quick->setSource(testFileUrl("mouse.qml"));
quick->move(50, 50);
widget.show();
stabilize and standardize tst_qquickwidget In tst_qquickwidget::enterLeave(), retain the changes from 9d2a929fa4dd0beae3c30fb08d4ed4df7368ea4f rather than the cherry-pick. Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry-picked from commit 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b) Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-01-31 19:05:38 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&widget));
Use localPos for windowPos when passing mouse events to QQuickWidget QQuickWidget thinks of itself as a toplevel window, so it cannot process the offsets in a parent window. Amends 41293196b4db1aa7a0c616af312875c484639644. Task-number: QTBUG-65800 Change-Id: I8c5dcb8f44a6cbdb58bcc956d8263e68d8180bec Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2018-01-16 13:29:40 +00:00
QQuickItem *rootItem = quick->rootObject();
QVERIFY(rootItem);
QVERIFY(!rootItem->property("wasClicked").toBool());
QVERIFY(!rootItem->property("wasDoubleClicked").toBool());
Fix a bug where hover events were not sent if the mouse was never moved This happened if the "real mouse" was never moved, since moving the real mouse caused it to update the internal QQuickWindowPrivate::lastMousePosition. If the window never got any mouse events, it would therefore fail to generate proper hover events. However, if the window got exposed under a mouse cursor it would generate a hover enter event. We therefore update lastMousePosition when that happens also. Change-Id: I77d9b1bd779a813756c4056b015f2e81664b6d36 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2018-08-23 12:00:01 +00:00
// Moving an item under the mouse cursor will trigger a mouse move event.
// The above quick->move() will trigger a mouse move event on macOS.
// Discard that in order to get a clean slate for the actual tests.
rootItem->setProperty("wasMoved", QVariant(false));
Use localPos for windowPos when passing mouse events to QQuickWidget QQuickWidget thinks of itself as a toplevel window, so it cannot process the offsets in a parent window. Amends 41293196b4db1aa7a0c616af312875c484639644. Task-number: QTBUG-65800 Change-Id: I8c5dcb8f44a6cbdb58bcc956d8263e68d8180bec Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
2018-01-16 13:29:40 +00:00
QWindow *window = widget.windowHandle();
QVERIFY(window);
QTest::mouseMove(window, QPoint(60, 60));
QTest::mouseClick(window, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(60, 60));
QTRY_VERIFY(rootItem->property("wasClicked").toBool());
QTest::mouseDClick(window, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(60, 60));
QTRY_VERIFY(rootItem->property("wasDoubleClicked").toBool());
QTest::mouseMove(window, QPoint(70, 70));
QTRY_VERIFY(rootItem->property("wasMoved").toBool());
}
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
void tst_qquickwidget::synthMouseFromTouch_data()
{
QTest::addColumn<bool>("synthMouse"); // AA_SynthesizeMouseForUnhandledTouchEvents
QTest::addColumn<bool>("acceptTouch"); // QQuickItem::touchEvent: setAccepted()
QTest::newRow("no synth, accept") << false << true; // suitable for touch-capable UIs
QTest::newRow("no synth, don't accept") << false << false;
QTest::newRow("synth and accept") << true << true;
QTest::newRow("synth, don't accept") << true << false; // the default
}
void tst_qquickwidget::synthMouseFromTouch()
{
QFETCH(bool, synthMouse);
QFETCH(bool, acceptTouch);
QCoreApplication::setAttribute(Qt::AA_SynthesizeMouseForUnhandledTouchEvents, synthMouse);
QWidget window;
window.setAttribute(Qt::WA_AcceptTouchEvents);
QScopedPointer<MouseRecordingQQWidget> childView(new MouseRecordingQQWidget(&window));
Fix and un-blacklist tst_qquickwidget::synthMouseFromTouch In Qt 6, any QQuickItem that wants to handle touch events needs to explicitly enable them by calling setAcceptTouchEvents(true). This was anticipated in 1457df74f4c1d770e1e820de8cd082be1bd2489e and ab91e7fa02a562d80fd0747f28a60e00c3b45a01 If an Item calls setAcceptTouchEvents(true), it will not receive synth-mouse events, even if it calls ignore() on a particular touch press event. So now in this test, when we want to test synth-mouse events, we call setAcceptTouchEvents(false). Task-number: QTBUG-86729 Task-number: QTBUG-101736 Pick-to: 6.4 6.3 6.2 Change-Id: I71d2f213bc62206c190c94de5e4d39ce17504a0d Reviewed-by: Doris Verria <doris.verria@qt.io>
2022-03-17 16:41:59 +00:00
MouseRecordingItem *item = new MouseRecordingItem(!synthMouse, acceptTouch, nullptr);
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
childView->setContent(QUrl(), nullptr, item);
window.resize(300, 300);
childView->resize(300, 300);
window.show();
QVERIFY(QTest::qWaitForWindowActive(&window));
Quick fix for not working input handling for eglfs On eglfs platform input events are driven by libinput and do not have window information as such. They are simply delivered based on QGuiApplication::topLevelAt window selection. In case of WebEnigne, QQuickWindow is returned as top level window. QQuickWidget uses this QQuickWindow as an offscreen window, however since 561b932 we fake 'visible' and 'visibility' values so windows api in qml can use those properties. This ends up with broken event delivery on eglfs, since window is offscreen and therefore not really visible. Make a minimalistic change to fix the issue, without braking QTBUG-49054, which requires 'visibility' to have fake values, and 'visible' will keep window as not visible for event delivery system. Fix encapsulation of setVisible(), prevent accidental window creation when setVsiible() called from qml via binding. The proper fix would require for example adding some new flag to underlying offscreen window, which could be used by event window selection mechanism or rework of qquickwidget offscreen window parameters expose to qml. Task-number: QTBUG-65761 Task-number: QTBUG-49054 Change-Id: I2a307ee5613771adf6d31f1c3cc4b4a25d7620df Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-04-02 14:07:34 +00:00
QVERIFY(!childView->quickWindow()->isVisible()); // this window is always not visible see QTBUG-65761
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
QVERIFY(item->isVisible());
QPoint p1 = QPoint(20, 20);
QPoint p2 = QPoint(30, 30);
QTest::touchEvent(&window, device).press(0, p1, &window);
QTest::touchEvent(&window, device).move(0, p2, &window);
QTest::touchEvent(&window, device).release(0, p2, &window);
Test MouseArea in QQuickWidget Task-number: QTBUG-101736 Pick-to: 6.2 6.4 6.5 Change-Id: Iecbe6b4da75851cb94c4c2bae41bb0cb50f0ed30 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-03-18 12:13:24 +00:00
qCDebug(lcTests) << item->m_touchEvents << item->m_mouseEvents;
Port from container::count() and length() to size() This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2022-10-05 05:29:16 +00:00
QCOMPARE(item->m_touchEvents.size(), synthMouse ? 0 : (acceptTouch ? 3 : 1));
QCOMPARE(item->m_mouseEvents.size(), synthMouse ? 3 : 0);
QCOMPARE(childView->m_mouseEvents.size(), 0);
Don't copy or assign QEvent instances in tests Copying/assigning polymorphic types is a code smell, use separate instances instead in the tests. Those should perhaps be rewritten to use a data driven testing approach, there's a lot of code repetition. In the test API implementation, first evaluate the parameters for the event, then construct the event once with the correct values. Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
2020-11-11 12:51:35 +00:00
for (const auto &ev : item->m_mouseEvents)
QCOMPARE(ev, Qt::MouseEventSynthesizedByQt);
add tst_qquickwidget::synthMouseFromTouch test Make sure events are delivered as expected and that synth-mouse events have the right source(). Task-number: QTBUG-64241 Change-Id: I95a073ce0faea2111c8e1aca42fa44c1b529a6ec Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2017-11-30 10:36:42 +00:00
}
Test MouseArea in QQuickWidget Task-number: QTBUG-101736 Pick-to: 6.2 6.4 6.5 Change-Id: Iecbe6b4da75851cb94c4c2bae41bb0cb50f0ed30 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-03-18 12:13:24 +00:00
void tst_qquickwidget::touchTapMouseArea()
{
QWidget window;
window.resize(100, 100);
window.setObjectName("window widget");
window.setAttribute(Qt::WA_AcceptTouchEvents);
QVERIFY(QCoreApplication::testAttribute(Qt::AA_SynthesizeMouseForUnhandledTouchEvents));
QQuickWidget *quick = new QQuickWidget(&window);
quick->setSource(testFileUrl("mouse.qml"));
quick->move(50, 50);
quick->setObjectName("quick widget");
window.show();
QVERIFY(QTest::qWaitForWindowExposed(&window));
QQuickItem *rootItem = quick->rootObject();
QVERIFY(rootItem);
QQuickMouseArea *ma = rootItem->findChild<QQuickMouseArea *>();
QVERIFY(ma);
QPoint p1 = QPoint(70, 70);
QTest::touchEvent(&window, device).press(0, p1, &window);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(ma->isPressed(), true);
Test MouseArea in QQuickWidget Task-number: QTBUG-101736 Pick-to: 6.2 6.4 6.5 Change-Id: Iecbe6b4da75851cb94c4c2bae41bb0cb50f0ed30 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-03-18 12:13:24 +00:00
QTest::touchEvent(&window, device).move(0, p1, &window);
QTest::touchEvent(&window, device).release(0, p1, &window);
QQuickMouseArea: do not overload pressed-signal Renames the pressed() getter of the pressed property in QQuickMouseArea to isPressed() to avoid overloading the pressed()-signal. Signals should not be overloaded. Also, it makes code generation in qmltc more complicated. Task-number: QTBUG-110029 Change-Id: I2373f4fe97b1e955b815825003bc746f2eaf43be Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
2023-01-11 09:37:21 +00:00
QTRY_COMPARE(ma->isPressed(), false);
Test MouseArea in QQuickWidget Task-number: QTBUG-101736 Pick-to: 6.2 6.4 6.5 Change-Id: Iecbe6b4da75851cb94c4c2bae41bb0cb50f0ed30 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2022-03-18 12:13:24 +00:00
QVERIFY(rootItem->property("wasClicked").toBool());
}
QQuickWidget: always accept touch events and grabbed event points A QQuickWidget contains a Quick UI, which can be expected to handle touch events, and it handles touch events by forwarding them to the QQuickWindow. So set the AcceptTouchEvents attribute and let the Qt Quick delivery machinery deal with the touch-mouse synthesis within the scene. Also, Qt Quick's event delivery might return event points as ignored after setting the exclusive grabber. Qt Widgets touch event delivery logic doesn't care about exclusive grabbers, and relies on the event points being accepted to make the widget that received the TouchBegin an implicit grabber. QQuickWidget needs to translate those states back, so accept all points that come back with a grabber. Add a test that verifies that a button in a popup gets all events, and that those events are translated correctly - without the fix, the "clicked" test fails, as the release is delivered, but with coordinates outside of the button. Also test that we can have two QQuickWidgets where each gets one touch point. Fixes: QTBUG-101736 Pick-to: 6.5 6.4 6.2 Change-Id: I3a2bf05fd297ae4d72b6e236ecd8e5ddac37ce06 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2022-12-14 08:52:51 +00:00
void tst_qquickwidget::touchTapButton()
{
QWidget window;
QQuickWidget *quick = new QQuickWidget;
quick->setSource(testFileUrl("button.qml"));
QHBoxLayout hbox;
hbox.addWidget(quick);
window.setLayout(&hbox);
window.show();
QVERIFY(QTest::qWaitForWindowExposed(&window));
QQuickItem *rootItem = quick->rootObject();
QVERIFY(rootItem);
QQuickButton *button = rootItem->findChild<QQuickButton *>("button");
QVERIFY(button);
const QPoint point = quick->mapTo(&window, button->mapToScene(button->boundingRect().center()).toPoint());
QTest::touchEvent(&window, device).press(0, point, &window).commit();
QTRY_VERIFY(rootItem->property("wasPressed").toBool());
QTest::touchEvent(&window, device).release(0, point, &window).commit();
QTRY_VERIFY(rootItem->property("wasReleased").toBool());
QTRY_VERIFY(rootItem->property("wasClicked").toBool());
}
void tst_qquickwidget::touchMultipleWidgets()
{
QWidget window;
QQuickWidget *leftQuick = new QQuickWidget;
leftQuick->setSource(testFileUrl("button.qml"));
QQuickWidget *rightQuick = new QQuickWidget;
rightQuick->setSource(testFileUrl("button.qml"));
QHBoxLayout hbox;
hbox.addWidget(leftQuick);
hbox.addWidget(rightQuick);
window.setLayout(&hbox);
window.show();
QVERIFY(QTest::qWaitForWindowExposed(&window));
QQuickItem *leftRootItem = leftQuick->rootObject();
QQuickItem *rightRootItem = rightQuick->rootObject();
QVERIFY(leftRootItem);
QVERIFY(rightRootItem);
QQuickButton *leftButton = leftRootItem->findChild<QQuickButton *>("button");
QQuickButton *rightButton = rightRootItem->findChild<QQuickButton *>("button");
QVERIFY(leftButton);
QVERIFY(rightButton);
const QPoint leftPoint = leftQuick->mapTo(&window, leftButton->mapToScene(
leftButton->boundingRect().center()).toPoint());
const QPoint rightPoint = rightQuick->mapTo(&window, rightButton->mapToScene(
rightButton->boundingRect().center()).toPoint());
QTest::touchEvent(&window, device).press(0, leftPoint, &window).commit();
QTRY_VERIFY(leftRootItem->property("wasPressed").toBool());
QTest::touchEvent(&window, device).press(1, rightPoint, &window).commit();
QTRY_VERIFY(rightRootItem->property("wasPressed").toBool());
QTest::touchEvent(&window, device).release(1, rightPoint, &window).commit();
QTRY_VERIFY(rightRootItem->property("wasReleased").toBool());
QVERIFY(rightRootItem->property("wasClicked").toBool());
QTest::touchEvent(&window, device).release(0, leftPoint, &window).commit();
QTRY_VERIFY(leftRootItem->property("wasReleased").toBool());
QVERIFY(leftRootItem->property("wasClicked").toBool());
}
Pass on tab presses to the offscreen window to handle first When pressing tab/backtab then the offscreen window needs to pass it on to the item in case it will handle this for changing focus. If it does not handle the event, it will pass it back for QWidget handling. [ChangeLog][QQuickWidget] Tab presses are now passed on to the root item to be handled first. When not handled by the root item, it will be handled like a standard QWidget. Task-number: QTBUG-45641 Change-Id: Ief0552ba496c87ab0b6e12aa8e67ef44b5a20ae2 Reviewed-by: Liang Qi <liang.qi@qt.io>
2017-11-01 14:40:14 +00:00
void tst_qquickwidget::tabKey()
{
if (QGuiApplication::styleHints()->tabFocusBehavior() != Qt::TabFocusAllControls)
QSKIP("This function doesn't support NOT iterating all.");
QWidget window1;
QQuickWidget *qqw = new QQuickWidget(&window1);
qqw->setSource(testFileUrl("activeFocusOnTab.qml"));
QQuickWidget *qqw2 = new QQuickWidget(&window1);
qqw2->setSource(testFileUrl("noActiveFocusOnTab.qml"));
qqw2->move(100, 0);
window1.show();
qqw->setFocus();
QVERIFY(QTest::qWaitForWindowExposed(&window1, 5000));
QVERIFY(qqw->hasFocus());
QQuickItem *item = qobject_cast<QQuickItem *>(qqw->rootObject());
QQuickItem *topItem = item->findChild<QQuickItem *>("topRect");
QQuickItem *middleItem = item->findChild<QQuickItem *>("middleRect");
QQuickItem *bottomItem = item->findChild<QQuickItem *>("bottomRect");
topItem->forceActiveFocus();
QVERIFY(topItem->property("activeFocus").toBool());
QTest::keyClick(qqw, Qt::Key_Tab);
QTRY_VERIFY(middleItem->property("activeFocus").toBool());
QTest::keyClick(qqw, Qt::Key_Tab);
QTRY_VERIFY(bottomItem->property("activeFocus").toBool());
QTest::keyClick(qqw, Qt::Key_Backtab);
QTRY_VERIFY(middleItem->property("activeFocus").toBool());
qqw2->setFocus();
QQuickItem *item2 = qobject_cast<QQuickItem *>(qqw2->rootObject());
QQuickItem *topItem2 = item2->findChild<QQuickItem *>("topRect2");
QTRY_VERIFY(qqw2->hasFocus());
QVERIFY(topItem2->property("activeFocus").toBool());
QTest::keyClick(qqw2, Qt::Key_Tab);
QTRY_VERIFY(qqw->hasFocus());
QVERIFY(middleItem->property("activeFocus").toBool());
}
Resize offscreen window when QQuickWidget is resized In a typical Qt Quick application, when a window is resized, the contentItem of that window is resized with it, and then the root item. QQuickOverlay in qtquickcontrols2 listens to size changes in the contentItem (QQuickRootItem) via addItemChangeListener(), as a cheap way (e.g. no signals) of knowing when to resize background dimming effects. It resizes the dimmer item to the size of the window. The first problem with QQuickWidget is that it only ever resizes the root item when using the SizeRootObjectToView resize mode, and not the contentItem. The second problem is that the root item is resized (via updateSize()) before the window itself even has a size (which happens in QQuickWidget::createFramebufferObject() via the call to d->offscreenWindow->setGeometry()). To demonstrate the second problem in detail, consider the following widget hierarchy (written in everybody's favorite language: QML): QMainWindow { QQuickWidget { QQuickWindow { // QQuickWidgetPrivate::offscreenWindow QQuickRootItem { // QQuickWindowPrivate::contentItem Page {} // QQuickWidgetPrivate::root } } } } The QMainWindow starts off as 200x200. When the window is resized, QQuickWidget::resizeEvent() is called. The first thing it does is call updateSize(), which in the case of SizeRootObjectToView, resizes the root item to 300x300. This causes QQuickOverlayPrivate::itemGeometryChanged() to be called, and the dimmers are resized to the size of the window, but the window still has its 200x200 size, as it is only updated later, when QQuickWidget::createFramebufferObject() is called. This patch fixes these issues by ensuring that contentItem and the window itself are resized along with the root item. As to why such manual intervention is necessary: from what I can see, it is because it's an "offscreen" window. This means that QWindowPrivate::platformWindow is null, and setGeometry() takes a different path that presumably results in no QResizeEvent being sent to the QQuickWindow. As QQuickWindow relies on resizeEvent() being called to resize its contentItem, the contentItem is never resized. With a typical Qt Quick application, all of this works as expected. Change-Id: I7401aa7a9b209096183416ab53014f67cceccbe4 Fixes: QTBUG-78323 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2020-03-05 15:00:04 +00:00
class Overlay : public QQuickItem, public QQuickItemChangeListener
{
Q_OBJECT
public:
Overlay() = default;
~Overlay()
{
QQuickItemPrivate::get(parentItem())->removeItemChangeListener(this, QQuickItemPrivate::Geometry);
}
// componentCompleted() is too early to add the listener, as parentItem()
// is still null by that stage, so we use this function instead.
void startListening()
{
QQuickItemPrivate::get(parentItem())->addItemChangeListener(this, QQuickItemPrivate::Geometry);
}
private:
Mark overrides in tests, fix compiler warnings Change-Id: If753558d911e50a73e351a93eed2e4df3e6592c7 Reviewed-by: David Skoland <david.skoland@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-03-25 13:44:04 +00:00
void itemGeometryChanged(QQuickItem *, QQuickGeometryChange, const QRectF &/*oldGeometry*/) override
Resize offscreen window when QQuickWidget is resized In a typical Qt Quick application, when a window is resized, the contentItem of that window is resized with it, and then the root item. QQuickOverlay in qtquickcontrols2 listens to size changes in the contentItem (QQuickRootItem) via addItemChangeListener(), as a cheap way (e.g. no signals) of knowing when to resize background dimming effects. It resizes the dimmer item to the size of the window. The first problem with QQuickWidget is that it only ever resizes the root item when using the SizeRootObjectToView resize mode, and not the contentItem. The second problem is that the root item is resized (via updateSize()) before the window itself even has a size (which happens in QQuickWidget::createFramebufferObject() via the call to d->offscreenWindow->setGeometry()). To demonstrate the second problem in detail, consider the following widget hierarchy (written in everybody's favorite language: QML): QMainWindow { QQuickWidget { QQuickWindow { // QQuickWidgetPrivate::offscreenWindow QQuickRootItem { // QQuickWindowPrivate::contentItem Page {} // QQuickWidgetPrivate::root } } } } The QMainWindow starts off as 200x200. When the window is resized, QQuickWidget::resizeEvent() is called. The first thing it does is call updateSize(), which in the case of SizeRootObjectToView, resizes the root item to 300x300. This causes QQuickOverlayPrivate::itemGeometryChanged() to be called, and the dimmers are resized to the size of the window, but the window still has its 200x200 size, as it is only updated later, when QQuickWidget::createFramebufferObject() is called. This patch fixes these issues by ensuring that contentItem and the window itself are resized along with the root item. As to why such manual intervention is necessary: from what I can see, it is because it's an "offscreen" window. This means that QWindowPrivate::platformWindow is null, and setGeometry() takes a different path that presumably results in no QResizeEvent being sent to the QQuickWindow. As QQuickWindow relies on resizeEvent() being called to resize its contentItem, the contentItem is never resized. With a typical Qt Quick application, all of this works as expected. Change-Id: I7401aa7a9b209096183416ab53014f67cceccbe4 Fixes: QTBUG-78323 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2020-03-05 15:00:04 +00:00
{
auto window = QQuickItemPrivate::get(this)->window;
if (!window)
return;
setSize(window->size());
}
};
// Test that an item that resizes itself based on the window size can use a
// Geometry item change listener to respond to changes in size. This is a
// simplified test to mimic a use case involving Overlay from Qt Quick Controls 2.
void tst_qquickwidget::resizeOverlay()
{
QWidget widget;
auto contentVerticalLayout = new QVBoxLayout(&widget);
Update dependencies.yaml and adapt to API changes in qtbase The evaluation callback does not have to perform the comparison anymore and the shared pointer of the private is not used in the API anymore. Also, the versionFunctions() has been moved out of QOpenGLContext and renamed QOpenGLVersionFunctionsFactory::get(). QHash doesn't keep iterators stable under erase(), so clean up the code relying on it, and avoid an intermediate QList at the same time. Task-number: QTBUG-74409 Change-Id: I90176be1067d88c8f2b1ea07198a06d432f5be9c Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
2020-04-14 12:38:13 +00:00
contentVerticalLayout->setContentsMargins(0, 0, 0, 0);
Resize offscreen window when QQuickWidget is resized In a typical Qt Quick application, when a window is resized, the contentItem of that window is resized with it, and then the root item. QQuickOverlay in qtquickcontrols2 listens to size changes in the contentItem (QQuickRootItem) via addItemChangeListener(), as a cheap way (e.g. no signals) of knowing when to resize background dimming effects. It resizes the dimmer item to the size of the window. The first problem with QQuickWidget is that it only ever resizes the root item when using the SizeRootObjectToView resize mode, and not the contentItem. The second problem is that the root item is resized (via updateSize()) before the window itself even has a size (which happens in QQuickWidget::createFramebufferObject() via the call to d->offscreenWindow->setGeometry()). To demonstrate the second problem in detail, consider the following widget hierarchy (written in everybody's favorite language: QML): QMainWindow { QQuickWidget { QQuickWindow { // QQuickWidgetPrivate::offscreenWindow QQuickRootItem { // QQuickWindowPrivate::contentItem Page {} // QQuickWidgetPrivate::root } } } } The QMainWindow starts off as 200x200. When the window is resized, QQuickWidget::resizeEvent() is called. The first thing it does is call updateSize(), which in the case of SizeRootObjectToView, resizes the root item to 300x300. This causes QQuickOverlayPrivate::itemGeometryChanged() to be called, and the dimmers are resized to the size of the window, but the window still has its 200x200 size, as it is only updated later, when QQuickWidget::createFramebufferObject() is called. This patch fixes these issues by ensuring that contentItem and the window itself are resized along with the root item. As to why such manual intervention is necessary: from what I can see, it is because it's an "offscreen" window. This means that QWindowPrivate::platformWindow is null, and setGeometry() takes a different path that presumably results in no QResizeEvent being sent to the QQuickWindow. As QQuickWindow relies on resizeEvent() being called to resize its contentItem, the contentItem is never resized. With a typical Qt Quick application, all of this works as expected. Change-Id: I7401aa7a9b209096183416ab53014f67cceccbe4 Fixes: QTBUG-78323 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2020-03-05 15:00:04 +00:00
qmlRegisterType<Overlay>("Test", 1, 0, "Overlay");
auto quickWidget = new QQuickWidget(testFileUrl("resizeOverlay.qml"), &widget);
QCOMPARE(quickWidget->status(), QQuickWidget::Ready);
quickWidget->setResizeMode(QQuickWidget::SizeRootObjectToView);
contentVerticalLayout->addWidget(quickWidget);
auto rootItem = qobject_cast<QQuickItem*>(quickWidget->rootObject());
QVERIFY(rootItem);
auto overlay = rootItem->property("overlay").value<Overlay*>();
QVERIFY(overlay);
QVERIFY(overlay->parentItem());
overlay->startListening();
widget.resize(200, 200);
Android: partly re-enable tst_qquickwidget This test does the following: - QSKIP reparentToNewWindow() because it crashes on Android - QSKIP enterLeave() because Android does not support cursor - Fix resizeOverlay() and focusOnClickInProxyWidget() by using QTestPrivate::androidCompatibleShow() that takes desired widget size and position into account while showing on Android. Task-number: QTBUG-100173 Pick-to: 6.3 6.2 Change-Id: I383d7d80ca645ca50c7a843d4906a99e1bb0d0ea Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-08 15:35:03 +00:00
QTestPrivate::androidCompatibleShow(&widget);
Resize offscreen window when QQuickWidget is resized In a typical Qt Quick application, when a window is resized, the contentItem of that window is resized with it, and then the root item. QQuickOverlay in qtquickcontrols2 listens to size changes in the contentItem (QQuickRootItem) via addItemChangeListener(), as a cheap way (e.g. no signals) of knowing when to resize background dimming effects. It resizes the dimmer item to the size of the window. The first problem with QQuickWidget is that it only ever resizes the root item when using the SizeRootObjectToView resize mode, and not the contentItem. The second problem is that the root item is resized (via updateSize()) before the window itself even has a size (which happens in QQuickWidget::createFramebufferObject() via the call to d->offscreenWindow->setGeometry()). To demonstrate the second problem in detail, consider the following widget hierarchy (written in everybody's favorite language: QML): QMainWindow { QQuickWidget { QQuickWindow { // QQuickWidgetPrivate::offscreenWindow QQuickRootItem { // QQuickWindowPrivate::contentItem Page {} // QQuickWidgetPrivate::root } } } } The QMainWindow starts off as 200x200. When the window is resized, QQuickWidget::resizeEvent() is called. The first thing it does is call updateSize(), which in the case of SizeRootObjectToView, resizes the root item to 300x300. This causes QQuickOverlayPrivate::itemGeometryChanged() to be called, and the dimmers are resized to the size of the window, but the window still has its 200x200 size, as it is only updated later, when QQuickWidget::createFramebufferObject() is called. This patch fixes these issues by ensuring that contentItem and the window itself are resized along with the root item. As to why such manual intervention is necessary: from what I can see, it is because it's an "offscreen" window. This means that QWindowPrivate::platformWindow is null, and setGeometry() takes a different path that presumably results in no QResizeEvent being sent to the QQuickWindow. As QQuickWindow relies on resizeEvent() being called to resize its contentItem, the contentItem is never resized. With a typical Qt Quick application, all of this works as expected. Change-Id: I7401aa7a9b209096183416ab53014f67cceccbe4 Fixes: QTBUG-78323 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io>
2020-03-05 15:00:04 +00:00
QCOMPARE(rootItem->width(), 200);
QCOMPARE(rootItem->height(), 200);
QCOMPARE(overlay->width(), rootItem->width());
QCOMPARE(overlay->height(), rootItem->height());
widget.resize(300, 300);
QCOMPARE(rootItem->width(), 300);
QCOMPARE(rootItem->height(), 300);
QCOMPARE(overlay->width(), rootItem->width());
QCOMPARE(overlay->height(), rootItem->height());
}
Handle redirected rendering better in styles Unlike in the QWidget-based desktop world, Qt Quick scenes can be rendered in a variety of ways, some completely offscreen wthout any native windows on screen, whereas some (most notably, QQuickWidget) work offscreen but in association with an on-screen window that is not the QQuickWindow. Therefore, every time a QQuickWindow is accessed, typically from QQuickStyleItem, it needs to be considered if further resolution is needed. For devicePixelRatio, there is a handy helper available in form of QQuickWindow::effectiveDevicePixelRatio(). This picks up the dpr from either the QQuickWindow or the QQuickWidget's associated top-level QWidget window (or whatever window a custom QQuickRenderControl implementation reports). Elsewhere, where we need a QWindow in order to do native window things, QQuickRenderControl::renderWindowFor() must be called to see if there is another QWindow we should be using in place of the QQuickWindow. Pick-to: 6.2 Fixes: QTBUG-95937 Change-Id: I0690915d995ebb5f5cc0c48f565dfaf978e849ea Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
2021-08-20 08:43:34 +00:00
void tst_qquickwidget::controls()
{
// Smoke test for having some basic Quick Controls in a scene in a QQuickWidget.
QWidget widget;
QVBoxLayout *contentVerticalLayout = new QVBoxLayout(&widget);
QQuickWidget *quickWidget = new QQuickWidget(testFileUrl("controls.qml"), &widget);
QCOMPARE(quickWidget->status(), QQuickWidget::Ready);
quickWidget->setResizeMode(QQuickWidget::SizeRootObjectToView);
contentVerticalLayout->addWidget(quickWidget);
widget.resize(400, 400);
widget.show();
QVERIFY(QTest::qWaitForWindowExposed(&widget));
QQuickItem *rootItem = qobject_cast<QQuickItem *>(quickWidget->rootObject());
QVERIFY(rootItem);
QCOMPARE(rootItem->size(), quickWidget->size());
QSize oldSize = quickWidget->size();
// Verify that QTBUG-95937 no longer occurs. (on Windows with the default
// native windows style this used to assert in debug builds)
widget.resize(300, 300);
QTRY_VERIFY(quickWidget->width() < oldSize.width());
QTRY_COMPARE(rootItem->size(), quickWidget->size());
widget.hide();
widget.show();
QVERIFY(QTest::qWaitForWindowExposed(&widget));
}
Fix focus for items inside a QQuickWidget in a QGraphicsProxyWidget QQuickWidgetRenderControl::renderWindowFor() did not take the proxy widget into account, making it impossible to give focus to items inside a QGraphicsProxyWidget by clicking on the item. This patch is based on a patch by Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>, which fixed renderWindowFor(), but did not handle the case where a proxy widget was in multiple views. This version of the patch adds QQuickRenderControlPrivate::isRenderWindowFor(), which allows all the views of the proxy widget to handle focus. This patch also carefully preserves the non-obvious feature of the previous implementation where all windows are considered to have focus if QGuiApplication::focusWindow() == nullptr. [ChangeLog][QuickWidget][Quick items inside a QuickWidget that is inside a QGraphicsProxyWidget can now get focus by clicking.] Fixes: QTBUG-91479 Pick-to: 6.2 Change-Id: I4a6fbbbeda2d14b5a6d8eb8218d5b14a3404d9c3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-11-29 16:23:18 +00:00
void tst_qquickwidget::focusOnClick()
{
QQuickWidget quick;
quick.setSource(testFileUrl("FocusOnClick.qml"));
quick.show();
QVERIFY(QTest::qWaitForWindowExposed(&quick));
QQuickItem *rootItem = quick.rootObject();
QVERIFY(rootItem);
QWindow *window = quick.windowHandle();
QVERIFY(window);
QQuickItem *text1 = rootItem->findChild<QQuickItem *>("text1");
QVERIFY(text1);
QQuickItem *text2 = rootItem->findChild<QQuickItem *>("text2");
QVERIFY(text2);
QTest::mouseClick(window, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(75, 25));
QTRY_VERIFY(text1->hasActiveFocus());
QVERIFY(!text2->hasActiveFocus());
QTest::mouseClick(window, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(75, 75));
QTRY_VERIFY(text2->hasActiveFocus());
QVERIFY(!text1->hasActiveFocus());
}
#if QT_CONFIG(graphicsview)
void tst_qquickwidget::focusOnClickInProxyWidget()
{
QGraphicsScene scene(0,0,400,400);
QGraphicsView view1(&scene);
view1.setFrameStyle(QFrame::NoFrame);
view1.resize(400,400);
Android: partly re-enable tst_qquickwidget This test does the following: - QSKIP reparentToNewWindow() because it crashes on Android - QSKIP enterLeave() because Android does not support cursor - Fix resizeOverlay() and focusOnClickInProxyWidget() by using QTestPrivate::androidCompatibleShow() that takes desired widget size and position into account while showing on Android. Task-number: QTBUG-100173 Pick-to: 6.3 6.2 Change-Id: I383d7d80ca645ca50c7a843d4906a99e1bb0d0ea Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-08 15:35:03 +00:00
QTestPrivate::androidCompatibleShow(&view1);
Fix focus for items inside a QQuickWidget in a QGraphicsProxyWidget QQuickWidgetRenderControl::renderWindowFor() did not take the proxy widget into account, making it impossible to give focus to items inside a QGraphicsProxyWidget by clicking on the item. This patch is based on a patch by Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>, which fixed renderWindowFor(), but did not handle the case where a proxy widget was in multiple views. This version of the patch adds QQuickRenderControlPrivate::isRenderWindowFor(), which allows all the views of the proxy widget to handle focus. This patch also carefully preserves the non-obvious feature of the previous implementation where all windows are considered to have focus if QGuiApplication::focusWindow() == nullptr. [ChangeLog][QuickWidget][Quick items inside a QuickWidget that is inside a QGraphicsProxyWidget can now get focus by clicking.] Fixes: QTBUG-91479 Pick-to: 6.2 Change-Id: I4a6fbbbeda2d14b5a6d8eb8218d5b14a3404d9c3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-11-29 16:23:18 +00:00
QQuickWidget* quick = new QQuickWidget(testFileUrl("FocusOnClick.qml"));
quick->resize(300,100);
quick->setAttribute(Qt::WA_AcceptTouchEvents);
QGraphicsProxyWidget* proxy = scene.addWidget(quick);
proxy->setAcceptTouchEvents(true);
// QTRY_VERIFY(quick->rootObject());
QQuickItem *rootItem = quick->rootObject();
QVERIFY(rootItem);
QQuickItem *text1 = rootItem->findChild<QQuickItem *>("text1");
QVERIFY(text1);
QQuickItem *text2 = rootItem->findChild<QQuickItem *>("text2");
QVERIFY(text2);
QVERIFY(QTest::qWaitForWindowExposed(&view1));
QWindow *window1 = view1.windowHandle();
QVERIFY(window1);
// Click in the QGraphicsView, outside the QuickWidget
QTest::mouseClick(window1, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(300, 300));
QTRY_VERIFY(!text1->hasActiveFocus());
QTRY_VERIFY(!text2->hasActiveFocus());
// Click on text1
QTest::mouseClick(window1, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(75, 25));
QTRY_VERIFY(text1->hasActiveFocus());
QVERIFY(!text2->hasActiveFocus());
// Now create a second view and repeat, in order to verify that we handle one QQuickItem being in multiple windows
QGraphicsView view2(&scene);
view2.resize(400,400);
Android: partly re-enable tst_qquickwidget This test does the following: - QSKIP reparentToNewWindow() because it crashes on Android - QSKIP enterLeave() because Android does not support cursor - Fix resizeOverlay() and focusOnClickInProxyWidget() by using QTestPrivate::androidCompatibleShow() that takes desired widget size and position into account while showing on Android. Task-number: QTBUG-100173 Pick-to: 6.3 6.2 Change-Id: I383d7d80ca645ca50c7a843d4906a99e1bb0d0ea Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-04-08 15:35:03 +00:00
QTestPrivate::androidCompatibleShow(&view2);
Fix focus for items inside a QQuickWidget in a QGraphicsProxyWidget QQuickWidgetRenderControl::renderWindowFor() did not take the proxy widget into account, making it impossible to give focus to items inside a QGraphicsProxyWidget by clicking on the item. This patch is based on a patch by Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>, which fixed renderWindowFor(), but did not handle the case where a proxy widget was in multiple views. This version of the patch adds QQuickRenderControlPrivate::isRenderWindowFor(), which allows all the views of the proxy widget to handle focus. This patch also carefully preserves the non-obvious feature of the previous implementation where all windows are considered to have focus if QGuiApplication::focusWindow() == nullptr. [ChangeLog][QuickWidget][Quick items inside a QuickWidget that is inside a QGraphicsProxyWidget can now get focus by clicking.] Fixes: QTBUG-91479 Pick-to: 6.2 Change-Id: I4a6fbbbeda2d14b5a6d8eb8218d5b14a3404d9c3 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-11-29 16:23:18 +00:00
QVERIFY(QTest::qWaitForWindowExposed(&view2));
QWindow *window2 = view2.windowHandle();
QVERIFY(window2);
QTest::mouseClick(window2, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(300, 300));
QTRY_VERIFY(!text1->hasActiveFocus());
QTRY_VERIFY(!text2->hasActiveFocus());
QTest::mouseClick(window2, Qt::LeftButton, Qt::KeyboardModifiers(), QPoint(75, 25));
QTRY_VERIFY(text1->hasActiveFocus());
QVERIFY(!text2->hasActiveFocus());
}
#endif
Fix problem with subFocusItem on non-OpenGL QSG The subFocusItem state was forgotten because the old parent was deleted, before its focused child was reparented. The test doesn't pass on Android and makes the test process exit with error. Since it prints warnings that indicate issues further down in the RHI stack, we'll skip it for now on that platform. Task-number: QTBUG-112696 Pick-to: 6.5 6.2 Change-Id: Ibb32a11564ff6fbb2091c241d508f12479b234b0 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2023-04-05 15:12:07 +00:00
void tst_qquickwidget::focusPreserved()
{
if (!QGuiApplicationPrivate::platformIntegration()->hasCapability(QPlatformIntegration::WindowActivation))
QSKIP("Window Activation is not supported.");
if (QGuiApplication::platformName() == "android")
QSKIP("Test doesn't exit cleanly on Android and generates many warnings - QTBUG-112696");
QScopedPointer<QWidget> widget(new QWidget());
QScopedPointer<QQuickWidget> quick(new QQuickWidget());
QQuickItem *root = new QQuickItem(); // will be owned by quick after setContent
QScopedPointer<QQuickItem> content(new QQuickItem());
content->setActiveFocusOnTab(true);
content->setFocus(true);
quick->setFocusPolicy(Qt::StrongFocus);
quick->setContent(QUrl(), nullptr, root);
root->setFlag(QQuickItem::ItemHasContents);
content->setParentItem(root);
quick->setGeometry(0, 0, 200, 200);
quick->show();
quick->setFocus();
quick->activateWindow();
QVERIFY(QTest::qWaitForWindowExposed(quick.get()));
QTRY_VERIFY(quick->hasFocus());
QTRY_VERIFY(content->hasFocus());
QTRY_VERIFY(content->hasActiveFocus());
widget->show();
widget->setFocus();
widget->activateWindow();
QVERIFY(QTest::qWaitForWindowExposed(widget.get()));
QTRY_VERIFY(widget->hasFocus());
quick->setParent(widget.get());
quick->show();
quick->setFocus();
quick->activateWindow();
QTRY_VERIFY(quick->hasFocus());
QTRY_VERIFY(content->hasFocus());
QTRY_VERIFY(content->hasActiveFocus());
}
QQuickWidget: don't crash in accessibility when reparenting QAccessibleQuickWidget delegates all calls to the QAccessibleQuickWindow, which it had as a member that was initialized at construction time to the offscreenWindow backing the QQuickWidget. Both are QAccessibleObject subclasses, and QAccessibleObject stores the object it wraps as a QPointer. The QAccessibleQuickWindow's object becomes null when that offscreen window gets destroyed (for instance, when reparenting). We might get called by the accessibility framework in that situation, as we are clicking a button and the hierarchy changes. To prevent crashes, we need to test for nullptr in QAccessibleQuickWindow. However, that alone would leave us with a useless QAccessibleQuickWindow, and in turn with a useless QAccessibleQuickWidget instance. The QAccessibleQuickWindow is not directly exposed to the accessibility framework, and all calls to it are dispatched through its QAccessibleQuickWidget owner. We can't repair the QAccessibleQuickWindow but we can replace it entirely if we manage it as a heap-allocated object. Use a std::unique_ptr for that, which we can reset with a new instance created from a new offscreen window in order to repair things. We can now either test in all functions whether the window's window is still alive. Or we can handle the destroyed() signal of the offscreen window. The latter solution is a bit more involved, but generally more scalable as we don't have to remember to check, and possibly repair, in each QAccessibleQuickWidget function. Pick-to: 6.5 Fixes: QTBUG-108226 Change-Id: Ib19c07d3679c0af28cb5aab4c80691cc57c4e514 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2023-04-08 16:53:14 +00:00
/*
Reparenting the QQuickWidget recreates the offscreen QQuickWindow.
Since the accessible interface that is cached for the QQuickWidget dispatches
all calls to the offscreen QQuickWindow, it must fix itself when the offscreen
view changes. QTBUG-108226
*/
void tst_qquickwidget::accessibilityHandlesViewChange()
{
if (QGuiApplication::platformName() == "offscreen")
QSKIP("Doesn't test anything on offscreen platform.");
if (QGuiApplication::platformName() == "android")
QSKIP("Test doesn't exit cleanly on Android and generates many warnings - QTBUG-112696");
QWidget window;
QPointer<QQuickWindow> backingScene;
QQuickWidget *childView = new QQuickWidget(&window);
childView->setSource(testFileUrl("rectangle.qml"));
window.show();
QVERIFY(QTest::qWaitForWindowExposed(&window));
backingScene = childView->quickWindow();
QVERIFY(backingScene);
QAccessibleInterface *iface = QAccessible::queryAccessibleInterface(childView);
QVERIFY(iface);
(void)iface->child(0);
std::unique_ptr<QQuickWidget> quickWidget(childView);
childView->setParent(nullptr);
childView->show();
QVERIFY(QTest::qWaitForWindowExposed(childView));
QVERIFY(!backingScene); // the old QQuickWindow should be gone now
QVERIFY(childView->quickWindow()); // long live the new QQuickWindow
iface = QAccessible::queryAccessibleInterface(childView);
QVERIFY(iface);
// this would crash if QAccessibleQuickWidget hadn't repaired itself to
// delegate calls to the new (or at least not the old, destroyed) QQuickWindow.
(void)iface->child(0);
}
QQuickWidget: Clean up if RHI goes away under our feet The QQuickWidget doesn't normally own the RHI; the QWidgetRepaintManager does, via QBackingStoreRhiSupport. If the top level widget is destroyed, so is its QBackingStore, and the corresponding RHI. But the QQuickWidget may outlive its top level parent, in which case it needs to update its cached reference to the RHI, and do proper cleanup before it goes away. QRhiWidget already does the same thing, for the same use-case. This was observed when recreating the top level QWidget via destroy/create as part of the RHI widget compositor logic. Fixes: QTBUG-119760 Pick-to: 6.6 6.5 Change-Id: Ic44449abcfe4271660a3ac4e132d0c4a71a21b65 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 0d342e83123b27befde95fc35760a358dbff0b16) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
2023-12-19 20:52:05 +00:00
class CreateDestroyWidget : public QWidget
{
public:
using QWidget::create;
using QWidget::destroy;
};
void tst_qquickwidget::cleanupRhi()
{
CreateDestroyWidget topLevel;
QQuickWidget quickWidget(&topLevel);
quickWidget.setSource(testFileUrl("rectangle.qml"));
topLevel.show();
QVERIFY(QTest::qWaitForWindowExposed(&topLevel));
topLevel.destroy();
topLevel.create();
}
QQuickWidget: don't crash in accessibility when reparenting QAccessibleQuickWidget delegates all calls to the QAccessibleQuickWindow, which it had as a member that was initialized at construction time to the offscreenWindow backing the QQuickWidget. Both are QAccessibleObject subclasses, and QAccessibleObject stores the object it wraps as a QPointer. The QAccessibleQuickWindow's object becomes null when that offscreen window gets destroyed (for instance, when reparenting). We might get called by the accessibility framework in that situation, as we are clicking a button and the hierarchy changes. To prevent crashes, we need to test for nullptr in QAccessibleQuickWindow. However, that alone would leave us with a useless QAccessibleQuickWindow, and in turn with a useless QAccessibleQuickWidget instance. The QAccessibleQuickWindow is not directly exposed to the accessibility framework, and all calls to it are dispatched through its QAccessibleQuickWidget owner. We can't repair the QAccessibleQuickWindow but we can replace it entirely if we manage it as a heap-allocated object. Use a std::unique_ptr for that, which we can reset with a new instance created from a new offscreen window in order to repair things. We can now either test in all functions whether the window's window is still alive. Or we can handle the destroyed() signal of the offscreen window. The latter solution is a bit more involved, but generally more scalable as we don't have to remember to check, and possibly repair, in each QAccessibleQuickWidget function. Pick-to: 6.5 Fixes: QTBUG-108226 Change-Id: Ib19c07d3679c0af28cb5aab4c80691cc57c4e514 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
2023-04-08 16:53:14 +00:00
Add grabFramebuffer() to QQuickWidget and use it in the autotest This introduces the need for a grab function in QQuickWidget. The render control has one already so there is no reason for not exposing this in QQuickWidget too. This also means that a relatively meaningful autotest can be now be added. [ChangeLog][QtQuick] Added QQuickWidget::grabFramebuffer() for capturing the content into a QImage. Task-number: QTBUG-37589 Change-Id: I5ca8192c0ef8dab4f076a4db27b64aebe3359bb8 Reviewed-by: Gunnar Sletta <gunnar.sletta@jollamobile.com>
2014-03-19 08:21:11 +00:00
QTEST_MAIN(tst_qquickwidget)
#include "tst_qquickwidget.moc"