qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fail on warnings for simple "default" controls tests 

This patch:

- Adds a simple, "default-constructed" (i.e. little or no properties
  set) test function for each control where one was missing.
- Causes those tests to fail on any warning.

It would be simpler to just call failOnWarnings(/.?/) in the
initTestCase() of each test, but there are too marning warnings to fix
right now.

Task-number: QTBUG-98718
Change-Id: Ia3aa901feab5db534925824528caf25297e02760
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Mitch Curtis 2022-11-25 16:11:57 +08:00
parent 20e745bbd8
commit 0765c176e7
53 changed files with 307 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/auto/quickcontrols2/controls/data/tst_abstractbutton.qml
View File

@ -13,6 +13,12 @@ TestCase {
when: windowShown
name: "AbstractButton"
Component {
id: defaultComponent
AbstractButton {}
}
Component {
id: button
AbstractButton {
@ -36,6 +42,13 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(defaultComponent, testCase)
verify(control)
}
function test_text() {
var control = createTemporaryObject(button, testCase);
verify(control);

7
tests/auto/quickcontrols2/controls/data/tst_action.qml
View File

@ -24,6 +24,13 @@ TestCase {
SignalSpy { }
}
function test_empty() {
failOnWarning(/.?/)
let control = createTemporaryObject(component, testCase)
verify(control)
}
function test_enabled() {
var action = createTemporaryObject(component, testCase)
verify(action)

2
tests/auto/quickcontrols2/controls/data/tst_actiongroup.qml
View File

@ -51,6 +51,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var group = createTemporaryObject(actionGroup, testCase)
verify(group)
compare(group.actions.length, 0)

8
tests/auto/quickcontrols2/controls/data/tst_busyindicator.qml
View File

@ -23,6 +23,14 @@ TestCase {
MouseArea { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(busyIndicator, testCase)
verify(control)
compare(control.running, true)
}
function test_running() {
var control = createTemporaryObject(busyIndicator, testCase)
verify(control)

9
tests/auto/quickcontrols2/controls/data/tst_button.qml
View File

@ -30,6 +30,15 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(button, testCase)
verify(control)
compare(control.highlighted, false)
compare(control.flat, false)
}
function test_text() {
var control = createTemporaryObject(button, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_buttongroup.qml
View File

@ -47,6 +47,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var group = createTemporaryObject(buttonGroup, testCase)
verify(group)
compare(group.buttons.length, 0)

9
tests/auto/quickcontrols2/controls/data/tst_checkbox.qml
View File

@ -25,6 +25,15 @@ TestCase {
}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(checkBox, testCase)
verify(control)
compare(control.tristate, false)
compare(control.checkState, Qt.Unchecked)
}
function test_text() {
var control = createTemporaryObject(checkBox, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_checkdelegate.qml
View File

@ -21,6 +21,8 @@ TestCase {
// TODO: data-fy tst_checkbox (rename to tst_check?) so we don't duplicate its tests here?
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(checkDelegate, testCase);
verify(control);
verify(!control.checked);

2
tests/auto/quickcontrols2/controls/data/tst_combobox.qml
View File

@ -98,6 +98,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(comboBox, testCase)
verify(control)

8
tests/auto/quickcontrols2/controls/data/tst_container.qml
View File

@ -24,6 +24,14 @@ TestCase {
Rectangle { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(container, testCase)
verify(control)
compare(control.count, 0)
}
function test_implicitSize() {
var control = createTemporaryObject(container, testCase)
verify(control)

9
tests/auto/quickcontrols2/controls/data/tst_control.qml
View File

@ -34,6 +34,15 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(component, testCase)
verify(control)
compare(control.background, null)
compare(control.contentItem, null)
}
function test_padding() {
var control = createTemporaryObject(component, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_dayofweekrow.qml
View File

@ -18,6 +18,13 @@ TestCase {
DayOfWeekRow { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(component, testCase)
verify(control)
}
function test_locale() {
var control = component.createObject(testCase)

13
tests/auto/quickcontrols2/controls/data/tst_delaybutton.qml
View File

@ -13,6 +13,12 @@ TestCase {
when: windowShown
name: "DelayButton"
Component {
id: defaultComponent
DelayButton {}
}
Component {
id: delayButton
DelayButton {
@ -32,6 +38,13 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(defaultComponent, testCase)
verify(control)
}
function test_mouse() {
var control = createTemporaryObject(delayButton, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_dial.qml
View File

@ -28,6 +28,8 @@ TestCase {
}
function test_instance() {
failOnWarning(/.?/)
var dial = createTemporaryObject(dialComponent, testCase);
verify(dial);
compare(dial.value, 0.0);

2
tests/auto/quickcontrols2/controls/data/tst_dialog.qml
View File

@ -43,6 +43,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(dialog, testCase)
verify(control)
verify(control.header)

2
tests/auto/quickcontrols2/controls/data/tst_dialogbuttonbox.qml
View File

@ -29,6 +29,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(buttonBox, testCase)
verify(control)
compare(control.count, 0)

2
tests/auto/quickcontrols2/controls/data/tst_frame.qml
View File

@ -53,6 +53,8 @@ TestCase {
}
function test_empty() {
failOnWarning(/.?/)
var control = createTemporaryObject(frame, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_groupbox.qml
View File

@ -53,6 +53,8 @@ TestCase {
}
function test_empty() {
failOnWarning(/.?/)
var control = createTemporaryObject(groupBox, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_itemdelegate.qml
View File

@ -18,6 +18,13 @@ TestCase {
ItemDelegate { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(itemDelegate, testCase)
verify(control)
}
function test_baseline() {
var control = createTemporaryObject(itemDelegate, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_label.qml
View File

@ -36,6 +36,8 @@ TestCase {
}
function test_creation() {
failOnWarning(/.?/)
var control = createTemporaryObject(label, testCase)
verify(control)
}

7
tests/auto/quickcontrols2/controls/data/tst_menuitem.qml
View File

@ -23,6 +23,13 @@ TestCase {
Menu { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(menuItem, testCase)
verify(control)
}
function test_baseline() {
var control = createTemporaryObject(menuItem, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_monthgrid.qml
View File

@ -37,6 +37,13 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(defaultGrid, testCase)
verify(control)
}
function test_locale() {
var control = delegateGrid.createObject(testCase, {month: 0, year: 2013})

4
tests/auto/quickcontrols2/controls/data/tst_page.qml
View File

@ -70,6 +70,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(page, testCase)
verify(control)
@ -79,6 +81,8 @@ TestCase {
}
function test_empty() {
failOnWarning(/.?/)
var control = createTemporaryObject(page, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_pageindicator.qml
View File

@ -23,6 +23,13 @@ TestCase {
MouseArea { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(pageIndicator, testCase)
verify(control)
}
function test_count() {
var control = createTemporaryObject(pageIndicator, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_pane.qml
View File

@ -66,6 +66,8 @@ TestCase {
}
function test_empty() {
failOnWarning(/.?/)
var control = createTemporaryObject(pane, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_popup.qml
View File

@ -42,6 +42,13 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(popupControl, testCase)
verify(control)
}
function test_padding() {
var control = createTemporaryObject(popupTemplate, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_progressbar.qml
View File

@ -18,6 +18,13 @@ TestCase {
ProgressBar { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(progressBar, testCase)
verify(control)
}
function test_value() {
var control = createTemporaryObject(progressBar, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_radiobutton.qml
View File

@ -25,6 +25,13 @@ TestCase {
}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(radioButton, testCase)
verify(control)
}
function test_text() {
var control = createTemporaryObject(radioButton, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_radiodelegate.qml
View File

@ -21,6 +21,8 @@ TestCase {
// TODO: data-fy tst_radiobutton (rename to tst_radio?) so we don't duplicate its tests here?
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(radioDelegate, testCase);
verify(control);
verify(!control.checked);

2
tests/auto/quickcontrols2/controls/data/tst_rangeslider.qml
View File

@ -43,6 +43,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(sliderComponent, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_roundbutton.qml
View File

@ -18,6 +18,13 @@ TestCase {
RoundButton { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(roundButton, testCase)
verify(control)
}
function test_radius() {
var control = createTemporaryObject(roundButton, testCase);
verify(control);

13
tests/auto/quickcontrols2/controls/data/tst_scrollbar.qml
View File

@ -19,6 +19,12 @@ TestCase {
SignalSpy { }
}
Component {
id: defaultScrollBar
ScrollBar {}
}
Component {
id: scrollBar
ScrollBar {
@ -46,6 +52,13 @@ TestCase {
}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(defaultScrollBar, testCase)
verify(control)
}
function test_attach() {
var container = createTemporaryObject(flickable, testCase)
verify(container)

7
tests/auto/quickcontrols2/controls/data/tst_scrollindicator.qml
View File

@ -35,6 +35,13 @@ TestCase {
}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(scrollIndicator, testCase)
verify(control)
}
function test_attach() {
var container = createTemporaryObject(flickable, testCase)
verify(container)

7
tests/auto/quickcontrols2/controls/data/tst_scrollview.qml
View File

@ -156,6 +156,13 @@ TestCase {
}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(scrollView, testCase)
verify(control)
}
function test_scrollBars() {
var control = createTemporaryObject(scrollView, testCase, {width: 200, height: 200})
verify(control)

13
tests/auto/quickcontrols2/controls/data/tst_selectionrectangle.qml
View File

@ -19,6 +19,12 @@ TestCase {
property Item handle: null
property bool handleWasDragged: false
Component {
id: defaultSelectionRectangle
SelectionRectangle {}
}
Component {
id: handleComp
Rectangle {
@ -87,6 +93,13 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(defaultSelectionRectangle, testCase)
verify(control)
}
function test_set_target() {
let tableView = createTemporaryObject(tableviewComp, testCase)
verify(tableView)

2
tests/auto/quickcontrols2/controls/data/tst_slider.qml
View File

@ -24,6 +24,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(slider, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_spinbox.qml
View File

@ -30,6 +30,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(spinBox, testCase)
verify(control)

13
tests/auto/quickcontrols2/controls/data/tst_splitview.qml
View File

@ -111,6 +111,12 @@ TestCase {
}
}
Component {
id: defaultSplitView
SplitView {}
}
Component {
id: splitViewComponent
@ -126,6 +132,13 @@ TestCase {
Rectangle {}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(defaultSplitView, testCase)
verify(control)
}
function test_addItemsAfterCompletion() {
var control = createTemporaryObject(splitViewComponent, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_stackview.qml
View File

@ -30,6 +30,13 @@ TestCase {
Component { id: withRequired; Item { required property int i }}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(stackView, testCase)
verify(control)
}
function test_initialItem() {
var control1 = createTemporaryObject(stackView, testCase)
verify(control1)

2
tests/auto/quickcontrols2/controls/data/tst_swipedelegate.qml
View File

@ -244,6 +244,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(swipeDelegateComponent, testCase);
verify(control);

7
tests/auto/quickcontrols2/controls/data/tst_swipeview.qml
View File

@ -28,6 +28,13 @@ TestCase {
SignalSpy { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(swipeView, testCase)
verify(control)
}
function test_current() {
var control = createTemporaryObject(swipeView, testCase)

7
tests/auto/quickcontrols2/controls/data/tst_switch.qml
View File

@ -25,6 +25,13 @@ TestCase {
}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(swtch, testCase)
verify(control)
}
function test_text() {
var control = createTemporaryObject(swtch, testCase)
verify(control)

2
tests/auto/quickcontrols2/controls/data/tst_switchdelegate.qml
View File

@ -28,6 +28,8 @@ TestCase {
// TODO: data-fy tst_checkbox (rename to tst_check?) so we don't duplicate its tests here?
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(switchDelegate, testCase);
verify(control);
verify(!control.checked);

2
tests/auto/quickcontrols2/controls/data/tst_tabbar.qml
View File

@ -54,6 +54,8 @@ TestCase {
}
function test_defaults() {
failOnWarning(/.?/)
var control = createTemporaryObject(tabBar, testCase)
verify(control)
compare(control.count, 0)

7
tests/auto/quickcontrols2/controls/data/tst_tabbutton.qml
View File

@ -28,6 +28,13 @@ TestCase {
}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(tabButton, testCase)
verify(control)
}
function test_autoExclusive() {
var container = createTemporaryObject(repeater, testCase)

2
tests/auto/quickcontrols2/controls/data/tst_textarea.qml
View File

@ -69,6 +69,8 @@ TestCase {
}
function test_creation() {
failOnWarning(/.?/)
var control = createTemporaryObject(textArea, testCase)
verify(control)
}

2
tests/auto/quickcontrols2/controls/data/tst_textfield.qml
View File

@ -30,6 +30,8 @@ TestCase {
}
function test_creation() {
failOnWarning(/.?/)
var control = createTemporaryObject(textField, testCase)
verify(control)
}

2
tests/auto/quickcontrols2/controls/data/tst_toolbar.qml
View File

@ -53,6 +53,8 @@ TestCase {
}
function test_empty() {
failOnWarning(/.?/)
var control = createTemporaryObject(toolBar, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_toolbutton.qml
View File

@ -23,6 +23,13 @@ TestCase {
ToolButton { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(toolButton, testCase)
verify(control)
}
function test_text() {
var control = createTemporaryObject(toolButton, testCase)
verify(control)

7
tests/auto/quickcontrols2/controls/data/tst_toolseparator.qml
View File

@ -17,6 +17,13 @@ TestCase {
ToolSeparator {}
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(toolSeparator, testCase)
verify(control)
}
function test_size() {
var control = createTemporaryObject(toolSeparator, testCase);
verify(control);

7
tests/auto/quickcontrols2/controls/data/tst_tooltip.qml
View File

@ -37,6 +37,13 @@ TestCase {
target: ToolTip.toolTip
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(toolTip, testCase)
verify(control)
}
function test_properties_data() {
return [
{tag: "text", property: "text", defaultValue: "", setValue: "Hello", signalName: "textChanged"},

13
tests/auto/quickcontrols2/controls/data/tst_tumbler.qml
View File

@ -21,6 +21,12 @@ TestCase {
readonly property real tumblerDelegateHeight: tumbler ? tumbler.availableHeight / tumbler.visibleItemCount : 0
property Item tumblerView: null
Component {
id: defaultTumbler
Tumbler {}
}
Component {
id: tumblerComponent
@ -107,6 +113,13 @@ TestCase {
text: modelData
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(defaultTumbler, testCase)
verify(control)
}
function test_wrapWithoutAttachedProperties() {
createTumbler();
verify(tumbler.wrap);

7
tests/auto/quickcontrols2/controls/data/tst_weeknumbercolumn.qml
View File

@ -18,6 +18,13 @@ TestCase {
WeekNumberColumn { }
}
function test_defaults() {
failOnWarning(/.?/)
let control = createTemporaryObject(component, testCase)
verify(control)
}
function test_locale() {
var control = component.createObject(testCase)