Fail on warnings for simple "default" controls tests

This patch:

- Adds a simple, "default-constructed" (i.e. little or no properties
  set) test function for each control where one was missing.
- Causes those tests to fail on any warning.

It would be simpler to just call failOnWarnings(/.?/) in the
initTestCase() of each test, but there are too marning warnings to fix
right now.

Task-number: QTBUG-98718
Change-Id: Ia3aa901feab5db534925824528caf25297e02760
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>

tests/auto/quickcontrols2/controls/data/tst_abstractbutton.qml

@@ -13,6 +13,12 @@ TestCase {
     when: windowShown
     name: "AbstractButton"
 
+    Component {
+        id: defaultComponent
+
+        AbstractButton {}
+    }
+
     Component {
         id: button
         AbstractButton {
@@ -36,6 +42,13 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(defaultComponent, testCase)
+        verify(control)
+    }
+
     function test_text() {
         var control = createTemporaryObject(button, testCase);
         verify(control);

tests/auto/quickcontrols2/controls/data/tst_action.qml

@@ -24,6 +24,13 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_empty() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(component, testCase)
+        verify(control)
+    }
+
     function test_enabled() {
         var action = createTemporaryObject(component, testCase)
         verify(action)

tests/auto/quickcontrols2/controls/data/tst_actiongroup.qml

@@ -51,6 +51,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var group = createTemporaryObject(actionGroup, testCase)
         verify(group)
         compare(group.actions.length, 0)

tests/auto/quickcontrols2/controls/data/tst_busyindicator.qml

@@ -23,6 +23,14 @@ TestCase {
         MouseArea { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(busyIndicator, testCase)
+        verify(control)
+        compare(control.running, true)
+    }
+
     function test_running() {
         var control = createTemporaryObject(busyIndicator, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_button.qml

@@ -30,6 +30,15 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(button, testCase)
+        verify(control)
+        compare(control.highlighted, false)
+        compare(control.flat, false)
+    }
+
     function test_text() {
         var control = createTemporaryObject(button, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_buttongroup.qml

@@ -47,6 +47,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var group = createTemporaryObject(buttonGroup, testCase)
         verify(group)
         compare(group.buttons.length, 0)

tests/auto/quickcontrols2/controls/data/tst_checkbox.qml

@@ -25,6 +25,15 @@ TestCase {
         }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(checkBox, testCase)
+        verify(control)
+        compare(control.tristate, false)
+        compare(control.checkState, Qt.Unchecked)
+    }
+
     function test_text() {
         var control = createTemporaryObject(checkBox, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_checkdelegate.qml

@@ -21,6 +21,8 @@ TestCase {
     // TODO: data-fy tst_checkbox (rename to tst_check?) so we don't duplicate its tests here?
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(checkDelegate, testCase);
         verify(control);
         verify(!control.checked);

tests/auto/quickcontrols2/controls/data/tst_combobox.qml

@@ -98,6 +98,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(comboBox, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_container.qml

@@ -24,6 +24,14 @@ TestCase {
         Rectangle { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(container, testCase)
+        verify(control)
+        compare(control.count, 0)
+    }
+
     function test_implicitSize() {
         var control = createTemporaryObject(container, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_control.qml

@@ -34,6 +34,15 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(component, testCase)
+        verify(control)
+        compare(control.background, null)
+        compare(control.contentItem, null)
+    }
+
     function test_padding() {
         var control = createTemporaryObject(component, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_dayofweekrow.qml

@@ -18,6 +18,13 @@ TestCase {
         DayOfWeekRow { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(component, testCase)
+        verify(control)
+    }
+
     function test_locale() {
         var control = component.createObject(testCase)
 

tests/auto/quickcontrols2/controls/data/tst_delaybutton.qml

@@ -13,6 +13,12 @@ TestCase {
     when: windowShown
     name: "DelayButton"
 
+    Component {
+        id: defaultComponent
+
+        DelayButton {}
+    }
+
     Component {
         id: delayButton
         DelayButton {
@@ -32,6 +38,13 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(defaultComponent, testCase)
+        verify(control)
+    }
+
     function test_mouse() {
         var control = createTemporaryObject(delayButton, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_dial.qml

@@ -28,6 +28,8 @@ TestCase {
     }
 
     function test_instance() {
+        failOnWarning(/.?/)
+
         var dial = createTemporaryObject(dialComponent, testCase);
         verify(dial);
         compare(dial.value, 0.0);

tests/auto/quickcontrols2/controls/data/tst_dialog.qml

@@ -43,6 +43,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(dialog, testCase)
         verify(control)
         verify(control.header)

tests/auto/quickcontrols2/controls/data/tst_dialogbuttonbox.qml

@@ -29,6 +29,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(buttonBox, testCase)
         verify(control)
         compare(control.count, 0)

tests/auto/quickcontrols2/controls/data/tst_frame.qml

@@ -53,6 +53,8 @@ TestCase {
     }
 
     function test_empty() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(frame, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_groupbox.qml

@@ -53,6 +53,8 @@ TestCase {
     }
 
     function test_empty() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(groupBox, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_itemdelegate.qml

@@ -18,6 +18,13 @@ TestCase {
         ItemDelegate { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(itemDelegate, testCase)
+        verify(control)
+    }
+
     function test_baseline() {
         var control = createTemporaryObject(itemDelegate, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_label.qml

@@ -36,6 +36,8 @@ TestCase {
     }
 
     function test_creation() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(label, testCase)
         verify(control)
     }

tests/auto/quickcontrols2/controls/data/tst_menuitem.qml

@@ -23,6 +23,13 @@ TestCase {
         Menu { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(menuItem, testCase)
+        verify(control)
+    }
+
     function test_baseline() {
         var control = createTemporaryObject(menuItem, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_monthgrid.qml

@@ -37,6 +37,13 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(defaultGrid, testCase)
+        verify(control)
+    }
+
     function test_locale() {
         var control = delegateGrid.createObject(testCase, {month: 0, year: 2013})
 

tests/auto/quickcontrols2/controls/data/tst_page.qml

@@ -70,6 +70,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(page, testCase)
         verify(control)
 
@@ -79,6 +81,8 @@ TestCase {
     }
 
     function test_empty() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(page, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_pageindicator.qml

@@ -23,6 +23,13 @@ TestCase {
         MouseArea { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(pageIndicator, testCase)
+        verify(control)
+    }
+
     function test_count() {
         var control = createTemporaryObject(pageIndicator, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_pane.qml

@@ -66,6 +66,8 @@ TestCase {
     }
 
     function test_empty() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(pane, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_popup.qml

@@ -42,6 +42,13 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(popupControl, testCase)
+        verify(control)
+    }
+
     function test_padding() {
         var control = createTemporaryObject(popupTemplate, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_progressbar.qml

@@ -18,6 +18,13 @@ TestCase {
         ProgressBar { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(progressBar, testCase)
+        verify(control)
+    }
+
     function test_value() {
         var control = createTemporaryObject(progressBar, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_radiobutton.qml

@@ -25,6 +25,13 @@ TestCase {
         }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(radioButton, testCase)
+        verify(control)
+    }
+
     function test_text() {
         var control = createTemporaryObject(radioButton, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_radiodelegate.qml

@@ -21,6 +21,8 @@ TestCase {
     // TODO: data-fy tst_radiobutton (rename to tst_radio?) so we don't duplicate its tests here?
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(radioDelegate, testCase);
         verify(control);
         verify(!control.checked);

tests/auto/quickcontrols2/controls/data/tst_rangeslider.qml

@@ -43,6 +43,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(sliderComponent, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_roundbutton.qml

@@ -18,6 +18,13 @@ TestCase {
         RoundButton { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(roundButton, testCase)
+        verify(control)
+    }
+
     function test_radius() {
         var control = createTemporaryObject(roundButton, testCase);
         verify(control);

tests/auto/quickcontrols2/controls/data/tst_scrollbar.qml

@@ -19,6 +19,12 @@ TestCase {
         SignalSpy { }
     }
 
+    Component {
+        id: defaultScrollBar
+
+        ScrollBar {}
+    }
+
     Component {
         id: scrollBar
         ScrollBar {
@@ -46,6 +52,13 @@ TestCase {
         }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(defaultScrollBar, testCase)
+        verify(control)
+    }
+
     function test_attach() {
         var container = createTemporaryObject(flickable, testCase)
         verify(container)

tests/auto/quickcontrols2/controls/data/tst_scrollindicator.qml

@@ -35,6 +35,13 @@ TestCase {
         }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(scrollIndicator, testCase)
+        verify(control)
+    }
+
     function test_attach() {
         var container = createTemporaryObject(flickable, testCase)
         verify(container)

tests/auto/quickcontrols2/controls/data/tst_scrollview.qml

@@ -156,6 +156,13 @@ TestCase {
         }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(scrollView, testCase)
+        verify(control)
+    }
+
     function test_scrollBars() {
         var control = createTemporaryObject(scrollView, testCase, {width: 200, height: 200})
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_selectionrectangle.qml

@@ -19,6 +19,12 @@ TestCase {
     property Item handle: null
     property bool handleWasDragged: false
 
+    Component {
+        id: defaultSelectionRectangle
+
+        SelectionRectangle {}
+    }
+
     Component {
         id: handleComp
         Rectangle {
@@ -87,6 +93,13 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(defaultSelectionRectangle, testCase)
+        verify(control)
+    }
+
     function test_set_target() {
         let tableView = createTemporaryObject(tableviewComp, testCase)
         verify(tableView)

tests/auto/quickcontrols2/controls/data/tst_slider.qml

@@ -24,6 +24,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(slider, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_spinbox.qml

@@ -30,6 +30,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(spinBox, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_splitview.qml

@@ -111,6 +111,12 @@ TestCase {
         }
     }
 
+    Component {
+        id: defaultSplitView
+
+        SplitView {}
+    }
+
     Component {
         id: splitViewComponent
 
@@ -126,6 +132,13 @@ TestCase {
         Rectangle {}
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(defaultSplitView, testCase)
+        verify(control)
+    }
+
     function test_addItemsAfterCompletion() {
         var control = createTemporaryObject(splitViewComponent, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_stackview.qml

@@ -30,6 +30,13 @@ TestCase {
 
     Component { id: withRequired; Item { required property int i }}
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(stackView, testCase)
+        verify(control)
+    }
+
     function test_initialItem() {
         var control1 = createTemporaryObject(stackView, testCase)
         verify(control1)

tests/auto/quickcontrols2/controls/data/tst_swipedelegate.qml

@@ -244,6 +244,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(swipeDelegateComponent, testCase);
         verify(control);
 

tests/auto/quickcontrols2/controls/data/tst_swipeview.qml

@@ -28,6 +28,13 @@ TestCase {
         SignalSpy { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(swipeView, testCase)
+        verify(control)
+    }
+
     function test_current() {
         var control = createTemporaryObject(swipeView, testCase)
 

tests/auto/quickcontrols2/controls/data/tst_switch.qml

@@ -25,6 +25,13 @@ TestCase {
         }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(swtch, testCase)
+        verify(control)
+    }
+
     function test_text() {
         var control = createTemporaryObject(swtch, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_switchdelegate.qml

@@ -28,6 +28,8 @@ TestCase {
     // TODO: data-fy tst_checkbox (rename to tst_check?) so we don't duplicate its tests here?
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(switchDelegate, testCase);
         verify(control);
         verify(!control.checked);

tests/auto/quickcontrols2/controls/data/tst_tabbar.qml

@@ -54,6 +54,8 @@ TestCase {
     }
 
     function test_defaults() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(tabBar, testCase)
         verify(control)
         compare(control.count, 0)

tests/auto/quickcontrols2/controls/data/tst_tabbutton.qml

@@ -28,6 +28,13 @@ TestCase {
         }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(tabButton, testCase)
+        verify(control)
+    }
+
     function test_autoExclusive() {
         var container = createTemporaryObject(repeater, testCase)
 

tests/auto/quickcontrols2/controls/data/tst_textarea.qml

@@ -69,6 +69,8 @@ TestCase {
     }
 
     function test_creation() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(textArea, testCase)
         verify(control)
     }

tests/auto/quickcontrols2/controls/data/tst_textfield.qml

@@ -30,6 +30,8 @@ TestCase {
     }
 
     function test_creation() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(textField, testCase)
         verify(control)
     }

tests/auto/quickcontrols2/controls/data/tst_toolbar.qml

@@ -53,6 +53,8 @@ TestCase {
     }
 
     function test_empty() {
+        failOnWarning(/.?/)
+
         var control = createTemporaryObject(toolBar, testCase)
         verify(control)
 

tests/auto/quickcontrols2/controls/data/tst_toolbutton.qml

@@ -23,6 +23,13 @@ TestCase {
         ToolButton { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(toolButton, testCase)
+        verify(control)
+    }
+
     function test_text() {
         var control = createTemporaryObject(toolButton, testCase)
         verify(control)

tests/auto/quickcontrols2/controls/data/tst_toolseparator.qml

@@ -17,6 +17,13 @@ TestCase {
         ToolSeparator {}
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(toolSeparator, testCase)
+        verify(control)
+    }
+
     function test_size() {
         var control = createTemporaryObject(toolSeparator, testCase);
         verify(control);

tests/auto/quickcontrols2/controls/data/tst_tooltip.qml

@@ -37,6 +37,13 @@ TestCase {
         target: ToolTip.toolTip
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(toolTip, testCase)
+        verify(control)
+    }
+
     function test_properties_data() {
         return [
             {tag: "text", property: "text", defaultValue: "", setValue: "Hello", signalName: "textChanged"},

tests/auto/quickcontrols2/controls/data/tst_tumbler.qml

@@ -21,6 +21,12 @@ TestCase {
     readonly property real tumblerDelegateHeight: tumbler ? tumbler.availableHeight / tumbler.visibleItemCount : 0
     property Item tumblerView: null
 
+    Component {
+        id: defaultTumbler
+
+        Tumbler {}
+    }
+
     Component {
         id: tumblerComponent
 
@@ -107,6 +113,13 @@ TestCase {
         text: modelData
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(defaultTumbler, testCase)
+        verify(control)
+    }
+
     function test_wrapWithoutAttachedProperties() {
         createTumbler();
         verify(tumbler.wrap);

tests/auto/quickcontrols2/controls/data/tst_weeknumbercolumn.qml

@@ -18,6 +18,13 @@ TestCase {
         WeekNumberColumn { }
     }
 
+    function test_defaults() {
+        failOnWarning(/.?/)
+
+        let control = createTemporaryObject(component, testCase)
+        verify(control)
+    }
+
     function test_locale() {
         var control = component.createObject(testCase)