qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qmllint: Mark anchors3.qml as dirty 

This is in fact invalid QML. The assignment shouldn't be accepted but
qmllint cannot see that, yet.

Change-Id: Ifcb2f01edaf10ada5ce4d762726c51af3b4f5087
Reviewed-by: Maximilian Goldstein <max.goldstein@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
This commit is contained in:
Ulf Hermann 2020-10-02 17:31:10 +02:00
parent 1b4a2f5def
commit 1b8987ffcc
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/auto/qml/qmllint/data/anchors3.qml
View File

@ -1,6 +1,6 @@
import QtQuick 2.15 import QtQuick 2.15
Rectangle { Rectangle {
anchors.horizontalCenter: parent anchors.horizontalCenter: parent
anchors.verticalCenter: parent anchors.verticalCenter: parent
} }

2
tests/auto/qml/qmllint/data/nanchors3.qml
View File

@ -1,6 +1,6 @@
import QtQuick 2.15 import QtQuick 2.15
Rectangle { Rectangle {
nanchors.horizontalCenter: parent nanchors.horizontalCenter: parent
nanchors.verticalCenter: parent nanchors.verticalCenter: parent
} }

6
tests/auto/qml/qmllint/tst_qmllint.cpp
View File

@ -199,6 +199,10 @@ void TestQmllint::dirtyQmlCode_data()
<< QStringLiteral("badEnumFromQtQml.qml") << QStringLiteral("badEnumFromQtQml.qml")
<< QString("Warning: Property \"Linear123\" not found on type \"QQmlEasingEnums\"") << QString("Warning: Property \"Linear123\" not found on type \"QQmlEasingEnums\"")
<< QString(); << QString();
QTest::newRow("anchors3")
<< QStringLiteral("anchors3.qml")
<< QString()
<< QString();
QTest::newRow("nanchors1") QTest::newRow("nanchors1")
<< QStringLiteral("nanchors1.qml") << QStringLiteral("nanchors1.qml")
<< QString() << QString()
@ -224,6 +228,7 @@ void TestQmllint::dirtyQmlCode()
const QString output = runQmllint(filename, [&](QProcess &process) { const QString output = runQmllint(filename, [&](QProcess &process) {
QVERIFY(process.waitForFinished()); QVERIFY(process.waitForFinished());
QCOMPARE(process.exitStatus(), QProcess::NormalExit); QCOMPARE(process.exitStatus(), QProcess::NormalExit);
QEXPECT_FAIL("anchors3", "We don't see that QQuickItem cannot be assigned to QQuickAnchorLine", Abort);
QEXPECT_FAIL("nanchors1", "Invalid grouped properties are not detected", Abort); QEXPECT_FAIL("nanchors1", "Invalid grouped properties are not detected", Abort);
QEXPECT_FAIL("nanchors2", "Invalid grouped properties are not detected", Abort); QEXPECT_FAIL("nanchors2", "Invalid grouped properties are not detected", Abort);
QEXPECT_FAIL("nanchors3", "Invalid grouped properties are not detected", Abort); QEXPECT_FAIL("nanchors3", "Invalid grouped properties are not detected", Abort);
@ -268,7 +273,6 @@ void TestQmllint::cleanQmlCode_data()
QTest::newRow("enumFromQtQml") << QStringLiteral("enumFromQtQml.qml"); QTest::newRow("enumFromQtQml") << QStringLiteral("enumFromQtQml.qml");
QTest::newRow("anchors1") << QStringLiteral("anchors1.qml"); QTest::newRow("anchors1") << QStringLiteral("anchors1.qml");
QTest::newRow("anchors2") << QStringLiteral("anchors2.qml"); QTest::newRow("anchors2") << QStringLiteral("anchors2.qml");
QTest::newRow("anchors3") << QStringLiteral("anchors3.qml");
} }
void TestQmllint::cleanQmlCode() void TestQmllint::cleanQmlCode()