qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use constBegin/End with const_iterator 

Change-Id: I9c4801ac91c52d487e98a99ff4d38e133f0679a3
Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
This commit is contained in:
Frederik Gladhorn 2015-07-23 13:16:38 +02:00 committed by Gabriel de Dietrich
parent 048a536329
commit 45969a0dbb
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/auto/sanity/tst_sanity.cpp
View File

@ -156,7 +156,7 @@ void tst_Sanity::initTestCase()
void tst_Sanity::jsFiles()
{
QMap<QString, QString>::const_iterator it;
for (it = files.begin(); it != files.end(); ++it) {
for (it = files.constBegin(); it != files.constEnd(); ++it) {
if (QFileInfo(it.value()).suffix() == QStringLiteral("js"))
QFAIL(qPrintable(it.value() + ": JS files are not allowed"));
}
@ -188,7 +188,7 @@ void tst_Sanity::functions_data()
QTest::addColumn<QString>("filePath");
QMap<QString, QString>::const_iterator it;
for (it = files.begin(); it != files.end(); ++it)
for (it = files.constBegin(); it != files.constEnd(); ++it)
QTest::newRow(qPrintable(it.key())) << it.key() << it.value();
}
@ -225,7 +225,7 @@ void tst_Sanity::signalHandlers_data()
QTest::addColumn<QString>("filePath");
QMap<QString, QString>::const_iterator it;
for (it = files.begin(); it != files.end(); ++it)
for (it = files.constBegin(); it != files.constEnd(); ++it)
QTest::newRow(qPrintable(it.key())) << it.key() << it.value();
}
@ -249,7 +249,7 @@ void tst_Sanity::anchors_data()
QTest::addColumn<QString>("filePath");
QMap<QString, QString>::const_iterator it;
for (it = files.begin(); it != files.end(); ++it)
for (it = files.constBegin(); it != files.constEnd(); ++it)
QTest::newRow(qPrintable(it.key())) << it.key() << it.value();
}
@ -278,7 +278,7 @@ void tst_Sanity::attachedObjects_data()
QTest::addColumn<QString>("filePath");
QMap<QString, QString>::const_iterator it;
for (it = files.begin(); it != files.end(); ++it)
for (it = files.constBegin(); it != files.constEnd(); ++it)
QTest::newRow(qPrintable(it.key())) << it.key() << it.value();
}

2
tests/auto/snippets/tst_snippets.cpp
View File

@ -97,7 +97,7 @@ void tst_Snippets::screenshots_data()
QTest::addColumn<QString>("output");
QMap<QString, QStringPair>::const_iterator it;
for (it = filePaths.begin(); it != filePaths.end(); ++it)
for (it = filePaths.constBegin(); it != filePaths.constEnd(); ++it)
QTest::newRow(qPrintable(it.key())) << it.value().first << it.value().second;
}