qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

QQmlIRBuilder: Clean up QStringView oddities 

The port from QStringRef to QStringView created a few odd constructs,
like locals of type const QStringView & and explicitly creating a
QStringView from a QString before passing it to a function taking a QSV.
Clean them up.

Change-Id: I92293198266530f8ab8b9c858a0f0a96e31d7680
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Fabian Kosmale 2023-01-05 15:57:52 +01:00
parent 054d62c2e0
commit 6b8743f3b6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qml/compiler/qqmlirbuilder.cpp
View File

@ -358,7 +358,7 @@ void ScriptDirectivesCollector::importModule(const QString &uri, const QString &
QV4::CompiledData::Import *import = engine->pool()->New<QV4::CompiledData::Import>();
import->type = QV4::CompiledData::Import::ImportLibrary;
import->uriIndex = jsGenerator->registerString(uri);
import->version = IRBuilder::extractVersion(QStringView(version));
import->version = IRBuilder::extractVersion(version);
import->qualifierIndex = jsGenerator->registerString(module);
import->location.set(lineNumber, column);
document->imports << import;
@ -1025,7 +1025,7 @@ bool IRBuilder::visit(QQmlJS::AST::UiPublicMember *node)
if (memberType == QLatin1String("alias")) {
return appendAlias(node);
} else {
const QStringView &name = node->name;
QStringView name = node->name;
Property *property = New<Property>();
property->setIsReadOnly(node->isReadonly());
@ -1038,7 +1038,7 @@ bool IRBuilder::visit(QQmlJS::AST::UiPublicMember *node)
else
property->setCustomType(registerString(memberType));
const QStringView &typeModifier = node->typeModifier;
QStringView typeModifier = node->typeModifier;
if (typeModifier == QLatin1String("list")) {
property->setIsList(true);
} else if (!typeModifier.isEmpty()) {