qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tst_qqmljsscope: Address unsigned value to 0 comparison warning 

As we deal with unsigned integer indices, there's no point in testing
them for >= 0 as this is always true. Apparently it is a -Wtype-limits
warning for some compilers

Change-Id: Ic5d633c2cc73f811f127f16f4d769d154364ccd0
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Andrei Golubev 2022-04-27 12:20:40 +02:00
parent e98faf1df4
commit ccf996fbe4
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/auto/qml/qqmljsscope/tst_qqmljsscope.cpp
View File

@ -524,9 +524,6 @@ void tst_qqmljsscope::scriptIndices()
const QString objectName = document.stringAt(irObject->inheritedTypeNameIndex); const QString objectName = document.stringAt(irObject->inheritedTypeNameIndex);
for (auto it = irObject->functionsBegin(); it != irObject->functionsEnd(); ++it) { for (auto it = irObject->functionsBegin(); it != irObject->functionsEnd(); ++it) {
QString name = document.stringAt(it->nameIndex); QString name = document.stringAt(it->nameIndex);
QVERIFY2(it->index >= 0,
qPrintable(QStringLiteral("(qmlir) Method %1 from %2 has no index")
.arg(name, objectName)));
populateQmlIRArrays(irObject, name, it->index); populateQmlIRArrays(irObject, name, it->index);
} }
for (auto it = irObject->bindingsBegin(); it != irObject->bindingsEnd(); ++it) { for (auto it = irObject->bindingsBegin(); it != irObject->bindingsEnd(); ++it) {
@ -534,10 +531,6 @@ void tst_qqmljsscope::scriptIndices()
continue; continue;
QString name = document.stringAt(it->propertyNameIndex); QString name = document.stringAt(it->propertyNameIndex);
int index = it->value.compiledScriptIndex; int index = it->value.compiledScriptIndex;
QVERIFY2(
index >= 0,
qPrintable(QStringLiteral("(qmlir) Binding on property %1 from %2 has no index")
.arg(name, objectName)));
populateQmlIRArrays(irObject, name, index); populateQmlIRArrays(irObject, name, index);
} }
} }