qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Canvas test_url: wait until image is loaded 

The loadImages() function has been waiting already since
6318560eca); but test_url() was not
waiting, which could result in CI flakiness. Anyway tryVerify is better
than waiting 200ms every time it's slow, and will give us a failure
message about isImageLoaded() if it fails.

Pick-to: 6.5 6.2
Task-number: QTBUG-41043
Change-Id: I0bb552d3452d85342d2ffa3b6becded5b01177a8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
This commit is contained in:
Shawn Rutledge 2023-03-09 07:10:42 +01:00
parent 38885dda73
commit e37d2dac8a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/auto/quick/qquickcanvasitem/data/tst_image.qml
View File

@ -11,8 +11,7 @@ CanvasTestCase {
canvas.loadImage('rgrg-256x256.png');
canvas.loadImage('ggrr-256x256.png');
canvas.loadImage('broken.png');
while (!canvas.isImageLoaded('green.png'))
wait(200);
tryVerify(function() { return canvas.isImageLoaded('green.png'); })
}
function test_3args(row) {
@ -223,6 +222,7 @@ CanvasTestCase {
var ctx = canvas.getContext('2d');
canvas.loadImage(testCase.green);
tryVerify(function() { return canvas.isImageLoaded(testCase.green); })
ctx.drawImage(testCase.green, 0, 0);
comparePixel(ctx, 0,0, 0,255,0,255,2);
}