qiurui
/
qtdeclarative
mirror of https://github.com/qt/qtdeclarative.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix warning in test when iterating QJsonArray 

QJsonArray doesn't hold QJsonValues, so we can't iterate over references.
Use QJsonValueConstRef instead.

Change-Id: I0246e2406b2f3d5aa2cd5382d17396717d899dfa
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Volker Hilsheimer 2022-03-20 13:39:52 +01:00
parent 445962d970
commit f85790d097
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/auto/qml/qmllint/tst_qmllint.cpp
View File

@ -1447,7 +1447,7 @@ void TestQmllint::searchWarnings(const QJsonArray &warnings, const QString &subs
Q_UNREACHABLE();
};
for (const QJsonValue &warning : warnings) {
for (const QJsonValueConstRef warning : warnings) {
QString warningMessage = warning[u"message"].toString();
quint32 warningLine = warning[u"line"].toInt();
quint32 warningColumn = warning[u"column"].toInt();
@ -1467,7 +1467,7 @@ void TestQmllint::searchWarnings(const QJsonArray &warnings, const QString &subs
break;
}
for (const QJsonValue &fix : warning[u"suggestions"].toArray()) {
for (const QJsonValueConstRef fix : warning[u"suggestions"].toArray()) {
const QString fixMessage = fix[u"message"].toString();
if (fixMessage.contains(substring)) {
contains = true;