By not relying on the return value of the macros we can #define them
away later, when compiling with -no-qml-debug
Change-Id: I24d50fa3f5d8e8765a42b050c81ddfae20f20a23
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
The compiler might be able to optimize better if it knows the methods
are empty.
Change-Id: Ib730e857d1ab948bb2f5c5006f4911d2e6db282d
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Under certain circumstances the clip node state would not get
propagated properly to child nodes.
Change-Id: I6f34690c7cc6f2837854fbcaff9aa4d7522e47c3
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
This is a new attempt at providing a threaded render loop for the
software adaptation in scenegraph. This approach is modeled after the
D3D12 backend, and provides a separate thread for each window. To
enable use the environment variable QSG_RENDER_LOOP=threaded as with the
other backends.
Change-Id: I6932975dd9c5579d36f0135aa4626dcc43b45ecd
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Properly close the connection on invalid hello messages and implement
flush() also for local sockets.
Change-Id: Ie78441b9933c6de053962a11b5d7e2636792a31c
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
The most common cases of property writes now come first.
Change-Id: I225b73746120870d9ca01d09983ad225e32bd99c
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
[ChangeLog][QtQuick] Added properties to access color values for the HSV
and HSL color models to the basic QML color type.
Task-number: QTBUG-48723
Change-Id: I45fa52f9f3878553e1b3d0a34b47804ede7794f8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Pass property reads/writes through utility functions in QQmlProperty,
which in turn will try to use accessors when available (and no
interceptors have to be called).
Change-Id: I60ecfc202b6024bfe4a33206a46299787b152546
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Perform various basic checks before proceeding to load an existing cache file,
including the qt version, architecture, data structure version and others.
Change-Id: Ie822b056e944ac120643aad260e97f62616688bf
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
Recent qtbase updates set QT_GCC_MAJOR_VERSION even for ICC.
Change-Id: I149e0540c00745fe8119fffd1463d34701f370f3
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
INT_MIN is negative.
qv4assembler_p.h(108): warning #68: integer conversion resulted in a
change of sign
Change-Id: I149e0540c00745fe8119fffd1463d31acd727690
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
MinGW's cc got upset at a QDateTime comparison when it only had a
forward declaration of the type.
Change-Id: I0404248cbdfc35610d8465294534bd5201dcf2a2
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
With the JIT and moth supporting persistence, we can enable the disk
cache tests unconditionally.
Change-Id: I6d6652411237001433a32a2de21d1f78f51b43ef
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
When using the threaded interpreter, don't produce the instruction handler
addresses right away but perform that as a separate step when linking against
the engine.
Change-Id: I216100f8b99f45eb8d954c733ac128e83aa6da38
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
This is useful for conditions which can't be tested using tryCompare.
One such situation is that of the currentItem property of ListView.
In Qt Quick Controls 2, the currentItem property of the ListView that
is internally a child of Tumbler can be null for a certain period of
time, so using tryCompare() would result in errors due to trying to
access a property of a null object:
tryCompare(tumblerView.currentItem, "text", "2")
The current workaround is to use wait(50) in a for loop, which is ugly
and could lead to flaky tests:
for (var delay = 1000; delay >= 0; delay -= 50) {
if (tumblerView.currentItem)
break;
wait(50);
}
verify(tumblerView.currentItem);
compare(tumblerView.currentItem.text, data.currentIndex.toString());
Using tryVerify(), we can first ensure that currentItem isn't null, and
then use a regular synchronous compare afterwards:
tryVerify(function(){ return tumblerView.currentItem; });
compare(tumbler.currentItem.text, data.currentIndex.toString());
[ChangeLog][QtTest][TestCase] Added tryVerify() function to allow
verification of asynchronous conditions that can't be tested using
tryCompare().
Change-Id: Ie93052b650f7fe0bf26853054a8f0f35a483e387
Task-number: QTBUG-19708
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
There's no apparent need to store the refptr to the compilation unit in a
persistent value, when the persistent's life time is bound to the life time of
the V4::Script.
Change-Id: Ib4f3008f45c17a680dbe12ca1f80522fd7f6fdfc
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Instead of relying on two time stamps in the file system (source file and cache
file), make the determination on whether the source file is newer than the
cache solely depend on the time stamp of only the source file. This means that
when cache files are stored in archives for example their modification date
does not need to be preserved upon extraction.
Change-Id: I0b4362663868c6fb9bd7e106028161b2d67274d4
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
This remains hidden behind the QML_DISK_CACHE flag until all backends
support it and the verification code is in place.
Change-Id: Ic77c64e20a2dc4c43473c47640e09f8070237e85
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
The bit indicating if accessors could be used only returned true when an
interceptor was added to the object, but the property in question was
not intercepted. So it missed the case where no interceptor was
installed on any property of the object.
Change-Id: I355eb7bbe232f512d02c1b9783a0e6f990552689
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Constant properties typically do not have change notification signals,
so do not attempt to listen to those.
Change-Id: I4b3622d014aa2f8b3794a63f78ada9806c53966b
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Make QSG_RENDERER_DEBUG more fine-grained, the maximum set is now
loop;build;change;render;descheap;buffer;texture;shader meaning "render" is
broken up into 5 categories.
Fix also a comment on the root signature to avoid future headache with
trying to optimize the descriptor table for textures away (in vain).
Change-Id: I06a2a624ed39aaf5de42b8e984a192c7966360ab
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Missing features in the QSGImageNode based software node.
Change-Id: If6a759873d201307e013a3ab019bd906d98ba7d5
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Have to change getResource() a bit since it turns out it is not suitable
currently for backends that do not have a per-window rendercontext and do
not implement the interface on the rendercontext. Pass in the window to
make sure it can always figure out which window we want the resources for.
(we do not want rendererInterface() to return window-specific instances
created on the fly, with ownership issues, so stick with the simple model
where backends implement the interface on one of their existing classes)
To support clipping, QSGRenderNode::RenderState is extended accordingly.
Also updated the docs since some claims in the rendernode docs are not true
since Qt 5.3.
Change-Id: I34779c83926f5231b888fcab7131e873ae97964f
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
FAIL! : tst_QQuickView::resizemodeitem() Compared values are not the same
Actual (sizeListener.at(i)): QSize(80x100)
Expected (view->size()) : QSize(200x300)
Loc: [tst_qquickview.cpp(172)]
The "SizeChangesListener" can be instantiated too early, catching
signals from the previous resize events. Make sure to flush all events
before.
Change-Id: Ib0933429f5c589f120c263619f00893fa813e361
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
The same condition is tested in the line above.
Change-Id: I99720e3603b1ae5e2f5161696f1de3dd03f6ff50
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Commit be491913c0 regressed the build with some
compilers that complained that the RegExp fields were uninitialized. Fix is
the same as for the Lookup class.
Change-Id: Ie6b2adf14496d75845f6a9d9b8fc680e61aa1155
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
So it can be changed to BGRA, if desired, although tests show that BGRA
reduces perf a little bit in fact.
Change-Id: Ieb87bba2298426f1503658f8dffb0c659c265ca5
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
It seems to be the same sort of persistent event for exposure to QML.
Change-Id: I4ebc48422ee517f37e300629b6d100f68b9703b3
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Similar to the regular property cache creation code, this also has to become a
template function so that it can be run on the compilation units loaded from
disk in the future. What is shared between the code path of a fresh compilation
vs. re-use of a unit from disk is the code to propagate the CompiledData::Alias
entries into entries in the property cache. The code for iterating through the
component spaces and resolving the alias references is not shared.
Change-Id: I04c2a5575310400156b457ae7b709cffecb7455e
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
The resolution of aliases needs to to be solved in iterations as an alias can
refer to another alias, which may not be created yet in the property cache by
the time we try to perform the resolution. Therefore the alias resolution code
works off a list of pending aliases after the initial pass of resolution. This
also requires the ability to detect circular references.
Change-Id: Id4e159b9c713aa8a8a095759e22e3fac456a38a0
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
128 is way too low. Experiments with qmlbench show that there is not much
improvement after 4000 so go with 4096.
Change-Id: I1fd8f4f55250b5e54d95adb28b4ea1f4fe5ca10a
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Ifdefing with no_debug_output is a bad idea in this case, these are
messages we want in any builds.
Change-Id: Ic842afe9b48961fb7fb010db868f92f8e85184c3
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
"frame buffers have been swapped" is a bit underspecified and is quite
confusing outside the EGL/GLX/WGL world.
Change-Id: Ib4b267c0b74a101e78b9368556d80aeee6ccbc4b
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
This method is used in ExecutionEngine::getProperty, which is called
quite often.
Change-Id: Ide49d158005ef1d9f51d1e734cf9e3b19f52cf26
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
With the software backend we entered an infinite loop when having
ShaderEffect items. The previous change introducing the usage of polish
requests to defer shader processing was a bit too keen on trying over and
over again: there is exactly one retry attempt we need, not more. If the
second fails too and everything looks initialized and ready, then we know
the backend has no shader effect support so it is futile to try again.
Change-Id: Ibaaefd45e5b26d0be42dbe7f9c080363b7a939bf
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Ulf Hermann
Andy Nichols
Erik Verbruggen
Nikita Krupenko
Simon Hausmann
Thiago Macieira
Edward Welbourne
Mitch Curtis
Laszlo Agocs
Frederik Gladhorn
Simon Hausmann
Shawn Rutledge
BogDan Vatra