qiurui
/
qtgraphs
mirror of https://github.com/qt/qtgraphs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GraphsWidgets: Pass QImage by reference to const instead of by value 

Based on API review.

Rationale: Non-trivial types should not be passed by value.

Task-number: QTBUG-137478
Change-Id: I9be369facb9f214e8bd11edbd67ef03c3c331de7
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
(cherry picked from commit 60a29fd7f9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Tomi Korpipaa 2025-08-21 07:01:46 +03:00 committed by Qt Cherry-pick Bot
parent 85cda1d547
commit 46d013f1b0
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/graphs3d/qml/qquickgraphsbars_p.h
View File

@ -218,7 +218,7 @@ Q_SIGNALS:
void selectedSeriesChanged(QBar3DSeries *series);
void floorLevelChanged(float level);
Q_REVISION(6, 10)
void sliceImageChanged(QImage image);
void sliceImageChanged(const QImage &image);
private:
enum SelectionType {

2
src/graphs3d/qml/qquickgraphssurface_p.h
View File

@ -198,7 +198,7 @@ Q_SIGNALS:
void selectedSeriesChanged(QSurface3DSeries *series);
void flipHorizontalGridChanged(bool flip);
Q_REVISION(6, 10)
void sliceImageChanged(QImage image);
void sliceImageChanged(const QImage &image);
private:
struct SurfaceVertex

2
src/graphs3d/widget/q3dbarswidgetitem.cpp
View File

@ -432,7 +432,7 @@ QList<QAbstract3DAxis *> Q3DBarsWidgetItem::axes() const
}
/*!
* \fn Q3DBarsWidgetItem::sliceImageChanged(QImage image)
* \fn Q3DBarsWidgetItem::sliceImageChanged(const QImage &image)
* \since 6.10
* Emitted when \l renderSliceToImage has prepared the \a{image}.
*/

2
src/graphs3d/widget/q3dbarswidgetitem.h
View File

@ -93,7 +93,7 @@ Q_SIGNALS:
void selectedSeriesChanged(QBar3DSeries *series);
void floorLevelChanged(float level);
Q_REVISION(6, 10)
void sliceImageChanged(QImage image);
void sliceImageChanged(const QImage &image);
private:
Q_DECLARE_PRIVATE(Q3DBarsWidgetItem)

2
src/graphs3d/widget/q3dsurfacewidgetitem.cpp
View File

@ -349,7 +349,7 @@ QList<QValue3DAxis *> Q3DSurfaceWidgetItem::axes() const
}
/*!
* \fn Q3DSurfaceWidgetItem::sliceImageChanged(QImage image)
* \fn Q3DSurfaceWidgetItem::sliceImageChanged(const QImage &image)
* \since 6.10
* Emitted when \l renderSliceToImage has prepared the \a{image}.
*/

2
src/graphs3d/widget/q3dsurfacewidgetitem.h
View File

@ -61,7 +61,7 @@ Q_SIGNALS:
void selectedSeriesChanged(QSurface3DSeries *series);
void flipHorizontalGridChanged(bool flip);
Q_REVISION(6, 10)
void sliceImageChanged(QImage image);
void sliceImageChanged(const QImage &image);
private:
Q_DECLARE_PRIVATE(Q3DSurfaceWidgetItem)