qiurui
/
qtgrpc
mirror of https://github.com/qt/qtgrpc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use const reference as the QGrpcCallOptions::metadata return type 

Small optimization bit, to avoid potential extra copy of QGrpcMetadata
aka std::unordered_multimap, which doesn't support implicit sharing.

Change-Id: I9173cde9ca743be04f00b01a608ee1cf7055ba3c
Reviewed-by: Tatiana Borisova <tatiana.borisova@qt.io>
This commit is contained in:
Alexey Edelev 2024-01-05 06:30:17 +01:00
parent 1b0deda281
commit 31f267affa
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/grpc/qgrpccalloptions.cpp
View File

@ -97,7 +97,7 @@ std::optional<std::chrono::milliseconds> QGrpcCallOptions::deadline() const
If value was not set returns empty QGrpcMetadata. If value was not set returns empty QGrpcMetadata.
*/ */
QGrpcMetadata QGrpcCallOptions::metadata() const const QGrpcMetadata &QGrpcCallOptions::metadata() const
{ {
return dPtr->metadata; return dPtr->metadata;
} }

2
src/grpc/qgrpccalloptions.h
View File

@ -29,7 +29,7 @@ public:
QGrpcCallOptions &withMetadata(const QGrpcMetadata &metadata); QGrpcCallOptions &withMetadata(const QGrpcMetadata &metadata);
std::optional<std::chrono::milliseconds> deadline() const; std::optional<std::chrono::milliseconds> deadline() const;
QGrpcMetadata metadata() const; const QGrpcMetadata &metadata() const;
private: private:
std::unique_ptr<QGrpcCallOptionsPrivate> dPtr; std::unique_ptr<QGrpcCallOptionsPrivate> dPtr;