qiurui
/
qtgrpc
mirror of https://github.com/qt/qtgrpc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

QGrpcCallOptions: modernize api with [[nodiscard]] 

This improves tooling for return values that shouldn't be ignored.

As a drive-by mark those functions as noexcept.

Task-number: QTBUG-123625
Pick-to: 6.7
Change-Id: I838e9ff62cc6e3b75e39fd2cd972cca53abdee9e
Reviewed-by:  Alexey Edelev <alexey.edelev@qt.io>
This commit is contained in:
Dennis Oberst 2024-03-25 15:22:59 +01:00
parent f6bd9afbca
commit c8ca806f43
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/grpc/qgrpccalloptions.cpp
View File

@ -88,7 +88,7 @@ QGrpcCallOptions &QGrpcCallOptions::withMetadata(const QGrpcMetadata &metadata)
If value was not set returns empty std::optional.
*/
std::optional<std::chrono::milliseconds> QGrpcCallOptions::deadline() const
std::optional<std::chrono::milliseconds> QGrpcCallOptions::deadline() const noexcept
{
return dPtr->deadline;
}
@ -98,7 +98,7 @@ std::optional<std::chrono::milliseconds> QGrpcCallOptions::deadline() const
If value was not set returns empty QGrpcMetadata.
*/
const QGrpcMetadata &QGrpcCallOptions::metadata() const
const QGrpcMetadata &QGrpcCallOptions::metadata() const noexcept
{
return dPtr->metadata;
}

4
src/grpc/qgrpccalloptions.h
View File

@ -28,8 +28,8 @@ public:
QGrpcCallOptions &withDeadline(std::chrono::milliseconds deadline);
QGrpcCallOptions &withMetadata(const QGrpcMetadata &metadata);
std::optional<std::chrono::milliseconds> deadline() const;
const QGrpcMetadata &metadata() const;
[[nodiscard]] std::optional<std::chrono::milliseconds> deadline() const noexcept;
[[nodiscard]] const QGrpcMetadata &metadata() const noexcept;
private:
std::unique_ptr<QGrpcCallOptionsPrivate> dPtr;