The newer protobuf version uses string_views as the return value.
Wrap the respecitive API with constructing std::string and update
some of the util functions to accept std::string_view arguments
but not plain std::string.
Fixes: QTBUG-134885
Pick-to: 6.8 6.9
Change-Id: I8bc06c46167a8b1bc0dca36242249e672ffcccd3
Reviewed-by: Tatiana Borisova <tatiana.borisova@qt.io>
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
Sanitize proto includes to ensure the generated
<Module>ProtobufProperties.cmake is fully relocatable.
Drive-by, ensure that includes do not contain duplicates.
Task-number: QTBUG-130113
Change-Id: I64f56d497d412705f174a027f711b90ad7614abf
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Ensure we store values correct way.
Pick-to: 6.8 6.9
Change-Id: I89ec10e41969a001d34a73a0fdd77a661b7c9506
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
gRPC doesn't provide the smart tool lookup when crosscompiling.
So gRPC lookup is unable to find the grpc_cpp_plugin plugin when
crosscompiling examples. Use find_program to find the plugin in
host paths.
Pick-to: 6.8 6.9
Fixes: QTBUG-134647
Change-Id: I961b180b348dee4f1b2f2523be225d3003847e4c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
The test was faulty positive because of invalid command line.
The input file name was missing there, so protoc was failing to
generate code, but didn't test the actual invalid EXPORT_MACRO name.
Pick-to: 6.8 6.9
Change-Id: Ib57235fb22c740dc30aec58076833c8f6de4a250
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
A QUIP 18[1] update sets git files, REUSE.toml and licenseRule.json
as infrastructure type files. They are licensed with:
LicenseRef-Qt-Commercial OR BSD-3-Clause
[1]: https://contribute.qt-project.org/quips/18
Pick-to: 6.9 6.8
Change-Id: Ib3bbda05a9b150dc9f7da564cd3bdc2691a749cc
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
The previous approach was error-prone, as using TARGET_FILE_DIR
hard-coded the path to the build directory and ignored install locations
entirely.
Fix this by using a more reliable approach: embedding the certificate
strings directly into the application.
Pick-to: 6.9 6.9.0 6.8 6.8.3
Change-Id: Ifb883891fd55bb023e7f9828f9c422ea3e5d1c3e
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Ensure that we received the connection SETTINGS from server before
sending the very first HEADER/DATA frame using the stream.
It's the expected flow for HTTP/2 communication, we are lucky that gRPC
servers accept us.
Drive-by change the way we handle the missing HTTP/2 connection. It's
the exceptional situation, when we failed to acquire the connection
using QHttp2Connection::createDirectConnection call, so make assertion
at this point.
Dive-by fix the "dead" Http2Handlers in m_activeHandlers, which were
eaten by "expired" pointer state(Users declined to keep QGrpcOperation
pointers alive).
Task-number: QTBUG-133254
Pick-to: 6.8 6.9 6.9.0
Change-Id: Icb19d12c54662a3b13e080da5cece5885fd767d9
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
Use the vcpkg manifest to configure and build QtGRPC the example.
This allows to automate the dependency installation using vcpkg.
Pick-to: 6.9
Task-number: QTBUG-132738
Change-Id: I7ba9d5a2c1186d1a70f3dc3a39117d86f2269271
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Use the vcpkg manifest to configure and build QtGRPC chat example.
This allows automating the dependency installation using vcpkg.
Pick-to: 6.9
Task-number: QTBUG-132738
Change-Id: Iafcb8e144d51f1af0d775869550f003c997d106a
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Use the vcpkg manifest to configure and build QtProtobuf sensors
example. This allows automating the dependency installation using
vcpkg.
Pick-to: 6.9
Task-number: QTBUG-132738
Change-Id: Icae7acf46d97d834a064d7663623757a7ec35742
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Use the vcpkg manifest to configure and build QtGRPC Magic 8 Ball
example. This allows automating the dependency installation using
vcpkg.
Pick-to: 6.9
Task-number: QTBUG-132738
Change-Id: Idaf8ee948a0a304633e1fe9f63327391adec96d8
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
QHttp2 implementation will make this favor for us, in general the
header is not mandatory for communication with gRPC server, but can
be used by other members of the network communication. Anyway it's
not the level of the gRPC channel where the header should be defined.
Pick-to: 6.9.0 6.9 6.8 6.8.3
Change-Id: I73fe3c780bfa373a724255dd26accf37f8a8ff50
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
We should be clearer about what transportation is used and when.
Otherwise, our users are left in the dark.
Task-number: QTBUG-134273
Change-Id: Ice58e2cd496fad472761bdb9022f0fd3280c265c
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
We should be clearer about what transportation is used and when.
Otherwise, our users are left in the dark.
Task-number: QTBUG-134273
Pick-to: 6.9 6.9.0 6.8 6.8.3
Change-Id: I6d1da9236447521a53b197808c55c89c49fbd4c2
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
QLocalSocket supports abstract namespaces. Grpc also supports it. Simply
make it available through the 'unix-abstract' scheme.
Ref: https://grpc.github.io/grpc/core/md_doc_naming.html
Ref: https://doc.qt.io/qt-6/qlocalsocket.html#SocketOption-enum
[ChangeLog][GRPC][QGrpcHttp2Channel] Added abstract namespace support
for QLocalSocket communication through the "unix-abstract" scheme.
Fixes: QTBUG-134273
Change-Id: Iea2b608478e00504d7cdbdff735fcbfb618529d7
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
The protocol does not require a user-agent, but it is recommended to
provide a structured user-agent string. This helps diagnose issues more
effectively in heterogeneous environments.
Ref: https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#user-agents
[ChangeLog][GRPC][QGrpcHttp2Channel] Added a structured user-agent
string to the request headers.
Task-number: QTBUG-133254
Change-Id: Ic312f2a3754108798bb7acc70e2d8bed4a891401
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
It doesn't make sense to use a view in this context. This would also be
more performant since it enables implicit sharing for the headers.
As a drive-by fix the Literals namespace usage to align what current
documentation says.
Pick-to: 6.9 6.9.0 6.8 6.8.3
Task-number: QTBUG-133254
Change-Id: I89be231de4b902d56d65d1729816681ce84ce90e
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
* grpc async client now properly drains the completion queue upon
finishing
* server and clients now use the 'transport' option for setting up the
communication. The server now supports multiple listening addresses.
* Fix a "off by one" mismatch for the client RPC calls
Task-number: QTBUG-133254
Pick-to: 6.9 6.8
Change-Id: Iccbec72f77adb374f144c7cc1b9a8072fef00b5e
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reference gRPC channel does this, to disable the Nagle's algorithm
and reduce the latency for the small flow control frames like
WINDOW_UPDATE and PING.
TODO: We should probably allow to opt out this behavior using
QGrpcChannelOptions. See QTBUG-134428.
Task-number: QTBUG-134428
Task-number: QTBUG-133254
Pick-to: 6.8 6.8.3 6.9 6.9.0
Change-Id: I96efac97077c7e527198bae9ca00500629bd4800
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
This patch fixes Q_ASSERT comparison between unsigned
integer and integer types on Android x86 build by using
C++20 compare function.
Fixes: QTBUG-134439
Pick-to: 6.9 6.9.0 6.8
Change-Id: I89e9a7384aad0fe908f4dd12680d3bf4770e6915
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Remove deployment of the now static proto lib.
Amends 9437a1f2bd
Pick-to: 6.9
Change-Id: I5bdda6157842c665165ae9b14255778ce2ac0bc9
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
This patch adds HttpsScheme variable definition behind
same ssl config where it is used in the source. This
fixes compile error on developer build for Android.
Fixes: QTBUG-134309
Pick-to: 6.9 6.9.0
Change-Id: I4d4425baa63f33724aff14b144339fb171e741d7
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
The deployment was incomplete. Fix it by:
* Building the dependent qtgrpc_chat_client_proto library as
a static library
* Add the server directory path for reading credentials universally
Amends: cb35d20adb.
Fixes: QTBUG-134266
Pick-to: 6.9.0 6.9 6.8.3 6.8
Change-Id: I0666c445fbce159436c5b084ffd77d4191e04213
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Remove \fn comments for QAbstractProtobufSerializer::(de)serializeObject().
These functions were dropped in 8ec55cb0cf.
Remove \fn for non-existent QProtobufRepeaterIterator constructor.
Remove unnecessary \fn commands from QAbstractProtobufSerializer, let QDoc
auto-tie the documentation instead.
Pick-to: 6.9 6.8
Task-number: QTBUG-134250
Change-Id: If49049a33a307a522b3275b114e879442432e4c4
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
This includes:
- turning VERIFY_SOURCE_SBOM ON
- adding rules to the licenseRule.json files
- correcting the licensing given via REUSE.toml files
A lot of files are skipped during the license test,
but all are present in the source SBOM.
This is why corrections are needed before turning the
source SBOM check on.
Task-number: QTBUG-131434
Pick-to: 6.9 6.8
Change-Id: I3a411c77c671d045b296cdacee1e90ec64307b6e
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
If the channel is in error state the socket could be non writable which
would result in an error loop if reconnections are steadily happening
since the logic would never reach m_reconnectFunction().
Add a safety check for the state to be Connected to protect against this
condition.
Pick-to: 6.9 6.8
Fixes: QTBUG-133937
Change-Id: Ie6c4858623ee8d7cc89a57d9bb14e4735fa64117
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Detect the situation where processOperation is called from within the
Q*Socket::errorOccurred, as it would be the case for immediate
reconnects.
The socket may not be ready for a immediate reconnect attempt and in
such a case the connectTo* function may return without signaling an
error. This would put the RPC in a dangling state, where its not able to
recover and no finished() signal will be emitted.
Solve this by adding a bool that we set during the
Q*Socket::errorOccurred and check during processOperation() calls and do
the asynchronous for our users. Print a warning to remind them about
this, as it's still preferred that users delay their reconnect attempts
on their own.
Ref: https://doc.qt.io/qt-6/qabstractsocket.html#errorOccurred
Pick-to: 6.9 6.8
Task-number: QTBUG-133937
Change-Id: Ic51f661ad576a24716f5790f5e6e2c96a19acbc4
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
`git-review` is a command line tool for interacting with Gerrit.
Some IDEs offer support for this tool, either natively or through
plugins. The tool relies on a configuration file, .gitreview. Adding
this configuration file to our repositories simplifies initial setup
for contributors that use the tool directly or through their IDE of
choice.
The configuration file adds a remote called 'gerrit'. This is the
default for the tool, and also the name set for
codereview.qt-project.org by Qt's `init-repository` script. Thus,
the configuration should work seamlessly alongside other repository
helpers.
As the file format doesn't seem to be designed with comments in mind,
add it to the other version control system exemptions in REUSE.toml.
Task-number: QTBUG-132604
Pick-to: 6.9 6.8
Change-Id: I5b3fd33b6c43d28c9268ad2cc3f43214d812d8c7
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>
Server and client request/responce time format differs, since
std::chrono::time_point::time_since_epoch() output contains
undeterminated units. Make the explicit conversion to milliseconds,
to align the time format between server and client.
Pick-to: 6.8 6.9
Change-Id: I5914221d3b3b8043721f4d97705ccb54c679be9c
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
The previous chat example was created many moons ago and much has
happened since then. These are the key improvements for the new qtchat:
- Server uses the Callback API
- Added support for Registering (stored in plain text on server side)
- Use long-lived bidirectional streaming for the ChatRoom method
- Any files can now be shared in any size with all chat users
- Use the Grpc client from a dedicated worker thread to have lag-free
UIs
- Use the generated protobuf QML-library declaratively in the app
- stylistic improvements
- Use SSL for safe communication
- Automatic reconnections
This is an advanced example showcasing many features of this module.
Pick-to: 6.9 6.8
Fixes: QTBUG-121871
Fixes: QTBUG-122625
Change-Id: I71114375fe91ffb20a235859b6ab51f7b3ab07a3
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
This was missing before and is a crucial information.
Pick-to: 6.9 6.8
Change-Id: I16c99c4d6482a0b94a9a39af360638ec438873e6
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Tatiana Borisova <tatiana.borisova@qt.io>
It worked previously since Qt::Quick->Qt::Qml linking propagated
it as private interface.
Change-Id: I2a28483e0baae728a6bbbf18df2c27a57230054a
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
If user doesn't specify the scheme or uses the unsupported one
fall back to the default one for the selected communication method.
Pick-to: 6.8 6.9
Change-Id: Ibe33cda464d4ef161c69d4f16862e543603b943e
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
QDoc now warns about C++ types in QML property documentation.
This change fixes existing documentation to prevent warnings.
Pick-to: 6.8 6.9
Change-Id: I293360f775cb3fd3472f57c73bc8f066f15b9fce
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
The :authority HTTP/2 header should contain the compatible ASCII
characters only. We should ensure that UTF-8 URIs are properly encoded.
Pick-to: 6.8 6.9
Change-Id: I2f18480e55ad86e32cfd190e198e73d14feba467
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
find_package with NAMES argument forces the CONFIG mode look up.
We accidentally looked for Protobuf uppercase in MODULE mode in
configure.cmake which allowed Protobuf targets be found for tests
and tools. Make this double lookup procedure explicit. All efforts
to support ubuntu/debian platforms, that decline to deliver protobuf
Config files.
Drive-by, use the correct variable to check that Protobuf is found
in golang grpc test server.
Pick-to: 6.9
Change-Id: I50d17aec72540a472bff30782d83e4555c51604a
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
It's not mutable during QGrpcHttp2ChannelPrivate lifetime, so we
may cache it.
Pick-to: 6.8 6.9
Change-Id: I2b84a4ec46acfca488d00d527e180a6e3fc430f1
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
QByteArrayView doesn't have any pros comparing to the cref. But causes
the deep copy each time we create HTTP/2 headers.
Pick-to: 6.8 6.9
Change-Id: Iddb44912c2eafa555e9dd2a19eae503a34be535b
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Qt Submodule Update Bot
Alexey Edelev
Lucie Gérard
Dennis Oberst
Matti Paaso
Rami Potinkara
Samuli Piippo
Topi Reinio
Paul Wicking