qiurui
/
rv1126-uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

input: rk8xx pwrkey: add some optimization 

1. add key name and type;
2. clear both fall and rise interrupt when detect rise.

Change-Id: I0698f3decc4b92cf32ce564a1827eedb5ee19a01
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
This commit is contained in:
Joseph Chen 2017-10-27 17:42:39 +08:00
parent 6e14addfbc
commit 9745ade23b
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/input/rk8xx_pwrkey.c
View File

@ -7,6 +7,7 @@
#include <common.h>
#include <dm.h>
#include <key.h>
#include <linux/input.h>
#include <power/pmic.h>
#include <power/rk8xx_pmic.h>
@ -39,23 +40,14 @@ static int rk8xx_pwrkey_read(struct udevice *dev)
return val;
}
if (val & key->pwron_fall_int) {
/* Clear rise when detect fall */
ret = pmic_reg_write(dev->parent, key->int_sts_reg,
key->pwron_rise_int);
if (ret < 0) {
printf("%s: i2c write failed, ret=%d\n", __func__, val);
return ret;
}
if (val & key->pwron_fall_int)
status = KEY_PRESS_DOWN;
}
/* Must check pwron rise behind of fall !! */
if (val & key->pwron_rise_int) {
/* Clear fall when detect rise */
ret = pmic_reg_write(dev->parent, key->int_sts_reg,
key->pwron_fall_int);
key->pwron_fall_int | key->pwron_rise_int);
if (ret < 0) {
printf("%s: i2c write failed, ret=%d\n", __func__, val);
return ret;
@ -64,10 +56,16 @@ static int rk8xx_pwrkey_read(struct udevice *dev)
status = KEY_PRESS_UP;
}
debug("%s: int sts = 0x%x msk = 0x%x\n",
__func__, pmic_reg_read(dev->parent, key->int_sts_reg),
pmic_reg_read(dev->parent, key->int_msk_reg));
return status;
}
static const struct dm_key_ops key_ops = {
.type = KEY_POWER,
.name = "pmic-pwrkey",
.read = rk8xx_pwrkey_read,
};
@ -111,6 +109,7 @@ static int rk8xx_pwrkey_probe(struct udevice *dev)
}
/* enable fall and rise interrupt */
val = 0xff;
val &= ~(key->pwron_rise_int | key->pwron_fall_int);
ret = pmic_reg_write(dev->parent, key->int_msk_reg, val);
if (ret < 0) {