diff --git a/drivers/video/drm/analogix_dp_reg.c b/drivers/video/drm/analogix_dp_reg.c
index e27d60a9ea..d2cb10cc0e 100644
--- a/drivers/video/drm/analogix_dp_reg.c
+++ b/drivers/video/drm/analogix_dp_reg.c
@@ -996,10 +996,10 @@ void analogix_dp_set_lane_link_training(struct analogix_dp_device *dp)
 				  ANALOGIX_DP_LN0_LINK_TRAINING_CTL + 4 * lane,
 				  dp->link_train.training_lane[lane]);
 
-		vs = (training_lane >> DP_TRAIN_VOLTAGE_SWING_SHIFT) &
-		     DP_TRAIN_VOLTAGE_SWING_MASK;
-		pe = (training_lane >> DP_TRAIN_PRE_EMPHASIS_SHIFT) &
-		     DP_TRAIN_PRE_EMPHASIS_MASK;
+		vs = (training_lane & DP_TRAIN_VOLTAGE_SWING_MASK) >>
+		     DP_TRAIN_VOLTAGE_SWING_SHIFT;
+		pe = (training_lane & DP_TRAIN_PRE_EMPHASIS_MASK) >>
+		     DP_TRAIN_PRE_EMPHASIS_SHIFT;
 		phy_cfg.dp.voltage[lane] = vs;
 		phy_cfg.dp.pre[lane] = pe;
 	}