From e9c98b3baf99badb58b1fd35d39283da222a8e1e Mon Sep 17 00:00:00 2001 From: Jianqun Xu Date: Thu, 12 Nov 2020 19:54:38 +0800 Subject: [PATCH] gpio: rockchip: fix get gpio mux operation error return Change-Id: Ia225ae3acea2d2d2347870b3d6a20c4a7d22e7e9 Signed-off-by: Jianqun Xu --- drivers/gpio/rk_gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c index f0146db320..1b1de01f19 100644 --- a/drivers/gpio/rk_gpio.c +++ b/drivers/gpio/rk_gpio.c @@ -109,11 +109,13 @@ static int rockchip_gpio_get_function(struct udevice *dev, unsigned offset) int ret; ret = pinctrl_get_gpio_mux(priv->pinctrl, priv->bank, offset); - if (ret) + if (ret < 0) { + dev_err(dev, "fail to get gpio mux %d\n", ret); return ret; + } /* If it's not 0, then it is not a GPIO */ - if (ret) + if (ret > 0) return GPIOF_FUNC; is_output = READ_REG(®s->swport_ddr) & OFFSET_TO_BIT(offset);