Tom Rini c9bf1d5a23 UPSTREAM: cmd/pxe.c: Rework bootargs construction to clarify string checks ... As the code currently stands, we first check that the length of the given command line, along with ip_str/mac_str along with an additional 1 for the NULL termination will fit within the buffer we have, and if not, we return an error. The way this code was originally written however left Coverity "unhappy" due to using strcat rather than strncat. Switching this to strncat however causes clang to be unhappy that we aren't enforcing the "1" portion within strncat. Rather than further re-work the code to include a "- 1" in this case as well, make the strcat code only be done within the else side of the length test. This keeps both clang and Coverity happy. Fixes: 48ee0a87bc46 ("cmd/pxe.c: Rework initrd and bootargs handling slightly") Change-Id: I6a3d3ea54d6b7e1f3c2aed200b2f706f42d570d4 Signed-off-by: Tom Rini <trini@konsulko.com> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> (cherry picked from commit 59ee8f83b6e77550d5697fced4899e9b5173981f)		2018-01-17 15:27:28 +08:00
..
fastboot	Add support for fastboot command over UDP	2017-11-14 10:55:44 +08:00
mvebu	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
.gitignore	…
Kconfig	UPSTREAM: cmd: Make CMD_LZMA / CMD_UNZIP default y if CMD_BOOTI	2018-01-17 15:27:28 +08:00
Makefile	cmd: bootrkp: add a cmd for rockchip rkimg bootloader	2017-12-08 18:13:25 +08:00
aes.c	…
android_ab_select.c	android: Fix off-by-one error when joining strings	2017-11-14 10:55:47 +08:00
android_cmds.c	android: Implement A/B slot select.	2017-11-14 10:55:46 +08:00
armflash.c	…
bdinfo.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
bedbug.c	…
blk_common.c	UPSTREAM: cmd: blk: Use LBAFU in the common block command	2018-01-16 18:16:48 +08:00
blkcache.c	…
blob.c	…
bmp.c	…
boot.c	…
boot_android.c	cmd: boot_android: support legacy aosp image from rockchip	2017-12-08 18:13:25 +08:00
bootefi.c	UPSTREAM: efi_loader: bootefi hello should use loadaddr	2018-01-16 18:16:48 +08:00
booti.c	…
bootm.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
bootmenu.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
bootrkp.c	rockchip: bootrkp: add log when boot from recovery	2018-01-12 15:40:12 +08:00
bootstage.c	…
bootz.c	…
cache.c	…
cbfs.c	…
charge.c	cmd: charge: support command parameter	2017-12-05 09:34:48 +08:00
clk.c	…
config.c	…
console.c	…
cpu.c	…
cramfs.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
cros_ec.c	…
dataflash_mmc_mux.c	…
date.c	…
demo.c	…
dfu.c	…
diag.c	…
disk.c	…
display.c	…
echo.c	…
eeprom.c	…
efi.c	…
elf.c	env: Rename some other getenv()-related functions	2017-08-16 08:31:11 -04:00
ethsw.c	…
exit.c	…
ext2.c	…
ext4.c	…
fastboot.c	treewide: replace with error() with pr_err()	2018-01-17 15:27:28 +08:00
fat.c	…
fdc.c	…
fdt.c	UPSTREAM: fdt: Switch to using the verbose overlay application method	2018-01-16 18:16:48 +08:00
fitupd.c	…
flash.c	UPSTREAM: Drop CONFIG_HAS_DATAFLASH	2018-01-17 15:27:28 +08:00
fpga.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
fpgad.c	…
fs.c	…
fs_uuid.c	…
fuse.c	…
gettime.c	…
gpio.c	…
gpt.c	UPSTREAM: cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity	2018-01-17 15:27:28 +08:00
hash.c	…
help.c	…
host.c	…
i2c.c	…
ide.c	cmd: ide: Make the first device the default one	2017-09-10 12:27:43 -04:00
ini.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
io.c	…
iotrace.c	…
irq.c	…
itest.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
jffs2.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
led.c	…
legacy_led.c	…
license.c	…
load.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
load_android.c	Move Android Image loading logic to image-android.c	2017-11-14 10:55:46 +08:00
log.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
lzmadec.c	…
mac.c	…
md5sum.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
mdio.c	…
mem.c	UPSTREAM: Drop CONFIG_HAS_DATAFLASH	2018-01-17 15:27:28 +08:00
mfsl.c	…
mii.c	…
misc.c	…
mmc.c	UPSTREAM: blk: Remove various places that do flush cache after read	2018-01-16 18:16:48 +08:00
mmc_spi.c	…
mp.c	…
mtdparts.c	mtdparts: Fix uninitialized scalar usage	2017-08-26 16:59:24 -04:00
nand.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
net.c	Add support for fastboot command over UDP	2017-11-14 10:55:44 +08:00
nvedit.c	UPSTREAM: env: Drop CONFIG_ENV_IS_IN_DATAFLASH	2018-01-17 15:27:28 +08:00
nvme.c	nvme: Adjust the 'nvme' command to use blk_common_cmd()	2017-08-28 07:17:15 -04:00
onenand.c	…
part.c	…
pci.c	…
pcmcia.c	…
pmic.c	…
pxe.c	UPSTREAM: cmd/pxe.c: Rework bootargs construction to clarify string checks	2018-01-17 15:27:28 +08:00
qfw.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
read.c	cmd/read.c: Fix checking blk_dread return value	2017-08-20 09:54:30 -04:00
reginfo.c	…
regulator.c	treewide: replace with error() with pr_err()	2018-01-17 15:27:28 +08:00
reiser.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
remoteproc.c	…
rknand.c	drivers: rknand: add nand flash drivers for Rockchip SoC	2017-10-20 08:59:10 +08:00
rockusb.c	treewide: replace with error() with pr_err()	2018-01-17 15:27:28 +08:00
sata.c	dm: sata: Support driver model with the 'sata' command	2017-08-17 16:44:17 +09:00
scsi.c	dm: scsi: Adjust the 'scsi' command to use blk_common_cmd()	2017-08-17 16:44:16 +09:00
setexpr.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
sf.c	…
sha1sum.c	…
sound.c	…
source.c	env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()	2017-08-16 08:30:32 -04:00
spi.c	…
spl.c	UPSTREAM: cmd: spl: fix compiling error when CONFIG_CMD_SPL_WRITE_SIZE not defined	2018-01-17 15:27:28 +08:00
strings.c	…
terminal.c	…
test.c	…
thordown.c	treewide: replace with error() with pr_err()	2018-01-17 15:27:28 +08:00
time.c	UPSTREAM: cmd/time.c: Initialize 'repeatable' variable	2018-01-17 15:27:28 +08:00
tpm.c	…
tpm_test.c	treewide: replace with error() with pr_err()	2018-01-17 15:27:28 +08:00
trace.c	env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()	2017-08-16 08:30:32 -04:00
tsi148.c	…
ubi.c	…
ubifs.c	…
universe.c	…
unzip.c	…
usb.c	dm: usb: Adjust the 'usb' command to use blk_common_cmd()	2017-08-17 16:44:16 +09:00
usb_gadget_sdp.c	treewide: replace with error() with pr_err()	2018-01-17 15:27:28 +08:00
usb_mass_storage.c	treewide: replace with error() with pr_err()	2018-01-17 15:27:28 +08:00
version.c	…
ximg.c	env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()	2017-08-16 08:30:32 -04:00
yaffs2.c	…
zfs.c	env: Rename getenv/_f() to env_get()	2017-08-16 08:30:24 -04:00
zip.c	…